o.k... I'll make the changes to the arch patch, and combine the two, and
send it to jiri.. as for the names and signed offs is what is below fine
or do I need to change some of them?
>
> Looks good to me.
>
> Finn
>
>
> On Mon, 27 Sep 2010, Justin P. Mattock wrote:
>
>
On 09/27/2010 07:59 PM, Finn Thain wrote:
On Sun, 26 Sep 2010, Justin P. Mattock wrote:
diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c
index 033e150..d7d9a78 100644
--- a/drivers/char/apm-emulation.c
+++ b/drivers/char/apm-emulation.c
@@ -8,7 +8,7 @@
* (APM
On 09/27/2010 09:15 PM, Finn Thain wrote:
On Mon, 27 Sep 2010, Justin P. Mattock wrote:
alright.. I'll redu this... remove the brackets, and fix up the rest..
one note is:
http://dri.freedesktop.org/wiki/Documentation
this address is already there..
Right you are.
probably best to just
On 09/28/2010 12:35 AM, Finn Thain wrote:
On Tue, 28 Sep 2010, Justin P. Mattock wrote:
o.k... I'll make the changes to the arch patch, and combine the two, and
send it to jiri..
Why?
My advice is don't do it unless you want to waste reviewers' time.
as for the names and signed offs
On 09/27/2010 09:15 PM, Finn Thain wrote:
>
> On Mon, 27 Sep 2010, Justin P. Mattock wrote:
>
>> alright.. I'll redu this... remove the brackets, and fix up the rest..
>> one note is:
>> http://dri.freedesktop.org/wiki/Documentation
>> this address
Below is an updated patch to fix broken web addresses in the kernel.
Please let me know if I missed anything, and I'll go back and fix it.
and lastly Thanks for all the help with this...
Signed-off-by: Justin P. Mattock
Cc: Maciej W. Rozycki
Cc: Geert Uytterhoeven
Cc: Finn Thain
Cc: Randy
On 09/27/2010 07:59 PM, Finn Thain wrote:
>
> On Sun, 26 Sep 2010, Justin P. Mattock wrote:
>
>> diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c
>> index 033e150..d7d9a78 100644
>> --- a/drivers/char/apm-emulation.c
>> +++ b/drivers/cha
On 09/27/2010 06:37 PM, Finn Thain wrote:
>
> On Mon, 27 Sep 2010, Justin P. Mattock wrote:
>
>> On 09/27/2010 09:03 AM, Joe Perches wrote:
>>> On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote:
>>>> On Sun, Sep 26, 2010 at 11:31:15AM -0700,
On 09/27/2010 09:03 AM, Joe Perches wrote:
> On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote:
>> On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote:
>>> Below is an updated patch from the original fixing broken web addresses in
>>> the kernel.
On 09/27/2010 08:10 AM, John W. Linville wrote:
> On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote:
>> Below is an updated patch from the original fixing broken web addresses in
>> the kernel.
>> Thanks for all the help and info on this to everybody..
>
alright(going to top post because of how long this is). I will go and
make the changes and resend it out...
On 09/26/2010 02:43 AM, Finn Thain wrote:
Hi Justin,
Some comments on your latest patch follow.
On Fri, 24 Sep 2010, Justin P. Mattock wrote:
--- a/drivers/ata/pata_it821x.c
+++ b
On 09/27/2010 08:10 AM, John W. Linville wrote:
On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote:
Below is an updated patch from the original fixing broken web addresses in the
kernel.
Thanks for all the help and info on this to everybody..
Hopefully I didnt miss any of them
On 09/27/2010 09:03 AM, Joe Perches wrote:
On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote:
On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote:
Below is an updated patch from the original fixing broken web addresses in the
kernel.
Thanks for all the help and info
On 09/27/2010 06:37 PM, Finn Thain wrote:
On Mon, 27 Sep 2010, Justin P. Mattock wrote:
On 09/27/2010 09:03 AM, Joe Perches wrote:
On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote:
On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote:
Below is an updated patch from
Below is an updated patch from the original fixing broken web addresses in the
kernel.
Thanks for all the help and info on this to everybody..
Hopefully I didnt miss any of them(if so let me know, and I'll resend).
Signed-off-by: Justin P. Mattock
Cc: Maciej W. Rozycki
Cc: Geert Uytterhoeven
alright(going to top post because of how long this is). I will go and
make the changes and resend it out...
On 09/26/2010 02:43 AM, Finn Thain wrote:
>
> Hi Justin,
>
> Some comments on your latest patch follow.
>
>
> On Fri, 24 Sep 2010, Justin P. Mattock wrote:
&
On 09/25/2010 01:47 PM, Matthew Dharm wrote:
> On Fri, Sep 24, 2010 at 05:51:56PM -0700, Justin P. Mattock wrote:
>> On 09/24/2010 05:34 PM, Greg KH wrote:
>>> On Fri, Sep 24, 2010 at 05:08:56PM -0700, Justin P. Mattock wrote:
>>>> The below patch, is a simple fix to
On 09/24/2010 05:34 PM, Greg KH wrote:
> On Fri, Sep 24, 2010 at 05:08:56PM -0700, Justin P. Mattock wrote:
>> The below patch, is a simple fix to a broken web address not using a period
>> in it's
>> name. I'll leave this up to you guys if you want to use it...
>>
&
Below is just a patch showing all the archive.org in the kernel so far.
up to you if you guys want to use this..
Signed-off-by: Justin P. Mattock
---
drivers/block/Kconfig |2 +-
drivers/edac/i82975x_edac.c |2 +-
drivers/hwmon/hwmon-vid.c
The below patch, is a simple fix to a broken web address not using a period in
it's
name. I'll leave this up to you guys if you want to use it...
Signed-off-by: Justin P. Mattock
---
.../comedi/drivers/addi-data/APCI1710_82x54.c |2 +-
.../comedi/drivers/addi-data/APCI1710_82x54.h
Below is an updated patch to fix some of the broken web addresses in the kernel.
Thanks to all the help from everybody, Ive made(hopefully)most of the changes.
Please have a look when you have time, and let me know what might need fixing.
Signed-off-by: Justin P. Mattock
Cc: Maciej W. Rozycki
The below patch, is a simple fix to a broken web address not using a period in
it's
name. I'll leave this up to you guys if you want to use it...
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
.../comedi/drivers/addi-data/APCI1710_82x54.c |2 +-
.../comedi/drivers/addi
Below is just a patch showing all the archive.org in the kernel so far.
up to you if you guys want to use this..
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/block/Kconfig |2 +-
drivers/edac/i82975x_edac.c |2 +-
drivers/hwmon
On 09/24/2010 05:34 PM, Greg KH wrote:
On Fri, Sep 24, 2010 at 05:08:56PM -0700, Justin P. Mattock wrote:
The below patch, is a simple fix to a broken web address not using a period in
it's
name. I'll leave this up to you guys if you want to use it...
Signed-off-by: Justin P
and fixes for now,
then when the time is right, I can bunch everything all into one big patch.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
Cc: Maciej W. Rozycki ma...@linux-mips.org
Cc: Finn Thain fth...@telegraphics.com.au
Cc: Randy Dunlap rdun...@xenotime.net
---
arch/arm/Kconfig
On 09/21/2010 08:25 PM, Finn Thain wrote:
On Tue, 21 Sep 2010, Justin P. Mattock wrote:
Below is an update from the original, with changes to the broken web
addresses and removal of archive.org and moved to a seperate patch for
you guys to decide if you want to use this and/or just leave
searching capabilities.
Please dont apply this to anything, just comments and changes for now, then
at the right time I'll bunch everything into one patch.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
Cc: Finn Thain fth...@telegraphics.com.au
---
arch/arm/mach-footbridge/Kconfig
On 09/21/2010 08:25 PM, Finn Thain wrote:
On Tue, 21 Sep 2010, Justin P. Mattock wrote:
Below is an update from the original, with changes to the broken web
addresses and removal of archive.org and moved to a seperate patch for
you guys to decide if you want to use this and/or just leave
and fixes for now,
then when the time is right, I can bunch everything all into one big patch.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
Cc: Maciej W. Rozycki ma...@linux-mips.org
Cc: Finn Thain fth...@telegraphics.com.au
Cc: Randy Dunlap rdun...@xenotime.net
---
arch/arm/Kconfig
searching capabilities.
Please dont apply this to anything, just comments and changes for now, then
at the right time I'll bunch everything into one patch.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
Cc: Finn Thain fth...@telegraphics.com.au
---
arch/arm/mach-footbridge/Kconfig
On 09/21/2010 08:25 PM, Finn Thain wrote:
On Tue, 21 Sep 2010, Justin P. Mattock wrote:
Below is an update from the original, with changes to the broken web
addresses and removal of archive.org and moved to a seperate patch for
you guys to decide if you want to use this and/or just leave
/LID0/state
then
/usr/sbin/s2ram
fi
works reliably over here(knock on wood..)with radeon not sure
with intel cards..
Justin P. Mattock
--
Start uncovering the many advantages of virtual appliances
and start using them
/acpi/lid.sh in there its a simple call to s2ram (works fine(with
radeon though))looking at some of the distros scripts(no-offense) theres
loads of stuff in there todo all kinds of calls..
hope this helps.
Justin P. Mattock
Below is a patch to update the broken web addresses, in crypto/*
that I could locate. Some are just simple typos that needed to be
fixed, and some had a change in location altogether..
let me know if any of them need to be changed and such.
Signed-off-by: Justin P. Mattock justinmatt
be diff..
Justin P. Mattock
On 09/03/2010 12:52 AM, Geert Uytterhoeven wrote:
linux-alpha was the wrong list?
it is... I became overwhelmed with who to send these too i.e. having too
many Cc's was in question, so I used getmaintainer.pl on the first patch
to give me some direction on who/what/where to send these too.
On 09/03/2010 01:20 AM, Finn Thain wrote:
These TIL articles are still around, and removing the article number from
the source code is doing it damage.
(I'm guessing that this change to human readable text was suggested by a
machine...)
I checked on archive.org for the URL, which lead me to
On 09/03/2010 01:23 AM, Finn Thain wrote:
URLs can't be split across lines usefully, so disregard the checkpatch
complaint.
Finn
with the coding style, what files should ignore coding style with the
tab rule i.e. Kconfig *.c, *.h, README, etc...
(from here Kconfig make sense due to the
On 09/03/2010 01:47 AM, Finn Thain wrote:
On Fri, 3 Sep 2010, Justin P. Mattock wrote:
On 09/03/2010 01:23 AM, Finn Thain wrote:
URLs can't be split across lines usefully, so disregard the checkpatch
complaint.
Finn
with the coding style, what files should ignore coding style
On 09/03/2010 01:57 AM, Finn Thain wrote:
Why http://www.linux-m68k.org/mail.html?
If you try this search:
http://www.google.com.au/search?q=inurl:680x0/q40
You should see:
http://ftp.uni-erlangen.de/pub/unix/Linux/680x0/q40/
Finn
no hits searching over here, just spamm..(snapshot to show)
On 09/03/2010 02:26 AM, Finn Thain wrote:
On Fri, 3 Sep 2010, Justin P. Mattock wrote:
On 09/03/2010 01:57 AM, Finn Thain wrote:
Why http://www.linux-m68k.org/mail.html?
If you try this search:
http://www.google.com.au/search?q=inurl:680x0/q40
You should see:
http://ftp.uni-erlangen.de
On 09/03/2010 02:13 AM, Finn Thain wrote:
On Fri, 3 Sep 2010, Justin P. Mattock wrote:
On 09/03/2010 01:47 AM, Finn Thain wrote:
On Fri, 3 Sep 2010, Justin P. Mattock wrote:
On 09/03/2010 01:23 AM, Finn Thain wrote:
URLs can't be split across lines usefully, so disregard the
checkpatch
On 09/03/2010 02:40 AM, Finn Thain wrote:
On Fri, 3 Sep 2010, Justin P. Mattock wrote:
so the safest is to just ignore the column limit for urls to make things
legit.
That's how I've dealt with URLs in C comments in the past, and no-one
complained (and I don't see any decent alternative
without crashing..
Ill add the allow rules into the policy and run it to see if anything
happens.
Thank you vary much for this..
Justin P. Mattock
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
old)
Message-ID :4c2fc0e3.6050...@gmail.com
References : http://marc.info/?l=linux-kernelm=127819798215589w=2
only have seen this once..on the other hand (If im correct)maciej or
pauli where able to reproduce this.. I say leave open then go from there.
Justin P. Mattock
USB Mouse: Close
[54.464] (II) UnloadModule: evdev
[54.470] (II) Built-in iSight: Close
[54.470] (II) UnloadModule: evdev
let me know if you need any info from a log or something.
Justin P. Mattock
___
xorg-devel@lists.x.org: X.Org
After reading through XACE-Spec.txt, then looking through all the code
I found the below comment, not to make sense. I think it needs to be
changed to adjust due to the Property access mode bits giving info
on adjusting different modes etc..(but could be wrong).
Signed-off-by: Justin P. Mattock
On 08/19/2010 10:06 AM, Adam Jackson wrote:
On Thu, 2010-08-19 at 09:43 -0700, Justin P. Mattock wrote:
After reading through XACE-Spec.txt, then looking through all the code
I found the below comment, not to make sense. I think it needs to be
changed to adjust due to the Property access mode
also) but the transition is a
with xfce4 is a bit tricky..
Justin P. Mattock
___
xorg@lists.freedesktop.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: http://lists.freedesktop.org/mailman/listinfo/xorg
Your subscription
.
Justin P. Mattock
this is my first attempt to build gcc with all these
packages in the source tree of gcc rather than building them separately.
Justin P. Mattock
(hosts system/new system etc..)
figured once im able to boot the fresh system I'll probably rebuild with
ppl/cloog added in.
Justin P. Mattock
On 08/02/2010 06:34 AM, Rafael J. Wysocki wrote:
On Monday, August 02, 2010, Justin P. Mattock wrote:
On 08/01/2010 06:52 AM, Rafael J. Wysocki wrote:
This message has been generated automatically as a part of a summary report
of recent regressions.
The following bug entry is on the current
: 2010-07-25 17:06 (8 days old)
Yes, I just managed to reproduce this with 2.6.35-final, and will
update the bugzilla entry with the wire-capture needed.
ahh.. cool.. lets get this bug fixed...
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe kernel-testers in
the body
: 2010-07-25 17:06 (8 days old)
Yes, I just managed to reproduce this with 2.6.35-final, and will
update the bugzilla entry with the wire-capture needed.
Oops just realized your talking about another bug. nevermind.
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe
://www.tux.org/lkml/
Ive played around with the machine that originally hit this. but still
cant seem to reproduce or trigger this.
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe kernel-testers in
the body of a message to majord...@vger.kernel.org
More majordomo
. atheros has one of these as
well(like I posted)
how to reproduce such a beast of a bug...
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe kernel-testers in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
at
-http://ozlabs.org/~dgibson/dtc/dtc.tar.gz
+http://ozlabs.org/
I think this link should really be:
git clone git://www.jdl.com/software/dtc.git/
Actually, maybe this instead?
http://git.jdl.com/gitweb/?p=dtc.git
Mikey
cool thanks.. I resent..
Justin P. Mattock
On 07/14/2010 05:12 AM, Herbert Xu wrote:
On Tue, Jul 06, 2010 at 11:36:37AM -0700, Justin P. Mattock wrote:
The below patch gets rid of an unused variable ctx reported by
GCC when building the kernel.
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795x.c: In function 'hifn_flush
read the FAQ at http://www.tux.org/lkml/
cool a solution... glad to see... no chance at a bisect with this?
(getting this down too a commit or two makes things easier)
Justin P. Mattock
On 07/07/2010 11:44 PM, Ingo Molnar wrote:
>
> * Justin P. Mattock wrote:
>
>> On 07/02/10 13:04, Justin P. Mattock wrote:
>>> this is new(below) has anybody reported/bisected hit this yet
>>> (if not I'll bisect it)
>>>
>>> [drm] Num pipes:
On 07/08/2010 11:28 AM, Corey Minyard wrote:
On 07/07/2010 11:05 PM, Justin P. Mattock wrote:
what ever came about with this?
Justin P. Mattock
Well, Sergey sent a patch, but I don't think it was quite in a form that
can be taken. Do you want to resend per the standard rules?
-corey
..
Tested-By: Justin P. Mattock justinmatt...@gmail.com
cheers as well,
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
what ever came about with this?
Justin P. Mattock
--
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
This fixes a warning I'm seeing when building:
CC [M] drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not in
enumerated type 'enum v4l2_memory'
Signed-off-by: Justin P. Mattock
/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used
Please have a look, and let me know if this is legit or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/crypto/hifn_795x.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git
not vary much results)
I believe the right answer is to delete the line initialising ctx.
Thanks,
o.k. then I'll resend with delete the line initialising ctx
Thanks for having a look..
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used
just remove the line that initialises ctx.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/crypto/hifn_795x.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto
This certainly does not look right! Returning with IRQs disabled
is considered to be rude.
I believe the right answer is to delete the line initialising ctx.
Thanks,
o.k. hopefully this is correct this time, resent with the following
change. let me know if it's legit or not..
Justin P
: In function 'hifn_process_queue':
drivers/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/crypto/hifn_795x.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/hifn_795x.c b
On 07/06/2010 11:58 AM, Evgeniy Polyakov wrote:
On Tue, Jul 06, 2010 at 11:36:37AM -0700, Justin P. Mattock
(justinmatt...@gmail.com) wrote:
The below patch gets rid of an unused variable ctx reported by
GCC when building the kernel.
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto
(KERN_ERR PFX Could not allocate SI data (3)\n);
return -ENOMEM;
-- 1.7.1.rc1.21.gf3bd6
Thanks for the info on this..
Justin P. Mattock
--
This SF.net email is sponsored by Sprint
What will you do first
On 07/06/2010 01:14 PM, Sergey V. wrote:
On Tuesday 06 of July 2010 22:30:00 Justin P. Mattock wrote:
Hello Justin.
[...]
@@ -2021,10 +2020,6 @@ static __devinit int try_init_spmi(struct SPMITable
*spmi)
}
if (spmi-addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY
On 07/05/2010 07:34 PM, Xiaotian Feng wrote:
On Tue, Jul 6, 2010 at 2:18 AM, Justin P. Mattock
justinmatt...@gmail.com wrote:
On 07/05/2010 10:27 AM, Marvin wrote:
Hi Wakko,
as nobody seems to have answered yet, I think it's better that you file a
bug
against the radeon driver
On 07/02/10 13:04, Justin P. Mattock wrote:
> this is new(below) has anybody reported/bisected hit this yet
> (if not I'll bisect it)
>
> [drm] Num pipes: 1
> [ 29.742432] [drm] writeback test succeeded in 1 usecs
> [ 30.089717] X:2252 conflicting memory types 4000-48
0x9a
[ 30.354255] [] sys_exit_group+0x12/0x16
[ 30.354255] [] system_call_fastpath+0x16/0x1b
[ 30.354255] RSP
[ 31.312879] ---[ end trace 9a7b92300d4121f6 ]---
[ 30.354255] [] fput+0x122/0x1f1
[ 30.354255] [] filp_close+0x63/0x6d
Justin P. Mattock
] [81026442] system_call_fastpath+0x16/0x1b
[ 30.354255] RSP 8800360dfc80
[ 31.312879] ---[ end trace 9a7b92300d4121f6 ]---
[ 30.354255] [810ebb6e] fput+0x122/0x1f1
[ 30.354255] [810e9181] filp_close+0x63/0x6d
Justin P. Mattock
On 07/02/10 13:04, Justin P. Mattock wrote:
this is new(below) has anybody reported/bisected hit this yet
(if not I'll bisect it)
[drm] Num pipes: 1
[ 29.742432] [drm] writeback test succeeded in 1 usecs
[ 30.089717] X:2252 conflicting memory types 4000-4800
uncached-minus-write
est it out!!)
Signed-off-by: Justin P. Mattock
---
drivers/gpu/drm/drm_gem.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 33dad3f..d1648bf 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
: warning: variable 'tun' set
but not used
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
Reviewed-By: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/common/tuners/tuner-simple.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common
, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;
- tun = priv-tun;
-
/* IFPCoff = Video Intermediate Frequency - Vif:
940 =16*58.75 NTSC/J (Japan)
732 =16*45.75 M/N STD
Justin P. Mattock
--
To unsubscribe from
On 06/19/2010 01:06 AM, Geert Uytterhoeven wrote:
On Sat, Jun 19, 2010 at 06:45, Justin P. Mattock
justinmatt...@gmail.com wrote:
This is not dead code. NLMSG_NEW() sets up an nlmsg in ab-skb.
If you remove the code, it's no longer initialized.
I played around with this code some more
On 06/19/2010 01:08 AM, Geert Uytterhoeven wrote:
On Sat, Jun 19, 2010 at 07:04, Justin P. Mattock
justinmatt...@gmail.com wrote:
Also wrong, you removed the creation of the links in sysfs.
The assignment to nowarn was there to avoid another compiler warning,
as sysfs_create_link() is marked
On 06/19/2010 12:45 PM, Geert Uytterhoeven wrote:
On Sat, Jun 19, 2010 at 21:10, Justin P. Mattock
justinmatt...@gmail.com wrote:
On 06/19/2010 01:08 AM, Geert Uytterhoeven wrote:
On Sat, Jun 19, 2010 at 07:04, Justin P. Mattock
justinmatt...@gmail.comwrote:
Also wrong, you removed
4f45beed80627d2bb32fb021bb6d22d88089557b Mon Sep 17 00:00:00 2001
From: Justin P. Mattock justinmatt...@gmail.com
Date: Fri, 18 Jun 2010 22:01:07 -0700
Subject: [PATCH 5/5] module.c
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
kernel/module.c |3 +--
1 files changed, 1 insertions(+), 2
On 06/15/2010 04:43 AM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here
);
mutex_unlock(core_lock);
return 0;
cool thanks!! applied the above patch and now the warning is no longer
there. Here is what I see:
LD kernel/built-in.o
CC drivers/i2c/i2c-core.o
LD drivers/i2c/built-in.o
CC [M] drivers/uio/uio.o
cheers,
Justin P. Mattock
On 06/15/2010 11:53 AM, Sergey V. wrote:
> On Tuesday 15 of June 2010 00:26:44 Justin P. Mattock wrote:
>> Im getting this warning when compiling:
>> CC drivers/char/tpm/tpm.o
>> drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
>> drivers/char/tpm/tpm.c:50
On 06/15/2010 04:38 AM, Jean Delvare wrote:
> On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote:
>> Temporary fix until something is resolved
>
> This is wrong by design, sorry. Warnings aren't blocking, and thus need
> no "temporary fix". Such temporar
On 06/15/2010 04:43 AM, Jean Delvare wrote:
> Hi Justin,
>
> On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
>> On 06/14/2010 01:53 PM, Jean Delvare wrote:
>>> Hi Justin,
>>>
>>> On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wr
On 06/14/2010 04:07 PM, Stefan Richter wrote:
On 14 Jun, Justin P. Mattock wrote:
On 06/14/2010 02:47 PM, Edward Shishkin wrote:
Whitespaces should be removed.
I recommend quilt package for managing patches:
quilt refresh --strip-trailing-whitespace is your friend..
o.k. I resent
On 06/14/2010 05:13 PM, valdis.kletni...@vt.edu wrote:
On Mon, 14 Jun 2010 13:26:44 PDT, Justin P. Mattock said:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc
On 06/14/2010 08:49 PM, valdis.kletni...@vt.edu wrote:
On Mon, 14 Jun 2010 19:12:31 PDT, Justin P. Mattock said:
what I tried was this:
if (!rc)
printk(test\n)
and everything looked good,
but as a soon as I changed
rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:
Em 14-06-2010 23:26, Justin P. Mattock escreveu:
not sure if this is correct or not for
fixing this warning:
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq
On 06/15/2010 04:38 AM, Jean Delvare wrote:
On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote:
Temporary fix until something is resolved
This is wrong by design, sorry. Warnings aren't blocking, and thus need
no temporary fix. Such temporary fixes would be only hiding the
warning
On 06/15/2010 11:53 AM, Sergey V. wrote:
On Tuesday 15 of June 2010 00:26:44 Justin P. Mattock wrote:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set
On 06/15/2010 02:19 AM, Jean Delvare wrote:
On Tue, 15 Jun 2010 07:29:44 +0200, Peter Stuge wrote:
Justin P. Mattock wrote:
*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.
I have no manual in front of me. Did a quick google, but came up with
(no hits
On 06/15/2010 04:43 AM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here
On 06/15/2010 04:38 AM, Jean Delvare wrote:
On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote:
Temporary fix until something is resolved
This is wrong by design, sorry. Warnings aren't blocking, and thus need
no temporary fix. Such temporary fixes would be only hiding the
warning
On 06/15/2010 11:53 AM, Sergey V. wrote:
On Tuesday 15 of June 2010 00:26:44 Justin P. Mattock wrote:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set
301 - 400 of 748 matches
Mail list logo
