[PATCH net-next 01/13] selftests: forwarding: Allow lib.sh sourcing from other directories

2018-06-29 Thread Petr Machata
Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/lib.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index d1f14f83979e..59272824ef37 100644

[PATCH net-next 02/13] selftests: forwarding: lib: Add check_err_fail()

2018-06-29 Thread Petr Machata
of the first argument, should_fail. Signed-off-by: Petr Machata Reviewed-by: Yuval Mintz --- tools/testing/selftests/net/forwarding/lib.sh | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh

[PATCH net-next 00/13] mlxsw: Add resource scale tests

2018-06-29 Thread Petr Machata
a Spectrum-specific wrapper. Patch #13 then introduces a scale test driver that runs (possibly a subset of) the tests introduced by patches from previous paragraph. Arkadi Sharshevsky (1): selftests: mlxsw: Add router test Petr Machata (8): selftests: forwarding: lib: Add check_err_fail()

[PATCH net-next 4/4] selftests: forwarding: mirror_gre_changes: Fix waiting for neighbor

2018-06-28 Thread Petr Machata
When running the test on soft devices, there's no mechanism to gratuitously start resolving the neighbor for remote tunnel endpoint. So instead of passively waiting, wait for the device to be up, and then probe the neighbor with a ping. Signed-off-by: Petr Machata --- tools/testing/selftests

[PATCH net-next 3/4] selftests: forwarding: Tweak tc filters for mirror-to-gretap tests

2018-06-28 Thread Petr Machata
out GRE packet. Drop the corresponding condition. - Because the above fixes the filters to match in slow path as well, they need to be made skip_hw so as not to double-count packets. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_gre_bridge_1d_vlan.sh | 6

[PATCH net-next 2/4] selftests: forwarding: lib: Avoid trapping soft devices

2018-06-28 Thread Petr Machata
is actually a soft device not backed by an ASIC. Therefore try to trap if possible, but fall back to inserting a continue if not. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/lib.sh | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 0/4] Fixes for running mirror-to-gretap tests on veth

2018-06-28 Thread Petr Machata
, installing a trap is made optional. In patch #3, tc filters in several tests are tweaked to work with veth. In patch #4, the logic for waiting for neighbor is fixed for veth. Petr Machata (4): selftests: forwarding: lib: Split out setup_wait_dev() selftests: forwarding: lib: Avoid trapping soft

[PATCH net-next 1/4] selftests: forwarding: lib: Split out setup_wait_dev()

2018-06-28 Thread Petr Machata
Split out of setup_wait() a function setup_wait_dev() that waits for a single device. This gives tests the opportunity to wait for a selected device after they tinkered with its upness. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/lib.sh | 25

[PATCH net-next 6/6] selftests: forwarding: README: Require diagrams

2018-06-25 Thread Petr Machata
the interconnects from the script itself proves to be difficult. Therefore state the requirement for topology ASCII art in README. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- tools/testing/selftests/net/forwarding/README | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing

[PATCH net-next 3/6] selftests: forwarding: tc_rule_stats_get: Parameterize direction

2018-06-25 Thread Petr Machata
The GRE multipath tests need stats on an egress counter. Change tc_rule_stats_get() to take direction as an optional argument, with default of ingress. Take the opportunity to change line continuation character from | to \. Move the | to the next line, which indent. Signed-off-by: Petr Machata

[PATCH net-next 5/6] selftests: forwarding: Test multipath tunneling

2018-06-25 Thread Petr Machata
Add a GRE-tunneling test such that there are two tunnels involved, with a multipath route listing both as next hops. Similarly to router_multipath.sh, test that the distribution of traffic to the tunnels honors the configured weights. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel

[PATCH net-next 4/6] selftests: forwarding: lib: Extract interface-init functions

2018-06-25 Thread Petr Machata
and address de/initialization logic to a new pair of helpers __simple_if_init() / __simple_if_fini(), and defer to these helpers from simple_if_init() and simple_if_fini(). Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- tools/testing/selftests/net/forwarding/lib.sh | 32

[PATCH net-next 1/6] selftests: forwarding: Move multipath_eval() to lib.sh

2018-06-25 Thread Petr Machata
This function will be useful for the GRE multipath test that is coming later. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- tools/testing/selftests/net/forwarding/lib.sh | 39 ++ .../selftests/net/forwarding/router_multipath.sh | 39

[PATCH net-next 2/6] selftests: forwarding: multipath_eval(): Improve style

2018-06-25 Thread Petr Machata
- Change the indentation of the function body from 7 spaces to one tab. - Move initialization of weights_ratio up so that it can be referenced from the error message about packet difference being zero. - Move |'s consistently to continuation line, which reindent. Signed-off-by: Petr Machata

[PATCH net-next 0/6] Multipath tests for tunnel devices

2018-06-25 Thread Petr Machata
, a requirement to add diagrams to selftests is documented. Petr Machata (6): selftests: forwarding: Move multipath_eval() to lib.sh selftests: forwarding: multipath_eval(): Improve style selftests: forwarding: tc_rule_stats_get: Parameterize direction selftests: forwarding: lib: Extract

[PATCH net-next] selftests: forwarding: mirror_gre_vlan_bridge_1q: Unset rp_filter

2018-06-25 Thread Petr Machata
. Fixes: 9c7c8a82442c ("selftests: forwarding: mirror_gre_vlan_bridge_1q: Add more tests") Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- .../selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh| 9 + 1 file changed, 9 insertions(+) diff --git a/tools/testing

[PATCH net-next v2] selftests: net: Test headroom handling of ip6_gre devices

2018-06-25 Thread Petr Machata
two patches included snippets that reproduced the issues. This patch elevates the snippets to a full-fledged test case. Suggested-by: David Miller Signed-off-by: Petr Machata --- Notes: Changes between v1 and v2: - Move tunnel construction to setup() and destruction to cleanup(). too

[Bridge] [PATCH net v2] net: bridge: Fix locking in br_fdb_find_port()

2018-06-08 Thread Petr Machata
. The device pointer copied from inside the FDB entry is then kept alive by the RTNL lock, which br_fdb_find_port() asserts. Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions") Signed-off-by: Petr Machata --- Notes: Changes from v1 to v2: - Instead of taking hash

Re: [PATCH net-next] selftests: forwarding: Fix importing dependent libraries

2018-06-05 Thread Petr Machata
Petr Machata writes: > When libraries are sourced from elsewhere from the tree, such as the > testing/selftests/drivers/net/mlxsw subdirectory, sourcing their own Sorry, I didn't realize the mirror_bridge.sh is not upstream yet. This patch is thus immaterial, it will be sent to

[PATCH net-next] selftests: forwarding: Fix importing dependent libraries

2018-06-05 Thread Petr Machata
, and source the file using relative path appropriate for the subdirectory. Fixes: d5ea2bfc806a ("selftests: forwarding: mirror_gre_lib: Extract generic functions") Fixes: 74ed089d48a4 ("selftests: forwarding: Split mirror_gre_topo_lib.sh") Signed-off-by: Petr Machata --- too

[PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description

2018-05-31 Thread Petr Machata
The test description is displayed with the PASS/FAIL resolution after the test is ran. There however already is one other test described exactly like this, which makes it unclear which of the tests passed or failed. Make the description unique. Signed-off-by: Petr Machata --- tools/testing

[PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets

2018-05-31 Thread Petr Machata
in suite is renamed to differentiate it from another test of the same name. Petr Machata (2): selftests: forwarding: mirror_vlan: Uninstall trap selftests: forwarding: mirror_vlan: Change test description tools/testing/selftests/net/forwarding/mirror_vlan.sh | 4 ++-- 1 file changed, 2 insert

[PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap

2018-05-31 Thread Petr Machata
Instead of installing a trap before tests run and uninstalling it after they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 9/9] selftests: forwarding: mirror_gre_bridge_1d_vlan: Add STP test

2018-05-31 Thread Petr Machata
To test offloading of mirror-to-gretap in mlxsw for cases that a VLAN-unaware bridge is in underlay packet path, test that the STP status of bridge egress port is reflected. Signed-off-by: Petr Machata --- .../selftests/net/forwarding/mirror_gre_bridge_1d_vlan.sh| 12 1 file

[PATCH net-next 8/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Add more tests

2018-05-31 Thread Petr Machata
that similarly check "egress untagged" - fdb_roaming tests that check whether learning FDB on a different port is reflected - stp tests for handling port STP status of bridge egress port Signed-off-by: Petr Machata --- .../net/forwarding/mirror_gre_vlan_bridge_1q.sh| 129 +++

[PATCH net-next 7/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Rename two tests

2018-05-31 Thread Petr Machata
Rename test_gretap_forbidden() and test_ip6gretap_forbidden() to a more specific test_gretap_forbidden_cpu() and test_ip6gretap_forbidden_cpu(). This will make it clearer which is which when further down a patch is introduced that forbids a VLAN on regular bridge port. Signed-off-by: Petr Machata

[PATCH net-next 6/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Test final config

2018-05-31 Thread Petr Machata
After the final change reestablishes the original configuration, make sure the traffic flows again as it should. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools

[PATCH net-next 5/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Fix tunnel name

2018-05-31 Thread Petr Machata
The "ip6gretap" in the test name refers to the tunnel device type that the test is supposed to be testing. However test_ip6gretap_forbidden() tests, due to a typo, a gretap tunnel. Fix the typo. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_gre_vlan_br

[PATCH net-next 0/9] Test mirror-to-gretap with bridge in UL

2018-05-31 Thread Petr Machata
. Petr Machata (9): selftests: forwarding: lib: Move here vlan_capture_{,un}install() selftests: forwarding: mirror_lib: Move here do_test_span_vlan_dir_ips() selftests: forwarding: mirror_lib: skip_hw the VLAN capture selftests: forwarding: mirror_gre_lib: Add STP test selftests

[PATCH net-next 4/9] selftests: forwarding: mirror_gre_lib: Add STP test

2018-05-31 Thread Petr Machata
Add a reusable full test that toggles STP state of a given bridge port and checks that the mirroring reacts appropriately. The test will be used by bridge tests in follow-up patches. Signed-off-by: Petr Machata --- .../selftests/net/forwarding/mirror_gre_lib.sh | 32

[PATCH net-next 3/9] selftests: forwarding: mirror_lib: skip_hw the VLAN capture

2018-05-31 Thread Petr Machata
When the VLAN capture is installed on a front panel device and not a soft device, the packets are counted twice: once in fast path, and once after they are trapped to the kernel. Resolve the problem by passing skip_hw flag to vlan_capture_install(). Signed-off-by: Petr Machata --- tools/testing

[PATCH net-next 2/9] selftests: forwarding: mirror_lib: Move here do_test_span_vlan_dir_ips()

2018-05-31 Thread Petr Machata
Move the function do_test_span_vlan_dir_ips() from mirror_vlan.sh test to a library file mirror_lib.sh to allow reuse. Fill in other entry points similar to other testing functions in mirror_lib.sh, they will be useful in following patches. Signed-off-by: Petr Machata --- .../testing/selftests

[PATCH net-next 1/9] selftests: forwarding: lib: Move here vlan_capture_{,un}install()

2018-05-31 Thread Petr Machata
Move vlan_capture_install() and vlan_capture_uninstall() from mirror_vlan.sh test to lib.sh so that it can be reused in other tests. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/lib.sh | 23 ++ .../selftests/net/forwarding/mirror_vlan.sh

Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-30 Thread Petr Machata
David Miller writes: > From: Petr Machata > Date: Mon, 28 May 2018 17:44:16 +0200 > >> Callers of br_fdb_find() need to hold the hash lock, which >> br_fdb_find_port() doesn't do. Add the missing lock/unlock >> pair. >> >> Signed-off-by: Pet

[Bridge] [PATCH net-next v4 8/8] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-29 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Bridge] [PATCH net-next v4 7/8] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata --- net/bridge/br_vlan.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index 602c869..7df2690 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c

[Bridge] [PATCH net-next v4 5/8] dsa: port: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
the current behavior. Signed-off-by: Petr Machata Reviewed-by: Vivien Didelot --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/port.c index 2413beb..ed05954 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -252,6 +252,9 @@ int dsa_port_vlan_add

[PATCH net-next v4 8/8] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-29 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next v4 7/8] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata --- net/bridge/br_vlan.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index 602c869..7df2690 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c

[PATCH net-next v4 6/8] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
the current behavior. Signed-off-by: Petr Machata --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index c723a04..a17dd29 100644 --- a/drivers/staging/fsl-dpaa2/ethsw

[PATCH net-next v4 5/8] dsa: port: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
the current behavior. Signed-off-by: Petr Machata Reviewed-by: Vivien Didelot --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/port.c index 2413beb..ed05954 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -252,6 +252,9 @@ int dsa_port_vlan_add

[PATCH net-next v4 4/8] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
the current behavior. Signed-off-by: Petr Machata --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index e73e4fe..aeafdb9 100644 --- a/drivers/net/ethernet

[Bridge] [PATCH net-next v4 2/8] net: bridge: Extract br_vlan_add_existing()

2018-05-29 Thread Petr Machata
Extract the code that deals with adding a preexisting VLAN to bridge CPU port to a separate function. A follow-up patch introduces a need to roll back operations in this block due to an error, and this split will make the error-handling code clearer. Signed-off-by: Petr Machata --- net/bridge

[PATCH net-next v4 3/8] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
the current behavior. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw

[PATCH net-next v4 2/8] net: bridge: Extract br_vlan_add_existing()

2018-05-29 Thread Petr Machata
Extract the code that deals with adding a preexisting VLAN to bridge CPU port to a separate function. A follow-up patch introduces a need to roll back operations in this block due to an error, and this split will make the error-handling code clearer. Signed-off-by: Petr Machata --- net/bridge

[PATCH net-next v4 1/8] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-29 Thread Petr Machata
and del calls. Thus to remove the duplication, extract the repetition into named functions and reuse. Signed-off-by: Petr Machata Reviewed-by: Vivien Didelot --- net/bridge/br_private.h | 13 + net/bridge/br_switchdev.c | 25 + net/bridge/br_vlan.c | 26

[Bridge] [PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
rt_obj_del() to br_switchdev_port_vlan_add() and br_switchdev_port_vlan_del(), and move from br_vlan.c to br_switchdev.c. Petr Machata (8): net: bridge: Extract boilerplate around switchdev_port_obj_*() net: bridge: Extract br_vlan_add_existing() mlxsw: spectrum_switchdev: Ignore bridge VLAN event

[PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
rt_obj_del() to br_switchdev_port_vlan_add() and br_switchdev_port_vlan_del(), and move from br_vlan.c to br_switchdev.c. Petr Machata (8): net: bridge: Extract boilerplate around switchdev_port_obj_*() net: bridge: Extract br_vlan_add_existing() mlxsw: spectrum_switchdev: Ignore bridge VLAN event

Re: [Bridge] [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
Ilias Apalodimas writes: >> diff --git a/drivers/net/ethernet/rocker/rocker_main.c >> b/drivers/net/ethernet/rocker/rocker_main.c >> index e73e4fe..aeafdb9 100644 >> --- a/drivers/net/ethernet/rocker/rocker_main.c >> +++ b/drivers/net/ethernet/rocker/rocker_main.c >> @@ -1632,6 +1632,9 @@

Re: [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
Ilias Apalodimas writes: >> diff --git a/drivers/net/ethernet/rocker/rocker_main.c >> b/drivers/net/ethernet/rocker/rocker_main.c >> index e73e4fe..aeafdb9 100644 >> --- a/drivers/net/ethernet/rocker/rocker_main.c >> +++ b/drivers/net/ethernet/rocker/rocker_main.c >> @@ -1632,6 +1632,9 @@

Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
Dan Carpenter writes: > On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: >> @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 >> flags, bool *changed) >> vg->num_vlans++; >>

Re: [Bridge] [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
Dan Carpenter writes: > On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: >> @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 >> flags, bool *changed) >> vg->num_vlans++; >>

Re: [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-28 Thread Petr Machata
Nikolay Aleksandrov writes: > Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions") Correct. Thanks, Petr

Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-28 Thread Petr Machata
Nikolay Aleksandrov writes: > Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions") Correct. Thanks, Petr

[PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-28 Thread Petr Machata
Callers of br_fdb_find() need to hold the hash lock, which br_fdb_find_port() doesn't do. Add the missing lock/unlock pair. Signed-off-by: Petr Machata <pe...@mellanox.com> --- net/bridge/br_fdb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bridge/br_fdb.c b/net/bridge/br

[Bridge] [PATCH net-next v3 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-28 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 fil

[Bridge] [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Tested-by: Florian Fainel

[Bridge] [PATCH net-next v3 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2

[Bridge] [PATCH net-next v3 4/7] dsa: port: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/

[Bridge] [PATCH net-next v3 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/

[Bridge] [PATCH net-next v3 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[PATCH net-next v3 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2

[PATCH net-next v3 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Tested-by: Florian Fainel

[PATCH net-next v3 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/

[PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
and del calls. Thus to remove the duplication, extract the repetition into named functions and reuse. Signed-off-by: Petr Machata <pe...@mellanox.com> --- net/bridge/br_private.h | 13 + net/bridge/br_switchdev.c | 25 + net/bridge/br_vlan.c

[PATCH net-next v3 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-28 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 fil

[PATCH net-next v3 4/7] dsa: port: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/

[PATCH net-next v3 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/

[PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Tested-by: Florian Fainel

[PATCH net-next v3 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2

[PATCH net-next v3 4/7] dsa: port: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/

[Bridge] [PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
and del calls. Thus to remove the duplication, extract the repetition into named functions and reuse. Signed-off-by: Petr Machata <pe...@mellanox.com> --- net/bridge/br_private.h | 13 + net/bridge/br_switchdev.c | 25 + net/bridge/br_vlan.c

[PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
- Rename br_switchdev_port_obj_add() and br_switchdev_port_obj_del() to br_switchdev_port_vlan_add() and br_switchdev_port_vlan_del(), and move from br_vlan.c to br_switchdev.c. Petr Machata (7): net: bridge: Extract boilerplate around switchdev_port_obj_*() mlxsw: spectrum_switchdev: Ignore bridge V

[PATCH net-next v3 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-28 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 fil

[PATCH net-next v3 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
and del calls. Thus to remove the duplication, extract the repetition into named functions and reuse. Signed-off-by: Petr Machata <pe...@mellanox.com> --- net/bridge/br_private.h | 13 + net/bridge/br_switchdev.c | 25 + net/bridge/br_vlan.c

[Bridge] [PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
- Rename br_switchdev_port_obj_add() and br_switchdev_port_obj_del() to br_switchdev_port_vlan_add() and br_switchdev_port_vlan_del(), and move from br_vlan.c to br_switchdev.c. Petr Machata (7): net: bridge: Extract boilerplate around switchdev_port_obj_*() mlxsw: spectrum_switchdev: Ignore bridge V

[PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
- Rename br_switchdev_port_obj_add() and br_switchdev_port_obj_del() to br_switchdev_port_vlan_add() and br_switchdev_port_vlan_del(), and move from br_vlan.c to br_switchdev.c. Petr Machata (7): net: bridge: Extract boilerplate around switchdev_port_obj_*() mlxsw: spectrum_switchdev: Ignore bridge V

Re: [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
Petr Machata <pe...@mellanox.com> writes: > diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h > index 11520ed..33bd914 100644 > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -1178,6 +1178,9 @@ static inline void br_switchdev_frame_unmark(s

Re: [Bridge] [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
Petr Machata <pe...@mellanox.com> writes: > diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h > index 11520ed..33bd914 100644 > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -1178,6 +1178,9 @@ static inline void br_switchdev_frame_unmark(s

Re: [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
Petr Machata <pe...@mellanox.com> writes: > diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h > index 11520ed..33bd914 100644 > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -1178,6 +1178,9 @@ static inline void br_switchdev_frame_unmark(s

[PATCH net-next v2 0/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
br_vlan.c to br_switchdev.c. Petr Machata (7): net: bridge: Extract boilerplate around switchdev_port_obj_*() mlxsw: spectrum_switchdev: Ignore bridge VLAN events rocker: rocker_main: Ignore bridge VLAN events dsa: port: Ignore bridge VLAN events staging: fsl-dpaa2: ethsw: Ignore bridge VLAN ev

[PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
and del calls. Thus to remove the duplication, extract the repetition into named functions and reuse. Signed-off-by: Petr Machata <pe...@mellanox.com> --- net/bridge/br_private.h | 3 +++ net/bridge/br_switchdev.c | 25 + net/bridge/br_vlan.c

[PATCH net-next v2 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[PATCH net-next v2 4/7] dsa: port: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/

[PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/

[PATCH net-next v2 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-28 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 fil

[PATCH net-next v2 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Tested-by: Florian Fainel

[Bridge] [PATCH net-next v2 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-28 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 fil

[Bridge] [PATCH net-next v2 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Tested-by: Florian Fainel

[Bridge] [PATCH net-next v2 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2

[Bridge] [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/

[Bridge] [PATCH net-next v2 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/

[Bridge] [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-28 Thread Petr Machata
and del calls. Thus to remove the duplication, extract the repetition into named functions and reuse. Signed-off-by: Petr Machata <pe...@mellanox.com> --- net/bridge/br_private.h | 3 +++ net/bridge/br_switchdev.c | 25 + net/bridge/br_vlan.c

[PATCH net-next v2 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-28 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2

[PATCH net-next v2 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-28 Thread Petr Machata
to changes in bridge vlan configuration right away and another notification would have to arrive for mlxsw to catch up. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Ido Schimmel <ido...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 fil

[PATCH net-next v2 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
port or a bridge. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Tested-by: Florian Fainel

[PATCH net-next v2 0/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
br_vlan.c to br_switchdev.c. Petr Machata (7): net: bridge: Extract boilerplate around switchdev_port_obj_*() mlxsw: spectrum_switchdev: Ignore bridge VLAN events rocker: rocker_main: Ignore bridge VLAN events dsa: port: Ignore bridge VLAN events staging: fsl-dpaa2: ethsw: Ignore bridge VLAN ev

<    1   2   3   4   5   6   7   8   9   10   >