On Wed, 23 Nov 2022 06:58:09 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
This pull request has now been integrated.
Changeset: 0ed8b337
Author: Dongxu Wang
Committer: Yi Yang
URL:
https://git.openjdk.org/jdk/com
8297385: Remove duplicated null typos in javadoc
-
Commit messages:
- 8297385: Remove duplicated null typo in javadoc
Changes: https://git.openjdk.org/jdk/pull/11311/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11311=00
Issue: https://bugs.openjdk.org/browse/JDK-8297385
On Tue, 15 Nov 2022 15:05:45 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/11169
On Wed, 23 Nov 2022 06:49:56 GMT, Dongxu Wang wrote:
>> 8297385: Remove duplicated null typos in javadoc
>
> Dongxu Wang has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in b
On Wed, 23 Nov 2022 06:43:56 GMT, Yi Yang wrote:
> This looks good, but I'm not a Reviewer, you still need an approval from
> Reviewer.
Thanks
-
PR: https://git.openjdk.org/jdk/pull/11169
> 8297385: Remove duplicated null typos in javadoc
Dongxu Wang has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains two additional commits since the
l
On Tue, 22 Nov 2022 03:33:55 GMT, Yi Yang wrote:
> > > good catch, do you need a JBS issue for this?
> >
> >
> > Thank you if you can help with that.
>
> I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change
> your PR title and commit message to [8297385: Remove
On Mon, 21 Nov 2022 15:16:14 GMT, Yi Yang wrote:
> good catch, do you need a JBS issue for this?
Thank you if you can help with that.
-
PR: https://git.openjdk.org/jdk/pull/11169
8297385: Remove duplicated null typos in javadoc
-
Commit messages:
- Minor remove duplicate null typo
Changes: https://git.openjdk.org/jdk/pull/11169/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11169=00
Issue: https://bugs.openjdk.org/browse/JDK-8297385
Stats: 3 lines
+1
On Mon, Jul 26, 2021 at 7:38 PM Dongxu 王东旭 wrote:
> +1
>
> ccing Manolo, thank you.
>
> On Mon, Jul 26, 2021 at 10:16 AM Rene Cordier wrote:
>
>> +1,
>>
>> Rene.
>>
>> On 23/07/2021 16:00, btell...@apache.org wrote:
>> > Hello all,
>> >
>> > Following a first email on the topic [1] I would
[
https://issues.apache.org/jira/browse/HUPA-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongxu Wang reassigned HUPA-109:
Assignee: Dongxu Wang (was: Manuel Carrasco Moñino)
> Mail Attachment does not work in HTTPS m
[
https://issues.apache.org/jira/browse/HUPA-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongxu Wang reassigned HUPA-117:
Assignee: Dongxu Wang (was: Manuel Carrasco Moñino)
> The folder item should be highlighted af
On 2013/6/3 9:48, Fam Zheng wrote:
On Thu, 05/30 18:00, Dongxu Wang wrote:
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Document for add-cow format, the usage and spec of add-cow are
introduced.
v18-v19:
1) backing_fmt and image_fmt NUL-terminated.
2) other fix.
V17-V18:
1) remove version
opts_accepts_any() ==
true.
2) since def_print_str is the default value if an option isn't set,
so rename it to def_value_str.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
include/qemu/option.h | 3 ++-
util/qemu-option.c| 32
)
If bar has been set in opts, return its value.
Else, if opt's QemuOptDesc has a default value for bar, return
that.
Else, return NULL.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
v13-v14:
1) change code style.
2) assert errors.
Signed-off-by: Dongxu Wang wdon
These patches will replace QEMUOptionParameter with QemuOpts. Change logs
please go to each patch's commit message.
V14-V15:
1) Only delete enum QEMUOptionParType.
Dong Xu Wang (6):
add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print
avoid duplication of default value in
-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
v13-v14:
1) rewrite commit message.
2) use def_value_str in qemu_opt_get_FOO_del() and qemu_opt_get_del().
3) delete redundant qemu_opt_del(opt).
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
include/qemu/option.h | 11 -
util/qemu
Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
include/qemu/option.h | 3 ++
util/qemu-option.c| 82 +++
2 files changed, 85 insertions(+)
diff --git a/include/qemu/option.h b/include/qemu/option.h
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
include/qemu/option.h | 39 ---
util/qemu-option.c| 285 --
2 files changed, 324 deletions(-)
diff --git a/include/qemu/option.h b
It will introduce a new file format: add-cow.
The add-cow file format makes it possible to perform copy-on-write on top of
a raw disk image. When we know that no backing file clusters remain visible
(e.g. we have streamed the entire image and copied all data from the backing
file), then it is
.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
docs/specs/add-cow.txt | 172 +
1 file changed, 172 insertions(+)
create mode 100644 docs/specs/add-cow.txt
diff --git a/docs/specs/add
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Block layer will use qcow2-cache as common cache code, so rename
it to block-cache.c.
v18-v19:
1) only rename, did not touch other code.
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
block/Makefile.objs| 3 +-
block/block-cache.c
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Make qed_read_string function to a common interface, so move it to
block.c.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
block.c | 27
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
We will use path_has_protocol outside block.c, so just make it public.
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
block.c
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
This patch will use qemu-iotests to test add-cow file format.
v17-v18:
1) add 037 and 038 tests.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
tests/qemu-iotests/017 | 2
-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
block/Makefile.objs | 1 +
block/add-cow.c | 812
block/block-cache.c | 16 +-
include/block/block-cache.h | 4 +
include/block/block_int.h | 2 +
5 files changed, 831
struct to source file.
2) cluster_size-table_size.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
block/block-cache.c | 75 ++---
block/qcow2-cluster.c | 30 +-
block
Hi,
Now block layer does not check whether backing_file chain can be a
circle, do you think it is necessary to do a check?
For example, 1.qcow2's backing_file is 2.qcow2 and 2.qcow2's
backing_file is 1.qcow2, then any IO operation will be a fault.
If necessary, I will post a patch to fix.
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com
---
block/blkdebug.c | 3 +++
block/block-cache.c | 4 ++--
include/block/block.h | 3 +++
3 files changed, 8 insertions(+), 2
On 2013/5/30 20:48, Stefan Hajnoczi wrote:
hain 1.qcow2' don't crash.
qemu-img info --backing-chain detects cycles and returns an error, see
the hash table in collect_image_info_list().
We should protect bdrv_open() too.
Okay, will send a patch.
Stefan
On 2013/5/31 5:22, Eric Blake wrote:
On 05/30/2013 03:55 AM, Dongxu Wang wrote:
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print will be used while using qemu-img create, it will
produce the same output
On 2013/5/31 5:43, Eric Blake wrote:
On 05/30/2013 03:55 AM, Dongxu Wang wrote:
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
This patch will create 4 functions, count_opts_list, qemu_opts_append,
s/will create/creates/ - commit messages make the most sense when
written in present tense
35 matches
Mail list logo
