[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...

2018-07-25 Thread Lemonjing
GitHub user Lemonjing reopened a pull request: https://github.com/apache/flink/pull/6411 [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ## What is the purpose of the change This pull request update scala api `ScalaCsvOutputFormat

[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...

2018-07-25 Thread Lemonjing
Github user Lemonjing closed the pull request at: https://github.com/apache/flink/pull/6411 ---

[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...

2018-07-25 Thread Lemonjing
GitHub user Lemonjing opened a pull request: https://github.com/apache/flink/pull/6411 [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ## What is the purpose of the change This pull request update scala api `ScalaCsvOutputFormat

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-01 Thread Lemonjing
Github user Lemonjing commented on a diff in the pull request: https://github.com/apache/spark/pull/20897#discussion_r178481268 --- Diff: docs/mllib-pmml-model-export.md --- @@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API * Table of contents {:toc

[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-01 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20897 see http://spark.apache.org/docs/latest/ml-features.html#elementwiseproduct --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-26 Thread Lemonjing
Github user Lemonjing commented on a diff in the pull request: https://github.com/apache/spark/pull/20897#discussion_r177113075 --- Diff: docs/mllib-feature-extraction.md --- @@ -278,8 +278,8 @@ for details on the API. multiplication. In other words, it scales each column

[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-25 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20897 @HyukjinKwon The description of ElementwiseProduct is obvious, and i think "`Qu8T948*1#`" is a mistake, if not, "`Qu8T948*1#`" is a input vector and

[GitHub] spark pull request #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-24 Thread Lemonjing
Github user Lemonjing closed the pull request at: https://github.com/apache/spark/pull/20889 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-24 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung thanks a lot. and i closed it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 can someone help me to close this pr? i have merged these commits to a new pr. https://github.com/apache/spark/pull/20897

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-23 Thread Lemonjing
GitHub user Lemonjing opened a pull request: https://github.com/apache/spark/pull/20897 [MINOR][DOC] Fix a few markdown typos ## What changes were proposed in this pull request? Easy fix in the markdown. ## How was this patch tested? jekyII build test

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @HyukjinKwon Thanks a lot, could u help me to review these commits if u have time。 --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung hi,In my reading process,I found another md file typos and fix it. Do I need to close this pr and merge it into one commit and give a new pr? Thanks

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung Yes, I read the entire docs of Spark Mlib. There is no problem with other mds (I may not have seen it or other contributors solved it). This error is obvious, and it affects the link

[GitHub] spark pull request #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
GitHub user Lemonjing opened a pull request: https://github.com/apache/spark/pull/20889 [MINOR][DOC] Fix ml-guide markdown typos ## What changes were proposed in this pull request? Easy fix in the markdown. ## How was this patch tested? Tested manually