[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements zoned_traits. (PR #91059)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/91059 Implements parts of: - P0355 Extending chrono to Calendars and Time Zones >From 0a602d2268923936a62034faaaf10f2401457d99 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_local. (PR #91003)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/91003 Implements parts of: - P0355 Extending chrono to Calendars and Time Zones >From 5f205f7478a13a6f7034808dff390c3fe87564dc Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90901)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/90901 >From 775f5459258db3416e90dbe0f8b0ee24f7125e95 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH] [libc++][TZDB] Implements time_zone::to_sys. This implements

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90901)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/90901 This implements the overload with the choose argument and adds this enum. Implements parts of: - P0355 Extending chrono to Calendars and Time Zones >From b888e3cc20a9198578348ac3bf3f6d505425a63c Mon Sep 17

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] [modules] Add _LIBCPP_USING_IF_EXISTS on aligned_alloc (#89827) (PR #89894)

mordante wrote: I don't feel like this needs a release note. https://github.com/llvm/llvm-project/pull/89894 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/90394 >From d7b42718303e017acfe3e61c67d6e8a9bb0ffa9d Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH] [libc++][TZDB] Implements time_zone::to_sys. This implements

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/90394 >From e72a966c0aca3319d7aea43d3a9dd4cc25eaeb70 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH] [libc++][TZDB] Implements time_zone::to_sys. This implements

[llvm-branch-commits] [libcxx] [libc++][chrono] implements UTC clock. (PR #90393)

@@ -0,0 +1,1004 @@ +//===--===// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] implements UTC clock. (PR #90393)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/90393 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] implements UTC clock. (PR #90393)

https://github.com/mordante commented: Thanks for your review comments. https://github.com/llvm/llvm-project/pull/90393 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][chrono] implements UTC clock. (PR #90393)

@@ -0,0 +1,124 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] implements UTC clock. (PR #90393)

@@ -0,0 +1,155 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/90394 >From fe9a4ce7f13e981d1ebcdfb088e16da686e22ea1 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH] [libc++][TZDB] Implements time_zone::to_sys. This implements

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/90394 >From e0f5f099af76108a1b3de6b2735e084047e029c0 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH] [libc++][TZDB] Implements time_zone::to_sys. This implements

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/90394 >From c0cdd074a1e22c3d35f2e235cfd6f0bf74b406dc Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH] [libc++][TZDB] Implements time_zone::to_sys. This implements

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/90394 This implements the throwing overload and the exception classes throw by this overload. Implements parts of: - P0355 Extending chrono to Calendars and Time Zones >From e722747d35b87cbcf8e12847c799f87a6082bb73

[llvm-branch-commits] [libcxx] [libc++][chrono] Fixes leap seconds. (PR #90070)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/90070 While implementing the UTC clock it turns out that the implementation of the leap seconds was not correct, it should store the individual value, not the sum. It also looks like LWG3359 has not been fully

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] [modules] Add _LIBCPP_USING_IF_EXISTS on aligned_alloc (#89827) (PR #89894)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/89894 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

mordante wrote: > @mordante The PR looks odd. Is this intentional or have you mixed two > branches? This is due to using manually stacked reviews in GitHub. This is patch 3 in a series * patch 1 has landed * I just rebased patch 2 and wait for the CI * patch 3 now believes patches 1 & 2 part

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time zone get_info(local_time). (PR #89537)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/89537 Implements parts of: - P0355 Extending to Calendars and Time Zones >From ed7053e22620924b6bc18a46cfd6d7201afab3fe Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject:

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/89503 >From d1f131136d005699a882bf30af9520b06fc898b4 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH 1/3] [libc++] Makes saturation functions privately available.

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/89503 >From d1f131136d005699a882bf30af9520b06fc898b4 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 17 Apr 2024 21:00:22 +0200 Subject: [PATCH 1/2] [libc++] Makes saturation functions privately available.

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

@@ -107,6 +107,35 @@ _LIBCPP_HIDE_FROM_ABI constexpr _Rp saturate_cast(_Tp __x) noexcept { return static_cast<_Rp>(__x); } +#endif // _LIBCPP_STD_VER >= 20 + +#if _LIBCPP_STD_VER >= 26 + +template <__libcpp_integer _Tp> +_LIBCPP_HIDE_FROM_ABI constexpr _Tp add_sat(_Tp __x,

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/89503 These functions are useful in the implementation of the time zone database. So expose them with private names. The functions could be exposed before C++ 20, but since libc++ is mostly C++ 17 complete it seems

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89498)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/89498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89498)

mordante wrote: This was not properly stacked, abandoned. https://github.com/llvm/llvm-project/pull/89498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89502)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/89502 Testing with the get_info() returning a local_info revealed some issues in the reverse lookup. This needed an additional quirck. Also the skipping when not in the current continuation optimization was wrong.

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89498)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/89498 Testing with the get_info() returning a local_info revealed some issues in the reverse lookup. This needed an additional quirck. Also the skipping when not in the current continuation optimization was wrong.

[llvm-branch-commits] [libcxx] [libc++][chrono] Fixes format output of negative values. (PR #89408)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/89408 The negative values were shown as 1900-01-01 00:01:39.-0001 after the changes they are shown as 1900-01-01 00:01:39.9 >From 11fa6e806dd9a2a6f0a036041de8245f5bcd Mon Sep 17 00:00:00 2001

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/86256 >From 73d01a392239c643c1636e9b34310c42f20b3c90 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 14 Mar 2024 21:10:58 +0100 Subject: [PATCH] [libc++][TZDB] Adds local_info formatter. Note the code using

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/86256 >From 42728d0c66c0a9592949d7bad611bd7d8fe1cd5e Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 14 Mar 2024 21:10:58 +0100 Subject: [PATCH] [libc++][TZDB] Adds local_info formatter. Note the code using

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From 96bc907e4f38cd771bc8fed3936932b841c6bd26 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From e6ae1f07641b79b63b772b866176ffef94a25d48 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] coerce formatter precision to int (#87738) (PR #87801)

mordante wrote: > > Is it OK to merge this with the failing test? > > is it possible this was a fix for an XFAIL @mordante ? This failure is in completely unrelated code. So I'm happy to merge it with the CI failure. https://github.com/llvm/llvm-project/pull/87801

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/88419 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From de4ba883c354ab8510fb0e5e4ad2a09d93000c30 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/86127 >From 677956d0923c499f8f6d1f13035f5f60d48ea7c8 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 21 Mar 2024 15:22:13 +0100 Subject: [PATCH] [libc++][chrono] Improves date formatting. The formatting of

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85797 >From cb87ecc505cf538eaa657a7cc3b1b282e3e7298d Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Improves time zone format specifiers. Per

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/88283 The change increments the size of the lookup table considerably. The table has an "upper boundary" check. The removal of the code units with the property Grapheme_Extend=Yes removes the range E0100..E01EF.

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] coerce formatter precision to int (#87738) (PR #87801)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/87801 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: Reapply [libcxx] [modules] Fix relative paths with absolute LIBCXX_INSTALL_MODULES_DIR (#86020) (PR #86197)

mordante wrote: > @mordante Is the test failure legitimate? I've checked and the test failure is unrelated to this patch. https://github.com/llvm/llvm-project/pull/86197 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/86256 >From 601338a04e28e356f0d9b90448ec2550f8870783 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 14 Mar 2024 21:10:58 +0100 Subject: [PATCH] [libc++][TZDB] Adds local_info formatter. Note the code using

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/86256 >From 358347b163202b27b724543727d7602b4c4a19a8 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 14 Mar 2024 21:10:58 +0100 Subject: [PATCH] [libc++][TZDB] Adds local_info formatter. Note the code using

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/86256 This adds the local_info type and its formatting options. The usage of the local_info object will be done in separate patches. Implements parts of: - P0355 Extending to Calendars and Time Zones - P1361

[llvm-branch-commits] [libcxx] release/18.x: Reapply [libcxx] [modules] Fix relative paths with absolute LIBCXX_INSTALL_MODULES_DIR (#86020) (PR #86197)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/86197 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/85896 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From f3e7b583dd8eae59c3caeb84ac3967f361f6e6eb Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 21 Mar 2024 15:22:13 +0100 Subject: [PATCH 1/2] [libc++][chrono] Improves date formatting. The formatting

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/86127 >From f3e7b583dd8eae59c3caeb84ac3967f361f6e6eb Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 21 Mar 2024 15:22:13 +0100 Subject: [PATCH] [libc++][chrono] Improves date formatting. The formatting of

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/86127 The formatting of years has been done manually since the results of %Y outside the "typical" range may produce unexpected values. The same applies to %F which is identical to %Y-%m-%d. Note of these conversion

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From 3eaa059039c7fe9ea4b5fdaadacac7d9c8fa5f3f Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From c17bb85f4863f1fffa8654b4e1931dfebc430e2d Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From 1c5788302b38da71881854bbee772e3ad8d58cb4 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From caa67f946d7128ebe63c859ed7aa9a03c825e81e Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From 0dbc61d5f18f9fe5f20119805baa968f66504144 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] [modules] Fix relative paths with absolute LIBCXX_INSTALL_MODULES_DIR (#85756) (PR #85907)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/85907 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85896 >From 7372394c21017fe3840a6c7a6c92ff9b66f0d13d Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject: [PATCH] [libc++][TZDB] Adds sys_info formatter. Implements parts of: -

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/85896 Implements parts of: - P0355 Extending to Calendars and Time Zones - P1361 Integration of chrono with text formatting >From 5597a07ac32a21d05b674d767395ee7583d11073 Mon Sep 17 00:00:00 2001 From: Mark de Wever

[llvm-branch-commits] [clang] release/18.x: Reland Print library module manifest path again (#84881) (PR #85637)

mordante wrote: Based on the [post review comments ](https://github.com/llvm/llvm-project/pull/84881#issuecomment-2003793001) on the original PR I feel I need to do additional work. The feature originally landed shortly before branching. Based on the number of issues we had with I feel we

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/85797 Per [tab:time.format.spec] %z The offset from UTC as specified in ISO 8601-1:2019, subclause 5.3.4.1. For example -0430 refers to 4 hours 30 minutes behind UTC. If the offset is zero, + is used. The

[llvm-branch-commits] [libcxx] [NFC][libc++][TZDB] Refactors argument order. (PR #85781)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/85781 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [NFC] Refactors argument order. (PR #85781)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/85781 Putting the output reference argument first looks more sensible. >From 1af98d79952669b1ce05b42aeeae32bd4ea83ee7 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 10 Mar 2024 17:49:39 +0100 Subject:

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

@@ -41,4 +41,5 @@ "`4001 `__","``iota_view`` should provide ``empty``","Kona November 2023","","","|ranges|" "","","","","","" "`3343 `__","Ordering of calls to ``unlock()`` and ``notify_all()`` in Effects element of

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/82157 >From 7a742c0e564ffa37ad299cf6186faadd61e34d29 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Fri, 23 Sep 2022 18:33:20 +0200 Subject: [PATCH] [libc++][chrono] Completes the tzdb class. It adds the missing

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

https://github.com/mordante approved this pull request. @tstellar due to the new LLVM version number scheme this code would mix LLVM 17 and LLVM 18. (LLVM 18.1 is not considered to be LLVM 18.) Since these are expected not to be ABI stable it seems we ran into ODR violations. For main I

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

mordante wrote: > Is the fix only to switch to 18.1 in the cmake? I can do that if that's it, I > just don't fully understand the situation w/ clang tidy ODR violations since > you were the one to make these changes That should be all. I'm also happy to do it, but that will be tomorrow.

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

mordante wrote: > @mordante So should I close this PR? I see you already did. Do you want to make a fix for the release branch or do you want me to pick that up? https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

mordante wrote: I'd rather fix the clang-tidy integration. I'm quite sure we have ODR violations since we use clang-tidy 18 with clang 17 libraries. These violations break the modules, but other clang-tidy checks may also have issues. Changing

[llvm-branch-commits] [libcxx] release/18.x: [libc++][modules] Fixes naming inconsistency. (#83036) (PR #83156)

mordante wrote: I assume it will then be in 18.1.1 in a few weeks. https://github.com/llvm/llvm-project/pull/83156 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/82157 It adds the missing member functions of the tzdb class and adds the free functions that use these member functions. Implements parts of: - P0355 Extending to Calendars and Time Zones >From

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/82113 >From 3710cf0f9e8fa6065b25123e9b2158079e10805c Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Fri, 23 Sep 2022 18:33:20 +0200 Subject: [PATCH] [libc++][chrono] Loads leap-seconds.list in tzdb. MIME-Version:

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/82113 This implements the loading of the leap-seconds.list file and store its contents in the tzdb struct. This adds the required `leap_seconds` member. The class leap_seconds is fully implemented including its

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Only include from the C library if it exists (#81887) (PR #82045)

https://github.com/mordante approved this pull request. It looks like the Buildkite failures are due to the known Windows bot issues. https://github.com/llvm/llvm-project/pull/82045 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [libcxx] release/18.x: [libc++][modules] Fix disabling Unicode (#81294) (PR #81361)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/81361 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] PR for llvm/llvm-project#79155 (PR #80484)

https://github.com/mordante approved this pull request. https://github.com/llvm/llvm-project/pull/80484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76246 >From eebe9b2fab5c5eef4776852270bf70af4626cfcb Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 20 Dec 2023 20:43:38 +0100 Subject: [PATCH 1/3] [libc++][modules] Adds module testing. This adds a new

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -52,6 +52,21 @@ def _executeScriptInternal(test, litConfig, commands): return (out, err, exitCode, timeoutInfo, parsedCommands) +def _validateModuleDependencies(modules): +for m in modules: +if m not in ("std", "std.compat"): +raise

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76246 >From eebe9b2fab5c5eef4776852270bf70af4626cfcb Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 20 Dec 2023 20:43:38 +0100 Subject: [PATCH 1/2] [libc++][modules] Adds module testing. This adds a new

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76268 >From b3c567f4a4369b1d22f189f272a3fa86c1f0f401 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Fri, 22 Dec 2023 21:43:57 +0100 Subject: [PATCH] [libc++][modules] Increase clang-tidy version used. As

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -156,7 +156,9 @@ export namespace std { using std::reinterpret_pointer_cast; using std::static_pointer_cast; +#ifndef _LIBCPP_HAS_NO_RTTI using std::get_deleter; +#endif // _LIBCPP_HAS_NO_RTTI mordante wrote: This tested here, but should land

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76246 >From eebe9b2fab5c5eef4776852270bf70af4626cfcb Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 20 Dec 2023 20:43:38 +0100 Subject: [PATCH] [libc++][modules] Adds module testing. This adds a new module

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -131,13 +138,65 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76246 >From 196cedd36534b02a7c55cf4a1746b34f87ead467 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 20 Dec 2023 20:43:38 +0100 Subject: [PATCH 1/3] [libc++][modules] Adds module testing. This adds a new

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -131,13 +138,65 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -131,13 +138,65 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76246 >From 196cedd36534b02a7c55cf4a1746b34f87ead467 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 20 Dec 2023 20:43:38 +0100 Subject: [PATCH 1/2] [libc++][modules] Adds module testing. This adds a new

[llvm-branch-commits] [libcxx] [llvm] [libc++][modules] Adds module testing. (PR #76246)

@@ -131,13 +138,65 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: > > Then I can prohibit clang-16 and clang-17. > > Yeah, that's the solution. clang-tidy defines the same version macros as > clang does, so prohibiting it from clang-16 is the same as prohibiting it for > clang-tidy 16. What makes it currently hard for modules is that in the

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: > > Oh shit. I just realized that this is most likely a latent bug no matter > > what. We build the module with Clang 18, and then essentially try to load > > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, > > and probably just happens to work

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy enable modernize-use-nullptr. (PR #76659)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/76659 Clang-tidy 18 no longer has false positives with the spaceship operator. Note that I'm quite sure there are more occurrences in our headers that are not caught. >From b28cb6581a371eee5e1f06da2b4d3711b501aee3

[llvm-branch-commits] [libcxx] [libc++] Implements filebuf unbuffered. (PR #76629)

@@ -276,6 +276,30 @@ private: state_type __st_; state_type __st_last_; ios_base::openmode __om_; + // Used to track the currently used mode and track whether the output should mordante wrote: Review note: It might be possible to use other fields to

[llvm-branch-commits] [libcxx] [libc++] Implements filebuf unbuffered. (PR #76629)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/76629 When calling setbuf(nullptr, 0) before performing file operations it should set the file to unbuffered mode. Currently the code avoids buffering internally, but the underlying stream still can buffer. This is

[llvm-branch-commits] [libcxx] [libc++][modules] Improves std.compat module. (PR #76330)

@@ -17,38 +17,17 @@ module; // The headers of Table 24: C++ library headers [tab:headers.cpp] // and the headers of Table 25: C++ headers for C library facilities  [tab:headers.cpp.c] -#include -#include -#include -#if !defined(_LIBCPP_HAS_NO_ATOMIC_HEADER) -# include

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: Good point, I actually think that's true. I think we should do that in a separate PR. Maybe discuss it on Discord after the holidays. https://github.com/llvm/llvm-project/pull/76268 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: It's the line `export import std;` in https://github.com/llvm/llvm-project/pull/76330/files#diff-e881fdd0e6e66610142a28228b2bbf0e38520ee7186946bca06cb8d195dcd2b4 This works with Clang-17, Clang-18, and clang-tidy-18. It fails with clang-tidy-17. Clang-tidy tests that directly

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

mordante wrote: > > > If you are okay with the suggestions that I made for some typos in the > > > documentation, I will preemptively incorporate it into my documentation > > > PR. > > > > > > Thanks for the suggestions! Please do no incorporate these in your PR. > > Other reviewers may

[llvm-branch-commits] [libcxx] [libc++][modules] Improves std.compat module. (PR #76330)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76330 >From 6134779ac0f53ed22d8ddfc14908e595eb94fb65 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 24 Dec 2023 12:13:00 +0100 Subject: [PATCH] [libc++][modules] Improves std.compat module. Let the

[llvm-branch-commits] [libcxx] [libc++][modules] Improves std.compat module. (PR #76330)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/76330 Let the std.compat module use the std module instead of duplicating the exports. Based on @ChuanqiXu9's suggestion in #71438. >From 246a8a14f125934b5e8c84b2d391db72ee4dc647 Mon Sep 17 00:00:00 2001 From: Mark

[llvm-branch-commits] [libcxx] [libc++][modules] Fixes clang-tidy exports. (PR #76288)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/76288 As suggested in #71438 we should use export import std; in the std.compat module. Using this exports some named declarations from functions and records, adding them to the global namespace. Clang correctly,

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: > I'm really not happy with bumping the clang-tidy version we use all the time > to the trunk version. We agreed to using the latest stable version, which > we've not done way too many times now. I'd really like to first understand > what exactly the issue is that is solved by

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/76268 >From 10dcb9404ac63bd1c10936e60f21159e7eabe38b Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Fri, 22 Dec 2023 21:43:57 +0100 Subject: [PATCH] [libc++][modules] Increase clang-tidy version used. As

  1   2   >