Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@felixcheung done
https://user-images.githubusercontent.com/7606389/45593911-617ad000-b9c3-11e8-892a-4690396b66a1.png;>
https://user-images.githubusercontent.com/7606
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@felixcheung is that to me?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@srowen thanks; done
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22370
@felixcheung thanks for the feedback, yes, I axed `registerTempTable` from
the `SparkDataFrame `@family`.
Sorry I botched an attempt to try and rename the branch of this PR
GitHub user MichaelChirico opened a pull request:
https://github.com/apache/spark/pull/22393
Axe deprecated doc refs
Continuation of #22370. Summary of discussion there:
There is some inconsistency in the R manual w.r.t. supercedent functions
linking back to deprecated
Github user MichaelChirico closed the pull request at:
https://github.com/apache/spark/pull/22370
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user MichaelChirico commented on a diff in the pull request:
https://github.com/apache/spark/pull/22370#discussion_r216222159
--- Diff: R/pkg/R/catalog.R ---
@@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) {
#' @param ... additional named parameters as opti
Github user MichaelChirico commented on a diff in the pull request:
https://github.com/apache/spark/pull/22370#discussion_r216222094
--- Diff: R/pkg/R/catalog.R ---
@@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) {
#' @param ... additional named parameters as opti
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22370
@felixcheung I disagree... what's the point of deprecation if it's going to
keep being considered as a co-equal function in the eyes of documentation?
If the function is being
Github user MichaelChirico commented on a diff in the pull request:
https://github.com/apache/spark/pull/22370#discussion_r216220254
--- Diff: R/pkg/R/catalog.R ---
@@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) {
#' @param ... additional named parameters as opti
GitHub user MichaelChirico opened a pull request:
https://github.com/apache/spark/pull/22370
don't link to deprecated function
Seems misleading to (without qualification) link to a deprecated function
## What changes were proposed in this pull request?
(Please fill
Github user MichaelChirico closed the pull request at:
https://github.com/apache/spark/pull/22278
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22278
@HyukjinKwon this is about usability/user-friendliness. As mentioned,
despite being a seasoned R user & increasingly familiar with `SparkR`
documentation, I spent several minutes goog
GitHub user MichaelChirico opened a pull request:
https://github.com/apache/spark/pull/22278
emphasize deprecation
Was poking around documentation for `formals` of this method as I'd seen it
recommended and completely missed the `Deprecated` tag; even after seeing
elsewhere it's
14 matches
Mail list logo
