[RFC 0/4] Kexec: Enable run time memory resrvation of crash kernel

2016-08-12 Thread Ronit Halder
movable pages become unmovable momentarily for pinning. The CMA fails for this reason. I don't have any solution for that right now. This approach will work when the this problems with CMA will be fixed. The patch is enabled by a kernel configuration option CONFIG_KEXEC_CMA. Ronit Halder (4):

[RFC 2/4] Functions for memory reservation and release

2016-08-12 Thread Ronit Halder
Functions reserve and release memory from CMA area(s). Signed-off-by: Ronit Halder <ronit@gmail.com> --- include/linux/kexec.h | 11 ++- kernel/kexec_core.c | 83 +++ 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/i

[RFC 4/4] Enable memory allocation through sysfs interface

2016-08-12 Thread Ronit Halder
e size set is zero, the both the allocated region in low and high memory will be released. Signed-off-by: Ronit Halder <ronit@gmail.com> --- kernel/ksysfs.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c index

[RFC 1/4] Creating one or two CMA area at Boot time

2016-08-12 Thread Ronit Halder
memory and one in high memory) will be created. Signed-off-by: Ronit Halder <ronit@gmail.com> --- arch/x86/kernel/setup.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c

[RFC 4/4] Enable memory allocation through sysfs interface

2016-08-12 Thread Ronit Halder
e size set is zero, the both the allocated region in low and high memory will be released. Signed-off-by: Ronit Halder <ronit@gmail.com> --- kernel/ksysfs.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c index

[RFC 4/4] Enable memory allocation through sysfs interface

2016-08-12 Thread Ronit Halder
e size set is zero, the both the allocated region in low and high memory will be released. Signed-off-by: Ronit Halder --- kernel/ksysfs.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c index e83b264..4cc286d 100644 --

[RFC 3/4] Adding a new kernel configuration to enable the feature

2016-08-12 Thread Ronit Halder
Kernel configuration option added to enable run time memory reservation feature for kexec. Signed-off-by: Ronit Halder <ronit@gmail.com> --- mm/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mm/Kconfig b/mm/Kconfig index 97a4e06..8b1533d 100644 --- a/mm/Kconfig ++

[RFC 3/4] Adding a new kernel configuration to enable the feature

2016-08-12 Thread Ronit Halder
Kernel configuration option added to enable run time memory reservation feature for kexec. Signed-off-by: Ronit Halder --- mm/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mm/Kconfig b/mm/Kconfig index 97a4e06..8b1533d 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -668,3

[RFC 2/4] Functions for memory reservation and release

2016-08-12 Thread Ronit Halder
Functions reserve and release memory from CMA area(s). Signed-off-by: Ronit Halder <ronit@gmail.com> --- include/linux/kexec.h | 11 ++- kernel/kexec_core.c | 83 +++ 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/i

[RFC 2/4] Functions for memory reservation and release

2016-08-12 Thread Ronit Halder
Functions reserve and release memory from CMA area(s). Signed-off-by: Ronit Halder --- include/linux/kexec.h | 11 ++- kernel/kexec_core.c | 83 +++ 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/include/linux/kexec.h b

[RFC 1/4] Creating one or two CMA area at Boot time

2016-08-12 Thread Ronit Halder
memory and one in high memory) will be created. Signed-off-by: Ronit Halder <ronit@gmail.com> --- arch/x86/kernel/setup.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c

[RFC 1/4] Creating one or two CMA area at Boot time

2016-08-12 Thread Ronit Halder
memory and one in high memory) will be created. Signed-off-by: Ronit Halder --- arch/x86/kernel/setup.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index d2bbe34..87c16c7 100644

[RFC 0/4] Kexec: Enable run time memory resrvation of crash kernel

2016-08-12 Thread Ronit Halder
movable pages become unmovable momentarily for pinning. The CMA fails for this reason. I don't have any solution for that right now. This approach will work when the this problems with CMA will be fixed. The patch is enabled by a kernel configuration option CONFIG_KEXEC_CMA. Ronit Halder (4):

[RFC 0/4] Kexec: Enable run time memory resrvation of crash kernel

2016-08-12 Thread Ronit Halder
movable pages become unmovable momentarily for pinning. The CMA fails for this reason. I don't have any solution for that right now. This approach will work when the this problems with CMA will be fixed. The patch is enabled by a kernel configuration option CONFIG_KEXEC_CMA. Ronit Halder (4):

Kexec rash kernel memory reservation

2016-08-04 Thread Ronit Halder
Hi, kexec reserves memory for loading crash kernel in the boot time for risk of DMA. I want to know, How kexec prevents allocation of memory which is adjacent to DMA memory? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

CMA failure

2016-07-08 Thread Ronit Halder
Hi, I am going through CMA (Contiguous Memory Allocator) code. In, What situation CMA unable to allocate memory from a CMA area? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

DMA address

2016-07-07 Thread Ronit Halder
Hi, What is a stale DMA address? I have another query. At the time of kernel crash, what happens to the iommu and what happens when devices try to DMA onto memory? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

Re: memblock structure

2016-07-07 Thread Ronit Halder
On Thu, Jul 7, 2016 at 1:45 AM, Silvan Jegen <m...@sillymon.ch> wrote: > On Wed, Jul 06, 2016 at 06:12:50PM +0530, Ronit Halder wrote: >> There are three memblock_type members memory , reserved and physmem in >> memblock structure. >> What is the significance of

memblock structure

2016-07-06 Thread Ronit Halder
There are three memblock_type members memory , reserved and physmem in memblock structure. What is the significance of each member? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

memblock structure

2016-07-06 Thread Ronit Halder
There are three memblock_type members memory , reserved and physmem in memblock structure. What is the significance of each member? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

Re: [RFC] proposal for run time memory allocation for crash kernel

2016-06-25 Thread Ronit Halder
On Thu, Jun 23, 2016 at 1:06 PM, Laura Abbott <labb...@redhat.com> wrote: > On 06/23/2016 05:20 AM, Ronit halder wrote: >> >> Currently, linux kernel allocates memory at the boot time for crash >> kernel booted using kexec system call in kernel crash. It will be very &

Re: [RFC] proposal for run time memory allocation for crash kernel

2016-06-23 Thread Ronit Halder
On Thu, Jun 23, 2016 at 8:31 AM, Paul Bolle <pebo...@tiscali.nl> wrote: > On do, 2016-06-23 at 08:20 -0400, Ronit halder wrote: >> I am attaching a prototype patch with the mail. > > That attachment didn't make it into my Inbox. > >> Please share your >>

[RFC] Prototype Patch of "proposal for run time memory allocation for crash kernel"

2016-06-23 Thread Ronit halder
Signed-off-by: Ronit Halder <ronit@gmail.com> ---  arch/x86/kernel/setup.c | 37 +++  include/linux/kexec.h   |  8 -  kernel/kexec_core.c | 80 +  kernel/ksysfs.c | 14 +++--  4 files changed, 117 inse

[RFC] proposal for run time memory allocation for crash kernel

2016-06-23 Thread Ronit halder
ally be freed. I am attaching a prototype patch with the mail. Please share your opinions on my approach. This patch is only for x86 and x86_64. Please note, this patch is only a prototype just to explain my approach and get the review. Signed-off-by: Ron

Proposal for run time memory allocation for crash kernel

2016-06-20 Thread Ronit halder
ea for crashkernel.\n", __func__); return; } - pr_info("Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", + pr_info("ronit halder Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", (unsigned long)(crash_

Proposal for run time memory allocation for crash kernel

2016-06-20 Thread Ronit halder
ea for crashkernel.\n", __func__); return; } - pr_info("Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", + pr_info("ronit halder Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", (unsigned long)(crash_

Proposal for run time memory allocation for crash kernel

2016-06-20 Thread Ronit halder
ea for crashkernel.\n", __func__); return; } - pr_info("Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", + pr_info("ronit halder Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", (unsigned long)(crash_

kimage structure

2016-06-15 Thread Ronit Halder
Hi, There is a member in "struct kimage" called "entry" in kexec.h. What does entry represents? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Kernel segment

2016-05-17 Thread Ronit Halder
Hi, What are segments in kernel image? In kimage structure there is a member called entry. What does it represents? regards ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Kernel memory

2016-05-17 Thread Ronit Halder
Hi, Where in the memory kernel is located in the boot time? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Proposal format

2016-03-22 Thread Ronit Halder
I have a query about the proposal submitted in https://summerofcode.withgoogle.com/. Will it be only the proposal or full application with my personal detail? do I need to put the dull proposal in the application in the "Proposal Description" part? regards, Ronit

Re: "kdumpbase" dracut module

2016-03-21 Thread Ronit Halder
Thanks for helping So, this module is used to dump the crash kernel. Am I right? If not then can you explain how kdump kernel calls the makedumpfile? ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

Re: Can't login into wiki

2016-03-20 Thread Ronit Halder
It is working. Thank you Patrick for quickly resolving the issue. ___ infrastructure mailing list infrastructure@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/infrastructure@lists.fedoraproject.org

Can't login into wiki

2016-03-19 Thread Ronit Halder
Hi, when i want to login into fas or wiki with my acc Leoryk i get error message: Login error You have entered an invalid username and password. If you are certain that your username and password are correct, confirm that you can log in to the Fedora Account System

"kdumpbase" dracut module

2016-03-19 Thread Ronit Halder
I want to know what is the job of "kdumpbase" dracut module. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Can't login into wiki

2016-03-19 Thread Ronit Halder
Sorry, My FAS user name is ronit, It is really urgent. regards, Ronit ___ infrastructure mailing list infrastructure@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/infrastructure@lists.fedoraproject.org

Initramfs extraction

2016-03-15 Thread Ronit Halder
I am trying to extract initramfs image. But it is only showing early_cpio and kernel directory. What am I doing wrong? ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Contiguous memory allocator

2016-03-12 Thread Ronit Halder
What is the difference between function cma_init_reserved_mem() and cma_declare_contiguous()? If I am trying to allocate new CMA area at boot time, How to do that? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

creating initramfs in fedora

2016-03-11 Thread Ronit Halder
Hi, How can I create a initramfs file without dracut from the files in an installed system in fedora? regards, Ronit ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

creating initramfs

2016-03-11 Thread Ronit Halder
Hi, How can I create a initramfs file without dracut from the files in an installed system with my own kernel configuration? regards, Ronit -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

creating initramfs

2016-03-11 Thread Ronit Halder
Hi, How can I create a initramfs file without dracut from the files in an installed system with my own kernel configuration? regards, Ronit -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

creating initramfs

2016-03-10 Thread Ronit Halder
Hi, How can I create a initramfs file without dracut from the files in an installed system with my own kernel configuration? regards, Ronit -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

creating initramfs

2016-03-10 Thread Ronit Halder
Hi, How can I create a initramfs file without dracut from the files in an installed system? regards, Ronit ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

format of proposal

2016-03-09 Thread Ronit Halder
where can I find format of gsoc proposal? regards ___ summer-coding mailing list summer-coding@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/summer-coding@lists.fedoraproject.org

[PATCH] Staging: comedi: removing useless init/exit

2015-10-20 Thread Ronit Halder
Removing init and exit functions as they do nothing. Signed-off-by: Ronit Halder --- drivers/staging/comedi/comedi_usb.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/comedi_usb.c b/drivers/staging/comedi/comedi_usb.c index 9c946d4..ed13bf6 100644

[PATCH] Staging: comedi: removing useless init/exit

2015-10-20 Thread Ronit Halder
Removing init and exit functions as they do nothing. Signed-off-by: Ronit Halder <ronit@gmail.com> --- drivers/staging/comedi/comedi_usb.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/comedi_usb.c b/drivers/staging/comedi/comedi_usb.c index 9

[PATCH] Staging: comedi: removing useless init/exit

2015-10-20 Thread Ronit Halder
Removing init and exit functions as they do nothing. Signed-off-by: Ronit Halder <ronit@gmail.com> --- drivers/staging/comedi/comedi_usb.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/comedi_usb.c b/drivers/staging/comedi/comedi_usb.c index 9

[PATCH] Staging: rts5208: use dmam_alloc_coherent

2015-10-16 Thread Ronit Halder
This patch replaces dma_alloc_coherent with the corresponding managed interface. Signed-off-by: Ronit Halder --- drivers/staging/rts5208/rtsx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index b4e4543

[PATCH] Staging: rts5208: use dmam_alloc_coherent

2015-10-16 Thread Ronit Halder
This patch replaces dma_alloc_coherent with the corresponding managed interface. Signed-off-by: Ronit Halder <ronit@gmail.com> --- drivers/staging/rts5208/rtsx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/r

[PATCH] Staging: rts5208: use dmam_alloc_coherent

2015-10-16 Thread Ronit Halder
This patch replaces dma_alloc_coherent with the corresponding managed interface. Signed-off-by: Ronit Halder <ronit@gmail.com> --- drivers/staging/rts5208/rtsx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/r

[PATCH] Staging: fbtft: Use BIT macro

2015-10-05 Thread Ronit Halder
Replace (1 << x) by BIT(x) Signed-off-by: Ronit halder --- drivers/staging/fbtft/fb_ssd1351.c | 4 +-- drivers/staging/fbtft/fbtft.h | 56 +++--- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/d

[PATCH] Staging: fbtft: Use BIT macro

2015-10-05 Thread Ronit Halder
Replace (1 << x) by BIT(x) Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/fbtft/fb_ssd1351.c | 4 +-- drivers/staging/fbtft/fbtft.h | 56 +++--- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/s

[PATCH] Staging: fbtft: Use BIT macro

2015-10-05 Thread Ronit Halder
Replace (1 << x) by BIT(x) Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/fbtft/fb_ssd1351.c | 4 +-- drivers/staging/fbtft/fbtft.h | 56 +++--- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/s

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-10-01 Thread Ronit Halder
> Why not just reject it earlier instead of allocating more data? I agree on your point. But we have to make different mechanism for that and my patch is only to fix the current code. regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-10-01 Thread Ronit Halder
> Why not just reject it earlier instead of allocating more data? I agree on your point. But we have to make different mechanism for that and my patch is only to fix the current code. regards ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-10-01 Thread Ronit Halder
> Why not just reject it earlier instead of allocating more data? I agree on your point. But we have to make different mechanism for that and my patch is only to fix the current code. regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
The existing dgap_parsefile() rejects invalid config file. But before we know that config file is invalid a lot of memory leak can happen. Removing the chances of memory leak won't heart anyone. regards, Ronit Halder -- To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
In dgap_parsefile() char pointers are set with kstrdup() without checking that some string is allocated to that char pointer before. This patch frees the memory if already allocated and then set the poniter with kstrdup(). Signed-off-by: Ronit halder --- drivers/staging/dgap/dgap.c | 12

[PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
In dgap_parsefile() char pointers are set with kstrdup() without checking that some string is allocated to that char pointer before. This patch frees the memory if already allocated and then set the poniter with kstrdup(). Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/s

[PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
In dgap_parsefile() char pointers are set with kstrdup() without checking that some string is allocated to that char pointer before. This patch frees the memory if already allocated and then set the poniter with kstrdup(). Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/s

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
The existing dgap_parsefile() rejects invalid config file. But before we know that config file is invalid a lot of memory leak can happen. Removing the chances of memory leak won't heart anyone. regards, Ronit Halder -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
The existing dgap_parsefile() rejects invalid config file. But before we know that config file is invalid a lot of memory leak can happen. Removing the chances of memory leak won't heart anyone. regards, Ronit Halder ___ devel mailing list de

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > Sorry for the ambiguity. > > I am talking about my second patch in the series. > > https://lkml.org/lkml/2015/9/15/293 > > > > > > None of the line edited in first patch haven't changed

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
Why not the second one? None of the line edited in first patch haven't changed after that. On Tue, Sep 15, 2015 at 7:24 PM, Greg KH wrote: > On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by sparse >> "Using plain int

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
Why not the second one? None of the line edited in first patch haven't changed after that. On Tue, Sep 15, 2015 at 7:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by s

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
Why not the second one? None of the line edited in first patch haven't changed after that. On Tue, Sep 15, 2015 at 7:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by s

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
Why not the second one? None of the line edited in first patch haven't changed after that. On Tue, Sep 15, 2015 at 7:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by s

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > Sorry for the ambiguity. > > I am talking about my second patch in the series. > > https://lkml.org/lkml/2015/9/15/293 > > > > > > None of the line edited in first patch haven't changed

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > Sorry for the ambiguity. > > I am talking about my second patch in the series. > > https://lkml.org/lkml/2015/9/15/293 > > > > > > None of the line edited in first patch haven't changed

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > Sorry for the ambiguity. > > I am talking about my second patch in the series. > > https://lkml.org/lkml/2015/9/15/293 > > > > > > None of the line edited in first patch haven't changed

[PATCH 2/2] Staging: wilc1000: fix NULL comparison style

2015-09-15 Thread Ronit Halder
Fixed NULL comparison style as suggested by checkpatch.pl with --strict option. Signed-off-by: Ronit halder --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-15 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder --- v2: added a new patch in this patch series to fix the NULL comparison style drivers/staging/wilc1000/coreconfigura

[PATCH 2/2] Staging: wilc1000: fix NULL comparison style

2015-09-15 Thread Ronit Halder
Fixed NULL comparison style as suggested by checkpatch.pl with --strict option. Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 2/2] Staging: wilc1000: fix NULL comparison style

2015-09-15 Thread Ronit Halder
Fixed NULL comparison style as suggested by checkpatch.pl with --strict option. Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 2/2] Staging: wilc1000: fix NULL comparison style

2015-09-15 Thread Ronit Halder
Fixed NULL comparison style as suggested by checkpatch.pl with --strict option. Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-15 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder <ronit@gmail.com> --- v2: added a new patch in this patch series to fix the NULL comparison style drivers/staging/wilc1000/co

[PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-15 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder <ronit@gmail.com> --- v2: added a new patch in this patch series to fix the NULL comparison style drivers/staging/wilc1000/co

[PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-15 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder <ronit@gmail.com> --- v2: added a new patch in this patch series to fix the NULL comparison style drivers/staging/wilc1000/co

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-14 Thread Ronit Halder
I checked but it didn't show me any warning. Can you please specify the warning? regards On Mon, Sep 14, 2015 at 2:06 PM, Sudip Mukherjee wrote: > On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by sparse >> "Using p

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-14 Thread Ronit Halder
I checked but it didn't show me any warning. Can you please specify the warning? regards On Mon, Sep 14, 2015 at 2:06 PM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote: >> This patch fixes the warning gene

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-14 Thread Ronit Halder
I checked but it didn't show me any warning. Can you please specify the warning? regards On Mon, Sep 14, 2015 at 2:06 PM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote: >> This patch fixes the warning gene

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-14 Thread Ronit Halder
I checked but it didn't show me any warning. Can you please specify the warning? regards On Mon, Sep 14, 2015 at 2:06 PM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote: >> This patch fixes the warning gene

Re: gfp_flag

2015-09-14 Thread Ronit Halder
Sorry, it is gfp_mask not gfp_flag. On Sep 14, 2015 9:51 AM, "Greg KH" <gre...@linuxfoundation.org> wrote: > On Mon, Sep 14, 2015 at 09:03:53AM +0530, Ronit Halder wrote: > > In drivers/staging/android/ion/ion.c in line 1475 and 1493 gfp_flag > > is set to -1 &

[PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-13 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder --- drivers/staging/wilc1000/coreconfigurator.c | 14 +++--- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 2 files c

[PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-13 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/wilc1000/coreconfigurator.c | 14 +++--- drivers/staging/wilc1000/linux_wlan.c

[PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-13 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/wilc1000/coreconfigurator.c | 14 +++--- drivers/staging/wilc1000/linux_wlan.c

[PATCH] Staging: wilc1000: Use NULL instead of zero

2015-09-13 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder <ronit@gmail.com> --- drivers/staging/wilc1000/coreconfigurator.c | 14 +++--- drivers/staging/wilc1000/linux_wlan.c

[PATCH] Staging: most: Use NULL instead of zero

2015-08-18 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder --- drivers/staging/most/aim-network/networking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagin

Re: [PATCH] Staging: fbtft: Fix iomem dereference

2015-08-18 Thread Ronit Halder
Yes, it is not I/O memory address. I was wrong on that. But it makes sparse happy. Is here any side effect of using ioread16() ? regards, ronit On Tue, Aug 18, 2015 at 2:27 PM, Dan Carpenter wrote: > On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote: >> This patch fixes th

[PATCH] Staging: fbtft: Fix iomem dereference

2015-08-18 Thread Ronit Halder
This patch fixes the warning generated by sparse "cast removes address space of expression" by using ioread16 function insted of directly dereferencing I/O memory. Signed-off-by: Ronit halder --- drivers/staging/fbtft/fb_agm1264k-fl.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH] Staging: fbtft: Fix iomem dereference

2015-08-18 Thread Ronit Halder
This patch fixes the warning generated by sparse cast removes address space of expression by using ioread16 function insted of directly dereferencing I/O memory. Signed-off-by: Ronit halder ronit@gmail.com --- drivers/staging/fbtft/fb_agm1264k-fl.c | 5 +++-- 1 file changed, 3 insertions

[PATCH] Staging: fbtft: Fix iomem dereference

2015-08-18 Thread Ronit Halder
This patch fixes the warning generated by sparse cast removes address space of expression by using ioread16 function insted of directly dereferencing I/O memory. Signed-off-by: Ronit halder ronit@gmail.com --- drivers/staging/fbtft/fb_agm1264k-fl.c | 5 +++-- 1 file changed, 3 insertions

[PATCH] Staging: most: Use NULL instead of zero

2015-08-18 Thread Ronit Halder
This patch fixes the warning generated by sparse Using plain integer as NULL pointer by using NULL instead of zero. Signed-off-by: Ronit halder ronit@gmail.com --- drivers/staging/most/aim-network/networking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] Staging: most: Use NULL instead of zero

2015-08-18 Thread Ronit Halder
This patch fixes the warning generated by sparse Using plain integer as NULL pointer by using NULL instead of zero. Signed-off-by: Ronit halder ronit@gmail.com --- drivers/staging/most/aim-network/networking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] Staging: fbtft: Fix iomem dereference

2015-08-18 Thread Ronit Halder
Yes, it is not I/O memory address. I was wrong on that. But it makes sparse happy. Is here any side effect of using ioread16() ? regards, ronit On Tue, Aug 18, 2015 at 2:27 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote

Re: [PATCH] Staging: fbtft: Fix iomem dereference

2015-08-18 Thread Ronit Halder
Yes, it is not I/O memory address. I was wrong on that. But it makes sparse happy. Is here any side effect of using ioread16() ? regards, ronit On Tue, Aug 18, 2015 at 2:27 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote

[PATCH] Staging: lustre: fixed a blank line after declarations coding style issue

2015-07-10 Thread Ronit Halder
Fixed a blank line after declarations coding style issue Signed-off-by: Ronit Halder --- drivers/staging/lustre/lustre/lov/lov_merge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/lov/lov_merge.c b/drivers/staging/lustre/lustre/lov/lov_merge.c index b7e7bfa

[PATCH] Staging: lustre: fixed a blank line after declarations coding style issue

2015-07-10 Thread Ronit Halder
Fixed a blank line after declarations coding style issue Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/lustre/lustre/lov/lov_merge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/lov/lov_merge.c b/drivers/staging/lustre/lustre/lov

[PATCH] Staging: lustre: fixed a blank line after declarations coding style issue

2015-07-10 Thread Ronit Halder
Fixed a blank line after declarations coding style issue Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/lustre/lustre/lov/lov_merge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/lov/lov_merge.c b/drivers/staging/lustre/lustre/lov

[PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-09 Thread Ronit Halder
Fixed a coding style issue. Signed-off-by: Ronit Halder --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..e44f5e6 100644 --- a/drivers/staging/android/ion/ion.c +++ b

  1   2   >