https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/91765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/91765
[P1787R6](https://wg21.link/p1787r6):
> [CWG1820](https://cplusplus.github.io/CWG/issues/1820.html) is resolved by
> requiring that a qualified declarator-id declare an entity.
P1787R6 changes wording of
Author: Vlad Serebrennikov
Date: 2024-05-10T19:03:21+03:00
New Revision: ef71c79d85fb3f94f19a92a84ab44719d112c1bd
URL:
https://github.com/llvm/llvm-project/commit/ef71c79d85fb3f94f19a92a84ab44719d112c1bd
DIFF:
Author: Vlad Serebrennikov
Date: 2024-05-10T19:00:20+03:00
New Revision: d358b2de458e0611a3f474a9c3e3deff926c07c4
URL:
https://github.com/llvm/llvm-project/commit/d358b2de458e0611a3f474a9c3e3deff926c07c4
DIFF:
Endilll wrote:
To be clear, we're asking for a reproducer with normal names first and
foremost. I'm thankful for @bgra8 help running `creduce` over what they had,
but we wouldn't had this particular conversation if they also provided full
original reproducer that we could run `creduce` on
Endilll wrote:
> but not having a convenient reproducer is not a good reason to keep the ToT
> Clang in a broken state
As someone who worked on a different reduction of Sam's reproducer yesterday,
and spent whopping 8 hours of work time to get
Endilll wrote:
It'd also be nice if someone can share a reproducer that crashes on trunk but
not on 18.1.0 without names reduced to 1-2 letters. Definitely would speed up
the work towards the fix.
https://github.com/llvm/llvm-project/pull/89807
___
https://github.com/Endilll approved this pull request.
LGTM
You should leave a link in the description to the buildbot failure you're
addressing.
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll approved this pull request.
LGTM, but someone else should take a look as well.
https://github.com/llvm/llvm-project/pull/91692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/91435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
If you're using `creduce`, this set of arguments disables all renaming passes:
`--remove-pass pass_clang rename-fun --remove-pass pass_clang rename-param
--remove-pass pass_clang rename-var --remove-pass pass_clang rename-class
--remove-pass pass_clang rename-cxx-method
Endilll wrote:
@bgra8 Your reduction has names replaced by the tool. This is quite hard to
work with. Can you reduce again, but with renaming passes disabled?
I uploaded your reproducer to CE: https://godbolt.org/z/9PK1oPoPW
https://github.com/llvm/llvm-project/pull/89807
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- //
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/91435
>From 32e3c974d5f3f5651c5805210a7215af4d6df24b Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 8 May 2024 09:31:32 +0300
Subject: [PATCH] [clang] Add examples from [dcl.init.aggr] to C++ conformance
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- //
@@ -0,0 +1,294 @@
+// RUN: %clang_cc1 -std=c++2c -verify %s
+
Endilll wrote:
Any reference would become outdated the moment this file is touched next time,
so I added one to the PR description, so it makes it into the commit message.
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/91435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/91435
This patch adds examples from
[[dcl.init.aggr]](http://eel.is/c++draft/dcl.init.aggr) to C++ conformance
tests. Testing is done via constant evaluation and static asserts. As far as I
can see, the rest of the
https://github.com/Endilll commented:
`Sema.h` changes look good.
https://github.com/llvm/llvm-project/pull/89565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
DR tests changes LGTM
https://github.com/llvm/llvm-project/pull/90760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -9739,6 +9739,9 @@ class Sema final : public SemaBase {
const PartialDiagnostic ,
bool Complain = true, QualType TargetType = QualType());
+ FunctionDecl *getMoreConstrainedFunction(FunctionDecl *FD1,
Endilll
Endilll wrote:
> Sounds like should perhaps note that we are implementing our own resolution,
> until there's an update to the cwg issue that can be referred to?
Our tooling is not ready for describing own own resolutions, unfortunately.
Ideally if we have a
Endilll wrote:
> Also, this needs to test a non-conforming mode until we finally remove the
> corresponding flag, and that is against the rules for the DR suite.
You should be able to split conforming part of the test into DR test, though.
Endilll wrote:
This file is not going to be picked up by the `make_cxx_dr_status`, because
it's not in `clang/test/CXX/drs`. If we're implementing what Jason Merill
speaks of (_In deduction we can determine that P is more specialized than B,
then substitute
https://github.com/Endilll commented:
`Sema.h` changes look good to me.
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
`Sema.h` changes look good to me.
https://github.com/llvm/llvm-project/pull/90786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
Changes to DR tests look good to me.
https://github.com/llvm/llvm-project/pull/90760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/90220
>From b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 26 Apr 2024 18:03:44 +0300
Subject: [PATCH 1/3] [clang] Fix crash when destructor definition is
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/89484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/89484
>From 5985dbe47e052505278d60628bbb5ca751cc3b6c Mon Sep 17 00:00:00 2001
From: offsetof <131769984+offse...@users.noreply.github.com>
Date: Sat, 20 Apr 2024 02:35:09 +
Subject: [PATCH 1/2] [clang] Allow
Endilll wrote:
https://github.com/llvm/llvm-project/pull/90352 has been merged.
https://github.com/llvm/llvm-project/pull/90387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/90352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
CI has been failing because of unrelated `Clang :: Driver/amdgpu-toolchain.c`
test. I'm merging this as is.
https://github.com/llvm/llvm-project/pull/90352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll commented:
I'm fine with the way DR test is written, but I'm not qualified to review the
contents on the test, unfortunately.
I'd like to point to related Core issues
[CWG2836](https://cplusplus.github.io/CWG/issues/2836.html) and
https://github.com/Endilll commented:
`Sema.h` changes look good to me.
https://github.com/llvm/llvm-project/pull/90376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/90352
Currently we're using official publication of CWG issue list available at
https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html. Unfortunately,
it's not updated as frequently as we sometimes need. For
https://github.com/Endilll commented:
Changes to `Sema.h` and DR tests look good to me.
https://github.com/llvm/llvm-project/pull/90152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -738,22 +736,21 @@ the following style significantly:
import M;
... // use declarations from module M.
-The key part of the tip is to reduce the duplications from the text includes.
+Reducing the duplication from textual includes is what improves compile-time
@@ -738,22 +736,21 @@ the following style significantly:
import M;
... // use declarations from module M.
-The key part of the tip is to reduce the duplications from the text includes.
+Reducing the duplication from textual includes is what improves compile-time
@@ -444,53 +435,57 @@ For example, the following example is allowed:
# Inconsistent debugging level.
$ clang++ -std=c++20 -g Use.cpp -fprebuilt-module-path=.
-Although the two examples have inconsistent optimization and debugging level,
both of them are accepted.
@@ -738,22 +736,21 @@ the following style significantly:
import M;
... // use declarations from module M.
-The key part of the tip is to reduce the duplications from the text includes.
+Reducing the duplication from textual includes is what improves compile-time
@@ -1817,27 +1804,29 @@ But with optimizations, things are different:
│ │
└---┘
-It would be very unfortunate if we end up with worse performance after using
modules.
@@ -776,9 +773,9 @@ export-using style
using decl_n;
}
-As the example shows, you need to include all the headers containing
declarations needs
-to be exported and `using` such declarations in an `export` block. Then,
basically,
-we're done.
+This example shows how to
@@ -432,9 +424,8 @@ The following example is not allowed:
$ clang++ -std=c++20 M.cppm --precompile -o M.pcm
$ clang++ -std=c++23 Use.cpp -fprebuilt-module-path=.
-The compiler would reject the example due to the inconsistent language options.
-Not all options are language
@@ -925,45 +923,41 @@ In that case, you need to convert your source files (.cpp
files) to module imple
// Following off should be unchanged.
...
-The module implementation unit will import the primary module implicitly.
-We don't include any headers in the module
@@ -633,36 +631,36 @@ example:
// module M's interface, so is discarded
int c = use_h(); // OK
-In the above example, the function definition of ``N::g`` is elided from the
Reduced
-BMI of ``M.cppm``. Then the use of ``use_g`` in
@@ -633,36 +631,36 @@ example:
// module M's interface, so is discarded
int c = use_h(); // OK
-In the above example, the function definition of ``N::g`` is elided from the
Reduced
-BMI of ``M.cppm``. Then the use of ``use_g`` in
@@ -444,53 +435,57 @@ For example, the following example is allowed:
# Inconsistent debugging level.
$ clang++ -std=c++20 -g Use.cpp -fprebuilt-module-path=.
-Although the two examples have inconsistent optimization and debugging level,
both of them are accepted.
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The
@@ -444,53 +435,57 @@ For example, the following example is allowed:
# Inconsistent debugging level.
$ clang++ -std=c++20 -g Use.cpp -fprebuilt-module-path=.
-Although the two examples have inconsistent optimization and debugging level,
both of them are accepted.
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The
@@ -279,8 +266,9 @@ we could put ``-x c++-module`` in front of the file. For
example,
return 0;
}
-Now the filename of the ``module interface`` ends with ``.cpp`` instead of
``.cppm``,
-we can't compile them by the original command lines. But we are still able to
do
@@ -95,22 +76,23 @@ In this document, we use the following umbrella terms:
* A ``module interface unit`` refers to either a ``primary module interface
unit``
or a ``module interface partition unit``.
-* An ``importable module unit`` refers to either a ``module interface
https://github.com/Endilll commented:
I have to admit that is rather shallow due to sheer amount of text, but it
still took me more like 90 minutes. Hope you find it useful.
https://github.com/llvm/llvm-project/pull/90237
___
cfe-commits mailing
@@ -444,53 +435,57 @@ For example, the following example is allowed:
# Inconsistent debugging level.
$ clang++ -std=c++20 -g Use.cpp -fprebuilt-module-path=.
-Although the two examples have inconsistent optimization and debugging level,
both of them are accepted.
@@ -312,75 +300,76 @@ So all of the following name is not valid by default:
__test
// and so on ...
-If you still want to use the reserved module names for any reason, use
-``-Wno-reserved-module-identifier`` to suppress the warning.
+Using a reserved module name is
@@ -444,53 +435,57 @@ For example, the following example is allowed:
# Inconsistent debugging level.
$ clang++ -std=c++20 -g Use.cpp -fprebuilt-module-path=.
-Although the two examples have inconsistent optimization and debugging level,
both of them are accepted.
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The
@@ -400,24 +389,27 @@ And the compilation process for module units are like:
mod1.cppm -> clang++ mod1.cppm ... -> mod1.pcm --,--> clang++
mod1.pcm ... -> mod1.o -+
src2.cpp +> clang++
src2.cpp --->
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/90237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/90220
>From b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 26 Apr 2024 18:03:44 +0300
Subject: [PATCH 1/2] [clang] Fix crash when destructor definition is
Endilll wrote:
I have a vague feeling I might be fixing the symptom instead of the cause.
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/90220
Fixes #89544
>From b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 26 Apr 2024 18:03:44 +0300
Subject: [PATCH] [clang] Fix crash when destructor definition
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/90079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,77 @@
+// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s
-verify=expected,cxx98 -fexceptions -fcxx-exceptions -pedantic-errors -ast-dump
| FileCheck %s --check-prefixes CXX98
+// RUN: %clang_cc1 -std=c++11 -triple x86_64-unknown-unknown %s
@@ -12702,7 +12702,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/2149.html;>2149
drafting
Brace elision and array length deduction
-Not resolved
+Not
Resolved*
Endilll wrote:
As I mentioned in
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-verify=expected,new
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-fno-relaxed-template-template-args -verify=expected,old
Endilll wrote:
> Since the core
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-verify=expected,new
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-fno-relaxed-template-template-args -verify=expected,old
Endilll wrote:
Given that you're
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-verify=expected,new
Endilll wrote:
Why only C++23 is tested? DR tests should test all language modes.
https://github.com/llvm/llvm-project/pull/89807
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-verify=expected,new
+// RUN: %clang_cc1 %s -fsyntax-only -std=c++23
-fno-relaxed-template-template-args -verify=expected,old
Endilll wrote:
We don't test
https://github.com/Endilll requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
`Sema.h` changes look good.
https://github.com/llvm/llvm-project/pull/89809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
Thank you for spotting and fixing this!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Endilll wrote:
@shafik I wonder how checking size of a vector is now considered an expensive
check.
(I stumbled upon it while reviewing)
https://github.com/llvm/llvm-project/blob/47682e4b4a0c8e7637d65868a7208aa6806a50f4/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp#L99-L101
Endilll wrote:
>Can you add examples 14, 16, 17, 18 of the paper?
I'll add them to conformance test suite in a subsequent PR. They don't belong
here, as the issue is about deducing array length from brace initializer, but
the examples you're listing are focusing on various aspects of how
Endilll wrote:
Status of 2149 changed just yesterday to say DR per 2024 Tokyo straw poll.
That's where the discrepancy between official `cwg_index.html` and CWG GitHub
repo comes (that I link in the description).
https://github.com/llvm/llvm-project/pull/90079
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/90079
This patch adds test for
[CWG2149](https://cplusplus.github.io/CWG/issues/2149.html), following
[P3106R1](https://wg21.link/p3106R1) "Clarifying rules for brace elision in
aggregate initialization" and a
Endilll wrote:
@Sirraide See example of
https://github.com/llvm/llvm-project/blob/662ef8604268b207910225ecca90daf30a46720b/clang/test/CXX/drs/dr25xx.cpp#L148
In this case, the date should be 2024-04-19.
https://github.com/llvm/llvm-project/pull/89828
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/89942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/89942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4,7 +4,7 @@
// RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK
// RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o -
https://github.com/Endilll commented:
LGTM
@erichkeane mind giving CWG650 test a quick look?
https://github.com/llvm/llvm-project/pull/89942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -3597,8 +3597,13 @@ class ASTIdentifierTableTrait {
/// doesn't check whether the name has macros defined; use
PublicMacroIterator
/// to check that.
bool isInterestingIdentifier(const IdentifierInfo *II, uint64_t MacroOffset)
{
-if (MacroOffset ||
Author: Vlad Serebrennikov
Date: 2024-04-24T11:09:06+03:00
New Revision: 662ef8604268b207910225ecca90daf30a46720b
URL:
https://github.com/llvm/llvm-project/commit/662ef8604268b207910225ecca90daf30a46720b
DIFF:
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/89536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/89536
>From 58058a88305c7d4c1b1a30d8572ca481889ea3f9 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 21 Apr 2024 13:29:39 +0300
Subject: [PATCH 1/2] [clang] Mark ill-formed partial specialization as
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/89536
Fixes #89374
Solution suggested by @cor3ntin
>From 58058a88305c7d4c1b1a30d8572ca481889ea3f9 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 21 Apr 2024 13:29:39 +0300
Subject: [PATCH] [clang] Mark
Endilll wrote:
@ronlieb nice and small reproducer would definitely help resolving this.
https://github.com/llvm/llvm-project/pull/88666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
Changes to DR tests look good to me, thank you!
Can you send an email to Jens Maurer asking him to mark 2526 as superseded by
2749?
I'm also somewhat suspicious of the fact that we check only LHS for being
`void*`, but that's what we did previously as
Endilll wrote:
I'm having second thoughts about leveraging recovery expressions as a side-band
mechanism to de-duplicate diagnostics, because not modeling things properly in
AST might backfire in the future. But I don't have anything better on my mind,
so I don't want to block the progress of
Endilll wrote:
Removing `ObjC` from the names of functions inside `SemaObjC` in an obvious
next step we can take, but I'm leaving this for a subsequent PR, because this
one is large enough already.
https://github.com/llvm/llvm-project/pull/89086
___
Author: Vlad Serebrennikov
Date: 2024-04-17T18:02:48+03:00
New Revision: 458328ae23d318a5055d5bac66426b8551bce01f
URL:
https://github.com/llvm/llvm-project/commit/458328ae23d318a5055d5bac66426b8551bce01f
DIFF:
Author: Vlad Serebrennikov
Date: 2024-04-17T09:51:50+03:00
New Revision: e11b17a4ed90e74147594012207fc35a60515944
URL:
https://github.com/llvm/llvm-project/commit/e11b17a4ed90e74147594012207fc35a60515944
DIFF:
Author: Vlad Serebrennikov
Date: 2024-04-17T09:21:29+03:00
New Revision: 64c649585ca23a0c996d8814d2796cd348441d69
URL:
https://github.com/llvm/llvm-project/commit/64c649585ca23a0c996d8814d2796cd348441d69
DIFF:
1 - 100 of 1065 matches
Mail list logo
