[GitHub] spark pull request #16975: [SPARK-19522] Fix executor memory in local-cluste...

2017-02-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/16975#discussion_r102569401 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -470,12 +470,25 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] spark pull request #16975: [SPARK-19522] Fix executor memory in local-cluste...

2017-02-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/16975#discussion_r101887609 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -466,7 +466,7 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #16975: [SPARK-19522] Fix executor memory in local-cluste...

2017-02-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/16975#discussion_r101887589 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -466,7 +466,7 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #16975: [SPARK-19522] Fix executor memory in local-cluste...

2017-02-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/16975#discussion_r101857385 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -466,7 +466,7 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #16975: [SPARK-19522] Fix executor memory in local-cluste...

2017-02-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/16975#discussion_r101857230 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -466,7 +466,7 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #16975: [SPARK-19522] Fix executor memory in local-cluste...

2017-02-17 Thread andrewor14
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/16975 [SPARK-19522] Fix executor memory in local-cluster mode ## What changes were proposed in this pull request? ``` bin/spark-shell --master local-cluster[2,1,2048

[GitHub] spark pull request #13899: [SPARK-16196][SQL] Codegen in-memory scan with Co...

2017-02-16 Thread andrewor14
Github user andrewor14 closed the pull request at: https://github.com/apache/spark/pull/13899 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #13899: [SPARK-16196][SQL] Codegen in-memory scan with ColumnarB...

2017-02-16 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/13899 Closing for now; too many conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16819: [SPARK-16441][YARN] Set maxNumExecutor depends on yarn c...

2017-02-06 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/16819 I agree. Resource managers generally expect applications to request more than what's available already so we don't have to do it again ourselves in Spark. --- If your project is set up

[GitHub] spark issue #16823: [SPARK] Config methods simplification at SparkSession#Bu...

2017-02-06 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/16823 This is a bad idea! First it breaks backward compatibility, and second, we intentionally didn't want to make it so general that the user can pass in any objects. Can you please close this PR

[GitHub] spark pull request #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of...

2017-01-27 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15396#discussion_r98218538 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1589,7 +1589,8 @@ abstract class RDD[T: ClassTag]( * This is introduced

[GitHub] spark issue #16081: [SPARK][EXAMPLE] Added missing semicolon in quick-start-...

2016-11-30 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/16081 and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

spark git commit: [SPARK][EXAMPLE] Added missing semicolon in quick-start-guide example

2016-11-30 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.0 1b1c849bf -> 5ecd3c23a [SPARK][EXAMPLE] Added missing semicolon in quick-start-guide example ## What changes were proposed in this pull request? Added missing semicolon in quick-start-guide java example code which wasn't compiling

spark git commit: [SPARK-18640] Add synchronization to TaskScheduler.runningTasksByExecutors

2016-11-30 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.0 8b33aa089 -> 1b1c849bf [SPARK-18640] Add synchronization to TaskScheduler.runningTasksByExecutors ## What changes were proposed in this pull request? The method `TaskSchedulerImpl.runningTasksByExecutors()` accesses the mutable

[GitHub] spark issue #16073: [SPARK-18640] Add synchronization to TaskScheduler.runni...

2016-11-30 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/16073 and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

spark git commit: [SPARK-18640] Add synchronization to TaskScheduler.runningTasksByExecutors

2016-11-30 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.1 eae85da38 -> 7c0e2962d [SPARK-18640] Add synchronization to TaskScheduler.runningTasksByExecutors ## What changes were proposed in this pull request? The method `TaskSchedulerImpl.runningTasksByExecutors()` accesses the mutable

[GitHub] spark issue #16073: [SPARK-18640] Add synchronization to TaskScheduler.runni...

2016-11-30 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/16073 LGTM merging into master 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16081: [SPARK][EXAMPLE] Added missing semicolon in quick-start-...

2016-11-30 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/16081 Ok, merging into master 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15462: [SPARK-17680] [SQL] [TEST] Added test cases for InMemory...

2016-11-28 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15462 @kiszk is there a JIRA associated specifically with adding tests for `InMemoryRelation`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

spark git commit: [SPARK-17680][SQL][TEST] Added test cases for InMemoryRelation

2016-11-28 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.1 81e3f9711 -> b386943b2 [SPARK-17680][SQL][TEST] Added test cases for InMemoryRelation ## What changes were proposed in this pull request? This pull request adds test cases for the following cases: - keep all data types with null or

spark git commit: [SPARK-17680][SQL][TEST] Added test cases for InMemoryRelation

2016-11-28 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 0f5f52a3d -> ad67993b7 [SPARK-17680][SQL][TEST] Added test cases for InMemoryRelation ## What changes were proposed in this pull request? This pull request adds test cases for the following cases: - keep all data types with null or

[GitHub] spark issue #15462: [SPARK-17680] [SQL] [TEST] Added test cases for InMemory...

2016-11-28 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15462 LGTM, merging into master 2.1 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15993: [SPARK-18050][SQL] do not create default database if it ...

2016-11-23 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15993 Sounds good. Merging into master 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

spark git commit: [SPARK-18050][SQL] do not create default database if it already exists

2016-11-23 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 70ad07a9d -> f129ebcd3 [SPARK-18050][SQL] do not create default database if it already exists ## What changes were proposed in this pull request? When we try to create the default database, we ask hive to do nothing if it already exists.

spark git commit: [SPARK-18050][SQL] do not create default database if it already exists

2016-11-23 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.1 599dac159 -> 835f03f34 [SPARK-18050][SQL] do not create default database if it already exists ## What changes were proposed in this pull request? When we try to create the default database, we ask hive to do nothing if it already

[GitHub] spark pull request #15462: [SPARK-17680] [SQL] [TEST] Added test cases for I...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15462#discussion_r89205894 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -20,18 +20,83 @@ package

[GitHub] spark issue #15462: [SPARK-17680] [SQL] [TEST] Added test cases for InMemory...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15462 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #15462: [SPARK-17680] [SQL] [TEST] Added test cases for I...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15462#discussion_r89205780 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -58,6 +123,12 @@ class

[GitHub] spark pull request #15462: [SPARK-17680] [SQL] [TEST] Added test cases for I...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15462#discussion_r89205541 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -20,18 +20,83 @@ package

[GitHub] spark pull request #15462: [SPARK-17680] [SQL] [TEST] Added test cases for I...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15462#discussion_r89205861 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -246,4 +317,59 @@ class

[GitHub] spark pull request #15462: [SPARK-17680] [SQL] [TEST] Added test cases for I...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15462#discussion_r89205730 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -20,18 +20,83 @@ package

[GitHub] spark issue #15978: [SPARK-18507][SQL] HiveExternalCatalog.listPartitions sh...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15978 (Oops never mind, not my fault! :p) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15978: [SPARK-18507][SQL] HiveExternalCatalog.listPartitions sh...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15978 @cloud-fan can you make a patch for 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

spark git commit: [SPARK-18507][SQL] HiveExternalCatalog.listPartitions should only call getTable once

2016-11-22 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.1 0e624e990 -> fa360134d [SPARK-18507][SQL] HiveExternalCatalog.listPartitions should only call getTable once ## What changes were proposed in this pull request? HiveExternalCatalog.listPartitions should only call `getTable` once,

spark git commit: [SPARK-18507][SQL] HiveExternalCatalog.listPartitions should only call getTable once

2016-11-22 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 45ea46b7b -> 702cd403f [SPARK-18507][SQL] HiveExternalCatalog.listPartitions should only call getTable once ## What changes were proposed in this pull request? HiveExternalCatalog.listPartitions should only call `getTable` once, instead

[GitHub] spark issue #15978: [SPARK-18507][SQL] HiveExternalCatalog.listPartitions sh...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15978 Oops, that was my fault. Thanks merging into master 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15811: [SPARK-18361] [PySpark] Expose RDD localCheckpoint in Py...

2016-11-22 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15811 I did --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #15896: [SPARK-18465] Uncache table shouldn't throw an exception...

2016-11-21 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15896 I personally think `UNCACHE TABLE IF EXISTS` is best. It preserves the old behavior but lets the user make sure a table is not cached if they really want. --- If your project is set up

spark git commit: [SPARK-18361][PYSPARK] Expose RDD localCheckpoint in PySpark

2016-11-21 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.1 b0a73c9be -> 406f33987 [SPARK-18361][PYSPARK] Expose RDD localCheckpoint in PySpark ## What changes were proposed in this pull request? Expose RDD's localCheckpoint() and associated functions in PySpark. ## How was this patch tested?

spark git commit: [SPARK-18517][SQL] DROP TABLE IF EXISTS should not warn for non-existing tables

2016-11-21 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.1 251a99276 -> b0a73c9be [SPARK-18517][SQL] DROP TABLE IF EXISTS should not warn for non-existing tables ## What changes were proposed in this pull request? Currently, `DROP TABLE IF EXISTS` shows warning for non-existing tables.

spark git commit: [SPARK-18517][SQL] DROP TABLE IF EXISTS should not warn for non-existing tables

2016-11-21 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 70176871a -> ddd02f50b [SPARK-18517][SQL] DROP TABLE IF EXISTS should not warn for non-existing tables ## What changes were proposed in this pull request? Currently, `DROP TABLE IF EXISTS` shows warning for non-existing tables. However,

[GitHub] spark issue #15953: [SPARK-18517][SQL] DROP TABLE IF EXISTS should not warn ...

2016-11-21 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15953 Makes sense. This LGTM merging into master and 2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15811: [SPARK-18361] [PySpark] Expose RDD localCheckpoint in Py...

2016-11-21 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15811 LGTM merging into master thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

spark git commit: [SPARK-18361][PYSPARK] Expose RDD localCheckpoint in PySpark

2016-11-21 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 07beb5d21 -> 70176871a [SPARK-18361][PYSPARK] Expose RDD localCheckpoint in PySpark ## What changes were proposed in this pull request? Expose RDD's localCheckpoint() and associated functions in PySpark. ## How was this patch tested? I

[GitHub] spark issue #15811: [SPARK-18361] [PySpark] Expose RDD localCheckpoint in Py...

2016-11-15 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15811 Looks good, just one question. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15811: [SPARK-18361] [PySpark] Expose RDD localCheckpoin...

2016-11-15 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15811#discussion_r88115031 --- Diff: python/pyspark/rdd.py --- @@ -181,6 +181,7 @@ def __init__(self, jrdd, ctx, jrdd_deserializer=AutoBatchedSerializer(PickleSeri

[GitHub] spark issue #15811: [SPARK-18361] [PySpark] Expose RDD localCheckpoint in Py...

2016-11-15 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15811 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #15833: [SPARK-18353][CORE] spark.rpc.askTimeout defalut ...

2016-11-15 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15833#discussion_r88113719 --- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala --- @@ -221,7 +221,9 @@ object Client { val conf = new SparkConf

[GitHub] spark issue #15766: [SPARK-18271][SQL]hash udf in HiveSessionCatalog.hiveFun...

2016-11-04 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15766 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15756: [SPARK-18256] Improve the performance of event log repla...

2016-11-04 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15756 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...

2016-11-03 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15739 Also there's another patch trying to solve the same issue: #15742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15756: [SPARK-18256] Improve the performance of event log repla...

2016-11-03 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15756 LGTM. That's a massive amount of time spent in `Class.getSimpleName`! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #15756: [SPARK-18256] Improve the performance of event lo...

2016-11-03 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15756#discussion_r86422590 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -540,7 +544,8 @@ private[spark] object JsonProtocol { def

[GitHub] spark pull request #15756: [SPARK-18256] Improve the performance of event lo...

2016-11-03 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15756#discussion_r86422652 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -540,7 +544,8 @@ private[spark] object JsonProtocol { def

[GitHub] spark pull request #15756: [SPARK-18256] Improve the performance of event lo...

2016-11-03 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15756#discussion_r86422521 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -540,7 +544,8 @@ private[spark] object JsonProtocol { def

[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...

2016-11-03 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15739 ok to test @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15698: [SPARK-18182] Expose ReplayListenerBus.read() overload w...

2016-11-01 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15698 LGTM retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15410: [SPARK-17843][Web UI] Indicate event logs pending for pr...

2016-10-14 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15410 We shouldn't display file names but we should display application names and IDs, something the user understands. We don't have to do that as part of this issue. --- If your project is set up

[GitHub] spark issue #15458: [SPARK-17899][SQL] add a debug mode to keep raw table pr...

2016-10-14 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15458 I see. Then maybe we should add a comment above the config to note that several commands don't work (e.g. ALTER TABLE) if this is turned on, even if it's only internal. --- If your project

[GitHub] spark issue #15458: [SPARK-17899][SQL] add a debug mode to keep raw table pr...

2016-10-13 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15458 Yes that's why it's `internal` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

spark git commit: [SPARK-17686][CORE] Support printing out scala and java version with spark-submit --version command

2016-10-13 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master db8784fea -> 7bf8a4049 [SPARK-17686][CORE] Support printing out scala and java version with spark-submit --version command ## What changes were proposed in this pull request? In our universal gateway service we need to specify different

[GitHub] spark issue #15456: [SPARK-17686][Core] Support printing out scala and java ...

2016-10-13 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15456 Merging into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15458: [SPARK-17899][SQL] add a debug mode to keep raw table pr...

2016-10-13 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15458 JK, actually it doesn't merge in 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

spark git commit: [SPARK-17899][SQL] add a debug mode to keep raw table properties in HiveExternalCatalog

2016-10-13 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 6f2fa6c54 -> db8784fea [SPARK-17899][SQL] add a debug mode to keep raw table properties in HiveExternalCatalog ## What changes were proposed in this pull request? Currently `HiveExternalCatalog` will filter out the Spark SQL internal

[GitHub] spark issue #15458: [SPARK-17899][SQL] add a debug mode to keep raw table pr...

2016-10-13 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15458 Cool beans. Merging into master 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

spark git commit: [SPARK-11272][WEB UI] Add support for downloading event logs from HistoryServer UI

2016-10-13 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 7222a25a1 -> 6f2fa6c54 [SPARK-11272][WEB UI] Add support for downloading event logs from HistoryServer UI ## What changes were proposed in this pull request? This is a reworked PR based on feedback in #9238 after it was closed and not

[GitHub] spark issue #15400: [SPARK-11272] [Web UI] Add support for downloading event...

2016-10-13 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15400 This one LGTM I'm merging it into master. Thanks for working on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15400: [SPARK-11272] [Web UI] Add support for downloading event...

2016-10-13 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15400 Usually we retest the PR if it's been a few days since it last ran tests. We have had build breaks before where we merged a PR that passed tests a long time ago. --- If your project is set up

[GitHub] spark issue #15410: [SPARK-17843][Web UI] Indicate event logs pending for pr...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15410 ok to test I think the idea is good, but it would be a better UX if we display the pending applications as rows in the existing table (or a new one) and indicate there that it's still

[GitHub] spark pull request #15410: [SPARK-17843][Web UI] Indicate event logs pending...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15410#discussion_r83044768 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala --- @@ -38,6 +39,13 @@ private[history] class HistoryPage(parent

[GitHub] spark issue #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of Vertex...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15396 Looks good. I left a suggestion that I think will make the code cleaner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15396#discussion_r83043442 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1589,7 +1589,8 @@ abstract class RDD[T: ClassTag]( * This is introduced

[GitHub] spark pull request #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15396#discussion_r83042522 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1589,7 +1589,8 @@ abstract class RDD[T: ClassTag]( * This is introduced

[GitHub] spark issue #15400: [SPARK-11272] [Web UI] Add support for downloading event...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15400 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15353: [SPARK-17724][WebUI][Streaming] Unevaluated new lines in...

2016-10-10 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15353 @keypointt by "working" I mean it should be replaced by a line break, not a space --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark issue #15405: [SPARK-15917][CORE] Added support for number of executor...

2016-10-10 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15405 Thanks for working on this. It's great to see how small the patch turned out to be! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #15405: [SPARK-15917][CORE] Added support for number of e...

2016-10-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15405#discussion_r82671287 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -637,6 +637,16 @@ private[deploy] class Master

[GitHub] spark issue #15405: [SPARK-15917][CORE] Added support for number of executor...

2016-10-10 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15405 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

spark git commit: [SPARK-16827] Stop reporting spill metrics as shuffle metrics

2016-10-07 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 2b01d3c70 -> e56614cba [SPARK-16827] Stop reporting spill metrics as shuffle metrics ## What changes were proposed in this pull request? Fix a bug where spill metrics were being reported as shuffle metrics. Eventually these spill metrics

[GitHub] spark issue #15347: [SPARK-16827] Stop reporting spill metrics as shuffle me...

2016-10-07 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15347 OK, this change by itself LGTM. @dafrista would you mind creating a separate JIRA (or point me to an existing one) about the TODO then? Merging this into master --- If your project is set up

[GitHub] spark issue #15353: [SPARK-17724][WebUI][Streaming] Unevaluated new lines in...

2016-10-05 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15353 But this isn't the original intention, which is to actually add a line break where `\n` is today. IIRC this works correctly on Chrome but not on Safari (or the other way round?). If you can make

[GitHub] spark issue #15353: [SPARK-17724][WebUI][Streaming] Unevaluated new lines in...

2016-10-05 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15353 Also this is a more general problem, not just for streaming --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #15347: [SPARK-16827] Stop reporting spill metrics as shu...

2016-10-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15347#discussion_r82042420 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -145,7 +145,9 @@ private UnsafeExternalSorter

[GitHub] spark issue #15350: [SPARK-17778][Tests]Mock SparkContext to reduce memory u...

2016-10-05 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15350 I think that's OK. This is supposed to be a unit test for the BlockManager, not how BlockManager interacts with the rest of the system. LGTM --- If your project is set up for it, you can reply

spark git commit: [SPARK-17715][SCHEDULER] Make task launch logs DEBUG

2016-09-29 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master cb87b3ced -> 027dea8f2 [SPARK-17715][SCHEDULER] Make task launch logs DEBUG ## What changes were proposed in this pull request? Ramp down the task launch logs from INFO to DEBUG. Task launches can happen orders of magnitude more than

[GitHub] spark issue #15290: [SPARK-17715] [Scheduler] Make task launch logs DEBUG

2016-09-29 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15290 Merging into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15290: [SPARK-17715] [Scheduler] Make task launch logs DEBUG

2016-09-29 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15290 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #15247: [SPARK-17672] Spark 2.0 history server web Ui tak...

2016-09-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15247#discussion_r81218774 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala --- @@ -109,4 +109,11 @@ private[history] abstract class

spark git commit: [SPARK-17672] Spark 2.0 history server web Ui takes too long for a single application

2016-09-29 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.0 f7839e47c -> 7c9450b00 [SPARK-17672] Spark 2.0 history server web Ui takes too long for a single application Added a new API getApplicationInfo(appId: String) in class ApplicationHistoryProvider and class SparkUI to get app info. In

spark git commit: [SPARK-17672] Spark 2.0 history server web Ui takes too long for a single application

2016-09-29 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 7f779e743 -> cb87b3ced [SPARK-17672] Spark 2.0 history server web Ui takes too long for a single application Added a new API getApplicationInfo(appId: String) in class ApplicationHistoryProvider and class SparkUI to get app info. In this

[GitHub] spark pull request #15247: [SPARK-17672] Spark 2.0 history server web Ui tak...

2016-09-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15247#discussion_r81219143 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala --- @@ -109,4 +109,11 @@ private[history] abstract class

[GitHub] spark issue #15247: [SPARK-17672] Spark 2.0 history server web Ui takes too ...

2016-09-29 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15247 LGTM merging into master 2.0, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15247: [SPARK-17672] Spark 2.0 history server web Ui tak...

2016-09-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15247#discussion_r81219049 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala --- @@ -222,6 +222,7 @@ private[spark] object ApiRootResource

[GitHub] spark pull request #15247: [SPARK-17672] Spark 2.0 history server web Ui tak...

2016-09-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15247#discussion_r81218992 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -182,6 +182,10 @@ class HistoryServer

[GitHub] spark issue #15295: [SPARK-17720][SQL] introduce global SQL conf

2016-09-29 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15295 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

spark git commit: [SPARK-17648][CORE] TaskScheduler really needs offers to be an IndexedSeq

2016-09-29 Thread andrewor14
Repository: spark Updated Branches: refs/heads/master 958200497 -> 7f779e743 [SPARK-17648][CORE] TaskScheduler really needs offers to be an IndexedSeq ## What changes were proposed in this pull request? The Seq[WorkerOffer] is accessed by index, so it really should be an IndexedSeq,

[GitHub] spark issue #15221: [SPARK-17648][CORE] TaskScheduler really needs offers to...

2016-09-29 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15221 This looks reasonable. Merging into master. I will leave it out from branch-2.0 just in case. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #15295: [SPARK-17720][SQL] introduce global SQL conf

2016-09-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15295#discussion_r81150854 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -791,7 +791,7 @@ object SparkSession { // Get the session

[GitHub] spark issue #15295: [SPARK-17720][SQL] introduce global SQL conf

2016-09-29 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15295 LGTM. Pretty straightforward. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

spark git commit: [Docs] Update spark-standalone.md to fix link

2016-09-26 Thread andrewor14
Repository: spark Updated Branches: refs/heads/branch-2.0 8a58f2e8e -> f4594900d [Docs] Update spark-standalone.md to fix link Corrected a link to the configuration.html page, it was pointing to a page that does not exist (configurations.html). Documentation change, verified in preview.

  1   2   3   4   5   6   7   8   9   10   >