[GitHub] spark issue #21944: [SPARK-24988][SQL]Add a castBySchema method which casts ...

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on the issue: https://github.com/apache/spark/pull/21944 Closed the PR. This might be a useful trick, but we want to avoid adding many methods to the API. We'll reopen this in case many users asks

[GitHub] spark pull request #21944: [SPARK-24988][SQL]Add a castBySchema method which...

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 closed the pull request at: https://github.com/apache/spark/pull/21944 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21944: [SPARK-24988][SQL]Add a castBySchema method which...

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on a diff in the pull request: https://github.com/apache/spark/pull/21944#discussion_r207250060 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1367,6 +1367,22 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21944: [SPARK-24988][SQL]Add a castBySchema method which...

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on a diff in the pull request: https://github.com/apache/spark/pull/21944#discussion_r207209633 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1367,6 +1367,22 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21944: [SPARK-24988][SQL]Add a castBySchema method which...

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on a diff in the pull request: https://github.com/apache/spark/pull/21944#discussion_r207164547 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1367,6 +1367,22 @@ class Dataset[T] private[sql

[GitHub] spark issue #21961: Spark 20597

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on the issue: https://github.com/apache/spark/pull/21961 Hello @Satyajitv, please rename the title of this PR properly. The PR title should be of the form [SPARK-][COMPONENT] Title, where SPARK- is the relevant JIRA number, COMPONENT

[GitHub] spark pull request #21944: [SPARK-24988][SQL]Add a castBySchema method which...

2018-08-02 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on a diff in the pull request: https://github.com/apache/spark/pull/21944#discussion_r207156078 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1367,6 +1367,22 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21944: [SPARK-24988][SQL]Add a castBySchema method which...

2018-08-01 Thread mahmoudmahdi24
GitHub user mahmoudmahdi24 opened a pull request: https://github.com/apache/spark/pull/21944 [SPARK-24988][SQL]Add a castBySchema method which casts all the values of a DataFrame based on the DataTypes of a StructType ## What changes were proposed in this pull request

[GitHub] spark pull request #21120: [SPARK-22448][ML] Added sum function to Summerize...

2018-06-29 Thread mahmoudmahdi24
Github user mahmoudmahdi24 commented on a diff in the pull request: https://github.com/apache/spark/pull/21120#discussion_r199119223 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala --- @@ -562,6 +573,23 @@ private[ml] object SummaryBuilderImpl extends