[GitHub] spark pull request #22593: [Streaming][DOC] Fix typo & format in DataStreamW...

2018-10-11 Thread niofire
Github user niofire commented on a diff in the pull request: https://github.com/apache/spark/pull/22593#discussion_r224539150 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -46,11 +46,13 @@ final class DataFrameWriter[T] private[sql](ds

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-11 Thread niofire
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 Is this happening for other PRs as well? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-11 Thread niofire
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 org.apache.spark.sql.hive.client.HiveClientSuites.(It is not a test it is a sbt.testing.SuiteSelector) -> Unable to instantiate org.apache.hadoop.hive.metastore.HiveMetaStoreCli

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-11 Thread niofire
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 Seems like this wasn't able to build due to a transient error with CI --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-10 Thread niofire
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 From https://spark.apache.org/docs/2.3.2/api/java/org/apache/spark/sql/streaming/DataStreamWriter.html ![image](https://user-images.githubusercontent.com/2295469/46749482-b3351400-cc6a-11e8

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-10 Thread niofire
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 @srowen Guessing you're referring to some other files? Could you link? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-10 Thread niofire
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 Sorry, was out of town, will update --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #22593: Fix typo & format in DataStreamWriter.scala

2018-09-29 Thread niofire
GitHub user niofire opened a pull request: https://github.com/apache/spark/pull/22593 Fix typo & format in DataStreamWriter.scala ## What changes were proposed in this pull request? - Fixed typo for function outputMode - OutputMode.Complete(), changed `these is