https://github.com/mtrofin approved this pull request.
LGTM for the `ctx_profile` part.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91886
>From f6135c1b825afd9fe733b845dfd12ffe3c162840 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sun, 12 May 2024 18:08:50 +0400
Subject: [PATCH 1/2] [lldb] Fixed the test TestQuoting
os.path.join() uses
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Target::Install() set 0700 permissions for the main executable file.
Platform::Install() just copies permissions from the source. But the permission
eFilePermissionsUserExecute is missing on the Windows
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91887
Target::Install() set 0700 permissions for the main executable file.
Platform::Install() just copies permissions from the source. But the permission
eFilePermissionsUserExecute is missing on the Windows host.
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1d6bf0ca29322b08e8b50681d440e7182441b025...f6135c1b825afd9fe733b845dfd12ffe3c162840
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
os.path.join() uses the path separator of the host OS by default. outfile_arg
will be incorrect in case of Windows host and Linux target. Use
lldbutil.append_to_process_working_directory() instead.
---
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91886
os.path.join() uses the path separator of the host OS by default. outfile_arg
will be incorrect in case of Windows host and Linux target. Use
lldbutil.append_to_process_working_directory() instead.
>From
https://github.com/ftynse approved this pull request.
LGTM for the MLIR part. Please seek approval from relevant reviewers for all
other subprojects.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/91880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JOE1994 wrote:
A new user already asked to be assigned to work on #91209 2 days ago in the
comments.
**I think that user deserves an opportunity to work on the issue**.
Next time when you see a **"good first issue"** which a new user had already
asked to get assigned to,
please assign it to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 63224d717108d927e998da8a67050a6cc5dd74a2
9b4160975efe059f39a842689b1f750a10453203 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (aabhinavg)
Changes
This commit addresses issue #87244, where a redundant condition was
found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the
Target.cpp file
fix #87244
---
Full diff:
https://github.com/aabhinavg created
https://github.com/llvm/llvm-project/pull/91882
This commit addresses issue #87244, where a redundant condition was found in
the Target.cpp file. Static analyzer cppcheck flagged the issue in the
Target.cpp file
fix #87244
>From
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: None (aabhinavg)
Changes
Author: aabhinavg tiwariabhinavak@gmail.com
Date: Sun May 12 12:46:54 2024 +0800
Reviewers: @JOE1994, @chelcassanova, @dcb314
Fixes: #91209
Summary of Changes:
- Replaced the ineffective call to 'substr'
https://github.com/aabhinavg created
https://github.com/llvm/llvm-project/pull/91880
Author: aabhinavg
Date: Sun May 12 12:46:54 2024 +0800
Reviewers: @JOE1994, @chelcassanova, @dcb314
Fixes: #91209
Summary of Changes:
- Replaced the ineffective call to 'substr' with a more efficient use of
e-kwsm wrote:
Commit message is updated/
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91858
>From 12e8ea6a0e104efbe130dd15d4d9051a7d86d50e Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH] fix(python): fix comparison to True/False
from PEP8
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91857
>From 7cec823d9a87b90bf8d9ae5c975f4492076e0abb Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(python): fix comparison to None
from PEP8
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
- **[lldb] Support custom LLVM formatting for variables (#81196)**
- **[lldb] Handle non-existent llvm_format**
---
Full diff: https://github.com/llvm/llvm-project/pull/91868.diff
5 Files Affected:
-
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/91868
- **[lldb] Support custom LLVM formatting for variables (#81196)**
- **[lldb] Handle non-existent llvm_format**
>From 30a36018b9c96d7ddd969815ef850987d781338e Mon Sep 17 00:00:00 2001
From: Dave Lee
Date:
e-kwsm wrote:
> Why do we need to make this change?
The valid escape sequences in Python are listed
[here](https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences):
`\t`, `\n`, etc.
Invalid ones fixed here seem to be used for regular expression,
ftynse wrote:
This should be included in the actual commit, not GitHub comments.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
e-kwsm wrote:
>From [PEP8](https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with `is` or `is
> not`, never the equality operators.
[flake8](https://flake8.pycqa.org/en/latest/) is used here.
Author: Dave Lee
Date: 2024-05-11T11:48:31-07:00
New Revision: baffaf000fd4667f33b3756d0d3b645b1d926b44
URL:
https://github.com/llvm/llvm-project/commit/baffaf000fd4667f33b3756d0d3b645b1d926b44
DIFF:
https://github.com/llvm/llvm-project/commit/baffaf000fd4667f33b3756d0d3b645b1d926b44.diff
tstellar wrote:
Two questions:
* Did you use a script to generate this patch?
* Why do we need to make this change?
https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ftynse wrote:
Please provide a proper patch description, i.e., why the change is being made.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91858.diff
18 Files Affected:
- (modified) clang/tools/scan-build/bin/set-xcode-analyzer (+1-1)
- (modified) clang/utils/check_cfc/check_cfc.py
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91858
None
>From 1e31186c01024c63fa4c0bd378fec7131ce84d56 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH] fix(python): fix comparison to True/False
---
llvmbot wrote:
@llvm/pr-subscribers-pgo
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 35.05 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91857.diff
50 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 35.05 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91857.diff
50 Files Affected:
- (modified)
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91857
None
>From c450df191a6b96591d7c7a7454b6e15cb925520f Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(python): fix comparison to None
---
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 120.87 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91856.diff
100 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-libcxx
@llvm/pr-subscribers-clang
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 120.87 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91856.diff
100 Files Affected:
- (modified)
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
aokblast wrote:
I extend this feature to all kernel module in
[here](https://reviews.freebsd.org/D45161/new/). Then I will write the
corresponding code for LLDB later. Since kernel is also in linker_files
structure. So I convinced that it can fix the problem.
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Ok, minor correction: if there is no complete parent chain, it just defaults to
the older implementation (which calls ProcessEntry). But my point still stands:
I don't believe this is related to the presence of IDX_parent.
```
void
felipepiovezan wrote:
> > we should probably fix the underlying issue instead: #77696
>
> We still have binaries that are floating around for now that contain this
> issue and this was causing crashes. So it would be nice to fix this in LLDB
> for now and back this out after we have a stable
ZequanWu wrote:
> > Could this commit have broken the bots?
> > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1897/
>
> Looks like so, but I cannot repro the test failure locally.
The error message is different in current latest build
jimingham wrote:
> Hm, so in that case should we focus on adding an `SBStream::GetUseColor` so
> that the stream's colour settings can take precedence here?
That's the only way it makes sense to me. But if we are going to rely on the
stream, we also have to be sure that we're setting the
ZequanWu wrote:
> Could this commit have broken the bots?
> https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1897/
Looks like so, but I cannot repro the test failure locally.
https://github.com/llvm/llvm-project/pull/90663
___
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/91686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
maybe the shell test is building without debug info, I am surprised to see
assembly there. If I build it like that and run it by hand,
```
(lldb) settings set platform.plugin.darwin.ignored-exceptions
EXC_BAD_INSTRUCTION
(lldb) b sigill_handler
Breakpoint 1: where =
jasonmolenda wrote:
Ah, I misunderstood what the nature of the failure was. I tried running the
shell test, and it's failing for different reasons. I almost never touch shell
tests, I find them really hard to debug so I'm not sure what the problem is.
If I run it by hand,
```
(lldb)
adrian-prantl wrote:
Could this commit have broken the bots?
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1897/
https://github.com/llvm/llvm-project/pull/90663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
chelcassanova wrote:
Hm, so in that case should we focus on adding an `SBStream::GetUseColor` so
that the stream's colour settings can take precedence here?
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
jasonmolenda wrote:
> I have fixed/worked around the mach exception issue in a [followup
> commit](https://github.com/llvm/llvm-project/commit/b903badd73a2467fdd4e363231f2bf9b0704b546)
> with a `settings set platform.plugin.darwin.ignored-exceptions
> EXC_BAD_INSTRUCTION`. Now the process
https://github.com/clayborg requested changes to this pull request.
We should make this thread safe. It can only help and this isn't an API which
gets called all of the time, so performance isn't an issue. A few inline
comments
https://github.com/llvm/llvm-project/pull/89868
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton =
@@ -1689,35 +1689,56 @@ void
SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback,
void SBDebugger::SetDestroyCallback(
lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) {
LLDB_INSTRUMENT_VA(this, destroy_callback, baton);
+
if
@@ -1689,35 +1689,56 @@ void
SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback,
void SBDebugger::SetDestroyCallback(
lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) {
LLDB_INSTRUMENT_VA(this, destroy_callback, baton);
+
if
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> we should probably fix the underlying issue instead: #77696
We still have binaries that are floating around for now that contain this issue
and this was causing crashes. So it would be nice to fix this in LLDB for now
and back this out after we have a stable and trustable
clayborg wrote:
> we should probably fix the underlying issue instead: #77696
This is one fix that is needed. Quoted from an e-mail chain:
> I need to find my notes from those days, but I don't think we did. As Greg
> points out, the standard forbids forward declarations in debug_names;
clayborg wrote:
> The change/explanation looks intuitive, but I remember having seen DIE entry
> with `DW_AT_declaration (true)` but is not a forward declaration (it is a
> definition and has other attributes) . Will we cause regression in that case?
No, it is ok for `DW_AT_declaration(true)`
felipepiovezan wrote:
we should probably fix the underlying issue instead:
https://github.com/llvm/llvm-project/issues/77696
https://github.com/llvm/llvm-project/pull/91808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jeffreytan81 wrote:
The change/explanation looks intuitive, but I remember having seen DIE entry
with `DW_AT_declaration (true)` but is not a forward declaration (it is a
definition and has other attributes) . Will we cause regression in that case?
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/91808
>From 0cc1be6988e6ab5498151f32485f525a66133be2 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Fri, 10 May 2024 13:49:22 -0700
Subject: [PATCH] Improve performance of .debug_names lookups when
DW_IDX_parent
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
When a .debug_names table has entries that use the DW_IDX_parent attributes, we
can end up with entries in the .debug_names table that are not full
definitions. This is because a class that is foward
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/91808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/91808
When a .debug_names table has entries that use the DW_IDX_parent attributes, we
can end up with entries in the .debug_names table that are not full
definitions. This is because a class that is foward declared,
https://github.com/royitaqi reopened
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
Gentle ping. :)
@jim
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi closed
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/91799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-05-10T16:39:20-04:00
New Revision: a7eff59f78f08f8ef0487dfe2a136fb311af4fd0
URL:
https://github.com/llvm/llvm-project/commit/a7eff59f78f08f8ef0487dfe2a136fb311af4fd0
DIFF:
https://github.com/llvm/llvm-project/commit/a7eff59f78f08f8ef0487dfe2a136fb311af4fd0.diff
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/91799
>From 1f6bf890dbfce07b6ab531597e876ab83cfd1298 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Fri, 10 May 2024 16:00:22 -0400
Subject: [PATCH 1/2] [lldb][DWARF] Do not complete type from declaration die.
---
@@ -85,3 +86,91 @@ def test_command_output(self):
self.assertEqual(res.GetOutput(), "")
self.assertIsNotNone(res.GetError())
self.assertEqual(res.GetError(), "")
+
+def test_structured_transcript(self):
+"""Test structured transcript
@@ -2343,7 +2343,10 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const
DWARFDIE ,
// clang::ExternalASTSource queries for this type.
m_ast.SetHasExternalStorage(clang_type.GetOpaqueQualType(), false);
- if (!die)
+ ParsedDWARFTypeAttributes attrs(die);
+ bool
https://github.com/clayborg approved this pull request.
This does fix things on your side. I will take care of a new PR for not
searching all definition DIEs from the .debug_names.
https://github.com/llvm/llvm-project/pull/91799
___
lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/91799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -290,6 +290,31 @@ class StructuredData {
void GetDescription(lldb_private::Stream ) const override;
+/// Creates an Array of substrings by splitting a string around the
+/// occurrences of a separator character.
+///
+/// \param[in] s
+/// The
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2044,6 +2052,15 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
m_transcript_stream << result.GetOutputData();
m_transcript_stream << result.GetErrorData();
+ // Add output and error to the transcript item after splitting lines. In the
+ //
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/90703
>From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 30 Apr 2024 21:35:49 -0700
Subject: [PATCH 01/13] Add SBCommandInterpreter::GetTranscript()
---
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/90703
>From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 30 Apr 2024 21:35:49 -0700
Subject: [PATCH 01/12] Add SBCommandInterpreter::GetTranscript()
---
ZequanWu wrote:
> To the above function to ensure we don't waste any time trying to parse any
> DIE information for forward declaration when using .debug_names. This will
> cause a TON of churn on our DWARF parser and cause us to pull in and parse
> way too much.
That sounds like a better
felipepiovezan wrote:
AFAICT we never added new entries -- definitely not forward declarations -- to
the table when doing the idx_parent work. Either they were already there, or
the entry would have no parent. Would be nice to have an example to see this in
action.
https://github.com/clayborg commented:
Let me verify this works. I would also like this to fix:
```
bool DebugNamesDWARFIndex::ProcessEntry(
const DebugNames::Entry ,
llvm::function_ref callback) {
std::optional ref = ToDIERef(entry);
if (!ref)
return true;
SymbolFileDWARF =
ZequanWu wrote:
I sent an alternative fix at https://github.com/llvm/llvm-project/pull/91799.
> The .debug_names spec states that only entries with definitions should be in
> the .debug_names table...
Do it mean the .debug_names is implemented incorrectly?
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
Fix the problem:
https://github.com/llvm/llvm-project/pull/90663#issuecomment-2105164917 by
enhancing a double-check for #90663
---
Full diff: https://github.com/llvm/llvm-project/pull/91799.diff
1 Files
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/91799
Fix the problem:
https://github.com/llvm/llvm-project/pull/90663#issuecomment-2105164917 by
enhancing a double-check for #90663
>From 1f6bf890dbfce07b6ab531597e876ab83cfd1298 Mon Sep 17 00:00:00 2001
From:
clayborg wrote:
See the `/// <<< newly added for fix` comments for the new lines
https://github.com/llvm/llvm-project/pull/90663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Ok, I found the issue. `.debug_names` tables with `DW_IDX_parent` entries,
might contain tons of entries for forward declared classes because in my
example `std::ios_base` is the parent declaration context for `seekdir`,
`openmode`, and `iostate` so `.debug_names` entries for
ZequanWu wrote:
> The issue might arise from having a .debug_names table that has DW_IDX_parent
> entries that means that there might be forward declarations included in the
> DWARF index.
Do you mean that the searching in the type index returns a declaration DIE (but
I expected it to always
ZequanWu wrote:
> So this DIE is just a declaration. Shouldn't this code have tried to find a
> non declaration DIE for "std::ios_base"?
Yes, I suppose `SymbolFileDWARF::CompleteType` will try to find the definition
DIE for it before calling `DWARFASTParserClang::CompleteTypeFromDWARF`. If
clayborg wrote:
Is `SymbolFileDWARF::CompleteType(...)` responsible for trying to find a
non-declaration DIE first? The issue might arise from having a .debug_names
table that has `DW_IDX_parent` entries that means that there might be forward
declarations included in the DWARF index.
clayborg wrote:
This is causing a clang assertion due:
```
(lldb) type lookup std::ios_base
Assertion failed: (DD && "queried property of class with no definition"),
function data, file DeclCXX.h, line 464.
bt
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = hit program
@@ -144,6 +144,19 @@ class ProcessInstanceInfo : public ProcessInfo {
long int tv_usec = 0;
};
+ enum class ProcessState {
+Unknown,
+Dead,
+DiskSleep,
+Idle,
+Paging,
+Parked,
+Running,
+Sleeping,
+TracedOrStopped,
+Zombie,
+
@@ -70,6 +71,12 @@ struct StatFields {
long unsigned stime;
long cutime;
long cstime;
+ // in proc_pid_stat(5) this field is specified as priority
hawkinsw wrote:
```suggestion
// In proc_pid_stat(5) this field is specified as priority
```
@@ -70,6 +71,12 @@ struct StatFields {
long unsigned stime;
long cutime;
long cstime;
+ // in proc_pid_stat(5) this field is specified as priority
+ // but documented as realtime priority. To keep with the adopted
+ // nomenclature in ProcessInstanceInfo we adopt the
@@ -115,13 +124,19 @@ static bool GetStatusInfo(::pid_t Pid,
ProcessInstanceInfo ,
return ts;
};
+ // priority (nice) values run from 19 to -20 inclusive (in linux). In the
+ // prpsinfo struct pr_nice is a char
hawkinsw wrote:
```suggestion
//
1 - 100 of 86195 matches
Mail list logo
