Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

[linux-next:master] BUILD REGRESSION d37e1e4c52bc60578969f391fb81f947c3e83118

2024-02-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d37e1e4c52bc60578969f391fb81f947c3e83118 Add linux-next specific files for 20240216 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202402161359.furktcoz-...@intel.com https

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH] drm/amd: Drop abm_level property

2024-02-16 Thread Harry Wentland
On 2024-02-16 10:33, Mario Limonciello wrote: > This vendor specific property has never been used by userspace > software and conflicts with the panel_power_savings sysfs file. > That is a compositor and user could fight over the same data. > > Fixes: f97e4303da16 ("drm/amd/display: add

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

RE: [PATCH 3/4] drm/amdgpu: Use correct SRIOV macro for gmc_v9_0_vm_fault_interrupt_state

2024-02-16 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed By Zhigang Luo From: Lu, Victor Cheng Chi (Victor) Sent: Friday, February 16, 2024 1:50 PM To: Luo, Zhigang Subject: Fw: [PATCH 3/4] drm/amdgpu: Use correct SRIOV macro for gmc_v9_0_vm_fault_interrupt_state [AMD Official Use Only - General]

Re: [PATCH 1/2] drm/amdkfd: Document and define SVM event tracing macro

2024-02-16 Thread Felix Kuehling
On 2024-02-15 10:18, Philip Yang wrote: Document how to use SMI system management interface to receive SVM events. Define SVM events message string format macro that could use by user mode for sscanf to parse the event. Add it to uAPI header file to make it obvious that is changing uAPI in

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Alex Deucher
On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: > > Am 16.02.24 um 16:12 schrieb Mario Limonciello: > > On 2/16/2024 09:05, Harry Wentland wrote: > >> > >> > >> On 2024-02-16 09:47, Christian König wrote: > >>> Am 16.02.24 um 15:42 schrieb Mario Limonciello: > On 2/16/2024 08:38,

Re: [PATCH v2] drm/amd/display: fix null-pointer dereference on edid reading

2024-02-16 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 16, 2024 at 7:24 AM Melissa Wen wrote: > > Use i2c adapter when there isn't aux_mode in dc_link to fix a > null-pointer derefence that happens when running > igt@kms_force_connector_basic in a system with DCN2.1 and HDMI connector > detected as below: > > [

Re: [PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Daniel Vetter
On Fri, Feb 16, 2024 at 05:51:59PM +0100, Christian König wrote: > Am 16.02.24 um 17:32 schrieb Daniel Vetter: > > On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote: > > > This new event can be used to trace where a given dma_fence is added > > > as a dependency of some

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

2024-02-16 Thread Alex Deucher
Applied. Thanks. Alex On Fri, Feb 16, 2024 at 5:38 AM Ilpo Järvinen wrote: > > On Thu, 15 Feb 2024, Deucher, Alexander wrote: > > > [Public] > > > > > -Original Message- > > > From: Ilpo Järvinen > > > Sent: Thursday, February 15, 2024 8:32 AM > > > To: Deucher, Alexander ; amd- > > >

Re: [PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Christian König
Am 16.02.24 um 17:32 schrieb Daniel Vetter: On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote: This new event can be used to trace where a given dma_fence is added as a dependency of some other work. How? What I'd expected here is that you add a dependency chain from

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-16 Thread Daniel Vetter
On Mon, Feb 12, 2024 at 01:27:57PM +0200, Jani Nikula wrote: > On Sat, 10 Feb 2024, Mario Limonciello wrote: > > On 2/9/2024 12:57, Daniel Vetter wrote: > >> On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote: > >>> On 2/9/2024 05:07, Daniel Vetter wrote: > On Thu, Feb 08,

Re: [PATCH v2 6/6] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Steven Rostedt
On Fri, 16 Feb 2024 17:37:23 +0100 Daniel Vetter wrote: > > > @@ -1503,6 +1504,24 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > > > drm_mode_object_put(obj); > > > } > > > > > > + if (trace_drm_mode_atomic_commit_enabled()) { > > > + struct drm_crtc_state

Re: [PATCH] drm/amd/display: Fix memory leak in dm_sw_fini()

2024-02-16 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 12, 2024 at 8:08 PM Armin Wolf wrote: > > After destroying dmub_srv, the memory associated with it is > not freed, causing a memory leak: > > unreferenced object 0x896302b45800 (size 1024): > comm "(udev-worker)", pid 222, jiffies 4294894636 > hex dump

Re: [PATCH v2 6/6] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 11:20:17AM -0500, Steven Rostedt wrote: > On Tue, 13 Feb 2024 16:50:31 +0100 > Pierre-Eric Pelloux-Prayer wrote: > > > @@ -1503,6 +1504,24 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > > drm_mode_object_put(obj); > > } > > > > + if

Re: [PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote: > This new event can be used to trace where a given dma_fence is added > as a dependency of some other work. How? What I'd expected here is that you add a dependency chain from one fence to another, but this only has one

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Mario Limonciello
On 2/16/2024 10:13, Harry Wentland wrote: On 2024-02-16 11:11, Harry Wentland wrote: On 2024-02-16 10:42, Pekka Paalanen wrote: On Fri, 16 Feb 2024 09:33:47 -0500 Harry Wentland wrote: On 2024-02-16 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote:

Re: [PATCH v2 0/6] dma-fence, drm, amdgpu new trace events

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 04:50:25PM +0100, Pierre-Eric Pelloux-Prayer wrote: > This series adds new events to make it easier for tools > like gpuvis or umr to graph the GPUs, kernel and applications > activity. > > UMR patches using these events can be found here: >

Re: [PATCH v3 6/8] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Ville Syrjälä
On Fri, Feb 16, 2024 at 04:09:55PM +0100, Pierre-Eric Pelloux-Prayer wrote: > With this and the dma_fence_used_as_dependency event, a tool can draw the > relationship between the compositing draw, the atomic commit, and vblank. > > An example on a 2 monitors system look like this: > >

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 11:11, Harry Wentland wrote: > > > On 2024-02-16 10:42, Pekka Paalanen wrote: >> On Fri, 16 Feb 2024 09:33:47 -0500 >> Harry Wentland wrote: >> >>> On 2024-02-16 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: > We want

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 10:42, Pekka Paalanen wrote: > On Fri, 16 Feb 2024 09:33:47 -0500 > Harry Wentland wrote: > >> On 2024-02-16 03:19, Pekka Paalanen wrote: >>> On Fri, 2 Feb 2024 10:28:35 -0500 >>> Hamza Mahfooz wrote: >>> We want programs besides the compositor to be able to enable or

Re: [PATCH v3 6/8] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Steven Rostedt
On Fri, 16 Feb 2024 16:09:55 +0100 Pierre-Eric Pelloux-Prayer wrote: > > Signed-off-by: Pierre-Eric Pelloux-Prayer > --- > drivers/gpu/drm/drm_atomic_uapi.c | 21 + > drivers/gpu/drm/drm_trace.h | 23 +++ > 2 files changed, 44 insertions(+) > >

Re: [PATCH v3 3/8] amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync

2024-02-16 Thread Christian König
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer: This makes it possible to understand the dependencies between jobs. Possible usage of this trace: * stuttering issues like Mesa !9189 * incorrect synchronization: I don't have a link for this one, but having these events was very useful

[PATCH] drm/amd: Drop abm_level property

2024-02-16 Thread Mario Limonciello
This vendor specific property has never been used by userspace software and conflicts with the panel_power_savings sysfs file. That is a compositor and user could fight over the same data. Fixes: f97e4303da16 ("drm/amd/display: add panel_power_savings sysfs entry to eDP connectors")

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 09:41, Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Pekka Paalanen
On Fri, 16 Feb 2024 09:33:47 -0500 Harry Wentland wrote: > On 2024-02-16 03:19, Pekka Paalanen wrote: > > On Fri, 2 Feb 2024 10:28:35 -0500 > > Hamza Mahfooz wrote: > > > >> We want programs besides the compositor to be able to enable or disable > >> panel power saving features. > > > >

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM

RE: [PATCH 9/9] drm/amdgpu: enable MES discovery for GC 11.5.1

2024-02-16 Thread Liu, Shaoyun
[AMD Official Use Only - General] Reviewed by shaoyun.liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 15, 2024 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Yifan ; Deucher, Alexander Subject: [PATCH 9/9] drm/amdgpu: enable MES discovery

Re: [PATCH v3 2/8] dma-buf/fence-chain: use trace_dma_fence_sync_to

2024-02-16 Thread Christian König
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer: To inform tools about the relationship between the fences. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König --- drivers/dma-buf/dma-fence-chain.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] drm/amdgpu: Do not program IH_CHICKEN in vega20_ih.c under SRIOV

2024-02-16 Thread Alex Deucher
On Tue, Feb 13, 2024 at 5:43 PM Victor Lu wrote: > > IH_CHICKEN is blocked for VF writes; this access should be skipped. > > Signed-off-by: Victor Lu Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 38 ++ > 1 file changed, 20 insertions(+), 18

Re: [PATCH v3 1/8] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Christian König
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer: This new event can be used to trace where a given dma_fence is added as a dependency of some other work. I plan to use it in amdgpu. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence.c | 1 +

Re: [PATCH] drm/amdgpu: Improve error checking in amdgpu_virt_rlcg_reg_rw (v2)

2024-02-16 Thread Alex Deucher
On Tue, Feb 13, 2024 at 2:03 PM Victor Lu wrote: > > The current error detection only looks for a timeout. > This should be changed to also check scratch_reg1 for any errors > returned from RLCG. > > v2: remove new error value > > Signed-off-by: Victor Lu Acked-by: Alex Deucher > --- >

Re: [PATCH v3 0/8] dma-fence, drm, amdgpu new trace events

2024-02-16 Thread Christian König
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer: This series adds new events to make it easier for tools like gpuvis or umr to graph the GPUs, kernel and applications activity. UMR patches using these events can be found here:

Reporting a null-ptr-deref in amdgpu

2024-02-16 Thread Joonkyo Jung
Hello, We would like to report a null-ptr-deref bug in the AMDGPU DRM driver in the linux kernel v6.8-rc4 that we found with our customized Syzkaller. The bug can be triggered by sending two ioctls to the AMDGPU DRM driver in succession. The first ioctl amdgpu_ctx_ioctl will create a ctx, and

Reporting a slab-use-after-free in amdgpu

2024-02-16 Thread Joonkyo Jung
Hello, We would like to report a slab-use-after-free bug in the AMDGPU DRM driver in the linux kernel v6.8-rc4 that we found with our customized Syzkaller. The bug can be triggered by sending two ioctls to the AMDGPU DRM driver in succession. In amdgpu_bo_move, struct ttm_resource *old_mem =

RE: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

2024-02-16 Thread Ilpo Järvinen
On Thu, 15 Feb 2024, Deucher, Alexander wrote: > [Public] > > > -Original Message- > > From: Ilpo Järvinen > > Sent: Thursday, February 15, 2024 8:32 AM > > To: Deucher, Alexander ; amd- > > g...@lists.freedesktop.org; Daniel Vetter ; David Airlie > > ; Dennis Dalessandro > > ; dri- > >

[PATCH 2/2] drm/amdgpu: use new reset-affected accessors for userspace interfaces

2024-02-16 Thread Alex Deucher
Use the new reset critical section accessors for debugfs, sysfs, and the INFO IOCTL to provide proper mutual exclusivity to hardware with respect the GPU resets. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c |

[PATCH 1/2] drm/amdgpu: add new accessors for GPU reset-affected critcal sections

2024-02-16 Thread Alex Deucher
Provide helper functions for code which needs to be mutually exclusive with GPU resets. While we are here, move amdgpu_in_reset in amdgpu_reset.c since that is the more logical location for it and add documentation. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH v3 8/8] drm/amdgpu: add devname to trace_amdgpu_sched_run_job

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
With the move to work queues for the drm scheduler it becomes impossible for a tool to match the events to the GPU. Before this move, the event source was fixed (eg: gfx_0.0.0-598), so even if the system had multiple GPUs with identical queue names it was possible to map the events using the PID.

[PATCH v3 7/8] drm/sched: use trace_dma_fence_used_as_dependency

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
drm_sched_job_add_dependency adds dependencies so use the new trace event. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/scheduler/sched_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and

[PATCH v3 6/8] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
With this and the dma_fence_used_as_dependency event, a tool can draw the relationship between the compositing draw, the atomic commit, and vblank. An example on a 2 monitors system look like this: gnome-shell-1638[018] . 2571.905124: drm_mode_atomic_commit: file=245c3f0c, pid=

[PATCH v3 5/8] drm/amdgpu: add a amdgpu_cs_start trace event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
amdgpu_cs_ioctl already exists but serves a different purpose. amdgpu_cs_start marks the beginning of the kernel processing of the ioctl which is useful for tools to map which events belong to the same submission (without this, the first event would be the amdgpu_bo_set_list ones). v2: renamed

[PATCH v3 4/8] drm/amdgpu: add a amdgpu_bo_fill trace event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
Useful to identify why sdma jobs are submitted. v2: moved from amdgpu_bo_create to amdgpu_bo_fill Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ 2 files changed, 20

[PATCH v3 3/8] amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
This makes it possible to understand the dependencies between jobs. Possible usage of this trace: * stuttering issues like Mesa !9189 * incorrect synchronization: I don't have a link for this one, but having these events was very useful to debug a virtio-gpu / native-context / radeonsi sync

[PATCH v3 2/8] dma-buf/fence-chain: use trace_dma_fence_sync_to

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
To inform tools about the relationship between the fences. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence-chain.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c index

[PATCH v3 1/8] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
This new event can be used to trace where a given dma_fence is added as a dependency of some other work. I plan to use it in amdgpu. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence.c | 1 + include/trace/events/dma_fence.h | 27 +++ 2 files

[PATCH v3 0/8] dma-fence, drm, amdgpu new trace events

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
This series adds new events to make it easier for tools like gpuvis or umr to graph the GPUs, kernel and applications activity. UMR patches using these events can be found here: https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37 V1:

Re: [PATCH] drm/amd: Change `jpeg_v4_0_5_start_dpg_mode()` to void

2024-02-16 Thread Alex Deucher
On Thu, Feb 15, 2024 at 4:58 PM Mario Limonciello wrote: > > jpeg_v4_0_5_start_dpg_mode() always returns 0 and the return value > doesn't get used in the caller jpeg_v4_0_5_start(). Modify the > function to be void. > > Reported-by: coverity-bot > Addresses-Coverity-ID: 1583635 ("Code

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 15:47 schrieb Matthew Auld: On 16/02/2024 14:02, Christian König wrote: Am 16.02.24 um 14:21 schrieb Matthew Auld: On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Harry Wentland
On 2024-02-16 09:47, Christian König wrote: > Am 16.02.24 um 15:42 schrieb Mario Limonciello: >> On 2/16/2024 08:38, Christian König wrote: >>> Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Matthew Auld
On 16/02/2024 14:02, Christian König wrote: Am 16.02.24 um 14:21 schrieb Matthew Auld: On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM:

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2: DRM -1: sysfs (IE via software like

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 03:19, Pekka Paalanen wrote: > On Fri, 2 Feb 2024 10:28:35 -0500 > Hamza Mahfooz wrote: > >> We want programs besides the compositor to be able to enable or disable >> panel power saving features. > > Could you also explain why, in the commit message, please? > > It is

[PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2: DRM -1: sysfs (IE via software like power-profiles-daemon) 0-4: User via command line Also

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 14:21 schrieb Matthew Auld: On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Hamza Mahfooz
On 2/16/24 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: We want programs besides the compositor to be able to enable or disable panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Hamza Mahfooz
On 2/16/24 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: We want programs besides the compositor to be able to enable or disable panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Matthew Auld
On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available.

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

[PATCH 3/3] drm/amdgpu: Remove pcie bw sys entry

2024-02-16 Thread Asad Kamal
Remove pcie bw sys entry for asics not supporting such function Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/soc15.c | 1 - drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/3] Revert "drm/amdgpu: Add pcie usage callback to nbio"

2024-02-16 Thread Asad Kamal
pcie usage is now handled by fw This reverts commit 8d759dc6644df4141a151293cb0e77fd8ca379ed. Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 3 --- 2 files changed, 11 deletions(-) diff

[PATCH 1/3] Revert "drm/amdgpu: Add pci usage to nbio v7.9"

2024-02-16 Thread Asad Kamal
Remove implementation to get pcie usage for nbio v7.9 as pcie usage is handled by fw This reverts commit 59070fd9ccea58c3363d39f69c25fa98c71eb02f. Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c| 63 ---

Re: [PATCH 0/6 V4] fdinfo shared stats

2024-02-16 Thread Christian König
Am 15.02.24 um 15:20 schrieb Alex Deucher: On Thu, Feb 15, 2024 at 9:18 AM Christian König wrote: Am 12.02.24 um 22:04 schrieb Alex Deucher: We had a request to add shared buffer stats to fdinfo for amdgpu and while implementing that, Christian mentioned that just looking at the GEM handle

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam

Re: [PATCH] drm/amd/display: fix null-pointer dereference on edid reading

2024-02-16 Thread Melissa Wen
On 02/15, Alex Deucher wrote: > On Thu, Feb 15, 2024 at 12:35 PM Melissa Wen wrote: > > > > Use i2c adapter when there isn't aux_mode in dc_link to fix a > > null-pointer derefence that happens when running > > igt@kms_force_connector_basic in a system with DCN2.1 and HDMI connector > > detected

Re: [PATCH 0/9] PSP 14.0 support

2024-02-16 Thread Christian König
Am 12.02.24 um 18:58 schrieb Alex Deucher: This set adds support for PSP 14.0.x. PSP handles firmware validation and various low level asic initialization. The first patch adds register headers and is large so it has been omitted. Hawking Zhang (2): drm/amdgpu: Add mp v14_0_2 ip headers

[PATCH v2] drm/amd/display: fix null-pointer dereference on edid reading

2024-02-16 Thread Melissa Wen
Use i2c adapter when there isn't aux_mode in dc_link to fix a null-pointer derefence that happens when running igt@kms_force_connector_basic in a system with DCN2.1 and HDMI connector detected as below: [ +0.178146] BUG: kernel NULL pointer dereference, address: 04c0 [ +0.10]

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Matthew Auld
On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld ---

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-16 Thread Matthew Auld
On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Christian König
Am 16.02.24 um 12:46 schrieb Arunpravin Paneer Selvam: On 2/16/2024 4:41 PM, Matthew Auld wrote: On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy:

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-16 Thread Arunpravin Paneer Selvam
Hi Matthew, Could you review the v6? Thanks, Arun. On 2/8/2024 9:19 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Arunpravin Paneer Selvam
On 2/16/2024 4:41 PM, Matthew Auld wrote: On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Matthew Auld
On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert Karwatzki Signed-off-by: Arunpravin Paneer

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Christian König
Am 02.02.24 um 16:28 schrieb Hamza Mahfooz: We want programs besides the compositor to be able to enable or disable panel power saving features. Well I don't know the full background, but that is usually a no-go. However, since they are currently only configurable through DRM properties,

[PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Arunpravin Paneer Selvam
Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert Karwatzki Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/drm_buddy.c | 4 ++-- 1

Re: 7840U amdgpu MMVM_L2_PROTECTION_FAULT_STATUS

2024-02-16 Thread Christian König
Can you bisect where exactly between 6.6.0 and 6.7.4 the problems started? Thanks, Christian. Am 15.02.24 um 16:59 schrieb Michael Zimmermann: I have a Framework 13 with a 7840U and started having massive GPU driver issues a few weeks ago (including system freezes). Unfortunately the

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Jani Nikula
On Thu, 15 Feb 2024, Mario Limonciello wrote: > I feel the solution to these concerns is that we should make a knob that > controls whether the DRM property is created or the sysfs file is > created but not let them happen simultaneously. *insert the eyeballs emoji here* I mean no matter what

[PATCH] drm/amd/display: fix a possible NULL dereference bug

2024-02-16 Thread Harshit Mogalapalli
Smatch warns: drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:136 dc_dmub_srv_cmd_list_queue_execute() warn: variable dereferenced before check 'dc_dmub_srv' (see line 131) Fix this by moving the dereference "dc_dmub_srv->ctx" after the NULL check. Fixes:

2024 X.Org Board of Directors Elections Nomination period is NOW

2024-02-16 Thread Christopher Michael
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2024 election are now open and will remain open until 23:59 UTC on 26 February 2024. The Board consists

Re: [PATCH] drm/amd/display: Add 'replay' NULL check in 'edp_set_replay_allow_active()'

2024-02-16 Thread Chung, ChiaHsuan (Tom)
Reviewed-by: Tom Chung On 2/15/2024 9:31 PM, Srinivasan Shanmugam wrote: In the first if statement, we're checking if 'replay' is NULL. But in the second if statement, we're not checking if 'replay' is NULL again before calling replay->funcs->replay_set_power_opt(). if (replay == NULL &&

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Pekka Paalanen
On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: > We want programs besides the compositor to be able to enable or disable > panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary programs to be able to override the KMS