Re: [PATCH v2] drm/amgpu: Check return value of amdgpu_device_baco_enter/exit

On 2/29/2024 11:49 AM, Ma Jun wrote: > Check return value of amdgpu_device_baco_enter/exit and print > warning message because these errors may cause runtime resume failure > > Signed-off-by: Ma Jun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 29 -- > 1 file

[PATCH v2] drm/amgpu: Check return value of amdgpu_device_baco_enter/exit

Check return value of amdgpu_device_baco_enter/exit and print warning message because these errors may cause runtime resume failure Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 29 -- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git

[PATCH V3] Revert "drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute" for Raven

fix the issue: "amdgpu: Failed to create process VM object". [Why]when amdgpu initialized, seq64 do mampping and update bo mapping in vm page table. But when clifo run. It also initializes a vm for a process device through the function kfd_process_device_init_vm and ensure the root PD is clean

RE: [PATCH V3] Revert "drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute" for Raven

[AMD Official Use Only - General] Please ignore the patch and will send a new patch out soon. -Original Message- From: Jesse.Zhang Sent: Thursday, February 29, 2024 1:51 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kuehling, Felix ; Paneer Selvam, Arunpravin ; Zhang,

[PATCH V3] Revert "drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute" for Raven

fix the issue: "amdgpu: Failed to create process VM object". [Why]when amdgpu initialized, seq64 do mampping and update bo mapping in vm page table. But when clifo run. It also initializes a vm for a process device through the function kfd_process_device_init_vm and ensure the root PD is clean

Re: [PATCH] drm/amdgpu: add deferred error check for UMC v12 address query

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking Get Outlook for iOS From: amd-gfx on behalf of Tao Zhou Sent: Thursday, February 29, 2024 11:45:47 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao

[PATCH] drm/amdgpu: add deferred error check for UMC v12 address query

Both RAS UE and deferred errors need page retirement. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c index

Re: [PATCH 2/2] drm/amgpu: Check return value of amdgpu_device_baco_enter/exit

On 2/28/2024 7:58 PM, Lazar, Lijo wrote: > > > On 2/28/2024 5:14 PM, Ma Jun wrote: >> Check return value of amdgpu_device_baco_enter/exit and print >> warning message because these errors may cause runtime resume failure >> >> Signed-off-by: Ma Jun >> --- >>

RE: [PATCH] drm/amd/swsmu: modify the gfx activity scaling

[AMD Official Use Only - General] Reviewed-by: Yifan Zhang -Original Message- From: Alex Deucher Sent: Wednesday, February 28, 2024 10:25 PM To: Ma, Li Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Yifan ; Yu, Lang Subject: Re: [PATCH] drm/amd/swsmu: modify the gfx

[PATCH 6/6] drm/amd/display: add amdgpu_dm support for DCN351

Add Display Manager specific changes for DCN3.5.1. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 1 + 2 files changed, 10 insertions(+) diff --git

[PATCH 5/6] drm/amd/display: add DC changes for DCN351

Add DC support for DCN 3.5.1. Signed-off-by: Hamza Mahfooz --- .../display/dc/bios/command_table_helper2.c |1 + .../gpu/drm/amd/display/dc/core/dc_resource.c |6 + .../dc/dcn35/dcn35_dio_stream_encoder.h |1 + drivers/gpu/drm/amd/display/dc/dml/Makefile |3 +

[PATCH 4/6] drm/amd/display: add DCN351 IRQ changes

Add DCN3.5.1 interrupt support. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/irq/Makefile | 11 +- .../dc/irq/dcn351/irq_service_dcn351.c| 409 ++ .../dc/irq/dcn351/irq_service_dcn351.h| 12 + 3 files changed, 431 insertions(+), 1

[PATCH 3/6] drm/amd/display: add DMUB source files and changes for DCN351

DMUB support is required to light-up displays. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dmub/src/Makefile | 1 + .../drm/amd/display/dmub/src/dmub_dcn351.c| 34 +++ .../drm/amd/display/dmub/src/dmub_dcn351.h| 13 +++

[PATCH 1/6] drm/amd/display: add DCN351 version identifiers

Add DCN3.5.1 ASIC identifiers. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 + drivers/gpu/drm/amd/display/include/dal_asic_id.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h

[PATCH] drm/amd/display: handle range offsets in VRR ranges

Need to check the offset bits for values greater than 255. v2: also update amdgpu_dm_connector values. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3203 Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 ++- 1 file changed, 14

[PATCH] drm/amd/display: handle range offsets in VRR ranges

Need to check the offset bits for values greater than 255. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3203 Signed-off-by: Alex Deucher --- Can we just drop this code (at least for DP)? drm_edid.c already handles this properly in get_monitor_range().

Re: [PATCH] Revert "drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute" for Raven

On 2024-02-28 01:41, Christian König wrote: Am 28.02.24 um 06:04 schrieb Jesse.Zhang: fix the issue when run clinfo: "amdgpu: Failed to create process VM object". when amdgpu initialized, seq64 do mampping and update bo mapping in vm page table. But when clifo run. It also initializes a vm

[PATCH 30/34] drm/amd/display: Backup and restore only on full updates

From: Alvin Lee [WHY & HOW] Since the backup and restore for plane and stream states has a significant amount of data to copy, we will change the backup and restore sequence to only take place during full updates. We will also move the scratch memory to struct dc instead of dc_state to avoid

Re: [PATCH 25/34] drm/amd/display: Set the power_down_on_boot function pointer to null

On 2/28/2024 12:39, Alex Hung wrote: From: Muhammad Ahmed [WHY] Blackscreen hang @ PC EF25 when trying to wake up from S0i3. DCN gets powered off due to dc_power_down_on_boot() being called after timeout. [HOW] Setting the power_down_on_boot function pointer to null since we don't expect

[PATCH 34/34] drm/amd/display: 3.2.275

From: Aric Cyr - Support long vblank feature - Add monitor patch for specific eDP - Init DPPCLK from SMU on dcn32 - Update odm when ODM combine is changed on an otg master pipe with no plane - Fix idle check for shared firmware state - Add guards for idle on reg read/write - Guard cursor idle

[PATCH 33/34] drm/amd/display: Add comments to v_total calculation and drop legacy TODO

From: Rodrigo Siqueira [WHY & HOW] This commit just adds some simple comments to help understand the calculation of V total duration for Freesync. Also, remove a legacy TODO comment from link service type. Acked-by: Alex Hung Signed-off-by: Rodrigo Siqueira ---

[PATCH 32/34] drm/amd/display: Return the correct HDCP error code

From: Rodrigo Siqueira [WHY & HOW] If the display is null when creating an HDCP session, return a proper error code. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Acked-by: Alex Hung Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c

[PATCH 31/34] drm/amd/display: Update DMUB flags and definitions

From: Anthony Koo [WHAT] - Update replay residency tracing design to support more types including tracking PHY and ALPM residency types - Add commands for Replay frame update count profiling - Enhance HWFQ with additional flags to allow for more optimized IPS low power state residencies -

[PATCH 29/34] drm/amd/display: Add a dc_state NULL check in dc_state_release

From: Allen Pan [How] Check wheather state is NULL before releasing it. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Charlene Liu Acked-by: Alex Hung Signed-off-by: Allen Pan --- drivers/gpu/drm/amd/display/dc/core/dc_state.c | 3 ++- 1 file changed, 2

[PATCH 28/34] drm/amd/display: Implement wait_for_odm_update_pending_complete

From: Wenjing Liu [WHY] Odm update is doubled buffered. We need to wait for ODM update to be completed before optimizing bandwidth or programming new udpates. [HOW] implement wait_for_odm_update_pending_complete function to wait for: 1. odm configuration update is no longer pending in timing

[PATCH 27/34] drm/amd/display: Lock all enabled otg pipes even with no planes

From: Wenjing Liu [WHY] On DCN32 we support dynamic ODM even when OTG is blanked. When ODM configuration is dynamically changed and the OTG is on blank pattern, we will need to reprogram OPP's test pattern based on new ODM configuration. Therefore we need to lock the OTG pipe to avoid temporary

[PATCH 26/34] drm/amd/display: Implement update_planes_and_stream_v3 sequence

From: Wenjing Liu [WHY & HOW] Update planes and stream version 3 separates FULL and FAST updates to their own sequences. It aims to clean up frequent checks for update type resulting unnecessary branching in logic flow. It also adds a new commit minimal transition sequence, which detects the

[PATCH 25/34] drm/amd/display: Set the power_down_on_boot function pointer to null

From: Muhammad Ahmed [WHY] Blackscreen hang @ PC EF25 when trying to wake up from S0i3. DCN gets powered off due to dc_power_down_on_boot() being called after timeout. [HOW] Setting the power_down_on_boot function pointer to null since we don't expect the function to be called for APU. Cc:

[PATCH 24/34] drm/amd/display: Refactor DPP into a component directory

From: Revalla Hari Krishna [WHY & HOW] Move all dpp files to a new dpp directory. Reviewed-by: Martin Leung Acked-by: Alex Hung Signed-off-by: Revalla Hari Krishna --- drivers/gpu/drm/amd/display/Makefile | 1 + drivers/gpu/drm/amd/display/dc/Makefile | 2 +-

[PATCH 23/34] drm/amd/display: Amend coasting vtotal for replay low hz

From: ChunTao Tso [WHY] The original coasting vtotal is 2 bytes, and it need to be amended to 4 bytes because low hz case. [HOW] Amend coasting vtotal from 2 bytes to 4 bytes. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Alvin Lee Acked-by: Alex Hung

[PATCH 22/34] drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split

From: George Shen [WHY] Currently 3-tap chroma subsampling is used for YCbCr422/420. When ODM pipesplit is used, pixels on the left edge of ODM slices need one extra pixel from the right edge of the previous slice to calculate the correct chroma value. Without this change, the chroma value is

[PATCH 21/34] drm/amd/display: Add debug counters to IPS exit prints

From: Nicholas Kazlauskas [WHY] To have a log of the entry/exit counters in case the system hangs to measure stability. [HOW] Read them from firmware state and pass them to the prints. Reviewed-by: Duncan Ma Acked-by: Alex Hung Signed-off-by: Nicholas Kazlauskas ---

[PATCH 20/34] drm/amd/display: Guard cursor idle reallow by DC debug option

From: Nicholas Kazlauskas [WHY] To control whether idle optimizations reallowed after the first cursor update. [HOW] Add checks to the conditions. Reviewed-by: Duncan Ma Acked-by: Alex Hung Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 ++-- 1

[PATCH 19/34] drm/amd/display: Add guards for idle on reg read/write

From: Nicholas Kazlauskas [WHY] If DCN is in idle then we should not be accessing DCN registers or it can lead to hangs. [HOW] Log the error and return 0 or drop the write if it's in idle. This is skipped in the exit sequence itself since the boolean flips before it starts. It also does not

[PATCH 18/34] drm/amd/display: Fix idle check for shared firmware state

From: Nicholas Kazlauskas [WHY] We still had an instance of get_idle_state checking the PMFW scratch register instead of the actual idle allow signal. [HOW] Replace it with the SW state check for whether we had allowed idle through notify_idle. Cc: Mario Limonciello Cc: Alex Deucher Cc:

[PATCH 17/34] drm/amd/display: Update odm when ODM combine is changed on an otg master pipe with no plane

From: Wenjing Liu [WHY] When committing an update with ODM combine change when the plane is removing or already removed, we fail to detect odm change in pipe update flags. This has caused mismatch between new dc state and the actual hardware state, because we missed odm programming. [HOW] -

[PATCH 16/34] drm/amd/display: Init DPPCLK from SMU on dcn32

From: Dillon Varone [WHY & HOW] DPPCLK ranges should be obtained from the SMU when available. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Chaitanya Dhere Acked-by: Alex Hung Signed-off-by: Dillon Varone --- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c |

[PATCH 15/34] drm/amd/display: Add monitor patch for specific eDP

From: Ryan Lin [WHY] Some eDP panels' ext caps don't write initial values. The value of dpcd_addr (0x317) can be random and the backlight control interface will be incorrect. [HOW] Add new panel patches to remove sink ext caps. Cc: Mario Limonciello Cc: Alex Deucher Cc:

[PATCH 14/34] drm/amd/display: Support long vblank feature

From: Robin Chen [WHY] We want to support low hz case, but the original vtotal/vtotal_min/vtotal_max can't support more than 0x7FFF. [HOW] We use the 2 HW reg to contorl long vblank case. 1. OTG_V_COUNT_STOP_CONTROL -> vcount_stop 2. OTG_V_COUNT_STOP_CONTROL2 -> vcount_stop_timer vcount_stop

[PATCH 13/34] drm/amd/display: 3.2.274

From: Aric Cyr - Change default size for dummy plane in DML2 - Enable DML2 debug flags - Add some forward declarations - Add DML2 folder to include path - Set DCN351 BB and IP the same as DCN35 - Override min required DCFCLK in dml1_validate - Fix function banner for amdgpu_dm_psr_disable_all()

[PATCH 12/34] drm/amd/display: Add entry and exit counters

From: Anthony Koo [WHY & HOW] Add new counters in the shared IPS firmware state. Acked-by: Alex Hung Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 11/34] drm/amd/display: Exit idle optimizations before HDCP execution

From: Nicholas Kazlauskas [WHY] PSP can access DCN registers during command submission and we need to ensure that DCN is not in PG before doing so. [HOW] Add a callback to DM to lock and notify DC for idle optimization exit. It can't be DC directly because of a potential race condition with the

[PATCH 10/34] drm/amd/display: Add debug prints for IPS testing

From: Nicholas Kazlauskas [WHY] To log commit states and when we transition in/out of allow and idle states and the caller. [HOW] Add a new logging helper and wrap idle optimization calls to receive the caller. Reviewed-by: Duncan Ma Acked-by: Alex Hung Signed-off-by: Nicholas Kazlauskas

[PATCH 09/34] drm/amd/display: Add debug key to allow disabling dtbclk

From: Muhammad Ahmed [HOW] Add debug key to allow disabling dtbclk Reviewed-by: Charlene Liu Acked-by: Alex Hung Signed-off-by: Muhammad Ahmed --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 3 ++- drivers/gpu/drm/amd/display/dc/dc.h | 1 + 2

[PATCH 08/34] drm/amd/display: Allow dirty rects to be sent to dmub when abm is active

From: Josip Pavic [WHY] It's beneficial for ABM to know when new frame data are available. [HOW] Add new condition to allow dirty rects to be sent to DMUB when ABM is active. ABM will use this as a signal that a new frame has arrived. Cc: Mario Limonciello Cc: Alex Deucher Cc:

[PATCH 07/34] drm/amd/display: Fix function banner for amdgpu_dm_psr_disable_all()

From: Roman Li [WHY] Incorrect function name in function banner. [HOW] Correct name and brief description. Reviewed-by: Hersen Wu Reviewed-by: Aurabindo Pillai Acked-by: Alex Hung Signed-off-by: Roman Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 +- 1 file changed, 1

[PATCH 06/34] drm/amd/display: Override min required DCFCLK in dml1_validate

From: Sohaib Nadeem [WHY]: Increasing min DCFCLK addresses underflow issues that occur when phantom pipe is turned on for some Sub-Viewport configs [HOW]: dcn32_override_min_req_dcfclk is added to override DCFCLK value in dml1_validate when subviewport is being used. Cc: Mario Limonciello Cc:

[PATCH 05/34] drm/amd/display: Set DCN351 BB and IP the same as DCN35

From: Xi Liu [WHY & HOW] DCN351 and DCN35 should use the same bounding box and IP settings. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Jun Lei Acked-by: Alex Hung Signed-off-by: Xi Liu --- .../gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 6

[PATCH 04/34] drm/amd/display: Add DML2 folder to include path

From: Aurabindo Pillai Add DML2 compilation rule in the Makefile. Reviewed-by: Chaitanya Dhere Acked-by: Alex Hung Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dml2/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 03/34] drm/amd/display: Add some forward declarations

From: Aurabindo Pillai [WHAT] Add DML2 pipe and config struct forward declaration as a preparation for DML2. Reviewed-by: Chaitanya Dhere Acked-by: Alex Hung Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.h | 2 ++ 1 file changed, 2

[PATCH 02/34] drm/amd/display: Enable DML2 debug flags

From: Aurabindo Pillai [WHY & HOW] Enable DML2 related debug config options in DM for testing purposes. Reviewed-by: Chaitanya Dhere Acked-by: Alex Hung Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 01/34] drm/amd/display: Change default size for dummy plane in DML2

From: Swapnil Patel [WHY & HOW] Currently, to map dc states into dml_display_cfg, We create a dummy plane if the stream doesn't have any planes attached to it. This dummy plane uses max addersable width height. This results in certain mode validations failing when they shouldn't. Cc: Mario

[PATCH 00/34] DC Patches Feb 28, 2020

This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes on HDCP, eDP and FW idle check. * Enhancement in debug messages * Improvement on updates sequences * DPP refactoring to a new directory * Enhancements in DMUB Cc: Daniel Wheeler Allen Pan (1):

RE: [PATCH] amd/amdkfd: remove unused parameter

[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Eric Huang Sent: Wednesday, February 28, 2024 10:17 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric Subject: [PATCH] amd/amdkfd: remove unused parameter The

Re: [PATCH] drm/amd/display: Add monitor patch for specific eDP

On 2/27/24 13:18, Rodrigo Siqueira wrote: From: Ivan Lipski [WHY] Some eDP panels's ext caps don't write initial value cause the value of dpcd_addr(0x317) is random. It means that sometimes the eDP will clarify it is OLED, miniLED...etc cause the backlight control interface is incorrect.

Re: [PATCH] drm/amd/display: Add monitor patch for specific eDP

On 2024-02-27 13:18, Rodrigo Siqueira wrote: > From: Ivan Lipski > > [WHY] > Some eDP panels's ext caps don't write initial value cause the value of > dpcd_addr(0x317) is random. It means that sometimes the eDP will > clarify it is OLED, miniLED...etc cause the backlight control interface >

[PATCH] amd/amdkfd: remove unused parameter

The adev can be found from bo by amdgpu_ttm_adev(bo->tbo.bdev), and adev is also not used in the function amdgpu_amdkfd_map_gtt_bo_to_gart(). Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 +--

Re: [PATCH 1/2] Revert "drm/amd: Remove freesync video mode amdgpu parameter"

Am 28.02.24 um 15:23 schrieb Alex Deucher: On Wed, Feb 28, 2024 at 2:03 AM Christian König wrote: Am 27.02.24 um 19:48 schrieb Alex Deucher: This reverts commit e94e787e37b99645e7c02d20d0a1ba0f8a18a82a. This conflicts with how compositors want to handle VRR. Now that compositors actually

Re: [PATCH] drm/amdgpu: Removed used parameter

On 2/27/2024 9:23 PM, Harish Kasiviswanathan wrote: > Also passing adev is misleading if BO is associated with different adev. > In this case BO is mapped to a different device > Looks like a typo in subject - unused? Thanks, Lijo > Signed-off-by: Harish Kasiviswanathan > --- >

Re: [PATCH v5 7/8] drm/amd/display: Introduce KUnit tests to dc_dmub_srv library

On 2/26/24 04:12, Jani Nikula wrote: On Thu, 22 Feb 2024, Rodrigo Siqueira wrote: diff --git a/drivers/gpu/drm/amd/display/test/kunit/.kunitconfig b/drivers/gpu/drm/amd/display/test/kunit/.kunitconfig index eb6f81601757..4c5861ad58bd 100644 ---

Re: [PATCH] drm/amdgpu: Removed used parameter

On Tue, Feb 27, 2024 at 11:13 AM Harish Kasiviswanathan wrote: > > Also passing adev is misleading if BO is associated with different adev. > In this case BO is mapped to a different device > > Signed-off-by: Harish Kasiviswanathan Acked-by: Alex Deucher > --- >

Re: [PATCH] drm/amd/swsmu: modify the gfx activity scaling

On Wed, Feb 28, 2024 at 6:39 AM Li Ma wrote: > > Add an if condition for gfx activity because the scaling has been changed > after smu fw version 5d4600. > And remove a warning log. > > Signed-off-by: Li Ma Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c

Re: [PATCH 1/2] Revert "drm/amd: Remove freesync video mode amdgpu parameter"

On Wed, Feb 28, 2024 at 2:03 AM Christian König wrote: > > Am 27.02.24 um 19:48 schrieb Alex Deucher: > > This reverts commit e94e787e37b99645e7c02d20d0a1ba0f8a18a82a. > > > > This conflicts with how compositors want to handle VRR. Now > > that compositors actually handle VRR, we probably don't

Re: [PATCH 1/2] drm/amdgpu: Use rpm_mode flag instead of checking it again for rpm

On 2/28/2024 5:14 PM, Ma Jun wrote: > Because the rpm_mode flag is already set when the driver > is initialized, we use it directly for runtime suspend/resume > instead of checking it again > > Signed-off-by: Ma Jun Reviewed-by: Lijo Lazar Thanks, Lijo > --- >

Re: [PATCH 2/2] drm/amgpu: Check return value of amdgpu_device_baco_enter/exit

On 2/28/2024 5:14 PM, Ma Jun wrote: > Check return value of amdgpu_device_baco_enter/exit and print > warning message because these errors may cause runtime resume failure > > Signed-off-by: Ma Jun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++-- > 1 file changed, 6

[PATCH 1/2] drm/amdgpu: Use rpm_mode flag instead of checking it again for rpm

Because the rpm_mode flag is already set when the driver is initialized, we use it directly for runtime suspend/resume instead of checking it again Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 1 file changed, 12 insertions(+), 12 deletions(-)

[PATCH 2/2] drm/amgpu: Check return value of amdgpu_device_baco_enter/exit

Check return value of amdgpu_device_baco_enter/exit and print warning message because these errors may cause runtime resume failure Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/swsmu: modify the gfx activity scaling

Add an if condition for gfx activity because the scaling has been changed after smu fw version 5d4600. And remove a warning log. Signed-off-by: Li Ma --- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 2 -- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 5 - 2 files

Re: [PATCH V2] Revert "drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute" for Raven

Hi Jesse, Am 28.02.24 um 09:43 schrieb jesse.zh...@amd.com: From: "Jesse.Zhang" fix the issue: "amdgpu: Failed to create process VM object". [Why]when amdgpu initialized, seq64 do mampping and update bo mapping in vm page table. But when clifo run. It also initializes a vm for a process

Re: [PATCH] drm/amdgpu: Fix multiple truncation issues in multiple driver files

On 2/27/2024 10:05 PM, Srinivasan Shanmugam wrote: > Fixes snprintf function by writing more bytes into various buffers than > they can hold. > > In several files - smu_v13_0.c, gfx_v11_0.c, gfx_v10_0.c, gfx_v9_0.c, > and amdgpu_mes.c. They were related to different directives, such as > '%s',

RE: [PATCH] drm/amd/pm: Fix esm reg mask use to get pcie speed

[AMD Official Use Only - General] Reviewed-by: Le Ma > -Original Message- > From: Kamal, Asad > Sent: Wednesday, February 28, 2024 2:52 PM > To: amd-gfx@lists.freedesktop.org > Cc: Lazar, Lijo ; Zhang, Hawking > ; Ma, Le ; Zhang, Morris > ; Kamal, Asad > Subject: [PATCH] drm/amd/pm:

[PATCH] drm/amd/display: Fix potential index out of bounds in color transformation function

Fixes index out of bounds issue in the color transformation function. The issue could occur when the index 'i' exceeds the number of transfer function points (TRANSFER_FUNC_POINTS). The fix adds a check to ensure 'i' is within bounds before accessing the transfer function points. If 'i' is out of

[PATCH V2] Revert "drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute" for Raven

From: "Jesse.Zhang" fix the issue: "amdgpu: Failed to create process VM object". [Why]when amdgpu initialized, seq64 do mampping and update bo mapping in vm page table. But when clifo run. It also initializes a vm for a process device through the function kfd_process_device_init_vm and ensure

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

Hi Am 27.02.24 um 19:14 schrieb Dmitry Osipenko: Hello, Thank you for the patches! On 2/27/24 13:14, Thomas Zimmermann wrote: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

Hello, Thank you for the patches! On 2/27/24 13:14, Thomas Zimmermann wrote: > Dma-buf locking semantics require the caller of pin and unpin to hold > the buffer's reservation lock. Fix DRM to adhere to the specs. This > enables to fix the locking in DRM's console emulation. Similar changes >

amdgpu kmemleaks

Hi folks, anyone interested in a bunch of amdgpu kmemleak reports from latest Linus tree + tip? GPU is: [ 11.317312] [drm] amdgpu kernel modesetting enabled. [ 11.363627] [drm] initializing kernel modesetting (CARRIZO 0x1002:0x9874 0x103C:0x807E 0xC4). [ 11.364077] [drm] register mmio

[PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions

uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer. Signed-off-by: Lu Yao --- drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index a757526153e5..455d49f7bd9c