[PATCH] drm/amd/amdkfd: Fix a resource leak in svm_range_validate_and_map()

2024-04-30 Thread Ramesh Errabolu
Analysis of code by Coverity, a static code analyser, has identified a resource leak in the symbol hmm_range. This leak occurs when one of the prior steps before it is released encounters an error. Signed-off-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 6 -- 1 file

[PATCH] drm/amdgpu: Add gfx v9_4_4 ip block

2024-04-30 Thread Alex Deucher
From: Hawking Zhang Add gfx v9_4_4 ip block support Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 10 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 11 -- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

[PATCH] drm/amdgpu: Add smu v13_0_14 ip block

2024-04-30 Thread Alex Deucher
From: Hawking Zhang Add smu v13_0_14 ip block support Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c| 1 +

[PATCH] drm/amdgpu: Add psp v13_0_14 ip block

2024-04-30 Thread Alex Deucher
From: Hawking Zhang Add psp v13_0_14 ip block support. Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 13 ++---

[PATCH] drm/amdgpu: Add sdma v4_4_5 ip block

2024-04-30 Thread Alex Deucher
From: Hawking Zhang Add sdma v4_4_5 ip block support Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 9 + drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c

[PATCH 1/4] drm/amd/pm: support mode1 reset on smu_v14_0_3

2024-04-30 Thread Alex Deucher
From: Kenneth Feng support mode1 reset on smu_v14_0_3 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c| 1 + drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ 2 files changed, 3 insertions(+) diff --git

[PATCH 4/4] drm/amd/pm: add pstate support for SMU_14_0_2

2024-04-30 Thread Alex Deucher
From: Gui Chengming Populate pstate clock. Signed-off-by: Gui Chengming Reviewed-by: Kenneth Feng Change-Id: Ib95b7a334c1bd51592535b40fd2e7b8f6802571f Signed-off-by: Alex Deucher --- .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 54 ++- 1 file changed, 53 insertions(+), 1

[PATCH 3/4] drm/amd/pm: add tool log support on smu v14.0.2/3

2024-04-30 Thread Alex Deucher
From: Kenneth Feng add tool log support on smu v14.0.2/3 Signed-off-by: Kenneth Feng Reviewed-by: Jack Gui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v14_0.h | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 2 ++ 2 files changed, 4

[PATCH 2/4] drm/amd/pm: enable mode1 reset on smu v14.0.2/v14.0.3

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable mode1 reset on smu v14.0.2/v14.0.3 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 3/3] drm/amdgpu/mes12: Use a separate fence per transaction

2024-04-30 Thread Alex Deucher
We can't use a shared fence location because each transaction should be considered independently. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git

[PATCH 2/3] drm/amdgpu/mes12: increase mes submission timeout

2024-04-30 Thread Alex Deucher
MES internally has a timeout allowance of 2 seconds. Increase driver timeout to 3 seconds to be safe. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c

[PATCH 1/3] drm/amdgpu/mes12: print MES opcodes rather than numbers

2024-04-30 Thread Alex Deucher
Makes it easier to review the logs when there are MES errors. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 81 -- 1 file changed, 77 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c

[PATCH] drm/amd/amdgpu: enable mmhub and athub cg on gc 12.0.1

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable mmhub and athub cg on gc 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c

[PATCH 7/7] drm/amd/amdgpu: enable gfxoff on gc 12.0.1

2024-04-30 Thread Alex Deucher
From: Kenneth Feng Enable gfxoff on gc 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Jack Gui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 14 +- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 1 + 2 files changed, 14 insertions(+), 1

[PATCH 6/7] drm/amdgpu: support cg state get for gfx v12

2024-04-30 Thread Alex Deucher
From: Likun Gao Support to get clockgating state for gfx v12. Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git

[PATCH 4/7] drm/amd/amdgpu: enable perfcounter mgcg and repeater fgcg

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable perfcounter mgcg and repeater fgcg on gc 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 32 -- drivers/gpu/drm/amd/amdgpu/soc24.c | 4 +++- 2 files

[PATCH 5/7] drm/amd/amdgpu: enable sram fgcg on gc 12.0.1

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable sram fgcg on gc 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 15 ++- drivers/gpu/drm/amd/amdgpu/soc24.c | 1 + 2 files changed, 15 insertions(+), 1 deletion(-)

[PATCH 3/7] drm/amd/amdgpu: enable 3D cgcg and 3D cgls

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable 3D cgcg and 3D cgls on gc 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c

[PATCH 2/7] drm/amd/amdgpu: enable mgcg on gfx 12.0.1

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable mgcg on gfx 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 30 +- drivers/gpu/drm/amd/amdgpu/soc24.c | 6 ++ 2 files changed, 31 insertions(+),

[PATCH 1/7] drm/amd/amdgpu: enable cgcg and cgls

2024-04-30 Thread Alex Deucher
From: Kenneth Feng enable cgcg and cgls on gc 12.0.1 Signed-off-by: Kenneth Feng Reviewed-by: Likun Gao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c

Re: [PATCH v1 03/12] drm/i915: Make I2C terminology more inclusive

2024-04-30 Thread Rodrigo Vivi
On Tue, Apr 30, 2024 at 05:38:02PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT

RE: [PATCH] Revert "drm/amdkfd: Add partition id field to location_id"

2024-04-30 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, April 23, 2024 7:28 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Joshi, Mukul ; > Kim, Jonathan ; Poag, Charis > ; Cheung, Donald ; Yat > Sin, David ; Chaudhary, Jatin Jaikishan > ;

[linux-next:master] BUILD REGRESSION d04466706db5e241ee026f17b5f920e50dee26b5

2024-04-30 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d04466706db5e241ee026f17b5f920e50dee26b5 Add linux-next specific files for 20240430 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404301738.j71xgyar-...@intel.com Unverified

Re: [PATCH v2] drm/amdkfd: Let VRAM allocations go to GTT domain on small APUs

2024-04-30 Thread Felix Kuehling
On 2024-04-30 6:08, Lang Yu wrote: Small APUs(i.e., consumer, embedded products) usually have a small carveout device memory which can't satisfy most compute workloads memory allocation requirements. We can't even run a Basic MNIST Example with a default 512MB carveout.

Re: [PATCH v3 1/4] drm/amdgpu: Fix two reset triggered in a row

2024-04-30 Thread Lazar, Lijo
On 4/26/2024 9:27 AM, Yunxiang Li wrote: > Some times a hang GPU causes multiple reset sources to schedule resets. > The second source will be able to trigger an unnecessary reset if they > schedule after we call amdgpu_device_stop_pending_resets. > > Move amdgpu_device_stop_pending_resets to

RE: [PATCH v3 1/4] drm/amdgpu: Fix two reset triggered in a row

2024-04-30 Thread Li, Yunxiang (Teddy)
[Public] Hi Christ, I got R-b from the SRIOV team for the rest of the patches, can you help review this last one? I think the concerns from the previous thread are all addressed https://patchwork.freedesktop.org/patch/590678/?series=132727 Regards, Teddy

[PATCH] drm/amdgpu/vcn5: Add VCN5 capabilities

2024-04-30 Thread Alex Deucher
From: "David (Ming Qiang) Wu" Add VCN5 encode and decode capabilities support Signed-off-by: David (Ming Qiang) Wu Reviewed-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 43 ++ 1 file changed, 43 insertions(+) diff --git

[PATCH 2/3] drm/amdgpu/jpeg5: enable power gating

2024-04-30 Thread Alex Deucher
From: Sonny Jiang Enable PG on JPEG5 Signed-off-by: Sonny Jiang Reviewed-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c

[PATCH 3/3] drm/amdgpu/vcn5: enable DPG mode support

2024-04-30 Thread Alex Deucher
From: Sonny Jiang Enable DPG mode Signed-off-by: Sonny Jiang Reviewed-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c b/drivers/gpu/drm/amd/amdgpu/soc24.c

[PATCH 1/3] amdgpu/vcn: enable AMD_PG_SUPPORT_VCN

2024-04-30 Thread Alex Deucher
From: "David (Ming Qiang) Wu" turn on AMD_PG_SUPPORT_VCN flag for power saving Signed-off-by: David (Ming Qiang) Wu Reviewed-by: Sonny Jiang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: Fix physical address mask

2024-04-30 Thread Alex Deucher
From: David Belanger Mask should be 44-bit. Signed-off-by: David Belanger Reviewed-by: Harish Kasiviswanathan Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] drm/amd/display: re-indent dc_power_down_on_boot()

2024-04-30 Thread Harry Wentland
On 2024-04-25 07:21, Dan Carpenter wrote: > These lines are indented too far. Clean the whitespace. > Thanks. Reviewed-by: Harry Wentland In the process of merging it into amd-staging-drm-next. Harry > Signed-off-by: Dan Carpenter > --- > v2: Delete another blank line (checkpatch.pl

Re: [PATCH][next] drm/amd/display: Fix spelling various spelling mistakes

2024-04-30 Thread Harry Wentland
On 2024-04-24 12:28, Colin Ian King wrote: > There are various spelling mistakes in dml2_printf messages, fix them. > Thanks. Reviewed-by: Harry Wentland In the process of merging it into amd-staging-drm-next. Harry > Signed-off-by: Colin Ian King > --- >

Re: [PATCH] drm/amd/display: Avoid -Wenum-float-conversion in add_margin_and_round_to_dfs_grainularity()

2024-04-30 Thread Harry Wentland
On 2024-04-24 12:14, Nathan Chancellor wrote: > When building with clang 19 or newer (which strengthened some of the > enum conversion warnings for C), there is a warning (or error with > CONFIG_WERROR=y) around doing arithmetic with an enumerated type and a > floating point expression. > >

Re: [RFC 0/5] Add capacity key to fdinfo

2024-04-30 Thread Alex Deucher
On Tue, Apr 30, 2024 at 1:27 PM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > I have noticed AMD GPUs can have more than one "engine" (ring?) of the same > type > but amdgpu is not reporting that in fdinfo using the capacity engine tag. > > This series is therefore an attempt to improve

RE: [PATCH 4/4] drm/amdgpu: Move ras resume into SRIOV function

2024-04-30 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Yunxiang Li Sent: Thursday, April 25, 2024 11:58 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Lazar, Lijo ; Kuehling, Felix ; Deng, Emily ;

RE: [PATCH v4 2/4] drm/amdgpu: Add reset_context flag for host FLR

2024-04-30 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Yunxiang Li Sent: Friday, April 26, 2024 2:27 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Lazar, Lijo ; Kuehling, Felix ; Deng, Emily ; Li,

RE: [PATCH v2 3/4] drm/amdgpu: Fix amdgpu_device_reset_sriov retry logic

2024-04-30 Thread Luo, Zhigang
[AMD Official Use Only - General] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Yunxiang Li Sent: Friday, April 26, 2024 2:29 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Lazar, Lijo ; Kuehling, Felix ; Deng, Emily ; Li,

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-30 Thread Harry Wentland
On 2024-03-29 03:18, Samuel Holland wrote: > Now that all previously-supported architectures select > ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead > of the existing list of architectures. It can also take advantage of the > common kernel-mode FPU API and method of

Re: [PATCH v4 12/15] drm/amd/display: Only use hard-float, not altivec on powerpc

2024-04-30 Thread Harry Wentland
On 2024-03-29 03:18, Samuel Holland wrote: > From: Michael Ellerman > > The compiler flags enable altivec, but that is not required; hard-float > is sufficient for the code to build and function. > > Drop altivec from the compiler flags and adjust the enable/disable code > to only enable FPU

[RFC 3/5] drm/amdgpu: Skip not present rings in amdgpu_ctx_mgr_usage

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Avoids a tiny bit of arithmetic and more importantly walking those empty arrays up to amdgpu_sched_jobs slots and amdgpu_ctx_num_entities, both which are pointless if there are no rings of the respective type. Signed-off-by: Tvrtko Ursulin ---

[RFC 5/5] drm/amdgpu: Only show VRAM in fdinfo if it exists

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Do not emit the key-value pairs if the VRAM does not exist ie. VRAM placement is not valid and accessible. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 29 +- 1 file changed, 17 insertions(+), 12 deletions(-) diff

[RFC 4/5] drm/amdgpu: Show engine capacity in fdinfo

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In cases where there is more than one user visible engine of the same type DRM fdinfo spec allows the capacity tag to be emitted. Start doing that so that gputop can adapt and show, for example, 50% if only one of the two engine instances is fully loaded, while the other is

[RFC 2/5] drm/amdgpu: Use cached number of rings from the AMDGPU_INFO_HW_IP_INFO ioctl

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Now that we keep a cached value it is no longer required to walk the arrays and check the fuses. Open however is whether at runtime this query is supposed to report if a ring has disappeared due for example amdgpu_ib_ring_tests() turning it off. Signed-off-by: Tvrtko

[RFC 1/5] drm/amdgpu: Cache number of rings per hw ip type

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the end goal being using the number of rings for exposing capacity in fdinfo, and the observation that the number could be used elsewhere in the driver, lets cache it during the driver init phase. We count the number of created scheduler instances for user visible hw

[RFC 0/5] Add capacity key to fdinfo

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I have noticed AMD GPUs can have more than one "engine" (ring?) of the same type but amdgpu is not reporting that in fdinfo using the capacity engine tag. This series is therefore an attempt to improve that, but only an RFC since it is quite likely I got stuff wrong on the

[PATCH v3 2/3] drm/amdgpu: Reduce mem_type to domain double indirection

2024-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin All apart from AMDGPU_GEM_DOMAIN_GTT memory domains map 1:1 to TTM placements. And the former be either AMDGPU_PL_PREEMPT or TTM_PL_TT, depending on AMDGPU_GEM_CREATE_PREEMPTIBLE. Simplify a few places in the code which convert the TTM placement into a domain by checking

Re: [PATCH] drm/amd/display: Remove redundant NULL check in dce110_set_input_transfer_func

2024-04-30 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 4/23/24 9:29 PM, Srinivasan Shanmugam wrote: This commit removes a redundant NULL check in the `dce110_set_input_transfer_func` function in the `dce110_hwseq.c` file. The variable `tf` is assigned the address of `plane_state->in_transfer_func` unconditionally,

Re: [PATCH] drm/amd/display: fix documentation warnings for mpc.h

2024-04-30 Thread Rodrigo Siqueira Jordao
Hi Marcelo, First of all, thanks a lot for your patch! Please check some of my inline comments. On 4/27/24 10:05 AM, Marcelo Mendes Spessoto Junior wrote: Fix most of the display documentation compile warnings by documenting struct mpc_funcs functions in dc/inc/hw/mpc.h file. Could you add

[PATCH] drm/amdgpu: add gfx eviction fence helpers

2024-04-30 Thread Shashank Sharma
This patch adds basic eviction fence framework for the gfx buffers. The idea is to: - One eviction fence is created per gfx process, at kms_open. - This same fence is attached to all the gem buffers created by this process. This framework will be further used for usermode queues. Cc: Christian

Re: [PATCH] drm/amd/display: Disable panel replay by default for now

2024-04-30 Thread Harry Wentland
On 2024-04-30 11:12, Mario Limonciello wrote: > Panel replay was enabled by default in commit 5950efe25ee0 > ("drm/amd/display: Enable Panel Replay for static screen use case"), but > it isn't working properly at least on some BOE and AUO panels. Instead > of being static the screen is solid

Re: [PATCH v2] drm/amd/display: Remove redundant NULL check in dcn10_set_input_transfer_func

2024-04-30 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Reviewed-by: Aurabindo Pillai -- Regards, Jay From: SHANMUGAM, SRINIVASAN Sent: Tuesday, April 23, 2024 9:34 PM To: Siqueira, Rodrigo ; Pillai, Aurabindo Cc: amd-gfx@lists.freedesktop.org ; SHANMUGAM, SRINIVASAN ; Liu,

[PATCH] drm/amd/display: Disable panel replay by default for now

2024-04-30 Thread Mario Limonciello
Panel replay was enabled by default in commit 5950efe25ee0 ("drm/amd/display: Enable Panel Replay for static screen use case"), but it isn't working properly at least on some BOE and AUO panels. Instead of being static the screen is solid black when active. As it's a new feature that was just

Re: [PATCH v2 2/2] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread David Wu
On 2024-04-30 10:48, Harry Wentland wrote: On 2024-04-30 09:43, Aurabindo Pillai wrote: Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai Series is Reviewed-by: Harry Wentland Harry ---

Re: [PATCH] drm/amdgpu: avoid reading vf2pf info size from FB

2024-04-30 Thread Lazar, Lijo
On 4/30/2024 7:53 PM, Zhigang Luo wrote: > VF can't access FB when host is doing mode1 reset. Using sizeof to get > vf2pf info size, instead of reading it from vf2pf header stored in FB. > > Signed-off-by: Zhigang Luo > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- > 1 file changed,

Re: [PATCH v2 2/2] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread Harry Wentland
On 2024-04-30 09:43, Aurabindo Pillai wrote: > Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is > made in DC codebase to use 4.1.0 > > Signed-off-by: Aurabindo Pillai Series is Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

RE: [PATCH] drm/amdgpu: update vf to pf message retry from 2 to 5

2024-04-30 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Luo, Zhigang Sent: Tuesday, April 30, 2024 22:23 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Saye, Sashank ; Chan, Hing Pong ; Lazar, Lijo ; Luo, Zhigang Subject:

RE: [PATCH] drm/amdgpu: avoid reading vf2pf info size from FB

2024-04-30 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Luo, Zhigang Sent: Tuesday, April 30, 2024 22:24 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Saye, Sashank ; Chan, Hing Pong ; Lazar, Lijo ; Luo, Zhigang Subject:

Re: [PATCH v1 5/5] drm/ci: update xfails for the new testlist

2024-04-30 Thread Helen Koike
On 30/04/2024 06:11, Vignesh Raman wrote: Now the testlist is used from IGT build, so update xfails with the new testlist. Signed-off-by: Vignesh Raman --- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 47 +++ .../drm/ci/xfails/amdgpu-stoney-flakes.txt| 8 +-

Re: [PATCH] drm/amd/amdxcp: Use unique name for partition dev

2024-04-30 Thread James Zhu
On 2024-04-30 07:36, Lijo Lazar wrote: amdxcp is a platform driver for creating partition devices. libdrm library identifies a platform device based on 'OF_FULLNAME' or 'MODALIAS'. If two or more devices have the same platform name, drm library only picks the first device. Platform driver core

Re: [PATCH v1 4/5] drm/ci: skip driver specific tests

2024-04-30 Thread Helen Koike
On 30/04/2024 06:11, Vignesh Raman wrote: Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Signed-off-by: Vignesh Raman --- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 14 +- drivers/gpu/drm/ci/xfails/i915-amly-skips.txt

Re: [PATCH v1 3/5] drm/ci: build virtual GPU driver as module

2024-04-30 Thread Helen Koike
On 30/04/2024 06:11, Vignesh Raman wrote: With latest IGT, the tests tries to load the module and it fails. So build the virtual GPU driver for virtio as module. Signed-off-by: Vignesh Raman Acked-by: Helen Koike --- drivers/gpu/drm/ci/build.sh | 1 -

Re: [PATCH v1 1/5] drm/ci: uprev mesa version

2024-04-30 Thread Helen Koike
On 30/04/2024 06:11, Vignesh Raman wrote: zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest

[PATCH] drm/amdgpu: avoid reading vf2pf info size from FB

2024-04-30 Thread Zhigang Luo
VF can't access FB when host is doing mode1 reset. Using sizeof to get vf2pf info size, instead of reading it from vf2pf header stored in FB. Signed-off-by: Zhigang Luo --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: update vf to pf message retry from 2 to 5

2024-04-30 Thread Zhigang Luo
increase retry times to wait host has enough time to complete reset. Signed-off-by: Zhigang Luo --- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c index

Re: [PATCH] drm/amdgpu/mes11: fix kiq ring ready flag

2024-04-30 Thread Alex Deucher
On Tue, Apr 30, 2024 at 2:42 AM Jack Xiao wrote: > > kiq ring test has overwitten ready flag, > need disable after gfx hw init. > > Signed-off-by: Jack Xiao Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH] drm/amd/amdxcp: Use unique name for partition dev

2024-04-30 Thread Christian König
Am 30.04.24 um 13:36 schrieb Lijo Lazar: amdxcp is a platform driver for creating partition devices. libdrm library identifies a platform device based on 'OF_FULLNAME' or 'MODALIAS'. If two or more devices have the same platform name, drm library only picks the first device. Platform driver core

Re: [PATCH] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thanks for the review! Just sent a v2 From: Wentland, Harry Sent: Tuesday, April 30, 2024 9:36 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Siqueira, Rodrigo ; Deucher, Alexander Subject: Re: [PATCH]

[PATCH v2 1/2] drm/amd/display: Enable DCN410 init

2024-04-30 Thread Aurabindo Pillai
Enable initializing Display Manager for DCN410 IP Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH v2 2/2] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread Aurabindo Pillai
Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

Re: [PATCH] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread Harry Wentland
On 2024-04-30 09:23, Aurabindo Pillai wrote: > Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is > made in DC codebase to use 4.1.0 > > Signed-off-by: Aurabindo Pillai > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 + > 1 file changed, 5 insertions(+) >

RE: [PATCH] drm/amd/amdxcp: Use unique name for partition dev

2024-04-30 Thread Kamal, Asad
[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, April 30, 2024 5:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig, Christian ; Zhu, James

[PATCH] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread Aurabindo Pillai
Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

Re: [PATCH] drm/amd/amdxcp: Use unique name for partition dev

2024-04-30 Thread Alex Deucher
On Tue, Apr 30, 2024 at 8:32 AM Lijo Lazar wrote: > > amdxcp is a platform driver for creating partition devices. libdrm > library identifies a platform device based on 'OF_FULLNAME' or > 'MODALIAS'. If two or more devices have the same platform name, drm > library only picks the first device.

RE: [PATCH 2/2] drm/amdgpu/pm: Fix uninitialized variable warning

2024-04-30 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Ma, Jun Sent: Sunday, April 28, 2024 5:55 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Koenig, Christian ; Ma, Jun

[PATCH] drm/amd/amdxcp: Use unique name for partition dev

2024-04-30 Thread Lijo Lazar
amdxcp is a platform driver for creating partition devices. libdrm library identifies a platform device based on 'OF_FULLNAME' or 'MODALIAS'. If two or more devices have the same platform name, drm library only picks the first device. Platform driver core uses name of the device to populate

Re: [PATCH v9 03/14] drm/amdgpu: add new IOCTL for usermode queue

2024-04-30 Thread Christian König
Am 26.04.24 um 15:47 schrieb Shashank Sharma: This patch adds: - A new IOCTL function to create and destroy - A new structure to keep all the user queue data in one place. - A function to generate unique index for the queue. V1: Worked on review comments from RFC patch series: - Alex: Keep a

Re: [PATCH v1 2/5] drm/ci: generate testlist from build

2024-04-30 Thread Dmitry Baryshkov
On Tue, Apr 30, 2024 at 02:41:18PM +0530, Vignesh Raman wrote: > Stop vendoring the testlist into the kernel. Instead, use the > testlist from the IGT build to ensure we do not miss renamed > or newly added tests. > > Signed-off-by: Vignesh Raman > --- > drivers/gpu/drm/ci/build-igt.sh | 23

Re: [PATCH v1 5/5] drm/ci: update xfails for the new testlist

2024-04-30 Thread Dmitry Baryshkov
On Tue, Apr 30, 2024 at 02:41:21PM +0530, Vignesh Raman wrote: > Now the testlist is used from IGT build, so update > xfails with the new testlist. > > Signed-off-by: Vignesh Raman > --- > .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 47 +++ >

Re: [PATCH v1 4/5] drm/ci: skip driver specific tests

2024-04-30 Thread Dmitry Baryshkov
On Tue, Apr 30, 2024 at 02:41:20PM +0530, Vignesh Raman wrote: > Skip driver specific tests and skip kms tests for > panfrost driver since it is not a kms driver. > > Signed-off-by: Vignesh Raman > --- > .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 14 +- >

[PATCH v2] drm/amdkfd: Let VRAM allocations go to GTT domain on small APUs

2024-04-30 Thread Lang Yu
Small APUs(i.e., consumer, embedded products) usually have a small carveout device memory which can't satisfy most compute workloads memory allocation requirements. We can't even run a Basic MNIST Example with a default 512MB carveout. https://github.com/pytorch/examples/tree/main/mnist. Error

RE: [PATCH] drm/amdgpu/vpe: fix vpe dpm clk ratio setup failed

2024-04-30 Thread Yu, Lang
[Public] Reviewed-by: Lang Yu >-Original Message- >From: Lee, Peyton >Sent: Monday, April 29, 2024 2:53 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Yu, Lang >; Liu, HaoPing (Alan) ; Lee, Peyton > >Subject: [PATCH] drm/amdgpu/vpe: fix vpe dpm clk ratio setup failed >

[PATCH v1 5/5] drm/ci: update xfails for the new testlist

2024-04-30 Thread Vignesh Raman
Now the testlist is used from IGT build, so update xfails with the new testlist. Signed-off-by: Vignesh Raman --- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 47 +++ .../drm/ci/xfails/amdgpu-stoney-flakes.txt| 8 +- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 15

[PATCH v1 4/5] drm/ci: skip driver specific tests

2024-04-30 Thread Vignesh Raman
Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Signed-off-by: Vignesh Raman --- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 14 +- drivers/gpu/drm/ci/xfails/i915-amly-skips.txt | 14 +-

[PATCH v1 3/5] drm/ci: build virtual GPU driver as module

2024-04-30 Thread Vignesh Raman
With latest IGT, the tests tries to load the module and it fails. So build the virtual GPU driver for virtio as module. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/build.sh | 1 - drivers/gpu/drm/ci/igt_runner.sh | 6 +++--- drivers/gpu/drm/ci/image-tags.yml | 4 ++--

[PATCH v1 2/5] drm/ci: generate testlist from build

2024-04-30 Thread Vignesh Raman
Stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/build-igt.sh | 23 + drivers/gpu/drm/ci/igt_runner.sh |9 +-

[PATCH v1 1/5] drm/ci: uprev mesa version

2024-04-30 Thread Vignesh Raman
zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest version which includes a fix for this issue.

[PATCH v1 0/5] drm/ci: uprev mesa and generate testlist

2024-04-30 Thread Vignesh Raman
Uprev mesa to the latest version and stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Update the xfails with the latest testlist run. Also build virtual GPU driver for virtio as module. The flakes

Re: [PATCH v9 5/5] drm/amdgpu: Enable userq fence interrupt support

2024-04-30 Thread Christian König
Am 29.04.24 um 08:43 schrieb Arunpravin Paneer Selvam: Add support to handle the userqueue protected fence signal hardware interrupt. Create a xarray which maps the doorbell index to the fence driver address. This would help to retrieve the fence driver information when an userq fence interrupt

Re: [PATCH v9 4/5] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-04-30 Thread Christian König
Am 29.04.24 um 08:43 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in as parameter to the driver to install the fence into it. The

[PATCH v8 07/35] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it

2024-04-30 Thread Jim Cromie
Add param: query_module to ddebug_apply_class_bitmap(), and pass it thru to _ddebug_queries(), replacing NULL with query_module. This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional

[PATCH v8 27/35] selftests-dyndbg: test dyndbg-to-tracefs

2024-04-30 Thread Jim Cromie
Add a series of trace-tests: test_actual_trace() etc, to validate that the dyndbg-to-tracefs feature (using +T flag) works as intended. The 1st test uses the global tracebuf, the rest use/excercise private tracebufs. These tests are currently optional, via "TRACE" arg1, because the feature code

[PATCH v8 31/35] drm-dyndbg: adapt to use DYNDBG_CLASSMAP_PARAM

2024-04-30 Thread Jim Cromie
use new export --- drivers/gpu/drm/drm_print.c | 8 ++-- include/drm/drm_print.h | 6 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index 4a5f2317229b..efdf82f8cbbb 100644 --- a/drivers/gpu/drm/drm_print.c

[PATCH v8 20/35] dyndbg-doc: add classmap info to howto

2024-04-30 Thread Jim Cromie
Describe the 3 API macros providing dynamic_debug's classmaps DYNDBG_CLASSMAP_DEFINE - create, exports a module's classmap DYNDBG_CLASSMAP_USE- refer to exported map DYNDBG_CLASSMAP_PARAM - bind control param to the classmap DYNDBG_CLASSMAP_PARAM_REF + use module's storage - __drm_debug cc:

[PATCH v8 35/35] drm-print: workaround compiler meh

2024-04-30 Thread Jim Cromie
For some reason I cannot grok, I get an unused variable 'category' warning/error, though the usage follows immediately. This drops the local var and directly derefs in the macro-call, which somehow avoids the warning. commit 9fd6f61a297e ("drm/print: add drm_dbg_printer() for drm device specific

[PATCH v8 23/35] dyndbg: split multi-query strings with %

2024-04-30 Thread Jim Cromie
Multi-query strings have long allowed: modprobe drm dyndbg="class DRM_UT_CORE +p; class DRM_UT_KMS +p" modprobe drm dyndbg=< [ 203.902703] dyndbg: query parse failed [ 203.902871] dyndbg: processed 2 queries, with 0 matches, 2 errs bash: echo: write error: Invalid argument The '%' splits

[PATCH v8 18/35] selftests-dyndbg: exit 127 if no facility

2024-04-30 Thread Jim Cromie
Test if /proc/dynamic_debug/control exists, exit 127 otherwise. This distinguishes an untestable config from both pass & fail. The 127 choice is pretty arbitrary, but imitating bisect. That control file's presense guarantees that dynamic-debugging is configured (unless /proc is off, unusually),

[PATCH v8 06/35] dyndbg: replace classmap list with a vector

2024-04-30 Thread Jim Cromie
Classmaps are stored in an elf section/array, but are individually list-linked onto dyndbg's per-module ddebug_table for operation. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple builtin modules), its contents are ordered, so a

[PATCH v8 13/35] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap

2024-04-30 Thread Jim Cromie
old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++-- 1 file changed, 11 insertions(+), 10

[PATCH v8 22/35] selftests-dyndbg: add comma_terminator_tests

2024-04-30 Thread Jim Cromie
New fn validates parsing and effect of queries using combinations of commas and spaces to delimit the tokens. It manipulates pr-debugs in builtin module/params, so might have deps I havent foreseen on odd configurations. Signed-off-by: Jim Cromie ---

  1   2   >