Re: [PATCH] drm/amd/display: Don't register panel_power_savings on OLED panels

2024-05-10 Thread Gergo Koteles
Hi Mario, On Thu, 2024-05-09 at 12:05 -0500, Mario Limonciello wrote: > OLED panels don't support the ABM, they shouldn't offer the > panel_power_savings attribute to the user. Check whether aux BL > control support was enabled to decide whether to offer it. > > Reported-by

[RFC PATCH] drm/amd/display: Disable panel_power_savings sysfs entry for OLED displays

2024-05-08 Thread Gergo Koteles
The panel_power_savings sysfs entry sets the Adaptive Backlight Management level (abm_level). OLED displays work without backlight, so it is unnecessary for them. Before creating the sysfs entry, make sure the display is not an OLED display. Signed-off-by: Gergo Koteles --- drivers/gpu/drm/amd

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-04-13 Thread Gergo Koteles
Hi> > ABM will reduce the backlight and compensate by adjusting brightness and > contrast of the image. It has 5 levels: 0, 1, 2, 3, 4. 0 means off. 4 means > maximum backlight reduction. IMO, 1 and 2 look okay. 3 and 4 can be quite > impactful, both to power and visual fidelity. I tried