RE: [PATCH] drm/amdgpu: Skip coredump during resets for debug

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Friday, May 31, 2024 6:04 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig,

RE: [PATCH] drm/amdgpu: Remove duplicate check for *is_queue_unmap in sdma_v7_0_ring_set_wptr

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Gao, Likun Sent: Friday, May 17, 2024 9:32 AM To: SHANMUGAM, SRINIVASAN ; Koenig, Christian ; Deucher, Alexander Cc:

RE: [PATCH v5 10/10] Documentation/amdgpu: Add PM policy documentation

[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Asad Kamal mailto:asad.ka...@amd.com>> Thanks & Regards Asad From: Deucher, Alexander Sent: Friday, May 17, 2024 12:57 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Kamal,

RE: [PATCH v4 01/10] drm/amd/pm: Add support for DPM policies

nder ; Kamal, Asad ; Ma, Le Subject: RE: [PATCH v4 01/10] drm/amd/pm: Add support for DPM policies [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, May 14, 2024 7:06 PM To: amd-gfx@lists.freedesktop.org Cc: Z

RE: [PATCH] drm/amd/pm: Fix aldebaran pcie speed reporting

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Thursday, May 9, 2024 2:29 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Yang(Kevin) Subject: [PATCH]

RE: [PATCH] drm/amd/amdxcp: Use unique name for partition dev

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, April 30, 2024 5:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig, Christian ; Zhu, James

RE: [PATCH] drm/amd/pm: Restore config space after reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Wednesday, April 17, 2024 5:32 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amd/pm: Res

RE: [PATCH] drm/amd/pm: Report uclk and sclk limit

[AMD Official Use Only - General] Please ignore this patch will send a fresh one -Original Message- From: Kamal, Asad Sent: Tuesday, April 2, 2024 3:45 PM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Zhang, Hawking ; Ma, Le ; Zhang, Morris ; Kamal, Asad ; Cheung, Donald

RE: [PATCH v2 1/4] drm/amdgpu: Set fatal errror detected flag earlier

[AMD Official Use Only - General] Series is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Thursday, March 28, 2024 8:06 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Yang(Kevin)

RE: [PATCH v2 2/4] drm/amd/pm: Add PMFW message and capability flags

smu_umd_pstate_table { struct cmn2asic_msg_mapping { int valid_mapping; int map_to; - int valid_in_vf; + uint32_t flags; }; [Kamal, Asad] Do we need to change the following macro , to have flags rather than valid_in_vf #define MSG_MAP(msg, index

RE: [PATCH] drm/amdgpu: Refine IB schedule error logging

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, March 21, 2024 6:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig, Christian ; Kamal, Asad Subject: [P

RE: [PATCH 2/2] drm/amd/pm: Use metric table for pcie speed/width

[AMD Official Use Only - General] -Original Message- From: Lazar, Lijo Sent: Friday, March 15, 2024 12:25 PM To: Kamal, Asad ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Ma, Le ; Zhang, Morris ; Cheung, Donald ; Khatir, Sepehr ; Oliveira, Daniel ; Poag, Charis Subject: Re

RE: [PATCH] drm/amdgpu: Do a basic health check before reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Wednesday, March 13, 2024 3:12 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amdgpu

RE: [PATCH] drm/amd/pm: Increase SMUv13.0.6 mode-2 reset time

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Monday, February 26, 2024 4:08 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amd/pm: Incr

RE: [PATCH 1/2] drm/amdgpu: Add fatal error detected flag

[AMD Official Use Only - General] Series is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, February 22, 2024 3:47 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kuehling, Felix ; Joshi, Mukul ; K

RE: [PATCH v2] drm/amd/pm: Allow setting max UCLK on SMU v13.0.6

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Tested-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Friday, February 9, 2024 1:21 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma

RE: [PATCH] drm/amd/pm: Fetch current power limit from FW

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, January 18, 2024 2:33 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amd/pm: F

RE: [PATCH] drm/amdgpu: fix sdma ecc irq unbalanced issue

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Monday, January 15, 2024 5:33 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix

RE: [PATCH] drm/amd/pm: Fix smuv13.0.6 current clock reporting

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, January 11, 2024 4:02 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le ; Wang, Yang(Kevin) Sub

RE: [PATCH] drm/amd/pm: Add error log for smu v13.0.6 reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, January 11, 2024 9:52 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amd/pm:

RE: [PATCH] drm/amdgpu: Update irq disable flow during unload

[AMD Official Use Only - General] Hi Christian, Thank you for the comment. This is not normal reset, it is reset done during unload for smu v_13_0_2. Thanks & Regards Asad -Original Message- From: Koenig, Christian Sent: Monday, January 8, 2024 1:33 PM To: Kamal, Asad Subject

RE: [PATCH v4] drm/amdgpu : Add register read/write debugfs support for AID's

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Mangesh Gadre Sent: Wednesday, December 20, 2023 10:43 AM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Lazar, Lijo Cc: Gadre, Mangesh ; Koenig,

RE: [PATCH] drm/amdgpu: Restrict extended wait to PSP v13.0.6

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Wednesday, November 29, 2023 6:07 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Limonciello, Mario Sub

RE: [PATCH] drm/amd/pm: Don't send unload message for reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal mailto:asad.ka...@amd.com>> Thanks & Regards Asad From: Wang, Yang(Kevin) Sent: Wednesday, November 15, 2023 8:42 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asa

RE: [PATCH] drm/amdgpu: Skip execution of pending reset jobs

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lazar, Lijo Sent: Friday, November 10, 2023 4:19 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking Subject: Re: [PATCH]

RE: [PATCH] drm/amdgpu: Fix sdma 4.4.2 doorbell rptr/wptr init

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Tested-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Monday, November 6, 2023 9:51 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma

RE: [PATCH 1/2] drm/amd/pm: Hide irrelevant pm device attributes

[AMD Official Use Only - General] Seies is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Friday, November 3, 2023 11:30 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking Subject: [PATCH 1/2]

RE: [PATCH] drm/amdgpu: Add a read to GFX v9.4.3 ring test

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Zhang, Hawking Sent: Friday, October 20, 2023 12:36 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kamal, Asad ; Ma, Le Subject: RE: [PATCH]

RE: [PATCH] Revert "drm/amdgpu: Program xcp_ctl registers as needed"

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Gadre, Mangesh Sent: Wednesday, October 11, 2023 3:11 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Lazar, Lijo ; Ma, Le ; Zhang, Morris ; Kamal, Asad Cc: G

RE: [PATCH v2 3/3] drm/amd/pm: Use gpu_metrics_v1_4 for SMUv13.0.6

[AMD Official Use Only - General] -Original Message- From: Lazar, Lijo Sent: Monday, October 9, 2023 7:59 PM To: Kamal, Asad ; amd-gfx@lists.freedesktop.org Cc: Ma, Le ; Zhang, Morris ; Zhang, Hawking Subject: Re: [PATCH v2 3/3] drm/amd/pm: Use gpu_metrics_v1_4 for SMUv13.0.6 On 10

RE: [PATCH 1/2] drm/amd/pm: Add throttle limit for SMU v13.0.6

[AMD Official Use Only - General] Series is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Wednesday, September 20, 2023 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking Subject: [PATCH

RE: [PATCH] drm/amdgpu:Expose physical id of device in XGMI hive

[AMD Official Use Only - General] With clarification from Lijo, patch is, Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, September 21, 2023 2:44 PM To: Kamal, Asad ; Gadre, Mangesh ; amd-gfx@lists.freedesktop.org; Zhang, Haw

RE: [PATCH] drm/amdgpu:Expose physical id of device in XGMI hive

tatic ssize_t amdgpu_xgmi_show_error(struct device *dev, static DEVICE_ATTR(xgmi_device_id, S_IRUGO, amdgpu_xgmi_show_device_id, NULL); +static DEVICE_ATTR(xgmi_physical_id, 0444, +amdgpu_xgmi_show_physical_id, NULL); [Kamal, Asad] Can we use S_IRUGO in place of hard code value 0444? Regards Asad stati

Re: [PATCH] drm/amd/pm: Round Q10 format values in SMU v13.0.6

[AMD Official Use Only - General] Reviewed-by: Asad Kamal mailto:asad.ka...@amd.com>> Thanks & Regards Asad From: amd-gfx on behalf of Lijo Lazar Sent: Friday, September 15, 2023 6:29:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexand

RE: [PATCH] drm/amdgpu: Restore partition mode after reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Tested-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Friday, September 8, 2023 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [P

RE: [PATCH] drm/amdgpu: Use default reset method handler

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Tested-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Wednesday, September 6, 2023 4:56 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Sub

RE: [PATCH] drm/amdgpu: Restrict bootloader wait to SMUv13.0.6

[AMD Official Use Only - General] Reviewed-by: Asad Kamal asad.ka...@amd.com Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Monday, September 4, 2023 6:32 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Kamal, Asad ; Z

RE: [PATCH] drm/amdgpu: Add only valid firmware version nodes

[AMD Official Use Only - General] Reviewed-by: Asad Kamal asad.ka...@amd.com Thanks & Regards Asad From: amd-gfx On Behalf Of Wang, Yang(Kevin) Sent: Friday, August 25, 2023 4:46 PM To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Deucher, Alexander ; Zhang,

RE: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

[AMD Official Use Only - General] With the following patch in place https://patchwork.freedesktop.org/patch/553433/?series=122640=1 Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Monday, August 21, 2023 12:06 PM To: Kamal,

RE: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

pu_hwmon_show_power_avg(struct device *dev, struct device_attribute *attr, char *buf) { - unsigned int val; + ssize_t val; val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_AV

RE: [PATCH] drm/amdgpu: Fix the return for gpu mode1_reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Hawking Zhang Sent: Saturday, August 19, 2023 12:11 PM To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Lazar, Lijo ; Deucher, Alexander ; Kamal, Asad Cc: Zhang, Hawking Sub

RE: [PATCH] drm/amdgpu: Keep reset handlers shared

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Tested-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Ma, Le Sent: Wednesday, August 16, 2023 4:17 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kamal, Asad ; Zhang, Haw

RE: [PATCH] drm/amdgpu: Restore HQD persistent state register

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Zhang, Hawking Sent: Tuesday, July 25, 2023 11:23 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kamal, Asad Subject: RE: [PATCH] drm/amdgpu: Res

RE: [PATCH] drm/amdgpu: Remove redundant GFX v9.4.3 sequence

[AMD Official Use Only - General] Reviewed-by: Asad Kamal -Original Message- From: Ma, Le Sent: Wednesday, July 5, 2023 11:52 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Gadre, Mangesh Subject: RE: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: Change golden settings for GFX v9.4.3

[AMD Official Use Only - General] Reviewed-by: Asad Kamal -Original Message- From: Lazar, Lijo Sent: Tuesday, July 4, 2023 9:09 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le ; Gadre, Mangesh Subject: [PATCH] drm/amdgpu: Change