Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Limonciello, Mario
Also a direct acpi_lid_open() call seems a bit iffy. But I guess if someone needs this to work on non-ACPI system they get to figure out how to abstract it better. acpi_lid_open() does seem to return != 0 when ACPI is not supported, so at least it would err on the side of enabling everything.

Re: [PATCH] drm/amdgpu: fix Kconfig for ISP v2

2024-05-16 Thread Limonciello, Mario
On 5/14/2024 4:28 PM, Alex Deucher wrote: Add new config option and set proper dependencies for ISP. v2: add missed guards, drop separate Kconfig Signed-off-by: Alex Deucher I have one optional remark regarding headers, but otherwise it looks fine by me. Feel free to ignore it or

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-12 Thread Limonciello, Mario
On 5/10/2024 4:24 AM, Jani Nikula wrote: On Fri, 10 May 2024, "Lin, Wayne" wrote: [Public] -Original Message----- From: Limonciello, Mario Sent: Friday, May 10, 2024 3:18 AM To: Linux regressions mailing list ; Wentland, Harry ; Lin, Wayne Cc: ly...@redhat.com; imre.d...

RE: [PATCH 2/3] drm/amd/amdgpu: Add ISP driver support

2024-05-09 Thread Limonciello, Mario
can use. It's okay this time, but if you end up spinning again for a v3 do that. > -Original Message- > From: Nirujogi, Pratap > Sent: Thursday, May 9, 2024 12:19 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander ; Chan, Benjamin > (Ko

RE: [PATCH] drm/amd: Disable ASPM for VI w/ all Intel systems

2023-10-23 Thread Limonciello, Mario
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Monday, October 23, 2023 09:22 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Limonciello, Mario ; > paolo.gent...@canonical.com > Subject: RE: [PATCH] drm/amd: Disable ASPM for

RE: [PATCH 13/16] drm/amd/display: Don't set dpms_off for seamless boot

2023-10-04 Thread Limonciello, Mario
[AMD Official Use Only - General] > From: Daniel Miess > > [Why] > eDPs fail to light up with seamless boot enabled > > [How] > When seamless boot is enabled don't configure dpms_off > in disable_vbios_mode_if_required. > > Reviewed-by: Charlene Liu > Cc: Mario Limonciello > Cc: Alex Deucher

Re: [V9 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-21 Thread Limonciello, Mario
On 8/19/2023 5:50 AM, Greg KH wrote: On Fri, Aug 18, 2023 at 05:49:14PM -0500, Limonciello, Mario wrote: On 8/18/2023 4:24 PM, Greg KH wrote: On Fri, Aug 18, 2023 at 11:26:11AM +0800, Evan Quan wrote: drivers/base/Makefile | 1 + drivers/base/wbrf.c

Re: [V9 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-18 Thread Limonciello, Mario
On 8/18/2023 4:24 PM, Greg KH wrote: On Fri, Aug 18, 2023 at 11:26:11AM +0800, Evan Quan wrote: drivers/base/Makefile | 1 + drivers/base/wbrf.c | 280 ++ Why is a wifi-specific thing going into drivers/base/? confused,

Re: [PATCH] drm/amd/display: Don't show stack trace for missing eDP

2023-07-31 Thread Limonciello, Mario
On 7/31/2023 11:15 AM, Hamza Mahfooz wrote: On 7/31/23 12:08, Mario Limonciello wrote: Some systems are only connected by HDMI or DP, so warning related to missing eDP is unnecessary.  Downgrade to debug instead. Cc: Hamza Mahfooz Fixes: 6d9b6dceaa51 ("drm/amd/display: only warn once in

Re: [PATCH -next] drm/amdgpu: Remove a lot of unnecessary ternary operators

2023-07-31 Thread Limonciello, Mario
On 7/31/2023 8:26 AM, Ruan Jinjie wrote: Ther are many ternary operators, the true or false judgement of which is unnecessary in C language semantics. s/Ther/There/ Unnecessary; sure. But don't they improve the readability quite a bit? Signed-off-by: Ruan Jinjie ---

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-24 Thread Limonciello, Mario
On 7/24/2023 04:22, Andrew Lunn wrote: @@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw) debugfs_hw_add(local); rate_control_add_debugfs(local); + ieee80211_check_wbrf_support(local); + rtnl_lock(); wiphy_lock(hw->wiphy); +void

RE: [PATCH] drm/amd: Fix an error handling mistake in psp_sw_init()

2023-07-18 Thread Limonciello, Mario
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Thursday, July 13, 2023 00:15 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario > Subject: [PATCH] drm/amd: Fix an error handling mistake in psp_sw_init() > > If the second call to

Re: [1/2] drm/amdgpu: fix slab-out-of-bounds issue in amdgpu_vm_pt_create

2023-07-16 Thread Limonciello, Mario
On 7/14/2023 6:05 AM, Guchun Chen wrote: Recent code set xcp_id stored from file private data when opening device to amdgpu bo for accounting memory usage etc, but not all VMs are attached to this fpriv structure like the vm cases in amdgpu_mes_self_test, otherwise, KASAN will complain below

RE: [PATCH 4/4] drm/amd: Drop amdgpu_device_aspm_support_quirk()

2023-07-11 Thread Limonciello, Mario
[AMD Official Use Only - General] OK, will pick up 1/2/3 and continue to think about 4. > -Original Message- > From: Quan, Evan > Sent: Sunday, July 9, 2023 20:54 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Subject: RE: [PATCH

Re: [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Limonciello, Mario
+regressions On 7/10/2023 04:58, Thomas Zimmermann wrote: Hi Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the

RE: [RFC 1/2] drm/amd: Extend Intel ASPM quirk to all dGPUs

2023-07-06 Thread Limonciello, Mario
[AMD Official Use Only - General] Thanks. I'm going to leave this series as the backup option, have another idea that I'll have Koba try first. > -Original Message- > From: Quan, Evan > Sent: Wednesday, July 5, 2023 20:04 > To: Limonciello, Mario ; amd- > g...@lists.

Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-06-30 Thread Limonciello, Mario
On 6/30/2023 05:32, Evan Quan wrote: Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has

RE: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-29 Thread Limonciello, Mario
eedesktop.org; Joonas Lahtinen > ; dri-de...@lists.freedesktop.org; Chai, > Thomas ; Limonciello, Mario > ; Gao, Likun ; David > Airlie ; Ville Syrjala ; Yi > Liu > ; k...@vger.kernel.org; amd-gfx@lists.freedesktop.org; > Jason Gunthorpe ; Ben Skeggs ; linux- > p..

RE: [PATCH] Revert "drm/amd/display: edp do not add non-edid timings"

2023-06-26 Thread Limonciello, Mario
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 26, 2023 12:45 PM > To: Hersen Wu ; amd-gfx@lists.freedesktop.org; > Wentland, Harry > Cc: Wu, Hersen > Subject: RE: [PATCH] Revert "drm/amd/display: edp do not add non-edid > timi

RE: [PATCH] Revert "drm/amd/display: edp do not add non-edid timings"

2023-06-26 Thread Limonciello, Mario
[Public] > This change causes regression when eDP and external display in mirror > mode. When external display supports low resolution than eDP, use eDP > timing to driver external display may cause corruption on external > display. > > This reverts commit

Re: [PATCH] drm/amd: Fix a documentation warning about excess parameters

2023-06-26 Thread Limonciello, Mario
On 6/26/2023 10:05 AM, Alex Deucher wrote: On Mon, Jun 26, 2023 at 11:00 AM Mario Limonciello wrote: `pcie_index` and `pcie_data` aren't used by amdgpu_device_indirect_wreg() since commit 65ba96e91b68 ("drm/amdgpu: Move to common indirect reg access helper") but the documentation wasn't

RE: [PATCH 2/4] drm/amd/display: Set minimum requirement for using PSR-SU on Rembrandt

2023-06-23 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Li, Sun peng (Leo) > Sent: Friday, June 23, 2023 2:27 PM > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Lin, Tsung-hua (Ryan) ; Rossi, Marc > ; Wang, Sean ; Mahfooz, > Hamza > S

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-23 Thread Limonciello, Mario
On 6/23/2023 11:28 AM, Rafael J. Wysocki wrote: On Fri, Jun 23, 2023 at 5:57 PM Limonciello, Mario wrote: On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote: On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote: From: Mario Limonciello Due to electrical and mechanical constraints in certain

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-23 Thread Limonciello, Mario
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote: On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote: From: Mario Limonciello Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-22 Thread Limonciello, Mario
On 6/21/2023 8:55 PM, Andrew Lunn wrote: Honestly I'm not sure though we need this complexity right now? I mean, it'd be really easy to replace the calls in mac80211 with some other more generalised calls in the future? You need some really deep platform/hardware level knowledge and

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another question would be where should the new "wbrf.c" be stored?  The ACPI only version most certainly made sense in drivers/acpi/wbrf.c, but a generic version that only has an ACPI implementation right now not so much. On

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 12:26 PM, Andrew Lunn wrote: I think what you're asking for is another layer of indirection like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF. Producers would call functions like wbrf_supported_producer() where the source file is not guarded behind CONFIG_ACPI_WBRF, but instead by

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 11:52 AM, Andrew Lunn wrote: On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote: On 6/21/2023 10:39 AM, Johannes Berg wrote: On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote: On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote: From: Mario Limonciello

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 11:31 AM, Andrew Lunn wrote: I think there is enough details for this to happen. It's done so that either the AML can natively behave as a consumer or a driver can behave as a consumer. +/** + * APIs needed by drivers/subsystems for contributing frequencies: + * During probe,

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 11:14 AM, Andrew Lunn wrote: Do only ACPI based systems have: interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7." Could Device Tree based systems not experience this problem?

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 10:39 AM, Johannes Berg wrote: On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote: On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote: From: Mario Limonciello Due to electrical and mechanical constraints in certain platform designs there may be likely interference of

Re: [PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 5:22 AM, Johannes Berg wrote: On Wed, 2023-06-21 at 13:45 +0800, Evan Quan wrote: To support AMD's WBRF interference mitigation mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated

RE: [PATCH] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-06-20 Thread Limonciello, Mario
[Public] You've got an A-b from Evan already on this. It looks fine to me too. Reviewed-by: Mario Limonciello > -Original Message- > From: Yang, WenYou > Sent: Sunday, June 11, 2023 12:53 AM > To: Yang, WenYou ; Deucher, Alexander > ; Limonciello, Mario > ; Koenig,

Re: [PATCH v6 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-19 Thread Limonciello, Mario
On 6/12/2023 2:25 PM, Sui Jingfeng wrote: From: Sui Jingfeng Deal only with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non-PCI display device(pdev->class != 0x0300) out. There no need to process the non-display PCI device.

RE: [PATCH 2/2] drm/amd: Tighten permissions on VBIOS flashing attributes

2023-06-07 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Wednesday, June 7, 2023 1:53 AM > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario > Subject: [PATCH 2/2] drm/amd: Tighten permissions on VBIOS flashing > attribut

RE: [PATCH] drm/amd: Check that a system is a NUMA system before looking for SRAT

2023-06-05 Thread Limonciello, Mario
[Public] > On 2023-06-02 08:18, Mario Limonciello wrote: > > It's pointless on laptops to look for the SRAT table as these are not > > NUMA. Check the number of possible nodes is > 1 to decide whether to > > look for SRAT. > > > > Suggested-by: Felix Kuehling > > Signed-off-by: Mario

Re: drm/amd: Drop messages in init for radeon, amdgpu

2023-06-05 Thread Limonciello, Mario
On 6/5/2023 9:28 AM, Alex Deucher wrote: Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the user's configuration. Drop the message in the module init function as this can be confusing to users. Link:

RE: [PATCH v2 1/2] drm/amd: Disallow s0ix without BIOS support again

2023-06-01 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Thursday, June 1, 2023 11:15 AM > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola > > Subject: Re: [PATCH v2 1/2] drm/amd: Disallow s0ix

RE: [PATCH v2 1/2] drm/amd: Disallow s0ix without BIOS support again

2023-06-01 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Wednesday, May 31, 2023 10:22 PM > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola > > Subject: Re: [PATCH v2 1/2] drm/amd: Disallow s0ix

Re: [PATCH 1/2] drm/amd: Disallow s0ix without BIOS support again

2023-05-30 Thread Limonciello, Mario
On 5/30/2023 4:34 PM, Alex Deucher wrote: On Tue, May 30, 2023 at 2:19 PM Limonciello, Mario wrote: [AMD Official Use Only - General] -Original Message- From: Alex Deucher Sent: Tuesday, May 30, 2023 1:16 PM To: Limonciello, Mario Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila

RE: [PATCH 1/2] drm/amd: Disallow s0ix without BIOS support again

2023-05-30 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Tuesday, May 30, 2023 1:38 PM > To: Rafael Ávila de Espíndola ; Alex Deucher > > Cc: amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 1/2] drm/amd: Disallow s0ix witho

RE: [PATCH 1/2] drm/amd: Disallow s0ix without BIOS support again

2023-05-30 Thread Limonciello, Mario
ix on APUs older than Raven") > Cheers, > Rafael > > "Limonciello, Mario" writes: > > > [AMD Official Use Only - General] > > > >> -----Original Message- > >> From: Alex Deucher > >> Sent: Tuesday, May 30, 2023 1:16 PM > >> To

RE: [PATCH 1/2] drm/amd: Disallow s0ix without BIOS support again

2023-05-30 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Tuesday, May 30, 2023 1:16 PM > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola > > Subject: Re: [PATCH 1/2] drm/amd: Disallow s0ix witho

Re: [PATCH 0/9] Support Wifi RFI interference mitigation feature

2023-05-30 Thread Limonciello, Mario
On 5/30/2023 1:22 AM, Felix Fietkau wrote: On 30.05.23 04:42, Evan Quan wrote: Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands

Re: [PATCH v2 0/3] Fix DCN 3.1.4 hangs on s2idle entry

2023-05-17 Thread Limonciello, Mario
I think we replaced this with golden timestamp value which doesn't require GFX register access. Ah yes; through 5591a051b86b ("drm/amdgpu: refine get gpu clock counter method") This wasn't part of the kernel this was originally reported on. I suspect this would significantly decrease the

Re: [PATCH v2 0/3] Fix DCN 3.1.4 hangs on s2idle entry

2023-05-16 Thread Limonciello, Mario
On 5/17/2023 12:26 AM, Lazar, Lijo wrote: On 5/17/2023 10:46 AM, Limonciello, Mario wrote: On 5/17/2023 12:07 AM, Lazar, Lijo wrote: On 5/17/2023 10:25 AM, Limonciello, Mario wrote: On 5/16/2023 11:43 PM, Lazar, Lijo wrote: On 5/17/2023 5:04 AM, Mario Limonciello wrote: DCN 3.1.4

Re: [PATCH v2 0/3] Fix DCN 3.1.4 hangs on s2idle entry

2023-05-16 Thread Limonciello, Mario
On 5/17/2023 12:07 AM, Lazar, Lijo wrote: On 5/17/2023 10:25 AM, Limonciello, Mario wrote: On 5/16/2023 11:43 PM, Lazar, Lijo wrote: On 5/17/2023 5:04 AM, Mario Limonciello wrote: DCN 3.1.4 s2idle entry will hang occasionally on s2idle entry, but only if running Wayland and only when

Re: [PATCH v2 0/3] Fix DCN 3.1.4 hangs on s2idle entry

2023-05-16 Thread Limonciello, Mario
On 5/16/2023 11:43 PM, Lazar, Lijo wrote: On 5/17/2023 5:04 AM, Mario Limonciello wrote: DCN 3.1.4 s2idle entry will hang occasionally on s2idle entry, but only if running Wayland and only when using `systemctl suspend`, not `echo mem | tee /sys/power/state`. This happens because using

Re: [PATCH 3/3] drm/amd: Add safety check to make sure RLC is only turned off while in GFXOFF

2023-05-16 Thread Limonciello, Mario
On 5/16/2023 4:57 PM, Alex Deucher wrote: On Tue, May 16, 2023 at 5:50 PM Limonciello, Mario wrote: On 5/16/2023 4:39 PM, Alex Deucher wrote: On Tue, May 16, 2023 at 2:15 PM Mario Limonciello wrote: On GFX11 if RLC is stopped when not in GFXOFF the system will hang. Prevent this case

Re: [PATCH 3/3] drm/amd: Add safety check to make sure RLC is only turned off while in GFXOFF

2023-05-16 Thread Limonciello, Mario
On 5/16/2023 4:39 PM, Alex Deucher wrote: On Tue, May 16, 2023 at 2:15 PM Mario Limonciello wrote: On GFX11 if RLC is stopped when not in GFXOFF the system will hang. Prevent this case from ever happening. Tested-by: Juan Martinez Signed-off-by: Mario Limonciello ---

Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()

2023-05-03 Thread Limonciello, Mario
On 5/2/2023 11:51 AM, Hamza Mahfooz wrote: As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It is meaningless to call amdgpu_irq_put() for

RE: [PATCH] drm/amd/pm: conditionally disable pcie lane switching for some sienna_cichlid SKUs

2023-04-21 Thread Limonciello, Mario
[Public] > -Original Message- > From: Quan, Evan > Sent: Friday, April 21, 2023 02:29 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Limonciello, Mario > ; Quan, Evan > Subject: [PATCH] drm/amd/pm: conditionally disable pcie lane switching for

Re: drm/amdgpu: skip kfd-iommu suspend/resume for S0ix

2023-04-12 Thread Limonciello, Mario
On 4/5/2023 06:29, Aaron Liu wrote: GFX is in gfxoff mode during s0ix so we shouldn't need to actually execute kfd_iommu_suspend/kfd_iommu_resume operation. Signed-off-by: Aaron Liu Acked-by: Alex Deucher Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8

Re: [PATCH v6 0/2] Send message to PMFW when SMT changes

2023-04-07 Thread Limonciello, Mario
On 4/7/2023 00:38, Wenyou Yang wrote: When the SMT changes on the fly, send the message to the PMFW to notify the SMT status changed. Changes in v6 1./ Update last_smt_active only when the return from smu_set_cpu_smt_enable() successfully. 2./ Use smu->adev->pm.fw_version to check smu version,

Re: [PATCH v5 1/2] drm/amd/pm: Add support to check SMT state periodically

2023-04-06 Thread Limonciello, Mario
On 4/6/2023 07:45, Wenyou Yang wrote: Add a timer to poll the SMT state periodically, if the SMT state is changed, invoke the interface to notify the PMFW. Signed-off-by: Wenyou Yang --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 8 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c|

Re: [PATCH v5 2/2] drm/amd/pm/vangogh: Send SMT enable message to PMFW

2023-04-06 Thread Limonciello, Mario
On 4/6/2023 07:45, Wenyou Yang wrote: When the SMT state is changed on the fly, sent the SMT enable message to the PMFW to notify it that the SMT state changed. Add the support to send PPSMC_MSG_SetCClkSMTEnable(0x58) message to the PMFW for Vangogh. Signed-off-by: Wenyou Yang ---

Re: [PATCH] drm/amdgpu: skip kfd-iommu suspend/resume for S0ix

2023-04-05 Thread Limonciello, Mario
On 4/5/2023 06:29, Liu, Aaron wrote: GFX is in gfxoff mode during s0ix so we shouldn't need to actually execute kfd_iommu_suspend/kfd_iommu_resume operation. Signed-off-by: Aaron Liu --- Probably should add to this patch: Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2449

RE: [PATCH v3] drm/amd/amdgpu: Drop the hang limit parameter

2023-04-05 Thread Limonciello, Mario
[Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > > Sent: Wednesday, April 5, 2023 10:24 > To: Koenig, Christian ; Deucher, Alexander > ; Limonciello, Mario > ; Russell, Kent > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > > Subj

RE: [PATCH] drm/amdgpu: allow more APUs to do mode2 reset when go to S4

2023-03-30 Thread Limonciello, Mario
top.org > Cc: Deucher, Alexander ; Limonciello, Mario > ; Yuan, Perry ; Du, > Xiaojian ; Ma, Li > Subject: RE: [PATCH] drm/amdgpu: allow more APUs to do mode2 reset > when go to S4 > > [AMD Official Use Only - General] > > Please add a Fixes tag: > > Fixes: 2bedd3f21

RE: [v1,2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-24 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, March 23, 2023 21:29 > To: Limonciello, Mario ; Yang, WenYou > ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui > Cc: Li, Ying ; Liu, Kun ; Liang

Re: [v1,2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-23 Thread Limonciello, Mario
On 3/23/2023 12:41, Limonciello, Mario wrote: On 3/22/2023 00:48, Wenyou Yang wrote: When the CPU SMT status change in the fly, sent the SMT-enable message to pmfw to notify it that the SMT status changed. Signed-off-by: Wenyou Yang ---   drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41

Re: [v1,2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-23 Thread Limonciello, Mario
On 3/22/2023 00:48, Wenyou Yang wrote: When the CPU SMT status change in the fly, sent the SMT-enable message to pmfw to notify it that the SMT status changed. Signed-off-by: Wenyou Yang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41 +++

Re: [v1,3/3] drm/amd/pm: vangogh: support to send SMT enable message

2023-03-23 Thread Limonciello, Mario
On 3/22/2023 00:48, Wenyou Yang wrote: Add the support to PPSMC_MSG_SetCClkSMTEnable(0x58) message to pmfw for vangogh. Signed-off-by: Wenyou Yang --- .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 3 ++- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 ++-

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Limonciello, Mario
[Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > > Sent: Thursday, March 23, 2023 07:37 > To: Limonciello, Mario ; Koenig, Christian > ; Deucher, Alexander > ; Li, Candice ; > Zhang, Hawking > Cc: amd-gfx@lists.freedesktop.org > Subject: R

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Limonciello, Mario
[Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > > Sent: Thursday, March 23, 2023 07:32 > To: Koenig, Christian ; Deucher, Alexander > ; Limonciello, Mario > ; Li, Candice ; Zhang, > Hawking > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRIN

RE: [PATCH v2] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-20 Thread Limonciello, Mario
lix ; Zhao, Victor ; > Xiao, Jack ; Quan, Evan ; > Limonciello, Mario ; Lazar, Lijo > ; Chai, Thomas ; Andrey > Grodzovsky ; Somalapuram, Amaranath > ; Zhang, Bokun > ; Liu, Leo ; Gopalakrishnan, > Veerabadhran (Veera) ; Gong, > Richard ; Feng, Kenneth > ; J

Re: [v2] drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume

2023-03-06 Thread Limonciello, Mario
On 3/4/2023 17:44, Błażej Szczygieł wrote: Always setup overdrive tables after resume. Preserve only some user-defined settings in user_overdrive_table if they're set. Copy restored user_overdrive_table into od_table to get correct values. Signed-off-by: Błażej Szczygieł ---

RE: [PATCH] drm/amd: Fix initialization mistake for NBIO 7.3.0

2023-03-02 Thread Limonciello, Mario
[Public] > -Original Message- > From: Thomas Glanzmann > Sent: Thursday, March 2, 2023 14:17 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Natikar, Basavaraj > > Subject: Re: [PATCH] drm/amd: Fix initialization mistake for NBIO 7.3.0 > >

RE: [PATCH 2/3] drm/amd: Use runtime suspend in lieu regular suspend on supported dGPUs

2023-02-21 Thread Limonciello, Mario
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, February 21, 2023 07:20 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Peter Kopec > Subject: Re: [PATCH 2/3] drm/amd: Use runtime suspend in lieu regular suspend

Re: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Limonciello, Mario
On 2/21/2023 07:34, Lazar, Lijo wrote: On 2/21/2023 6:57 PM, Mario Limonciello wrote: On 2/21/23 07:25, Lazar, Lijo wrote: On 2/21/2023 1:46 AM, Mario Limonciello wrote: dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter

RE: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven

2023-02-20 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Monday, February 20, 2023 11:10 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Subject: Re: [PATCH v2] drm/amd: Don't allow s0ix on

RE: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven

2023-02-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Monday, February 13, 2023 15:11 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Deucher, Alexander > > Subject: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven > &g

RE: [PATCH] drm/amd: Don't allow s0ix on APUs older than Raven

2023-02-10 Thread Limonciello, Mario
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Friday, February 10, 2023 14:47 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Deucher, Alexander > > Subject: [PATCH] drm/amd: Don't allow s0ix on APUs older than Raven > &g

RE: [PATCH] drm/amd: Allow s0ix without BIOS support

2023-02-02 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Wednesday, February 1, 2023 21:49 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola > > Subject: Re: [PATCH] drm/amd: Allow s0ix without BIO

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-02-01 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Greg KH > Sent: Sunday, January 29, 2023 07:32 > To: Limonciello, Mario > Cc: Linux regressions mailing list ; dri- > de...@lists.freedesktop.org; sta...@vger.kernel.org; > stanislav.lisovs...@intel.

RE: [PATCH] drm/amd: Allow s0ix without BIOS support

2023-01-30 Thread Limonciello, Mario
[Public] > -Original Message- > From: Rafael Ávila de Espíndola > Sent: Monday, January 30, 2023 08:08 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Limonciello, Mario > Subject: Re: [PATCH] drm/amd: Allow s0ix without BIOS support >

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-27 Thread Limonciello, Mario
[Public] > -Original Message- > From: Linux kernel regression tracking (Thorsten Leemhuis) > > Sent: Friday, January 27, 2023 03:15 > To: Greg KH ; Limonciello, Mario > > Cc: dri-de...@lists.freedesktop.org; sta...@vger.kernel.org; > stanislav.lisovs...@int

Re: drm/amdgpu: add force_sg_display module parameter

2023-01-26 Thread Limonciello, Mario
On 1/24/2023 09:13, Alex Deucher wrote: Add a module parameter to force sg (scatter/gather) display on APUs. Normally we allow displays in both VRAM and GTT, but this option forces displays into GTT so we can explicitly test more scenarios with GTT. Signed-off-by: Alex Deucher ---

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Friday, January 20, 2023 12:18 > To: Limonciello, Mario > Cc: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org; sta...@vger.kernel.org; > stanisla

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Limonciello, Mario
On 1/20/2023 11:46, Guenter Roeck wrote: On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why] Changes cause regression on amdgpu mst. E.g. In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload one

RE: [PATCH 1/2] drm/amdgpu: skip psp suspend for IMU enabled ASICs mode2 reset

2023-01-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Huang, Tim > Sent: Friday, January 20, 2023 10:29 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Du, Xiaojian ; Ma, Li > ; Limonciello, Mario ; > Huang, Tim > Subject: [PATCH 1/2] d

RE: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Huang, Tim > Sent: Friday, January 20, 2023 10:29 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Du, Xiaojian ; Ma, Li > ; Limonciello, Mario ; > Huang, Tim > Subject: [PATCH 2/2] dr

Re: Documentation/gpu: update dGPU asic info table

2023-01-19 Thread Limonciello, Mario
On 1/18/2023 15:14, Alex Deucher wrote: Update to the latest launched dGPUs. Link: https://www.amd.com/en/graphics/radeon-rx-graphics Link: https://www.amd.com/en/graphics/amd-radeon-rx-laptops Signed-off-by: Alex Deucher Reviewed-by: Mario Limonciello ---

RE: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Limonciello, Mario
[Public] > -Original Message- > From: Guilherme G. Piccoli > Sent: Tuesday, January 17, 2023 12:14 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org; Deucher, Alexander > > Cc: dri-de...@lists.freedesktop.org; Koenig, Christian > ; Pan, Xinhui

RE: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Limonciello, Mario
t; kernel-...@igalia.com; Guilherme G. Piccoli > ; Zhu, James ; Lazar, Lijo > ; Liu, Leo ; Limonciello, Mario > ; Jiang, Sonny > Subject: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM > HW model check > > The HW model validation that guards the indirect SRAM checking

RE: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Tuesday, January 17, 2023 09:11 > To: Guilherme G. Piccoli > Cc: Limonciello, Mario ; Liu, Leo > ; amd-gfx@lists.freedesktop.org; Jiang, Sonny > ; ker...@gpiccoli.net; Pan, Xinhui > ; dri-de...@list

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-16 Thread Limonciello, Mario
On 1/16/2023 18:47, Guilherme G. Piccoli wrote: On 16/01/2023 20:00, Alex Deucher wrote: [...] It's not clear to me when this would be used. We only disable it briefly during new asic bring up, after that we never touch it again. No end user on production hardware should ever have to change

RE: [PATCH 2/3] drm/amdgpu/vcn: Deduplicate indirect SRAM checking code

2023-01-16 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Monday, January 16, 2023 15:54 > To: Limonciello, Mario > Cc: Guilherme G. Piccoli ; amd- > g...@lists.freedesktop.org; Jiang, Sonny ; > ker...@gpiccoli.net; Pan, Xinhui ; dri- > de...@lists.free

RE: [PATCH 2/3] drm/amdgpu/vcn: Deduplicate indirect SRAM checking code

2023-01-16 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Monday, January 16, 2023 15:42 > To: Guilherme G. Piccoli > Cc: amd-gfx@lists.freedesktop.org; Jiang, Sonny ; > ker...@gpiccoli.net; Pan, Xinhui ; dri- > de...@lists.freedesktop.org; Lazar, Lijo ; Limoncie

RE: [PATCH 1/3] drm/amd: Adjust legacy IP discovery for Picasso/Raven/Raven2

2023-01-16 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Monday, January 16, 2023 07:51 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/3] drm/amd: Adjust legacy IP discovery for > Picasso/Raven/Raven2 > > On Sun, Ja

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-13 Thread Limonciello, Mario
On 1/13/2023 13:28, Lyude Paul wrote: On Fri, 2023-01-13 at 11:25 +0100, Daniel Vetter wrote: On Fri, Jan 13, 2023 at 12:16:57PM +0200, Jani Nikula wrote: Cc: intel-gfx, drm maintainers Please have the courtesy of Cc'ing us for changes impacting us, and maybe try to involve us earlier

RE: Coverity: dm_dmub_sw_init(): Incorrect expression

2023-01-12 Thread Limonciello, Mario
[AMD Official Use Only - General] This particular one was fixed already in https://patchwork.freedesktop.org/patch/518050/ which got applied today. > -Original Message- > From: coverity-bot > Sent: Thursday, January 12, 2023 16:25 > To: Limonciello, Mario >

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-12 Thread Limonciello, Mario
On 1/12/2023 02:50, Wayne Lin wrote: This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why] Changes cause regression on amdgpu mst. E.g. In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload one by one and call fill_dc_mst_payload_table_from_drm() to update

RE: [PATCH] drm/amd: Only load TA microcode for psp v12_0 once

2023-01-10 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Tuesday, January 10, 2023 13:29 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amd: Only load TA microcode for psp v12_0 once > > On T

RE: [PATCH v7 20/45] drm/amd: Parse both v1 and v2 TA microcode headers using same function

2023-01-09 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 5, 2023 21:27 > To: Limonciello, Mario ; Deucher, Alexander > ; linux-ker...@vger.kernel.org > Cc: Javier Martinez Canillas ; Carlos Soriano Sanchez > ; amd-gfx@

RE: [PATCH v2] drm/amd/amdgpu: Fix an uninitialized variable

2023-01-09 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Monday, January 9, 2023 10:04 > To: SHANMUGAM, SRINIVASAN > Cc: Wentland, Harry ; Deucher, Alexander > ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org; Limonciello, > Mario > Subject: Re: [PA

RE: [PATCH v6 20/45] drm/amd: Parse both v1 and v2 TA microcode headers using same function

2023-01-05 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 5, 2023 07:22 > To: Limonciello, Mario ; Deucher, Alexander > ; linux-ker...@vger.kernel.org > Cc: Javier Martinez Canillas ; Carlos Soriano Sanchez > ; amd-gfx@

RE: [PATCH v5 10/45] drm/amd: Load VCN microcode during early_init

2023-01-04 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Wednesday, January 4, 2023 11:16 > To: Limonciello, Mario > Cc: Deucher, Alexander ; linux- > ker...@vger.kernel.org; Pan, Xinhui ; Lazar, Lijo > ; Javier Martinez Canillas ; dri- > de...@lists.

RE: [PATCH v4 27/27] drm/amd: Optimize SRIOV switch/case for PSP microcode load

2023-01-04 Thread Limonciello, Mario
[Public] > -Original Message- > From: Christian König > Sent: Wednesday, January 4, 2023 07:18 > To: Limonciello, Mario ; Deucher, Alexander > ; linux-ker...@vger.kernel.org > Cc: Pan, Xinhui ; Lazar, Lijo ; > Javier Martinez Canillas ; dri- > de...@lists.

Re: drm/amdgpu: skip mes self test after s0i3 resume for MES IP v11.0

2022-12-19 Thread Limonciello, Mario
On 12/19/2022 06:12, Tim Huang wrote: MES is part of gfxoff for S0i3 and does not require self-test after S0i3. Besides, self-test will free the BO that triggers a wraning while in the suspend state. [ 81.656085] WARNING: CPU: 2 PID: 1550 at drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:425

  1   2   3   >