Re: [PATCH v0 04/14] media: au0828: Make I2C terminology more inclusive

2024-05-03 Thread Mauro Carvalho Chehab
Em Fri, 29 Mar 2024 17:00:28 + Easwar Hariharan escreveu: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT

Re: scripts/kernel-doc does not handle duplicate struct & function names (e.g., in amdgpu)

2023-07-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Jul 2023 20:45:18 -0700 Randy Dunlap escreveu: > On 7/11/23 20:32, Akira Yokosawa wrote: > > Hi Randy, > > > >> [just documenting this for posterity or in case someone wants to fix it.] > >> > >> In drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c, one can find both > >> > >> struct

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
obably the issue was due to some badly solved merge conflict. Thank you! Mauro > > Alex > > > > > > I will double check drm-tip once more. > > > > Regards, > > Christian. > > > > Am 14.07.22 um 14:54 schrieb Mauro Carvalho Chehab: &g

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Thu, 14 Jul 2022 15:08:48 +0200 Christian König wrote: > Hi Mauro, > > well the last time I checked drm-tip was clean. > > The revert is necessary because we had some problems with the commit > which we couldn't fix in the 5.19 cycle. I see. I don't have any issues with the patch itself,

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Fri, 8 Jul 2022 03:21:24 -0700 Arunpravin Paneer Selvam wrote: > This reverts the following commits: > commit 708d19d9f362 ("drm/amdgpu: move internal vram_mgr function into the C > file") > commit 5e3f1e7729ec ("drm/amdgpu: fix start calculation in > amdgpu_vram_mgr_new") > commit

[PATCH 09/22] drm: amdgpu: amdgpu_dm: fix kernel-doc markups

2022-06-28 Thread Mauro Carvalho Chehab
' not described in 'amdgpu_display_manager' Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mche...@kernel.org/ drivers/gpu/drm/amd/display

[PATCH 11/22] drm: amd: amd_shared.h: Add missing doc for PP_GFX_DCS_MASK

2022-06-28 Thread Mauro Carvalho Chehab
This symbol is missing documentation: drivers/gpu/drm/amd/include/amd_shared.h:224: warning: Enum value 'PP_GFX_DCS_MASK' not described in enum 'PP_FEATURE_MASK' Document it. Fixes: 680602d6c2d6 ("drm/amd/pm: enable DCS") Signed-off-by: Mauro Carvalho Chehab --- To avoid m

[PATCH 10/22] drm: amdgpu: amdgpu_device.c: fix a kernel-doc markup

2022-06-28 Thread Mauro Carvalho Chehab
The function was renamed without renaming also kernel-doc markup: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5095: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead Signed-off-by: Mauro Carvalho Chehab --- To avoid

[PATCH 00/22] Fix kernel-doc warnings at linux-next

2022-06-28 Thread Mauro Carvalho Chehab
/sta_info.h:569: warning: Function parameter or member 'cur_max_bandwidth' not described in 'link_sta_info' Mauro Carvalho Chehab (22): net: cfg80211: fix kernel-doc warnings all over the file net: mac80211: add a missing comma at kernel-doc markup net: mac80211: sta_info: fix a missing kernel

[PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Mauro Carvalho Chehab
There are some places at drm that ended receiving a REPLACEMENT CHARACTER U+fffd ('�'), probably because of some bad charset conversion. Fix them by using what it seems to be the proper character. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/include/atombios.h | 10

[PATCH 00/10] Fix documentation warnings at linux-next

2021-01-13 Thread Mauro Carvalho Chehab
warnings were introduced. Regards, Mauro Mauro Carvalho Chehab (10): doc/zh_CN: fix Sphinx errors ABI: sysfs-fs-f2fs: fix a table identation KVM: x86: hyper-v: add a blank line to remove building warnings ABI: sysfs-firmware-sgi_uv docs: fpga: dfl.rst: Fix a couple building issues drm: amd

[PATCH 06/10] drm: amd: amdgpu_dm.h: fix a wrong kernel-doc markup

2021-01-13 Thread Mauro Carvalho Chehab
: warning: Function parameter or member 'active_vblank_irq_count' not described in 'amdgpu_display_manager' Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH 2/2] drm: amdgpu: fix a kernel-doc markup

2020-12-02 Thread Mauro Carvalho Chehab
The function name at kernel-doc markup doesn't match the name of the function: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1534: warning: expecting prototype for amdgpu_debugfs_print_bo_info(). Prototype was for amdgpu_bo_print_info() instead Fix it. Signed-off-by: Mauro Carvalho

[PATCH 0/2] Fix some kernel-doc markups with wrong identifiers

2020-12-02 Thread Mauro Carvalho Chehab
address them. Mauro Carvalho Chehab (2): asm: sgx.h: fix a typo on a kernel-doc markup drm: amdgpu: fix a kernel-doc markup arch/x86/include/uapi/asm/sgx.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.28.0

[PATCH v3 30/32] amdgpu: fix a few kernel-doc markup issues

2020-10-27 Thread Mauro Carvalho Chehab
A kernel-doc markup can't be mixed with a random comment, as it causes parsing problems. While here, change an invalid kernel-doc markup into a common comment. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v3 28/32] drm: amdgpu_dm: fix a typo

2020-10-27 Thread Mauro Carvalho Chehab
dm_comressor_info -> dm_compressor_info The kernel-doc markup is right, but the struct itself and their references contain a typo. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

[PATCH v3 22/32] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-27 Thread Mauro Carvalho Chehab
meter for it to be the same on all functions using a pointer to struct amdgpu_device. Update the kernel-doc documentation accordingly. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

[PATCH v3 11/56] drm/amdgpu: fix some kernel-doc markups

2020-10-23 Thread Mauro Carvalho Chehab
Some functions have different names between their prototypes and the kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- include/uapi/drm/amdgpu_drm.h| 2 +- 3 files

[PATCH v3 03/56] amdgpu: fix a few kernel-doc markup issues

2020-10-23 Thread Mauro Carvalho Chehab
A kernel-doc markup can't be mixed with a random comment, as it causes parsing problems. While here, change an invalid kernel-doc markup into a common comment. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v3 02/56] drm: amdgpu_dm: fix a typo

2020-10-23 Thread Mauro Carvalho Chehab
dm_comressor_info -> dm_compressor_info The kernel-doc markup is right, but the struct itself and their references contain a typo. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

[PATCH v3 0/6] Documentation build fixes against upstream

2020-10-21 Thread Mauro Carvalho Chehab
warnings caused by patches pending merges. I'll be posting those in separate. Regards, Mauro Mauro Carvalho Chehab (6): drm: amdgpu: kernel-doc: update some adev parameters docs: lockdep-design: fix some warning issues locking/refcount: move kernel-doc markups to the proper place IB/srpt

[PATCH v3 1/6] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-21 Thread Mauro Carvalho Chehab
meter for it to be the same on all functions using a pointer to struct amdgpu_device. Update the kernel-doc documentation accordingly. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

[PATCH v2 07/24] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-13 Thread Mauro Carvalho Chehab
ation accordingly. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 5 ++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v6 72/80] drm/amd/display: kernel-doc: document force_timing_sync

2020-10-13 Thread Mauro Carvalho Chehab
4e52d0cf24 ("drm/amd/display: Add debugfs for forcing stream timing sync") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/a

Re: [PATCH v15 14/17] media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get

2019-05-24 Thread Mauro Carvalho Chehab
user_get() uses provided user pointers for vma > lookups, which can only by done with untagged pointers. > > Untag the pointers in this function. > > Signed-off-by: Andrey Konovalov Acked-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/videobuf-dma-contig.c | 9 +

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Apr 2019 16:35:34 +0100 Al Viro escreveu: > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s39

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
uble-checked all these drivers to ensure that all ioctl arguments > are used as pointers or are ignored, but are not interpreted as integer > values. > > Acked-by: Jason Gunthorpe > Acked-by: Daniel Vetter > Acked-by: Mauro Carvalho Chehab > Acked-by: Greg Kroah-Hartman > A

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Mauro Carvalho Chehab
e controller codes to adjust the air conditioning system ;-) From lirc driver's PoV, there's nothing that really prevents one to do that and use lirc API, and the driver is generic enough to work on any hardware platform. I didn't check the implementation of generic_c

allmodconfig/allyesconfig doesn't work with Kernel 4.18 - Was: Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled

2018-08-15 Thread Mauro Carvalho Chehab
Em Sat, 11 Aug 2018 17:54:12 +0200 Arnd Bergmann escreveu: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > >

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-19 Thread Mauro Carvalho Chehab
e gnu complexity to work > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches <j...@perches.com> For the media patch: Acked-by: Mauro Carvalho Chehab <mche...@s-op

Re: [PATCH 00/18] use ARRAY_SIZE macro

2017-10-03 Thread Mauro Carvalho Chehab
Em Sun, 1 Oct 2017 20:52:20 -0400 Jérémy Lefaure escreveu: > Anyway, I can tell to each maintainer that they can apply the patches > they're concerned about and next time I may send individual patches. In the case of media, we'll handle it as if they were individual