Re: [PATCH v3 5/7] PCI: ACPI: Detect PCIe root ports that are used for tunneling

2023-11-16 Thread Mika Westerberg
Hi Mario, On Tue, Nov 14, 2023 at 02:07:53PM -0600, Mario Limonciello wrote: > USB4 routers support a feature called "PCIe tunneling". This > allows PCIe traffic to be transmitted over USB4 fabric. > > PCIe root ports that are used in this fashion can be discovered > by device specific data that

Re: [PATCH v3 5/7] PCI: ACPI: Detect PCIe root ports that are used for tunneling

2023-11-16 Thread Mika Westerberg
Hi Mario, On Wed, Nov 15, 2023 at 11:08:43AM -0600, Mario Limonciello wrote: > On 11/15/2023 04:40, Mika Westerberg wrote: > > Hi Mario, > > > > On Tue, Nov 14, 2023 at 02:07:53PM -0600, Mario Limonciello wrote: > > > USB4 routers support a feature called "PCIe

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-07 Thread Mika Westerberg
On Tue, Nov 07, 2023 at 07:45:26AM +0200, Mika Westerberg wrote: > Hi, > > On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > > Tangentially related; the link speed is currently symmetric

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-07 Thread Mika Westerberg
Hi, On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > Tangentially related; the link speed is currently symmetric but there are > > two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may > >

Re: [PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Mika Westerberg
On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: > On Fri, 3 Nov 2023, Mario Limonciello wrote: > > > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > > using dev_is_removable() to be able to detect USB4 devices as well. > > Please extend this with more

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-03-01 Thread Mika Westerberg
Hi, On Mon, Feb 28, 2022 at 10:36:59PM +, Limonciello, Mario wrote: > [AMD Official Use Only] > > > -Original Message- > > From: Lukas Wunner > > Sent: Monday, February 28, 2022 16:33 > > To: Bjorn Helgaas > > Cc: Limonciello, Mario ; Mika Weste

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Mika Westerberg
Hi Bjorn, On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-facing" > assumption above. Not having a Thunderbolt spec, I have no idea how > you deal with that. You can download the spec here:

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-17 Thread Mika Westerberg
Hi Mario, On Wed, Feb 16, 2022 at 10:50:31AM -0600, Limonciello, Mario wrote: > On 2/16/2022 08:44, Alex Deucher wrote: > > On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg > > wrote: > > > > > > Hi all, > > > > > > On Tue, Feb 15,

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-16 Thread Mika Westerberg
Hi all, On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote: > On 2/15/2022 01:29, Lukas Wunner wrote: > > On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- > > > drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
On Mon, Feb 14, 2022 at 01:11:05PM +0200, Mika Westerberg wrote: > > > It is used to identify "tunneled" ports (whether PCIe, USB 3.x or > > > DisplayPort). Tunnels are created by software (in Linux it is the > > > Thunderbolt driver) and are dynamic in nat

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
On Mon, Feb 14, 2022 at 09:52:02AM +0100, Lukas Wunner wrote: > On Mon, Feb 14, 2022 at 09:34:26AM +0200, Mika Westerberg wrote: > > On Fri, Feb 11, 2022 at 03:45:46PM -0600, Bjorn Helgaas wrote: > > > My expectation is that "USB" (like "PCI" and "PCIe&qu

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-14 Thread Mika Westerberg
Hi, On Sun, Feb 13, 2022 at 09:39:28AM +0100, Lukas Wunner wrote: > On Fri, Feb 11, 2022 at 12:23:51PM +0200, Mika Westerberg wrote: > > On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > > > @@ -2955,7 +2955,7 @@ bool pci_bridge_d3_possible(stru

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
> > This can be done by looking for the device property specified in > > the ACPI tables `usb4-host-interface`. > > > > Suggested-by: Mika Westerberg > > Link: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#mappin

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-14 Thread Mika Westerberg
Hi Lukas, On Sun, Feb 13, 2022 at 10:19:20AM +0100, Lukas Wunner wrote: > On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: > > `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt > > controller to indicate that D3 is possible. As this is used solely > > for

Re: [PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-14 Thread Mika Westerberg
Hi Mario, On Sun, Feb 13, 2022 at 11:26:56AM -0600, Limonciello, Mario wrote: > On 2/13/2022 02:20, Lukas Wunner wrote: > > On Fri, Feb 11, 2022 at 01:32:42PM -0600, Mario Limonciello wrote: > > > The `is_thunderbolt` attribute is currently a dumping ground for a > > > variety of things. > > > >

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-14 Thread Mika Westerberg
> controller to indicate that D3 is possible. As this is used solely > > > for older Apple systems, move it into a quirk that enumerates across > > > all Intel TBT controllers. > > > > > > Suggested-by: Mika Westerberg > > > Signe

Re: [PATCH v2 4/9] PCI: mark USB4 devices as removable

2022-02-11 Thread Mika Westerberg
Hi Mario, On Thu, Feb 10, 2022 at 04:43:24PM -0600, Mario Limonciello wrote: > USB4 class devices are also removable like Intel Thunderbolt devices. > > Drivers of downstream devices use this information to declare functional > differences in how the drivers perform by knowing that they are

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-11 Thread Mika Westerberg
Hi Mario, On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > The `is_thunderbolt` attribute is currently a dumping ground for a > variety of things. > > Instead use the driver core removable attribute to indicate the > detail a device is attached to a thunderbolt or USB4 chain.

Re: [PATCH v2 1/9] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

2022-02-11 Thread Mika Westerberg
> Acked-by: Alex Deucher > Signed-off-by: Mario Limonciello Acked-by: Mika Westerberg

Re: close() on some Intel CNP-LP PCI devices takes up to 2.7 s

2020-06-10 Thread Mika Westerberg
On Wed, Jun 10, 2020 at 08:18:07AM +0200, Paul Menzel wrote: > Thank you for replying so quickly. Hopefully, I’ll be able to test the > commit tomorrow. > > One question though. The commit talks about resuming from suspend. I > understand that training happens there. > > In my case the system is

Re: close() on some Intel CNP-LP PCI devices takes up to 2.7 s

2020-06-09 Thread Mika Westerberg
On Tue, Jun 09, 2020 at 05:39:21PM +0200, Paul Menzel wrote: > Dear Linux folks, > > > On the Intel Cannon Point-LP laptop Dell Precision 3540 with a dedicated AMD > graphics card (both graphics devices can be used) with Debian Sid/unstable > with Linux 5.6.14, running lspci takes quite some