Re: [PATCH v3] drm/amdgpu: Fix the BO release clear memory warning

Hi Christian, On 6/10/2024 11:35 PM, Christian König wrote: Am 10.06.24 um 20:04 schrieb Arunpravin Paneer Selvam: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling

Re: [PATCH] drm/amdgpu: Fix the BO release clear memory warning

Hi Christian, On 5/7/2024 8:21 PM, Christian König wrote: Am 06.05.24 um 15:48 schrieb Arunpravin Paneer Selvam: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

Hi Dave, Please help pull this patch into drm-next. This will fix any unnecessary warnings in memory pressure situation. Thanks for the help. Regards, Arun. On 5/17/2024 8:03 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont

Re: 6.10/regression/bisected - commit a68c7eaa7a8f cause *ERROR* Trying to clear memory with ring turned off in amdgpu_fill_buffer.

On 5/17/2024 6:56 PM, Mikhail Gavrilov wrote: Hi, I am continuing to test unstable kernels. Yesterday at Fedora Rawhide arrived the new kernel 20240516git3c999d1ae3c7 and I spotted in kernel log new error message: [ 13.676117] [drm] Seamless boot condition check passed [ 13.676996]

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

On 5/17/2024 7:30 PM, Matthew Auld wrote: On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

Hi Matthew, This fixes the problem. Regards, Arun. On 5/17/2024 7:20 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

Hi Matthew, Could you help review this patch quickly. Hi Dave This patch just fixes the unnecessary warn on's triggered during the force_merge call. Regards, Arun. On 5/17/2024 6:08 PM, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e) on

Re: [PATCH v2 2/2] drm/tests: Add a unit test for range bias allocation

Hi Matthew, On 5/13/2024 1:49 PM, Matthew Auld wrote: On 12/05/2024 08:59, Arunpravin Paneer Selvam wrote: Allocate cleared blocks in the bias range when the DRM buddy's clear avail is zero. This will validate the bias range allocation in scenarios like system boot when no cleared blocks are

Re: [PATCH] drm/buddy: Fix the range bias clear memory allocation issue

Hi Daniel, On 5/8/2024 2:11 PM, Daniel Vetter wrote: On Wed, May 08, 2024 at 12:27:20PM +0530, Arunpravin Paneer Selvam wrote: Problem statement: During the system boot time, an application request for the bulk volume of cleared range bias memory when the clear_avail is zero, we dont fallback

Re: Splat during driver probe

Hi Alex, yes, this is related to memory clearing changes. This is a known issue. I am working on a fix. Thanks, Arun. On 5/3/2024 6:46 PM, Alex Deucher wrote: Possibly related to Arun's new memory clearing changes. @Arunpravin can you take a look? Alex On Fri, May 3, 2024 at 9:10 AM Tvrtko

Re: [PATCH v3] drm/amdgpu: Modify the contiguous flags behaviour

Hi Christian, On 4/24/2024 2:02 PM, Christian König wrote: Am 24.04.24 um 09:13 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

Hi Philip, On 4/17/2024 8:58 PM, Philip Yang wrote: On 2024-04-17 10:32, Paneer Selvam, Arunpravin wrote: Hi Christian, On 4/17/2024 6:57 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 4/17/2024 12:19 PM, Christian König wrote: Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

Hi Christian, On 4/17/2024 6:57 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 4/17/2024 12:19 PM, Christian König wrote: Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

Hi Christian, On 4/17/2024 12:19 PM, Christian König wrote: Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

Hi Christian, On 4/16/2024 6:24 PM, Christian König wrote: Am 16.04.24 um 14:34 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a chance that we will access the previous application data and this would leads to an abnormal behaviour in the current

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

Hi Christian, On 4/16/2024 1:16 PM, Christian König wrote: Am 16.04.24 um 00:02 schrieb Philip Yang: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

On 4/16/2024 3:32 AM, Philip Yang wrote: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

Hi Christian, On 4/15/2024 7:33 PM, Christian König wrote: Am 14.04.24 um 16:57 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS

Re: [PATCH v11 1/3] drm/buddy: Implement tracking clear page feature

Hi Christian, Could you please push these patches into drm branch. Thanks, Arun. On 4/15/2024 2:53 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the

Re: [PATCH v10 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, On 4/10/2024 6:22 PM, Matthew Auld wrote: On 08/04/2024 16:16, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

Re: [PATCH v10 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, Could you please review these changes as few clients are waiting for these patches. Thanks, Arun. On 4/8/2024 8:46 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, On 3/28/2024 10:18 PM, Matthew Auld wrote: On 28/03/2024 16:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

Hi Alex, On 3/26/2024 8:23 PM, Alex Deucher wrote: On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that.

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, ping? Thanks, Arun. On 3/19/2024 3:10 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. -

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

Hi Christian, On 3/19/2024 7:17 PM, Christian König wrote: Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):    - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that.   

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, On 3/6/2024 11:19 PM, Matthew Auld wrote: On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

Hi Matthew, Ping? Thanks, Arun. On 3/4/2024 10:02 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. -

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 +++--  

Re: [PATCH v7 3/3] drm/buddy: Add defragmentation support

Hi Matthew, On 2/22/2024 12:12 AM, Matthew Auld wrote: On 21/02/2024 12:18, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1:    - Defragment the memory beginning from min_order till the required memory space is available. v2(Matthew):    - add amdgpu user

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as

RE: [PATCH] [RFC] drm/drm_buddy fails to initialize on 32-bit architectures

Mailing List ; Paneer Selvam, Arunpravin Subject: Re: [PATCH] [RFC] drm/drm_buddy fails to initialize on 32-bit architectures Hi, Ping? This is actually a regression. If there is no one available to work this, maybe I can have a look in my spare time, in accordance with your suggestion. Regards

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

[AMD Official Use Only - General] Hi Christian, If this change is possible, I think it would improve the performance by eliminating the frequent BO eviction when there is a memory pressure. Thanks, Arun. Get Outlook for Android

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

eucher ; Zhang, Jesse(Jie) Cc: Zhang, Yifan ; amd-gfx ; Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed I would go a step further and just allow GTT domain on

RE: [PATCH] drm/ttm: fix bulk move handling v2

[AMD Official Use Only - General] Hi Christian, I verified the patch, I don’t see the crashes. Reviewed-by: Arunpravin Paneer Selvam Thanks, Arun -Original Message- From: Christian König Sent: Monday, June 13, 2022 1:38 PM To: Paneer Selvam, Arunpravin ; m...@fireburn.co.uk; amd

RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

: Monday, May 16, 2022 8:36 PM To: Mike Lothian Cc: Paneer Selvam, Arunpravin ; Intel Graphics Development ; amd-gfx list ; Maling list - DRI developers ; Deucher, Alexander ; Koenig, Christian ; Matthew Auld Subject: Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu On Mon, May 16, 2022

RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

[AMD Official Use Only - General] Hi Christian, I will check this issue. Regards, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, April 26, 2022 10:06 PM To: Mike Lothian ; Paneer Selvam, Arunpravin Cc: intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org

RE: [drm/selftests] 39ec47bbfd: kernel_BUG_at_drivers/gpu/drm/drm_buddy.c

[AMD Official Use Only] Hi Christian, I will check Thanks, Arun -Original Message- From: Koenig, Christian Sent: Monday, February 28, 2022 4:29 PM To: kernel test robot ; Paneer Selvam, Arunpravin Cc: 0day robot ; Matthew Auld ; LKML ; l...@lists.01.org; dri-de

RE: [PATCH v9 1/6] drm: move the buddy allocator from i915 into common drm

and forth. Let me know when there are more rbs on the rest and I will push that as well. Thanks, Christian. -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, January 19, 2022 12:54 PM To: Paneer Selvam, Arunpravin ; dri-de...@lists.freedesktop.org; intel

RE: [PATCH v4 4/6] drm: implement a method to free unused pages

[Public] Hi Matthew, Ping? Regards, Arun -Original Message- From: Paneer Selvam, Arunpravin Sent: Wednesday, December 1, 2021 10:10 PM To: dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: matthew.a...@intel.com; dan...@ffwll.ch

RE: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

; Paneer Selvam, Arunpravin ; jani.nik...@linux.intel.com; matthew.a...@intel.com; tzimmerm...@suse.de; Deucher, Alexander ; Koenig, Christian Subject: [PATCH v4 2/6] drm: improve drm_buddy_alloc function - Make drm_buddy_alloc a single function to handle range allocation and non-range

RE: [PATCH 1/2] Enable buddy memory manager support

ch public function Thanks, Arun -Original Message- From: Koenig, Christian Sent: Wednesday, September 22, 2021 12:28 PM To: Paneer Selvam, Arunpravin ; dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; matthew.a...@intel.com; dan...

RE: [PATCH 1/2] Enable buddy memory manager support

[AMD Public Use] Hi Alex, I will fix the name and send a document in my next version. Thanks, Arun -Original Message- From: Alex Deucher Sent: Tuesday, September 21, 2021 12:54 AM To: Paneer Selvam, Arunpravin Cc: Maling list - DRI developers ; Intel Graphics Development ; amd-gfx

RE: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

[AMD Public Use] Hi Christian, Thanks for the review, I will the send the next version fixing all issues. Regards, Arun -Original Message- From: Christian König Sent: Wednesday, September 22, 2021 12:18 PM To: Paneer Selvam, Arunpravin ; Koenig, Christian ; dri-de

RE: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

[AMD Public Use] Hi Christian, Please find my comments. Thanks, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, September 21, 2021 2:34 PM To: Paneer Selvam, Arunpravin ; dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org

RE: [PATCH 1/8] drm/amdgpu: new resource cursor

[AMD Public Use] Hi Christian, Reviewed the changes, it looks good to me. Reviewed-by: Arunpravin Thanks, Arun -Original Message- From: Christian König Sent: Friday, March 12, 2021 4:22 PM To: Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm

RE: [PATCH] drm/amd/pm/swsmu: clean up user profile function

[AMD Public Use] -Original Message- From: Quan, Evan Sent: Tuesday, March 2, 2021 6:54 AM To: Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Paneer Selvam, Arunpravin Subject: RE: [PATCH] drm/amd/pm/swsmu: clean up user profile