Re: [PATCH] drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

2024-01-10 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Christian König Sent: Wednesday, January 10, 2024 9:31 AM To: Lazar, Lijo ; Chai, Thomas ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: revert "Adjust removal control flow fo

[PATCH] drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

2024-01-10 Thread Christian König
Calling amdgpu_device_ip_resume_phase1() during shutdown leaves the HW in an active state and is an unbalanced use of the IP callbacks. Using the IP callbacks like this can lead to memory leaks, double free and imbalanced reference counters. Leaving the HW in an active state can lead to DMA