Re: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442

2024-03-15 Thread Lazar, Lijo
ailto:asher.s...@amd.com>>; Deucher, Alexander > <_Alexander.Deucher@amd.com_ <mailto:alexander.deuc...@amd.com>> >> Subject: Re: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442 >> >> >> >> On 3/15/2024 2:46 PM, Le Ma wrote: &g

RE: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442

2024-03-15 Thread Ma, Le
Cc: Zhang, Hawking mailto:hawking.zh...@amd.com>>; > Song, Asher > mailto:asher.s...@amd.com>>; Deucher, Alexander > mailto:alexander.deuc...@amd.com>> > Subject: Re: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442 > > > > On 3/15/2024 2:

Re: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442

2024-03-15 Thread Lazar, Lijo
On 3/15/2024 3:43 PM, Lazar, Lijo wrote: > > > On 3/15/2024 2:46 PM, Le Ma wrote: >> To fix the entity rq NULL issue. This setting has been moved to upper level. >> > > Need to call amdgpu_ttm_set_buffer_funcs_status(adev, true/false) in > mode-2 reset handlers as well. > Please also check

Re: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442

2024-03-15 Thread Lazar, Lijo
On 3/15/2024 2:46 PM, Le Ma wrote: > To fix the entity rq NULL issue. This setting has been moved to upper level. > Need to call amdgpu_ttm_set_buffer_funcs_status(adev, true/false) in mode-2 reset handlers as well. Thanks, Lijo > Fixes b70438004a14 ("drm/amdgpu: move buffer funcs setting

RE: [PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442

2024-03-15 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Ma, Le Sent: Friday, March 15, 2024 17:16 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Song, Asher ; Deucher, Alexander ; Ma, Le Subject: [PATCH 1/1] drm/amdgpu: drop

[PATCH 1/1] drm/amdgpu: drop setting buffer funcs in sdma442

2024-03-15 Thread Le Ma
To fix the entity rq NULL issue. This setting has been moved to upper level. Fixes b70438004a14 ("drm/amdgpu: move buffer funcs setting up a level") Signed-off-by: Le Ma --- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-)