[PATCH] drm/amdkfd: reserve the BO before validating it

Fixes: 410f08516e0f ("drm/amdkfd: Move dma unmapping after TLB flush") [ 41.708711] WARNING: CPU: 0 PID: 1463 at drivers/gpu/drm/ttm/ttm_bo.c:846 ttm_bo_validate+0x146/0x1b0 [ttm] [ 41.708989] Call Trace: [ 41.708992] [ 41.708996] ? show_regs+0x6c/0x80 [ 41.709000] ?

Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

Hi Felix, On 1/10/2024 11:57 PM, Felix Kuehling wrote: > On 2024-01-10 04:39, Ma Jun wrote: >> There is following shift-out-of-bounds warning if ecode=0. >> "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned >> int'" >> >> Signed-off-by: Ma Jun >> --- >>

RE: [PATCH] drm/amd/pm: Add error log for smu v13.0.6 reset

[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, January 11, 2024 9:52 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amd/pm: Add

[PATCH] drm/amd/pm: Add error log for smu v13.0.6 reset

For all mode-2 reset fail cases, add error log. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c

Re: [PATCH] drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

[Public] Acked-by: Alex Deucher From: Christian König Sent: Wednesday, January 10, 2024 9:31 AM To: Lazar, Lijo ; Chai, Thomas ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: revert "Adjust removal control flow for smu

[PATCH v3] amd/amdkfd: Set correct svm range actual loc after spliting

While svm range partial migrating to system memory, clear dma_addr vram domain flag, otherwise the future split will get incorrect vram_pages and actual loc. After range spliting, set new range and old range actual_loc: new range actual_loc is 0 if new->vram_pages is 0. old range actual_loc is 0

[PATCH 19/19] drm/amd/display: 3.2.267

From: Martin Leung - Align the returned error code with legacy DP - Allow Z8 for multiplane configurations on DCN35 - Set default Z8 minimum residency for DCN35 - Rework DC Z10 restore - Enable Panel Replay for static screen use case - Add DP audio BW validation - Fix dml2 assigned pipe search -

[PATCH 18/19] drm/amd/display: Align the returned error code with legacy DP

From: Wayne Lin [Why] For usb4 connector, AUX transaction is handled by dmub utilizing a differnt code path comparing to legacy DP connector. If the usb4 DP connector is disconnected, AUX access will report EBUSY and cause igt@kms_dp_aux_dev fail. [How] Align the error code with the one

[PATCH 17/19] drm/amd/display: Allow Z8 for multiplane configurations on DCN35

From: Nicholas Kazlauskas [Why] Power improvement over DCN314, but also addresses a functional issue where plane_state remains uncleared on pipes that aren't actually active. [How] Update the check to allow for zero streams to be treated as z8 allow. Update the check to remove plane count on

[PATCH 16/19] drm/amd/display: Set default Z8 minimum residency for DCN35

From: Nicholas Kazlauskas [Why & How] Match DCN314's policy. Reviewed-by: Gabe Teeger Reviewed-by: Charlene Liu Acked-by: Alex Hung Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 15/19] drm/amd/display: Rework DC Z10 restore

From: Nicholas Kazlauskas [Why] The call currently does two things: 1. Exits DMCUB from idle optimization if it was in 2. Checks DMCUB scratch register to determine if we need to call DMCUB to do deferred HW restore and then sends the command if it's ready for it. By doing (1) we prevent

[PATCH 14/19] drm/amd/display: Enable Panel Replay for static screen use case

From: Tom Chung [Why] Enable the Panel Replay if eDP panel and ASIC support. (prioritize Panel Replay over PSR) [How] - Setup the Panel Replay config during the device init (prioritize Panel Replay over PSR). - Separate the Replay init function into two functions

[PATCH 13/19] drm/amd/display: Add DP audio BW validation

From: George Shen [Why] Timings with small HBlank (such as CVT RBv2) can result in insufficient HBlank bandwidth for audio SDP transmission when DSC is active. This will cause some higher bandwidth audio modes to fail. The combination of CVT RBv2 timings + DSC can commonly be encountered in MST

[PATCH 12/19] drm/amd/display: Fix dml2 assigned pipe search

From: Dmytro Laktyushkin [Why & How] DML2 currently finds assigned pipes in array order rather than the existing linked list order. This results in rearranging pipe order on flip and more importantly otg inst and pipe idx mismatch. This change preserves the order of existing pipes and

[PATCH 11/19] drm/amd/display: Ensure populate uclk in bb construction

From: Alvin Lee [Description] - For some SKUs, the optimal DCFCLK for each UCLK is less than the smallest DCFCLK STA target due to low memory bandwidth. There is an assumption that the DCFCLK STA targets will always be less than one of the optimal DCFCLK values, but this is not true for

[PATCH 10/19] drm/amd/display: Update P010 scaling cap

From: Charlene Liu [Why] Keep the same as previous APU and also insert clock dump Reviewed-by: Ovidiu Bunea Acked-by: Alex Hung Signed-off-by: Charlene Liu --- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 25 +-- .../dc/resource/dcn35/dcn35_resource.c| 2 +- 2

[PATCH 09/19] drm/amd/display: Reenable windowed mpo odm support

From: Wenjing Liu [Why] The feature was disabled due to regression found during testing. Now that all the pending issues are addressed, we are reenabling the power saving feature again. The feature optimizes dispclk level when user is using MPO capable broswers or watching MPO capable videos in

[PATCH 08/19] drm/amd/display: Fix DML2 watermark calculation

From: Ovidiu Bunea [Why] core_mode_programming in DML2 should output watermark calculations to locals, but it incorrectly uses mode_lib [How] update code to match HW DML2 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Charlene Liu Acked-by: Alex Hung

[PATCH 07/19] drm/amd/display: Clear OPTC mem select on disable

From: Ilya Bakoulin [Why] Not clearing the memory select bits prior to OPTC disable can cause DSC corruption issues when attempting to reuse a memory instance for another OPTC that enables ODM. [How] Clear the memory select bits prior to disabling an OPTC. Cc: Mario Limonciello Cc: Alex

[PATCH 06/19] drm/amd/display: Floor to mhz when requesting dpp disp clock changes to SMU

From: Wenjing Liu [Why] SMU uses discrete dpp and disp clock levels. When we submit SMU request for clock changes in Mhz we need to floor the requested value from Khz so SMU will choose the next higher clock level in Khz to set. If we ceil to Mhz, SMU will have to choose the next higher clock

[PATCH 05/19] drm/amd/display: Port DENTIST hang and TDR fixes to OTG disable W/A

From: Nicholas Kazlauskas [Why] We can experience DENTIST hangs during optimize_bandwidth or TDRs if FIFO is toggled and hangs. [How] Port the DCN35 fixes to DCN314. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Charlene Liu Acked-by: Alex Hung

[PATCH 04/19] drm/amd/display: Add logging resource checks

From: Charlene Liu [Why] When mapping resources, resources could be unavailable. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Sung joon Kim Acked-by: Alex Hung Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +++-

[PATCH 03/19] drm/amd/display: Add Replay IPS register for DMUB command table

From: Alvin Lee - Introduce a new Replay mode for DMUB version 0.0.199.0 Reviewed-by: Martin Leung Acked-by: Alex Hung Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 02/19] drm/amd/display: Init link enc resources in dc_state only if res_pool presents

From: Dillon Varone [Why & How] res_pool is not initialized in all situations such as virtual environments, and therefore link encoder resources should not be initialized if res_pool is NULL. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Martin Leung

[PATCH 01/19] drm/amd/display: Allow IPS2 during Replay

From: Nicholas Kazlauskas [Why & How] Add regkey to block video playback in IPS2 by default Allow idle optimizations in the same spot we allow Replay for video playback usecases. Avoid sending it when there's an external display connected by modifying the allow idle checks to check for active

[PATCH 00/19] DC Patches January 10, 2024

This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes on DCN35 and DML2. * Enhancements in DMUB. * Improvements on IPS, DP and MPO and others. Cc: Daniel Wheeler Alvin Lee (2): drm/amd/display: Add Replay IPS register for DMUB command table

RE: Documentation for RGB strip on RX 7900 XTX (Reference)

[Public] > -Original Message- > From: amd-gfx On Behalf Of > Alexander Koskovich > Sent: Tuesday, January 9, 2024 9:21 PM > To: Christian König > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: Documentation for RGB strip on RX 7900 XTX (Reference) > > Are there any userspace utilities

[PATCH] drm/amd/display: Avoid enum conversion warning

} --- base-commit: 6e7a29f011ac03a765f53844f7c3f04cdd421715 change-id: 20240110-amdgpu-display-enum-enum-conversion-e2451adbf4a7 Best regards, -- Nathan Chancellor

RE: Documentation for RGB strip on RX 7900 XTX (Reference)

[Public] > -Original Message- > From: Alexander Koskovich > Sent: Tuesday, January 9, 2024 6:01 PM > To: Deucher, Alexander > Cc: amd-gfx@lists.freedesktop.org > Subject: RE: Documentation for RGB strip on RX 7900 XTX (Reference) > > I initially tried reaching out to the Coolermaster

Re: [PATCH v2] amd/amdkfd: Set correct svm range actual loc after spliting

On 2024-01-10 11:30, Felix Kuehling wrote: On 2024-01-09 15:05, Philip Yang wrote: After svm range partial migrating to system memory, unmap to cleanup the corresponding dma_addr vram domain flag, otherwise the

RE: [PATCH] drm/amdgpu: drop exp hw support check for GC 9.4.3

[Public] Ping! > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, January 9, 2024 10:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu: drop exp hw support check for GC 9.4.3 > > No longer needed. > > Signed-off-by: Alex

Re: [PATCH] Revert "drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole"

It looks like this would cause failures even with regular 64-bit allocations because the virtual address range allocator in libdrm asks the kernel what ranges of addresses are free, and the kernel doesn't exclude the KFD allocation from that. Basically, no VM allocations can be done by the kernel

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

Hi Werner, mið., 10. jan. 2024 kl. 13:14 skrifaði Werner Sembach : > > Hi, > > Am 10.01.24 um 14:09 schrieb Daniel Vetter: > > On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: > >> mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : > >>> On Tue, Jan 09, 2024 at 06:11:00PM +, Andri

Re: [PATCH v2] amd/amdkfd: Set correct svm range actual loc after spliting

On 2024-01-09 15:05, Philip Yang wrote: After svm range partial migrating to system memory, unmap to cleanup the corresponding dma_addr vram domain flag, otherwise the future split will get incorrect vram_pages and actual loc. After range spliting, set new range and old range actual_loc: new

Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

On 2024-01-10 04:39, Ma Jun wrote: There is following shift-out-of-bounds warning if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: Ma Jun --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2] drm/amdkfd: Fix variable dereferenced before NULL check in 'kfd_dbg_trap_device_snapshot()'

Fixes the below: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_debug.c:1024 kfd_dbg_trap_device_snapshot() warn: variable dereferenced before check 'entry_size' (see line 1021) Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - Changed from u32

[PATCH] drm/amd/display: Fix late derefrence 'dsc' check in 'link_set_dsc_pps_packet()'

In link_set_dsc_pps_packet(), 'struct display_stream_compressor *dsc' was dereferenced in a DC_LOGGER_INIT(dsc->ctx->logger); before the 'dsc' NULL pointer check. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:905 link_set_dsc_pps_packet() warn: variable dereferenced

Re: [PATCH] drm/amdkfd: Fix 'node' NULL check in 'svm_range_get_range_boundaries()'

On 2024-01-10 03:26, Srinivasan Shanmugam wrote: Range interval [start, last] is ordered by rb_tree, rb_prev, rb_next return value still needs NULL check, thus modified from "node" to "rb_node". Fixes the below: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2691

Re: [PATCH v2] amd/amdkfd: Set correct svm range actual loc after spliting

On 2024-01-09 17:29, Chen, Xiaogang wrote: On 1/9/2024 2:05 PM, Philip Yang wrote: After svm range partial migrating to system memory, unmap to cleanup the corresponding dma_addr vram domain flag, otherwise the

Re: [PATCH v2 10/14] riscv: Add support for kernel-mode FPU

On Wed, 27 Dec 2023 17:42:00 PST (-0800), samuel.holl...@sifive.com wrote: This is motivated by the amdgpu DRM driver, which needs floating-point code to support recent hardware. That code is not performance-critical, so only provide a minimal non-preemptible implementation for now.

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

Hi, mið., 10. jan. 2024 kl. 09:27 skrifaði Maxime Ripard : > On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: > > From: Werner Sembach > > > > Add a new general drm property "preferred color format" which can be used > > by userspace to tell the graphic drivers to which color

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

mið., 10. jan. 2024 kl. 13:09 skrifaði Werner Sembach : > > Hi, > > Am 10.01.24 um 11:11 schrieb Andri Yngvason: > > Hi, > > > > mið., 10. jan. 2024 kl. 09:27 skrifaði Maxime Ripard : > >> On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: > >>> From: Werner Sembach > >>> > >>> Add

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : > > On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > > + /* Extract information from crtc to communicate it to userspace as > > connector properties */ > > + for_each_new_connector_in_state(state, connector,

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

Hi, Am 10.01.24 um 14:42 schrieb Andri Yngvason: mið., 10. jan. 2024 kl. 13:09 skrifaði Werner Sembach: Hi, Am 10.01.24 um 11:11 schrieb Andri Yngvason: Hi, mið., 10. jan. 2024 kl. 09:27 skrifaði Maxime Ripard: On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: From: Werner

[PATCH] drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

Calling amdgpu_device_ip_resume_phase1() during shutdown leaves the HW in an active state and is an unbalanced use of the IP callbacks. Using the IP callbacks like this can lead to memory leaks, double free and imbalanced reference counters. Leaving the HW in an active state can lead to DMA

Re: [PATCH 2/3] arch and include: Update LLVM Phabricator links

On Tue, Jan 09, 2024 at 03:16:30PM -0700, Nathan Chancellor wrote: > reviews.llvm.org was LLVM's Phabricator instances for code review. It > has been abandoned in favor of GitHub pull requests. While the majority > of links in the kernel sources still work because of the work Fangrui > has done

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

Hi, Am 09.01.24 um 19:10 schrieb Andri Yngvason: From: Werner Sembach Add a new general drm property "active color format" which can be used by graphic drivers to report the used color format back to userspace. There was no way to check which color format got actually used on a given

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

Hi, On Wed, 10 Jan 2024 at 10:44, Daniel Vetter wrote: > On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote: > > ţri., 9. jan. 2024 kl. 22:32 skrifađi Daniel Stone : > > > How does userspace determine what's happened without polling? Will it > > > only change after an `ALLOW_MODESET`

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

Hi, Am 10.01.24 um 11:11 schrieb Andri Yngvason: Hi, mið., 10. jan. 2024 kl. 09:27 skrifaði Maxime Ripard : On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: From: Werner Sembach Add a new general drm property "preferred color format" which can be used by userspace to tell

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

Hi, Am 10.01.24 um 14:09 schrieb Daniel Vetter: On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: + /* Extract information from crtc to communicate it to userspace as

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: > > mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : > > > > On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > > > + /* Extract information from crtc to communicate it to userspace as > > > connector properties */ > >

Re: [PATCH 1/1] drm/virtio: Implement RESOURCE_GET_LAYOUT ioctl

On 2024/1/10 18:47, Daniel Vetter wrote: > On Thu, Dec 21, 2023 at 06:00:16PM +0800, Julia Zhang wrote: >> From: Daniel Stone >> >> Add a new ioctl to allow the guest VM to discover how the guest >> actually allocated the underlying buffer, which allows buffers to >> be used for GL<->Vulkan

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > From: Werner Sembach > > This commit implements the "active color format" drm property for the AMD > GPU driver. > > Signed-off-by: Werner Sembach > Signed-off-by: Andri Yngvason > Tested-by: Andri Yngvason > --- >

RE: [PATCH 2/2] drm/amdgpu: Do bad page retirement for deferred errors

[AMD Official Use Only - General] Let's drop the following message. + dev_info(adev->dev, "%ld uncorrectable hardware errors and " + "%ld deferred hardware errors detected in UMC block\n", + err_data->ue_count,

Re: [PATCH 1/1] drm/virtio: Implement device_attach

On Wed, Jan 10, 2024 at 11:46:35AM +0100, Christian König wrote: > Am 10.01.24 um 11:22 schrieb Daniel Vetter: > > On Wed, Jan 10, 2024 at 11:19:37AM +0100, Christian König wrote: > > > Am 10.01.24 um 10:56 schrieb Julia Zhang: > > > > drm_gem_map_attach() requires

Re: [PATCH 1/1] drm/virtio: Implement RESOURCE_GET_LAYOUT ioctl

On Thu, Dec 21, 2023 at 06:00:16PM +0800, Julia Zhang wrote: > From: Daniel Stone > > Add a new ioctl to allow the guest VM to discover how the guest > actually allocated the underlying buffer, which allows buffers to > be used for GL<->Vulkan interop and through standard window systems. > It's

Re: [PATCH 1/1] drm/virtio: Implement device_attach

Am 10.01.24 um 11:22 schrieb Daniel Vetter: On Wed, Jan 10, 2024 at 11:19:37AM +0100, Christian König wrote: Am 10.01.24 um 10:56 schrieb Julia Zhang: drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote: > Hi Daniel, > > þri., 9. jan. 2024 kl. 22:32 skrifaði Daniel Stone : > > > On Tue, 9 Jan 2024 at 18:12, Andri Yngvason wrote: > > > + * active color format: > > > + * This read-only property tells userspace the color format >

Re: [PATCH 1/1] drm/virtio: Implement device_attach

On Wed, Jan 10, 2024 at 11:19:37AM +0100, Christian König wrote: > Am 10.01.24 um 10:56 schrieb Julia Zhang: > > drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be > > implemented, or else return ENOSYS. Virtio has no get_sg_table > > implemented for vram object. To fix this,

Re: [PATCH 1/1] drm/virtio: Implement device_attach

On Wed, Jan 10, 2024 at 05:56:28PM +0800, Julia Zhang wrote: > drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be > implemented, or else return ENOSYS. Virtio has no get_sg_table > implemented for vram object. To fix this, add a new device_attach to > call drm_gem_map_attach()

Re: [PATCH v3] drm/amdgpu: Check extended configuration space register when system uses large bar

Am 10.01.24 um 11:13 schrieb Ma Jun: Some customer platforms do not enable mmconfig for various reasons, such as bios bug, and therefore cannot access the GPU extend configuration space through mmio. When the system enters the d3cold state and resumes, the amdgpu driver fails to resume because

Re: [PATCH 1/1] drm/virtio: Implement device_attach

Am 10.01.24 um 10:56 schrieb Julia Zhang: drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table implemented for vram object. To fix this, add a new device_attach to call drm_gem_map_attach() for shmem object and

[PATCH v3] drm/amdgpu: Check extended configuration space register when system uses large bar

Some customer platforms do not enable mmconfig for various reasons, such as bios bug, and therefore cannot access the GPU extend configuration space through mmio. When the system enters the d3cold state and resumes, the amdgpu driver fails to resume because the extend configuration space

[PATCH 1/1] drm/virtio: Implement device_attach

drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table implemented for vram object. To fix this, add a new device_attach to call drm_gem_map_attach() for shmem object and return 0 for vram object instead of calling

[PATCH 0/1] Implement device_attach for virtio gpu

To realize dGPU prime feature for virtio gpu, we are trying let dGPU import vram object of virtio gpu. But this feature would finally call function virtio_dma_buf_ops.device_attach(), which was set as drm_gem_map_attach(). drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be

Re: [PATCH v2 0/1] Implementation of resource_query_layout

I see, I will implement this. Thank you very much. On 2023/12/27 09:29, Gurchetan Singh wrote: > > > On Thu, Dec 21, 2023 at 2:01 AM Julia Zhang > wrote: > > Hi all, > > Sorry to late reply. This is v2 of the implementation of > resource_query_layout.

[PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

There is following shift-out-of-bounds warning if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: Ma Jun --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

Hi, On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: > From: Werner Sembach > > Add a new general drm property "preferred color format" which can be used > by userspace to tell the graphic drivers to which color format to use. > > Possible options are: > - auto

Re: [PATCH 3/3] drm/amdgpu: move debug options init prior to amdgpu device init

Am 09.01.24 um 11:13 schrieb Le Ma: To bring debug options into effect in early initialization phase Signed-off-by: Le Ma Reviewed-by: Christian König for this one and #1 in the series. --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 2/3 v2] drm/amdgpu: add debug flag to place fw bo on vram for frontdoor loading

Am 09.01.24 um 14:00 schrieb Le Ma: Use debug_mask=0x8 param to help isolating data path issues on new systems in early phase. v2: rename the flag for explicitness (lijo) Signed-off-by: Le Ma Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +

[PATCH 2/2] drm/amdgpu: Do bad page retirement for deferred errors

Needs to do bad page retirement for deferred errors. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c index

[PATCH 1/2] drm/amdgpu: Log deferred error separately

Separate deferred error from UE and CE and log it individually. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 11 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 116 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 6 +

[PATCH] drm/amdkfd: Fix 'node' NULL check in 'svm_range_get_range_boundaries()'

Range interval [start, last] is ordered by rb_tree, rb_prev, rb_next return value still needs NULL check, thus modified from "node" to "rb_node". Fixes the below: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2691 svm_range_get_range_boundaries() warn: can 'node' even be NULL? Suggested-by:

Re: Documentation for RGB strip on RX 7900 XTX (Reference)

Are there any userspace utilities for checking out the ATOMBIOS tables? Have never done so and all the utilities I've found online are too old for this card (at least it refuses to open the VBIOS for this card). On Tuesday, January 9th, 2024 at 3:02 AM, Christian König wrote: > > > Am

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

Hi Daniel, þri., 9. jan. 2024 kl. 22:32 skrifaði Daniel Stone : > On Tue, 9 Jan 2024 at 18:12, Andri Yngvason wrote: > > + * active color format: > > + * This read-only property tells userspace the color format > actually used > > + * by the hardware display engine "on the cable" on a

RE: Documentation for RGB strip on RX 7900 XTX (Reference)

Is the AIB/OEM for this board not AMD? https://www.amd.com/en/products/graphics/amd-radeon-rx-7900xtx On Tuesday, January 9th, 2024 at 4:53 PM, Deucher, Alexander wrote: > > > [AMD Official Use Only - General] > > > -Original Message- > > From: Alexander Koskovich

回复: Re: 回复: Re: 回复: Re: [PATCH libdrm 1/2] amdgpu: fix parameter of amdgpu_cs_ctx_create2

My plan is to obtain the process priority  and convert it into the drm-scheduler's priority, so that the user is unaware and does not need to use environment variables to set it. This is my patch:--- a/amdgpu/amdgpu_cs.c+++ b/amdgpu/amdgpu_cs.c@@ -31,6 +31,7 @@#if HAVE_ALLOCA_H# include

RE: Documentation for RGB strip on RX 7900 XTX (Reference)

I initially tried reaching out to the Coolermaster technical email, but I got no response. Is there a better contact for something like this? On Tuesday, January 9th, 2024 at 5:58 PM, Deucher, Alexander wrote: > > > [Public] > > > -Original Message- > > From: amd-gfx

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

Hi Daniel, Please excuse my misconfigured email client. HTML was accidentally enabled in my previous messages, so I'll re-send it for the benefit of mailing lists. þri., 9. jan. 2024 kl. 22:32 skrifaði Daniel Stone : > > On Tue, 9 Jan 2024 at 18:12, Andri Yngvason wrote: > > + * active color

RE: Documentation for RGB strip on RX 7900 XTX (Reference)

Doe AMD have documentation on the i2c data that gets sent currently though? I was hoping to figure out what you need to change in the command that gets sent to change stuff like brightness, color (red, green, blue), rainbow, morse code, etc. On Tuesday, January 9th, 2024 at 10:10 AM, Deucher,