[CC Kent FYI]
On 16-08-11 04:31 PM, Deucher, Alexander wrote:
>> -Original Message-
>> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
>> Of Felix Kuehling
>> Sent: Thursday, August 11, 2016 3:52 PM
>> To: Michel Dänzer;
We're reverting this commit on the KFD branch because it's causing hangs
on a bunch of HSA compute tests on CZ.
Regards,
Felix
On 16-07-28 10:19 AM, Tom St Denis wrote:
> Signed-off-by: Tom St Denis
> ---
> drivers/gpu/drm/amd/amdgpu/vi.c | 6 ++
> 1 file changed, 6
Thank you. Sorry, I already pushed it with Alex's R-B, without yours.
On 16-08-16 03:53 AM, Christian König wrote:
> Am 15.08.2016 um 23:03 schrieb Alex Deucher:
>> On Mon, Aug 15, 2016 at 3:06 PM, Felix Kuehling
>> <felix.kuehl...@amd.com> wrote:
>>> Patch a
Patch against current amd-staging-4.6 is attached.
Regards,
Felix
On 16-08-13 05:25 AM, Christian König wrote:
> Am 13.08.2016 um 01:22 schrieb Felix Kuehling:
>> [CC Kent FYI]
>>
>> On 16-08-11 04:31 PM, Deucher, Alexander wrote:
>>>> -Original Message---
One suggestion inline [FK].
With that fixed, Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
Regards,
Felix
On 16-08-17 08:26 AM, Christian König wrote:
> From: Christian König <christian.koe...@amd.com>
>
> Adding a BO can make it the insertion point for
Hi Andres,
Thank you for tackling this task. It's more involved than I expected,
mostly because I didn't have much awareness of the MQD management in amdgpu.
I made one comment in a separate message about the unified MQD commit
function, if you want to bring that more in line with our latest
Series reviewed by me as well:
Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
On 17-01-24 10:48 AM, Deucher, Alexander wrote:
>> -Original Message-
>> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
>> Of Christian König
>> Sen
On 17-01-24 10:05 AM, Xue, Ken wrote:
>> From: Christian König [mailto:deathsim...@vodafone.de]
>> Sent: Tuesday, January 24, 2017 10:09 PM
>> To: Xue, Ken; amd-gfx mailing list
>> Cc: dl.SRDC_SW_GPUVirtualization
>> Subject: Re: [PATCH] drm/amdgpu: Refine the handshake between guest and
>> server
I think Nicolai beat you to this with his patch "drm/ttm: make
TTM_MAX_BO_PRIORITY unsigned".
On 17-02-14 01:03 PM, Kent Russell wrote:
> Addresses this compile warning:
>
> warning: comparison of distinct pointer types lacks a cast [enabled by
> default]
> bo->tbo.priority =
expected value any more.
>
> I'm going to add a comment explaining that this shouldn't be moved apart.
>
> Christian.
>
> Am 17.08.2016 um 23:00 schrieb Felix Kuehling:
>> One suggestion inline [FK].
>>
>> With that fixed, Reviewed-by: Felix Kuehling <felix.kuehl..
lit over the whole address space.
>
> The problem is the importing device needs to be able to handle that as
> well.
>
> Regards,
> Christian.
>
> Am 16.08.2016 um 20:33 schrieb Felix Kuehling:
>> Very nice. I'm looking forward to this for KFD as well.
>>
>>
I looked really hard and couldn't find anything obviously broken. It
makes me a bit nervous that there is no bounds checking on the nodes
array, though.
Just one minor nit pick.
With that fixed, Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
On 16-08-29 05:20 AM, Christian König
didn't review it
too thoroughly, and if you forgot to map to GART somewhere important, I
would probably have missed it.
Acked-by: Felix Kuehling <felix.kuehl...@amd.com>
Once we pull this change into the KFD branch, we can probably revert our
ridiculous GART size without losing the ability to ma
This requires an assumption that there is no partial overlap between the
the mm_nodes in the old and new memory. As long as BOs are always split
into fixed size portions that should work OK for copying between linear
and split BOs. But it can fail if you copy between split BOs that are
split in
Some comments inline.
Would it make sense to free the GTT address space in amdgpu_ttm_unbind?
Basically the counterpart of amdgpu_gtt_mgr_alloc, call it
amdgpu_gtt_mgr_free, that frees the address space but keeps the node
allocated and sets its node->start address back to
On 16-09-27 05:49 AM, Christian König wrote:
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -1195,6 +1195,15 @@ int amdgpu_cs_sysvm_access_required(struct
> amdgpu_cs_parser *parser)
> r = amdgpu_ttm_bind(>tbo, >tbo.mem);
>
Hi Christian,
I'm back from vacation and finally caught up with my email and
code-review backlog.
I added a comment on patch 1.
I don't understand patch 2. I couldn't find where a non-0 lpfn would
trigger any reallocation. I think this would have to be somewhere in
ttm_bo_validate or
As a next step, you could also remove HDP flushing on APUs.
Regards,
Felix
On 16-11-07 04:21 AM, Christian König wrote:
> From: Christian König
>
> We don't need to use the PCI BAR on APUs. This allows us to access
> the full VRAM directly without being limited by
On 17-01-03 08:47 PM, Andres Rodriguez wrote:
> This patch series provides the initial APIs for high priority contexts.
>
> The current implementation is based on top of the SW scheduler, there
> are no HW priorities set yet.
>
> This doesn't provide the quality of service we need for VR. Further
on't use any information
about RBs.
Regards,
Felix
>
> I think we should disallow reading CC_RB_BACKEND_DISABLE and
> GC_USER_RB_BACKEND_DISABLE through this interface.
>
> Regards,
> Christian.
>
> Am 24.03.2017 um 21:08 schrieb Felix Kuehling:
>> We're repo
We're reporting gb_addr_config to user mode in our KFD tiling info API.
If this is no longer needed by user mode for soc15, we could just put in
a dummy value. However, I haven't been told that it can be removed for
older ASICs.
Regards,
Felix
On 17-03-24 03:48 PM, Alex Deucher wrote:
> On
(or masking of high bits) could be
>>> moved up
>>> to the caller.
>>>
>>> Regards,
>>>Felix
>>>
>>>
>>> --
>>> F e l i x K u e h l i n g
>>> SMTS Software Development Engineer | Vertical Workstati
This only makes a difference for 32-bit systems. The idea is to have a
fixed virtual address space size with 4-level page tables and to
minimize differences between 32 and 64-bit systems.
Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
On 17-03-30 08:23 AM, Christian König wrote:
Technically interval trees use unsigned long. That's 64-bit on a 64-bit
system. Your change is only needed if you want to use 48-bits of virtual
address space on a 32-bit system. Even with a 32-bit interval tree you
can still cover 44-bit virtual addresses.
How important is it to use the full
On 17-03-30 10:19 AM, Christian König wrote:
> Am 30.03.2017 um 16:06 schrieb Felix Kuehling:
>> Technically interval trees use unsigned long. That's 64-bit on a 64-bit
>> system. Your change is only needed if you want to use 48-bits of virtual
>> address space on a 32-bit s
On 17-03-29 12:34 PM, Christian König wrote:
> Am 29.03.2017 um 17:48 schrieb Felix Kuehling:
>> Fix the start/end address calculation for address ranges that span
>> multiple page directories in amdgpu_vm_alloc_levels.
>>
>> Add WARN_ONs if page tables aren't foun
On 17-03-29 11:22 AM, Christian König wrote:
> Am 29.03.2017 um 16:46 schrieb Michel Dänzer:
>> On 29/03/17 11:32 PM, Felix Kuehling wrote:
>>> On 17-03-29 02:52 AM, Christian König wrote:
>>>> Please clean that up and also remove all those WARN_ON(), we don't
&g
to caller
* Add range-check for "from" and "to"
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_v
on that branch.
Felix Kuehling (3):
drm/amdgpu: Make max_pfn 64-bit
drm/amdgpu: Fix Vega10 VM initialization
drm/amdgpu: Fix multi-level page table bugs for large BOs
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 -
drivers/gpu
Fix the start/end address calculation for address ranges that span
multiple page directories in amdgpu_vm_alloc_levels.
Add WARN_ONs if page tables aren't found. Otherwise the page table
update would just fail silently.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/g
With 4-level page tables the maximum VM size is 256TB. That's 64G
pages, which can't be represented in 32-bit.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +-
drivers/gpu/drm/amd/
m VM-size enforcement ahead of max_pfn
initializtion. Cast to 64-bit before the left-shift.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 17 +++--
2 files changed, 10 in
n Behalf
>>> Of Felix Kuehling
>>> Sent: Tuesday, March 28, 2017 2:10 PM
>>> To: Zhang, Jerry; amd-gfx@lists.freedesktop.org
>>> Subject: Re: [PATCH] drm/amdgpu: Improve Vega10 VM fault handling
>>>
>>>
>>> On 17-03-27 09:23 PM, Zhang,
On 17-03-27 09:23 PM, Zhang, Jerry (Junwei) wrote:
>
>
> On 03/28/2017 06:25 AM, Felix Kuehling wrote:
>> Register AMDGPU_IH_CLIENTID_UTCL2 as a source of VM faults. Clean
>> up the VM fault message format and use rate-limiting similar to
>> other ASICs.
>>
It looks like the multi-level page table changes have been submitted.
They're causing problems when we're trying to integrate them into our
KFD branch.
We resolved the obvious changes and it's working on older ASICs without
problems. But we're getting hangs on Vega10. With my patch to enable
On 17-03-28 04:25 PM, Deucher, Alexander wrote:
> Simple KFD tests that don't use the non-coherent (high) address range
> > seem to be working fine. That tells me that the multi-level page table
> > code has a problem with high addresses.
> >
> > I'll keep digging ...
>
> Do you have multiple GPUs
Register AMDGPU_IH_CLIENTID_UTCL2 as a source of VM faults. Clean
up the VM fault message format and use rate-limiting similar to
other ASICs.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 19 +--
1 file changed, 13 inse
On 17-03-31 03:15 AM, Christian König wrote:
> Am 30.03.2017 um 16:55 schrieb Felix Kuehling:
>> This only makes a difference for 32-bit systems. The idea is to have a
>> fixed virtual address space size with 4-level page tables and to
>> minimize differences between
On 17-04-09 09:28 PM, Michel Dänzer wrote:
> On 10/04/17 09:56 AM, Michel Dänzer wrote:
>> On 08/04/17 05:15 AM, Felix Kuehling wrote:
>>> Advertise CIK PCI IDs only when they are not supported by amdgpu.
>>> Use the CONFIG_DRM_AMDGPU_CIK to check so that a single opti
On 17-04-10 02:50 PM, Alex Deucher wrote:
> On Mon, Apr 10, 2017 at 2:13 PM, Felix Kuehling <felix.kuehl...@amd.com>
> wrote:
>>
>> Are there any other ideas or requests, before I go spend more time on this?
>
> In the short term, it would probably be good to jus
Provide convenient compile time and boot time options for selecting
CIK ASIC support in either or both drivers.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 10 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/d
On 17-04-08 04:50 AM, Nicolai Hähnle wrote:
> On 07.04.2017 22:15, Felix Kuehling wrote:
>> Change the wording of the CONFIG_DRM_AMDGPU_CIK option to indicate
>> that it's no longer experimental.
>>
>> Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
>
Provide convenient compile time and boot time options for selecting
CIK ASIC support in either or both drivers.
v2: git add missing files
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/Kconfig | 51 ++
drivers/gpu/drm/amd/amdgpu/K
On 17-04-10 09:42 PM, Michel Dänzer wrote:
> On 11/04/17 08:29 AM, Felix Kuehling wrote:
>> I tested this with Hawaii on the KFD branch and
>> DRM_CIK_BOTH_DEFAULT_AMDGPU. Both modules get loaded, but radeon doesn't
>> initialize the device. Amdgpu works with kfdtest.
> D
On 17-04-10 09:39 PM, Michel Dänzer wrote:
> On 11/04/17 03:13 AM, Felix Kuehling wrote:
>> On 17-04-09 09:28 PM, Michel Dänzer wrote:
>>> On 10/04/17 09:56 AM, Michel Dänzer wrote:
>>>> On 08/04/17 05:15 AM, Felix Kuehling wrote:
>>>>> Advertise
On 17-04-11 12:01 AM, Michel Dänzer wrote:
> One issue with this per-driver enable_cik option is that if the user
> only enables it in the driver where it's disabled by default, without
> also disabling it in the driver where it's enabled by default, it's back
> to the current situation where both
The amdgpu_amdkfd code you're modifying has changed a lot on the KFD
branch. I'm not sure it's worth fixing on the amdgpu branch. We'll
largely replace it when we upstream KFD changes.
I spotted an obvious bug in your patch, but it was also broken before.
See inline [FK].
On 17-04-06 02:21 AM,
See comment inline [FK].
On 17-04-06 02:21 AM, Andres Rodriguez wrote:
> Instead of picking an arbitrary queue for KIQ, search for one according
> to policy. The queue must be unused.
>
> Also report the KIQ as an unavailable resource to KFD.
>
> In testing I ran into KCQ initialization issues
What about GFX9?
See one more comment inline [FK].
On 17-04-06 02:21 AM, Andres Rodriguez wrote:
> Instead of taking the first pipe and giving the rest to kfd, take the
> first 2 queues of each pipe.
>
> Effectively, amdgpu and amdkfd own the same number of queues. But
> because the queues are
are Acked-by: Felix Kuehling <felix.kuehl...@amd.com>
5-9, 11-12, 15-16 are Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
Regards,
Felix
On 17-04-06 02:21 AM, Andres Rodriguez wrote:
> Includes fixes for Alex's comments on v7.
>
> Also includes a new patch to
I haven't reviewed this in detail. But would it make sense to squash
that into the commit that introduced the LRU policy for the queue
manager (patch 18 in this series)?
Regards,
Felix
On 17-04-06 02:21 AM, Andres Rodriguez wrote:
> Depending on usage patterns, the current LRU policy may
:21 PM, Felix Kuehling wrote:
> Provide convenient compile time and boot time options for selecting
> CIK ASIC support in either or both drivers.
>
> v2: git add missing files
>
> Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
> ---
> drivers/gpu/drm
cik_support_param, 1,
+ -32768, 32767, NULL, NULL);
+ if (r)
+ return r;
+
+ amdgpu_cik_support = !radeon_cik_support;
+#endif
+
r = amdgpu_sync_init();
if (r)
goto error_sync;
Regards,
Felix
On 17-04-20 05:25 AM, Michel Dänzer wrote:
> On 2
On 17-04-21 03:11 AM, Christian König wrote:
> Hi Alex,
>
>> No. For the current source code, I think the premap and no-op is not
>> working.
>>
> Indeed, we don't set bo->mem.bus.addr in amdgpu_ttm_io_mem_reserve()
> any more. Felix will probably want to fix that for the KFD branch.
I vaguely
On 17-04-11 10:23 PM, Michel Dänzer wrote:
> One possibility would be making each driver also parse the other
> driver's module parameter on the kernel command line. I.e. radeon would
> parse
>
> amdgpu.enable_cik=0
I looked for a way to do this. I think I figured out the parsing part.
But I
Patches 1 and 2 are Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
Note that we're making another change to this programming sequence in
the upcoming release. Conceptually the MQD represents the state of an
inactive queue. So the CP_HQD_ACTIVE and DOORBELL_EN bits should be 0 in
t
önig <christian.koe...@amd.com>
> Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
> Signed-off-by: Andres Rodriguez <andre...@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 51
> ++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_
On 17-04-21 01:01 PM, Christian König wrote:
> Am 21.04.2017 um 17:43 schrieb Felix Kuehling:
>> On 17-04-21 03:11 AM, Christian König wrote:
>>> Hi Alex,
>>>
>>>> No. For the current source code, I think the premap and no-op is not
>>>> work
On 17-04-07 12:10 PM, Christian König wrote:
> Am 07.04.2017 um 18:01 schrieb Felix Kuehling:
>> Advertise CIK PCI IDs only when they are not supported by amdgpu.
>> Use the CONFIG_DRM_AMDGPU_CIK to check so that a single option in
>> the kernel config keeps
in the
Radeon driver.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/radeon/radeon_drv.c | 3 +
include/drm/drm_pciids.h| 114 ++--
2 files changed, 61 insertions(+), 56 deletions(-)
diff --git a/drivers/gpu/drm/
Kconfig still calls CIK and SI support in amdgpu "experimental". Is that
still true? Should we stop calling it experimental if we actually want
distributions to start using it?
Regards,
Felix
On 17-04-07 03:17 PM, Alex Deucher wrote:
> On Fri, Apr 7, 2017 at 2:00 PM, F
Change the wording of the CONFIG_DRM_AMDGPU_CIK option to indicate
that it's no longer experimental.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/d
in the
Radeon driver.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/radeon/Kconfig | 12 +++
drivers/gpu/drm/radeon/radeon_drv.c | 3 +
include/drm/drm_pciids.h| 146 ++--
3 files changed, 89 insertions(+), 72 del
in the
Radeon driver.
v2: Add CONFIG_DRM_RADEON_FORCE_CIK option
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/radeon/Kconfig | 12
drivers/gpu/drm/radeon/radeon_drv.c | 3 +
include/drm/drm_pciids.h
Patches 1 and 3 are Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
I'm not sure about Patch 2. See my comment in reply to that patch.
Regards,
Felix
On 17-07-29 07:32 AM, Christian König wrote:
> From: Christian König <christian.koe...@amd.com>
>
> This s
Hi Christian,
If I'm reading this correctly, now you're only binding page directories,
but not the leaf page tables. Is that intentional?
Regards,
Felix
On 17-07-29 07:32 AM, Christian König wrote:
> From: Christian König
>
> No need to do this on every CS.
>
> v2:
On 17-07-31 11:30 AM, Christian König wrote:
> Am 31.07.2017 um 17:24 schrieb Felix Kuehling:
>> Hi Christian,
>>
>> If I'm reading this correctly, now you're only binding page directories,
>> but not the leaf page tables. Is that intentional?
>
> You are n
Otherwise bo->shadow_list (which is aliased by bo->mn_list) will not
appear empty in amdgpu_ttm_bo_destroy and cause an oops when freeing
former userptr BOs.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 2 +-
1 file changed,
On 17-08-01 10:34 PM, Felix Kuehling wrote:
> Otherwise bo->shadow_list (which is aliased by bo->mn_list) will not
> appear empty in amdgpu_ttm_bo_destroy and cause an oops when freeing
> former userptr BOs.
>
> Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
&
tch series rebased on current amd-kfd-staging-4.11?
Thanks,
Felix
On 17-07-18 10:22 PM, Felix Kuehling wrote:
> This patch series adds experimental P2P buffer sharing in amdgpu. It's
> disabled by default and can be enabled with amdgpu.p2p_sharing=1.
>
> v2:
> * Changed drm helper funct
On 17-07-19 11:26 AM, Christian König wrote:
> From: Christian König
>
> The fragment bits work differently for Vega10 compared to previous
> generations.
>
> Increase the fragment size to 2MB for now to better handle that.
>
> v2: handle the hardware setup as well
>
>
directly?
>
>
> Yong
>
>
> *From:* Oded Gabbay <oded.gab...@gmail.com>
> *Sent:* Saturday, August 12, 2017 10:54:41 AM
> *To:* Kuehling, Felix
> *Cc:* amd-gfx list; Zhao, Yong
> *Subject:* Re: [PATCH 14/19] drm/amdkfd: Add more error printing to
> help br
In most cases, BUG_ONs can be replaced with WARN_ON with an error
return. In some void functions just turn them into a WARN_ON and
possibly an early exit.
v2:
* Cleaned up error handling in pm_send_unmap_queue
* Removed redundant WARN_ON in kfd_process_destroy_delayed
Signed-off-by: Felix
gtt_sa_bitmap is accessed by bitmap functions, which operate on longs.
Therefore the array should be allocated in long units. Also round up
in case the number of bits is not a multiple of BITS_PER_LONG.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Oded Gabbay <
This register only has a single instance in the hardware. Its value
applies to all VMIDS.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
It's causing problems with user mode queues and the HIQ, and can
lead to hard hangs during boot after programming RLC_CP_SCHEDULERS.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vi.c | 3
nd %d, %i and 0x%llX.
According to kernel.org:
"Printing numbers in parentheses (%d) adds no value and should be
avoided."
Signed-off-by: Kent Russell <kent.russ...@amd.com>
Signed-off-by: Yong Zhao <yong.z...@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@am
ed-off-by: Moses Reuben <moses.reu...@amd.com>
Signed-off-by: Ben Goz <ben@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 37 ++
.../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c |
acking in kgd_kfd_interface.h
Signed-off-by: Moses Reuben <moses.reu...@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 15 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 16 +++-
drivers/g
From: Yong Zhao <yong.z...@amd.com>
v2:
* Removed amdgpu_amdkfd prefix from static functions
* Documented get_tile_config in kgd_kfd_interface.h
Signed-off-by: Yong Zhao <yong.z...@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Acked-by: Oded Gabbay <
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
b/drivers/gpu/dr
m>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 22 +-
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 20 -
drivers/gpu/drm/amd/amdkfd/kfd_
Handle errors in doorbell aperture initialization instead of BUG_ON.
iounmap doorbell aperture during finalization.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 9 -
Use shared_resources.queue_bitmap to determine the queues available
for KFD in each pipe.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 12 +---
1 fil
Various bug fixes and improvements that accumulated over the last two
years.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Acked-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 16 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_amd
y: Jay Cornwall <jay.cornw...@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>
Acked-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/dr
Remove hard-coded assumption that the first compute pipe is
reserved for amdgpu. Pipe 0 actually means pipe 0 now.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
Reviewed-by: Oded Gabbay <oded.gab...@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 +-
dri
4 or Dave Airlie's drm-next
>> (which amdkfd-next currently points to) branches ?
>> I tried to apply this patch-set on amdkfd-next, but it fails on patch
>> 5. I can't upstream them to Dave when they don't apply to his upstream
>> branch.
>>
>>
? If it's the latter,
we could reshuffle the ioctls later to better match the current release
ABI before going upstream.
Regards,
Felix
On 2017-08-14 11:18 AM, Felix Kuehling wrote:
> On 2017-08-13 05:08 AM, Oded Gabbay wrote:
>> As in the previous patch, there is a hole here in the IOCTLs
>
[+Marek, Alex for comment, see below]
On 2017-08-13 04:56 AM, Oded Gabbay wrote:
> On Sat, Aug 12, 2017 at 7:47 AM, Felix Kuehling <felix.kuehl...@amd.com>
> wrote:
>> From: Moses Reuben <moses.reu...@amd.com>
>>
>> Signed-off-by: Moses Reuben <moses.
.@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 24 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 16 ++---
drivers/
Remove BUG_ONs that check for NULL pointer arguments that are
dereferenced in the same function. Dereferencing the NULL pointer
will generate a BUG anyway, so the explicit check is redundant and
unnecessary overhead.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/d
Various bug fixes and improvements that accumulated over the last two
years.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 16 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 130 +---
drivers/gpu/d
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
index d5e19b5..8b14a4e 100644
--- a/drive
cleanup has to be done. If there is no cleanup needed then just return
directly."
Signed-off-by: Kent Russell <kent.russ...@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 15 +--
.../gpu/drm/amd/amdkfd/kfd_d
m>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 22 +-
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 20 -
drivers/gpu/drm/amd/amdkfd/kfd_dbgmgr.c| 4 +-
drivers/gpu/drm/amd/a
To match current firmware. The map process packet has been extended
to support scratch. This is a non-backwards compatible change and
it's about two years old. So no point keeping the old version around
conditionally.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/d
Use shared_resources.queue_bitmap to determine the queues available
for KFD in each pipe.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drive
From: Yong Zhao <yong.z...@amd.com>
Signed-off-by: Yong Zhao <yong.z...@amd.com>
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/
In most cases, BUG_ONs can be replaced with WARN_ON with an error
return. In some void functions just turn them into a WARN_ON and
possibly an early exit.
Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 3 +-
drivers/gpu/d
1 - 100 of 3319 matches
Mail list logo