Re: [arch-projects] [arch-ports] [devtools] Rebasing devtools32 to contribute upstream

2018-01-15 Thread Erich Eckner
Hi Luke, yeah, sure, we/I can switch to a rebasing workflow. Thanks for the suggestion. In retrospect, I have no Idea anymore, why I started with a merging workflow :-/ Cheers, Erich On 15.01.2018 18:24, Luke Shumaker wrote: > Hi all, > > As the maintainer of Parabola's devtools, I know that

[arch-projects] [archweb] Origin of konami.js

2018-01-15 Thread Luke Shumaker
Hi Dan, I'm sorry to bother you. In archweb commit bec4e79 (2013-02-09), you added `sitestatic/konami.min.js`. It is apparently https://github.com/snaptortoise/konami-js commit ec0f686 run through UglifyJS 2.2, but with a few modifications (below) made first. Would it be correct to assume that

Re: [arch-projects] [devtools] [PATCH 5/7] lib/common.sh: Adjust to work properly with `set -u`

2018-01-15 Thread Luke Shumaker
On Mon, 15 Jan 2018 12:25:22 -0500, Eli Schwartz via arch-projects wrote: > > [1 Re: [arch-projects] [devtools] [PATCH 5/7] lib/common.sh: Adjust to work > properly with `set -u` ] > [1.1 ] > On 01/15/2018 11:57 AM, Luke Shumaker wrote: > > From: Luke Shumaker > > >

Re: [arch-projects] [devtools] [PATCH 3/7] arch-nspawn: make sure that makepkg.conf is always parsed as text

2018-01-15 Thread Luke Shumaker
On Mon, 15 Jan 2018 12:11:29 -0500, Eli Schwartz wrote: > > On 01/15/2018 11:57 AM, Luke Shumaker wrote: > > From: Luke Shumaker > > > > https://lists.parabola.nu/pipermail/dev/2017-June/005576.html > > --- > > arch-nspawn.in | 2 +- > > 1 file changed, 1 insertion(+), 1

[arch-projects] [devtools] [PATCH] makechrootpkg: Do not copy the user keyring into the chroot.

2018-01-15 Thread Eli Schwartz via arch-projects
Since commit 75fdff1811a0487f82c75b2e260da905102b4eea we no longer run integrity checks inside the chroot anyway, so this is no longer needed and will never be used. Signed-off-by: Eli Schwartz --- makechrootpkg.in | 7 +-- 1 file changed, 1 insertion(+), 6

Re: [arch-projects] [devtools] [PATCH 7/7] makechrootpkg: Put "keyserver-options auto-key-retrieve" in gpg.conf

2018-01-15 Thread Eli Schwartz via arch-projects
On 01/15/2018 11:57 AM, Luke Shumaker wrote: > From: Luke Shumaker > > This allows signature verification by `makepkg --verifysource`, `git > verify-tag`, and such without requiring the user to manually retrieve > the keys first. > > This is based off of devtools32 commit

[arch-projects] [devtools] Rebasing devtools32 to contribute upstream

2018-01-15 Thread Luke Shumaker
Hi all, As the maintainer of Parabola's devtools, I know that with a merging workflow, it can be a huge pain to rebase out changes to have patchset that you can contribute upstream. If any of the Arch Linux 32 team ever decide that you want to contribute changes from devtools32 into upstream

Re: [arch-projects] [devtools] [PATCH 5/7] lib/common.sh: Adjust to work properly with `set -u`

2018-01-15 Thread Eli Schwartz via arch-projects
On 01/15/2018 11:57 AM, Luke Shumaker wrote: > From: Luke Shumaker > libmakepkg does not work with `set -u`; but mostly because of the include > guards! So we just need to temporarily disable `set -u` (nounset) while > loading libmakepkg. Instead of introducing a new

Re: [arch-projects] [devtools] [PATCH 3/7] arch-nspawn: make sure that makepkg.conf is always parsed as text

2018-01-15 Thread Eli Schwartz via arch-projects
On 01/15/2018 11:57 AM, Luke Shumaker wrote: > From: Luke Shumaker > > https://lists.parabola.nu/pipermail/dev/2017-June/005576.html > --- > arch-nspawn.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch-nspawn.in b/arch-nspawn.in > index

[arch-projects] [devtools] [PATCH 5/7] lib/common.sh: Adjust to work properly with `set -u`

2018-01-15 Thread Luke Shumaker
From: Luke Shumaker Support for working with `set -u` was broken by 94160d6. Egg on my face; I'm the one who wants `set -u` support, and I'm the author of that commit! libmakepkg does not work with `set -u`; but mostly because of the include guards! So we just need to

[arch-projects] [devtools] [PATCH 7/7] makechrootpkg: Put "keyserver-options auto-key-retrieve" in gpg.conf

2018-01-15 Thread Luke Shumaker
From: Luke Shumaker This allows signature verification by `makepkg --verifysource`, `git verify-tag`, and such without requiring the user to manually retrieve the keys first. This is based off of devtools32 commit 009695b (2017-06-27) by Erich Eckner .

[arch-projects] [devtools] [PATCH 2/7] makechrootpkg: Fix anti-pattern when checking for enabled features

2018-01-15 Thread Luke Shumaker
From: Eli Schwartz Don't use error-prone logic e.g. foo=true; if $foo ... This completely fails to act as expected when the variable is unset because of unrelated bugs. While this merely causes the default behavior to be "false" rather than "true" in such cases, it is

[arch-projects] [devtools] [PATCH 1/7] makechrootpkg: Fix unconditionally running namcap

2018-01-15 Thread Luke Shumaker
From: Eli Schwartz Fixes regression in 2fd5931a8c67289a8a4acd327b3ce99a5d64c8c7 $run_namcap will always be set to "" `if $not_a_var; then ...; fi` is always truthful when $not_a_var is unset or equal to "" and the `then` clause will always be run. I'm not sure why

[arch-projects] [devtools] [PATCH 4/7] arch-nspawn: Remove pointless $(echo ...) subshell

2018-01-15 Thread Luke Shumaker
From: Luke Shumaker --- arch-nspawn.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch-nspawn.in b/arch-nspawn.in index 3949ee1..7a7a274 100644 --- a/arch-nspawn.in +++ b/arch-nspawn.in @@ -91,7 +91,7 @@ copy_hostconf () { cp -T

[arch-projects] [devtools] [PATCH 0/7] Backports from Parabola v20180103

2018-01-15 Thread Luke Shumaker
From: Luke Shumaker These are the commits in Parabola's developer tools v20180103 that are not in upstream devtools that I think are upstreamable. There's no real theme to them. Some of theme have been seen on this mailing list before. (I appologize that I waited 2 weeks

[arch-projects] [devtools] [PATCH 3/7] arch-nspawn: make sure that makepkg.conf is always parsed as text

2018-01-15 Thread Luke Shumaker
From: Luke Shumaker https://lists.parabola.nu/pipermail/dev/2017-June/005576.html --- arch-nspawn.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch-nspawn.in b/arch-nspawn.in index c55f498..3949ee1 100644 --- a/arch-nspawn.in +++ b/arch-nspawn.in

[arch-projects] [devtools] [PATCH 6/7] makechrootpkg: Adjust to work properly with `set -e`

2018-01-15 Thread Luke Shumaker
From: Luke Shumaker This worked properly until eab5aba. --- makechrootpkg.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makechrootpkg.in b/makechrootpkg.in index c7fe076..a6c54cc 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -205,7 +205,7

Re: [arch-projects] [archweb] Licensing issues with JS code

2018-01-15 Thread Jelle van der Waa
On 01/14/18 at 08:34pm, Luke Shumaker wrote: > On Sun, 16 Jul 2017 23:46:01 -0400, > Andrew Gregory via arch-projects wrote: > > > > On 07/09/17 at 11:21am, Jelle van der Waa wrote: > > > Looking at the issue on the bugtracker, I'm not sure what you want to > > > achieve? personally I don't see

Re: [arch-projects] [archweb] Licensing issues with JS code

2018-01-15 Thread Jelle van der Waa
On 01/15/18 at 12:56am, Eli Schwartz via arch-projects wrote: > On 01/15/2018 12:07 AM, Luke Shumaker wrote: > > From what I see, that's a minority position, but of course I run in > > FSF circles, so my perception is a bit skewed. :P > > > > If that's the official position that the archweb team