Re: [arch-projects] [dbscripts] [PATCH 0/5] Be less tightly coupled with SVN

2018-06-22 Thread Luke Shumaker
On Fri, 22 Jun 2018 12:52:04 -0400, Eli Schwartz wrote: > On 06/19/2018 12:20 AM, Luke Shumaker wrote: > > From: Luke Shumaker > > > > This patchset is intended to clean up dbscripts' interaction with SVN. > > Besides (IMO) improved code clarity, this should make it easier for those > > who wish

Re: [arch-projects] [dbscripts] [PATCH 0/5] Be less tightly coupled with SVN

2018-06-22 Thread Eli Schwartz via arch-projects
On 06/19/2018 12:20 AM, Luke Shumaker wrote: > From: Luke Shumaker > > This patchset is intended to clean up dbscripts' interaction with SVN. > Besides (IMO) improved code clarity, this should make it easier for those > who wish to replace SVN with something else. > > There are two major themes

[arch-projects] [dbscripts] [PATCH v2 3/6] db-move: Clarify the flow of the preflight check

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker This should have the same result, but be a bit less confusing to read. Also, have a slightly more specific error message on a missing PKGBUILD. --- db-move | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/db-move b/db-move index

[arch-projects] [dbscripts] [PATCH v2 1/6] test: db-move: Verify that it works on single-arch packages

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker --- test/cases/db-move.bats | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/cases/db-move.bats b/test/cases/db-move.bats index df3dbdf..27fe8d1 100644 --- a/test/cases/db-move.bats +++ b/test/cases/db-move.bats @@ -39,6 +39,25 @@ load

[arch-projects] [dbscripts] [PATCH v2 0/6] Be less tightly coupled with SVN

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker This patchset is intended to clean up dbscripts' interaction with SVN. Besides (IMO) improved code clarity, this should make it easier for those who wish to replace SVN with something else. There are two major themes here: 1. Avoid asking SVN for information; to the extent

[arch-projects] [dbscripts] [PATCH v2 4/6] testing2x: Discover correct repos based on the DBEXT files, not SVN

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker testing2x needs to: 1. Verify that the new version of the package is found in TESTING_REPO 2. Determine which of STABLE_REPOS the old version of the package is in Currently, to do those things, it checks for the existence of PKGBUILD files in SVN. That information is

[arch-projects] [dbscripts] [PATCH v2 6/6] db-move, db-abs: Simplify calling the abs_move_* functions

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker Currently, abs_move_preflight_check and abs_move_arch require the exact pkgarch (i.e. "any" or "x86_64"). Modify them so that they take the tarch (i.e. "x86_64") and figure out themselves if it needs to set pkgarch=$tarch or pkgarch=any. abs_export could probably stand to

[arch-projects] [dbscripts] [PATCH v2 5/6] Centralize all SVN access into 'abs_*' functions in a new 'db-abs' file

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker Moving all SVN code in to a separate file means both that: 1. It is easier to identify the interactions with SVN, when considering a replacement. 2. It is easier to swap out the one file if/when replacing SVN with something else. Put another way: try to be less

[arch-projects] [dbscripts] [PATCH v2 2/6] db-move, db-remove: Don't parse PKGBUILD files

2018-06-22 Thread Luke Shumaker
From: Luke Shumaker Don't try to parse PKGBUILD files from SVN; all of the information we need is already in the DBEXT files. Several programs use [[ -f PKGBUILD ]] or [[ -r PKGBUILD ]] on files from SVN; those checks can stay, just remove all instances of actually trying to *parse* those