Spent too much time figuring out why I was getting an error of "object
has no attribute 'rule'". Perhaps it's correct spelling and grammer for
"set up" to be two words here, being used as a verb, but I wasn't
expecting that. Maybe this will help someone someday.
Signed off by: James P. Harvey
Signed-off-by: James P. Harvey
---
.../tests/pkgbuild/test_nonuniquesources.py | 36 +++
1 file changed, 36 insertions(+)
diff --git a/Namcap/tests/pkgbuild/test_nonuniquesources.py
b/Namcap/tests/pkgbuild/test_nonuniquesources.py
index 1c6d75c..b8f3542 100644
---
Signed-off-by: James P. Harvey
---
.../tests/pkgbuild/test_nonuniquesources.py | 58 +++
1 file changed, 58 insertions(+)
create mode 100644 Namcap/tests/pkgbuild/test_nonuniquesources.py
diff --git a/Namcap/tests/pkgbuild/test_nonuniquesources.py
Filenames in source() are required to be unique. A common violation of
this is from commonly named files (i.e. LICENSE) that aren't part of an
upstream tarball.
Warn if a source file doesn't have an overriding name, and has a
commonly used name, ignoring extension and case.
Signed-off-by: James
This was originally here, because it used PkgInfoRule, but was changed to use
PkgbuildRule and was left here.
Signed-off-by: James P. Harvey
---
Namcap/rules/__init__.py | 1 +
Namcap/rules/nonuniquesources.py | 34
Namcap/rules/pkginfo.py | 11
Done by:
$ find . -not \( -name .git -prune \) -type f -print0 | xargs -0 sed -i -E
"s/[[:space:]]*$//"
And manually reviewed.
Signed-off-by: James P. Harvey
---
COPYING | 10 +--
Namcap/__init__.py| 6 +-
Namcap/depends.py
On Sun, May 26, 2019 at 10:45 PM Eli Schwartz via arch-projects
wrote:
> All your patches show up as attachments, which makes it difficult to
> review, and they don't show up in patchwork.
>
> Generally speaking, the most reliable way to send a patch is by using
> `git send-email`.
Sorry about
On 5/26/19 10:35 PM, James Harvey via arch-projects wrote:
> Filenames in source() are required to be unique. A common violation of
> this is from commonly named files (i.e. LICENSE) that aren't part of an
> upstream tarball.
>
> Warn if a source file doesn't have an overriding name, and has a
>
On 5/26/19 10:35 PM, James Harvey via arch-projects wrote:
> There's no good way for namcap to ensure source() filenames are unique
> across all packages, required for users with SRCDEST. But, I think by
> far the most common offending filename would be LICENSE, as
> non-standard ones are
Signed-off-by: James P. Harvey
.../tests/pkgbuild/test_nonuniquesources.py | 36 +++
1 file changed, 36 insertions(+)
0004-nonuniquesources-Add-test-for-common-filenames.patch
Description: Binary data
Spent too much time figuring out why I was getting an error of "object
has no attribute 'rule'". Perhaps it's correct spelling and grammer for
"set up" to be two words here, being used as a verb, but I wasn't
expecting that. Maybe this will help someone someday.
Signed off by: James P. Harvey
Signed-off-by: James P. Harvey
.../tests/pkgbuild/test_nonuniquesources.py | 58 +++
1 file changed, 58 insertions(+)
create mode 100644 Namcap/tests/pkgbuild/test_nonuniquesources.py
0002-Add-test-for-non-unique-source-filenames.patch
Description: Binary data
This was originally here, because it used PkgInfoRule, but was changed to use
PkgbuildRule and was left here.
Signed-off-by: James P. Harvey
Namcap/rules/__init__.py | 1 +
Namcap/rules/nonuniquesources.py | 34
Namcap/rules/pkginfo.py | 11
Filenames in source() are required to be unique. A common violation of
this is from commonly named files (i.e. LICENSE) that aren't part of an
upstream tarball.
Warn if a source file doesn't have an overriding name, and has a
commonly used name, ignoring extension and case.
Signed-off-by: James
There's no good way for namcap to ensure source() filenames are unique
across all packages, required for users with SRCDEST. But, I think by
far the most common offending filename would be LICENSE, as
non-standard ones are required to be included, but sometimes there's
no upstream tarball or
Done by:
$ find . -not \( -name .git -prune \) -type f -print0 | xargs -0 sed
-i -E "s/[[:space:]]*$//"
And manually reviewed.
Signed-off-by: James P. Harvey
COPYING | 10 +--
Namcap/__init__.py| 6 +-
Namcap/depends.py
16 matches
Mail list logo
