On 02/15/2018 05:17 PM, Luke Shumaker wrote:
> Huh? My version isn't broken. Unless you mean that the glob is more
> restrictive than the one used by makepkg?
As you saw my other message, this should be answered already, but
consider this additional perspective on globs:
The glob is both
On Thu, 15 Feb 2018 16:57:26 -0500,
Eli Schwartz wrote:
>
> On 02/15/2018 04:43 PM, Luke Shumaker wrote:
> > That's not a bad idea. But then someone reading the code might wonder
> > "why does such a trivial function exist?". I think it would be silly,
> > and ultimately hurt readability to go
On 02/15/2018 04:43 PM, Luke Shumaker wrote:
> That's not a bad idea. But then someone reading the code might wonder
> "why does such a trivial function exist?". I think it would be silly,
> and ultimately hurt readability to go through and replace all
>
> "[[ -f ... ]]" instances with
On Thu, 15 Feb 2018 15:11:13 -0500,
Dave Reisner wrote:
>
> On Thu, Feb 15, 2018 at 02:49:45PM -0500, Luke Shumaker wrote:
> > - [[ -f ${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}${PKGEXT}
> > ]] && return 1
> > - [[ -f
> >
On 02/15/2018 03:48 PM, Dave Reisner wrote:
> Nope, changing the kind of glob doesn't work here. There's simply no
> glob expansion of any kind inside [[ -f ]] (or any other stat-like
> check).
I was thinking maybe something like the way makepkg compares filenames
to various extended globs, but
On Thu, Feb 15, 2018 at 03:14:19PM -0500, Eli Schwartz via arch-projects wrote:
> On 02/15/2018 03:11 PM, Dave Reisner wrote:
> > Rather than making this stand out like a sore thumb for the next person
> > to trip over, why don't we just define a "file_exists" function?
> >
> > file_exists() {
On 02/15/2018 03:11 PM, Dave Reisner wrote:
> Rather than making this stand out like a sore thumb for the next person
> to trip over, why don't we just define a "file_exists" function?
>
> file_exists() {
> [[ -f $1 ]]
> }
>
> Now you're free to do this:
>
> file_exists
>
On Thu, Feb 15, 2018 at 02:49:45PM -0500, Luke Shumaker wrote:
> From: Luke Shumaker
>
> This partially reverts commit b61a7148eaf546a31597b74d9dd8948e4a39dea1.
>
> In dbscripts, PKGEXT is a glob pattern--it needs to be "unquoted"; and
> The magic-quoting done by `[[ ...
From: Luke Shumaker
This partially reverts commit b61a7148eaf546a31597b74d9dd8948e4a39dea1.
In dbscripts, PKGEXT is a glob pattern--it needs to be "unquoted"; and
The magic-quoting done by `[[ ... ]]` breaks that. The closing-quote
coming before ${PKGEXT} was quite