Re: [arch-projects] [dbscripts] [PATCH v2 5/5] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-19 Thread Luke Shumaker
On Mon, 19 Feb 2018 15:11:45 -0500, Eli Schwartz via arch-projects wrote: > +# Check if a file exists, even if the file uses wildcards > +is_globfile() { > + [[ -f $1 ]] > +} > + Dave's comment on my version of this patchset applies equally to this version: > Frankly, this function name and

Re: [arch-projects] [dbscripts] [PATCH v2 5/5] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-19 Thread Eli Schwartz via arch-projects
On 02/19/2018 04:59 PM, Luke Shumaker wrote: > Is there a reason you reject '.pkg.tar' (no compression, which makepkg > accepts)? I don't think there is any utility in supporting uncompressed packages in dbscripts. Anyone who wants to customize this in a non-Arch Linux deployment is free to do

Re: [arch-projects] [dbscripts] [PATCH v2 5/5] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-19 Thread Luke Shumaker
On Mon, 19 Feb 2018 15:11:45 -0500, Eli Schwartz via arch-projects wrote: > Document the fact that this has *always* been some sort of glob, and > update the two cases where this was (not!) being evaluated by bash > [[ ... ]], to use a not-elegant-at-all proxy function is_globfile() to > evaluate

[arch-projects] [dbscripts] [PATCH v2 5/5] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-19 Thread Eli Schwartz via arch-projects
The current glob `*.pkg.tar.?z` is both less restrictive and more restrictive than makepkg, as it accepts any valid unicode character. To be more exact, it's almost completely orthogonal to the one in makepkg. makepkg only accepts .tar.gz, .tar.bz2, .tar.xz, .tar.lzo, .tar.lrz, and .tar.Z and