---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 24, 2014, 9:03 a.m.)
Review request for Asterisk
On March 23, 2014, 3:46 p.m., wdoekes wrote:
Minor nits. Still waiting for someone to test this.
Sure, no hurry:)
- zvision
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 24, 2014, 9:11 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 24, 2014, 9:11 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11333
---
Minor nits. Still waiting for someone to test this.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11243
---
You're right that this is a bug fix. (We change no working
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 9:57 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 9:58 a.m.)
Review request for Asterisk
On March 17, 2014, 9:08 a.m., wdoekes wrote:
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_pgsql.c,
lines 761-772
https://reviewboard.asterisk.org/r/3346/diff/1/?file=55850#file55850line761
The double occurrence of count++ smells bad.
In both cases
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11249
---
Ship it!
Looks good to go.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 11:56 a.m.)
Review request for Asterisk
On March 17, 2014, 11:48 a.m., wdoekes wrote:
http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_config_pgsql.c,
line 682
https://reviewboard.asterisk.org/r/3346/diff/2/?file=56146#file56146line682
Try to limit line lengths to about 100.
Done:)
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 12:17 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11254
---
Ship it!
Other than this small nitpick, looks good to go.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 4:16 p.m.)
Review request for Asterisk
On March 17, 2014, 2:46 p.m., Tilghman Lesher wrote:
http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_config_pgsql.c,
line 682
https://reviewboard.asterisk.org/r/3346/diff/3/?file=56148#file56148line682
Just a nitpick. I really hate the double-negative form of
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 4:22 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 17, 2014, 4:23 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11214
---
One issue is that this patch is against a released version,
On March 14, 2014, 8:49 p.m., Tilghman Lesher wrote:
One issue is that this patch is against a released version, Asterisk 11,
and not against trunk. Since we've never previously supported NULL columns
as such, I think we'd want this change in trunk only.
Also, while you've changed
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23351
On March 13, 2014, 2:21 p.m., Matt Jordan wrote:
Before this patch goes any further, it needs adequate testing.
While posting a patch with 'it compiles' is a bare minimum requirement, for
it to be included seriously for inclusion the How this was tested field
should be filled in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11166
---
Before this patch goes any further, it needs adequate testing.
23 matches
Mail list logo
