Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Geert Van Pamel
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 15, 2014, 1:12 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Geert Van Pamel
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 15, 2014, 1:42 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

2014-03-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/ --- (Updated March 15, 2014, 5:29 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11228 --- /trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11227 --- Ship it! One very minor tweak, this looks good. Geert you

[asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-03-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/#review11230 --- So, after talking to pabelanger about it, this could be a bit

Re: [asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Corey Farrell
On March 15, 2014, 2:46 p.m., Russell Bryant wrote: So, after talking to pabelanger about it, this could be a bit more generic without a lot of effort. Right now it's hard coded to do a Playback(beep) into the call. It could pretty easily changed to just be a periodic dialplan

Re: [asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/#review11229 --- Some things I found before I saw your comment about making

Re: [asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Paul Belanger
On March 15, 2014, 6:46 p.m., Russell Bryant wrote: So, after talking to pabelanger about it, this could be a bit more generic without a lot of effort. Right now it's hard coded to do a Playback(beep) into the call. It could pretty easily changed to just be a periodic dialplan

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Geert Van Pamel
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 15, 2014, 11:02 p.m.) Review request for Asterisk