Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 22, 2014, 2:08 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11323 --- I don't see what happens with the phone-context argument.

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Olle E Johansson
On March 21, 2014, 7:01 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, line 130 https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130 This needs to blank both variables: userinfo = uri = ; Geert Van Pamel wrote: We return the

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Corey Farrell
On March 21, 2014, 2:01 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, line 130 https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130 This needs to blank both variables: userinfo = uri = ; Geert Van Pamel wrote: We return the

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? We return this into the hostport. - Geert --- This is an

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? Geert Van Pamel wrote: We return this into the hostport. According to RFC 3966 phone-context is either a domain-name, or

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
On March 15, 2014, 7:04 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, line 111 https://reviewboard.asterisk.org/r/3349/diff/3/?file=56070#file56070line111 scheme is the input parameter listing acceptable schemes, we don't need to see it here. The other