Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-26 Thread Geert Van Pamel
.) Review request for Asterisk Developers. Bugs: ASTERISK-17179 https://issues.asterisk.org/jira/browse/ASTERISK-17179 Repository: Asterisk Description --- This patch is filed on behalf of Geert Van Pamel as filed against Asterisk-12 on ASTERISK-17179

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-13 Thread Geert Van Pamel
Attachments RFC-3966 tel URI patch https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Geert Van Pamel
output. File Attachments RFC-3966 tel URI patch https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Geert Van Pamel
RFC-3966 tel URI patch https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-15 Thread Geert Van Pamel
RFC-3966 tel URI patch https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-17 Thread Geert Van Pamel
-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-17 Thread Geert Van Pamel
, 8:01 p.m., Geert Van Pamel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/ --- (Updated March 17, 2014, 8:01 p.m

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-17 Thread Geert Van Pamel
. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11237 --- On March 17, 2014, 8:01 p.m., Geert Van Pamel wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-19 Thread Geert Van Pamel
/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-20 Thread Geert Van Pamel
://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-20 Thread Geert Van Pamel
generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11291 --- On March 20, 2014, 10:59 p.m., Geert Van Pamel wrote: --- This is an automatically generated e

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-21 Thread Geert Van Pamel
://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-21 Thread Geert Van Pamel
--- On March 21, 2014, 8:32 a.m., Geert Van Pamel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
-3966 tel URI patch https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349/#review11323 --- On March 22, 2014, 2:08 p.m., Geert Van Pamel wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? Geert Van Pamel wrote: We return this into the hostport. According to RFC 3966 phone-context is either a domain-name

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-22 Thread Geert Van Pamel
--- On March 22, 2014, 2:08 p.m., Geert Van Pamel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3349

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-23 Thread Geert Van Pamel
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? Geert Van Pamel wrote: We return this into the hostport. Geert Van Pamel wrote: According to RFC 3966 phone

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-03-24 Thread Geert Van Pamel
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote: I don't see what happens with the phone-context argument. Shouldn't we pass that on as a channel variable? Geert Van Pamel wrote: We return this into the hostport. Geert Van Pamel wrote: According to RFC 3966 phone

Re: [asterisk-dev] [Code Review] 3349: Implement RFC-3966 TEL URI incoming INVITE

2014-04-13 Thread Geert Van Pamel
on SIP debug output. File Attachments RFC-3966 tel URI patch https://reviewboard.asterisk.org/media/uploaded/files/2014/03/13/cad7a996-88c1-47fe-a2a9-cc6987af3b75__rfc-3966-tel-uri-patch-diff.txt Thanks, Geert Van Pamel