Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-03-17 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/ --- (Updated March 17, 2014, 8:46 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-26 Thread Geert Van Pamel
On Feb. 23, 2014, 9:04 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, lines 103-118 https://reviewboard.asterisk.org/r/3250/diff/1/?file=54390#file54390line103 I feel this section should only apply when scheme is 'tel:'. I'm concerned with changes to how sip

[asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/ --- Review request for Asterisk Developers. Bugs: ASTERISK-17179

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/#review10929 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread wdoekes
On Feb. 23, 2014, 8:04 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, lines 103-118 https://reviewboard.asterisk.org/r/3250/diff/1/?file=54390#file54390line103 I feel this section should only apply when scheme is 'tel:'. I'm concerned with changes to how sip

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/#review10931 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/#review10932 --- I've gone ahead and rectified the access issue. If Geert would