Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-18 Thread Lenz Emilitri
Yes that's cool! :) l. 2010/2/17 Miguel Molina mmol...@millenium.com.co Ok, if I get it the simplest workaround would be changing this: exten = _X.,1,Dial(SIP/${EXTEN}) To this: exten = _X.,1,Dial(SIP/${FILTER(0123456789,${EXTEN})}) If you're intended to receive only numbers from the

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-17 Thread Lenz Emilitri
Ok but this is available today and works fine, so it can be used as a zero day replacement. Any syntax change is welcome but will take time until it gets in a public release and does not save you the hassle to change the dialplans anyway - unless you implement it as a default behaviour at the SIP

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-17 Thread Olle E. Johansson
While we continue discussing all possible solutions to this and build an expanding knowledgebase, I would like to repeat myself and kindly ask everyone that blogs, twitters, talks and teaches about Asterisk to please spread the word and the links. Later today, there will be an official Asterisk

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-17 Thread Miguel Molina
Lenz Emilitri escribió: Ok but this is available today and works fine, so it can be used as a zero day replacement. Any syntax change is welcome but will take time until it gets in a public release and does not save you the hassle to change the dialplans anyway - unless you implement it

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-17 Thread Warren Selby
That's what I've started doing. Thanks, --Warren Selby On Feb 17, 2010, at 8:29 AM, Miguel Molina mmol...@millenium.com.co wrote: Lenz Emilitri escribió: Ok but this is available today and works fine, so it can be used as a zero day replacement. Any syntax change is welcome but will

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Tzafrir Cohen
On Mon, Feb 15, 2010 at 09:40:31AM -0700, Steve Murphy wrote: On Mon, Feb 15, 2010 at 8:25 AM, Lenz Emilitri lenz.lo...@gmail.com wrote: Yes but in any case you can enter all of the strings that reasonably match - even if you have variable-length numbers, you will be able to determine

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Olle E. Johansson
16 feb 2010 kl. 09.43 skrev Tzafrir Cohen: On Mon, Feb 15, 2010 at 09:40:31AM -0700, Steve Murphy wrote: On Mon, Feb 15, 2010 at 8:25 AM, Lenz Emilitri lenz.lo...@gmail.com wrote: Yes but in any case you can enter all of the strings that reasonably match - even if you have variable-length

Re: [asterisk-users] Important security alert: update your?dialplans now!

2010-02-16 Thread Leif Madsen
Tilghman Lesher wrote: On Monday 15 February 2010 18:01:11 Vinícius Fontes wrote: He probably means AgentCallbackLogin While it has been deprecated, that hasn't been removed, either. If an enterprising person would like to try to fix it, I don't have an objection. Wasn't

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Steve Murphy
On Tue, Feb 16, 2010 at 1:43 AM, Tzafrir Cohen tzafrir.co...@xorcom.comwrote: On Mon, Feb 15, 2010 at 09:40:31AM -0700, Steve Murphy wrote: On Mon, Feb 15, 2010 at 8:25 AM, Lenz Emilitri lenz.lo...@gmail.com wrote: Yes but in any case you can enter all of the strings that reasonably

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Steve Murphy
On Tue, Feb 16, 2010 at 3:01 AM, Olle E. Johansson o...@edvina.net wrote: 16 feb 2010 kl. 09.43 skrev Tzafrir Cohen: On Mon, Feb 15, 2010 at 09:40:31AM -0700, Steve Murphy wrote: On Mon, Feb 15, 2010 at 8:25 AM, Lenz Emilitri lenz.lo...@gmail.com wrote: Yes but in any case you can

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Tzafrir Cohen
On Tue, Feb 16, 2010 at 10:53:16AM -0700, Steve Murphy wrote: (is there some escape mech in the syntax to let you say \NA\NCY? I haven't checked). [N]A[N]CY . Or, if we have it your way, [N][A][N]C[Y] But, there's no reason we can't add other matching chars for handy things. A = alpha

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Philipp von Klitzing
Hi! But, there's no reason we can't add other matching chars for handy things. A = alpha chars Y = alphanum chars, G = Graphical chars, Pretty please! Philipp -- _ -- Bandwidth and Colocation Provided by

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread meetmecall
I have read the posts about the security issue and from what I understand there should be a check to make sure that the characters used are actually allowed. I wrote a very straightforward and not so rocket science kind of macro that will do the job I guess. Just two parameters, one with

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Landy Landy
bridge? --- On Mon, 2/15/10, Tony Mountifield t...@softins.clara.co.uk wrote: From: Tony Mountifield t...@softins.clara.co.uk Subject: Re: [asterisk-users] Important security alert: update your dialplans now! To: asterisk-users@lists.digium.com Date: Monday, February 15, 2010, 11:58 AM

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Tommy Botten Jensen
= to_client include = test-agi include = menu that goes to an ivr. Can this be a security bridge? --- On Mon, 2/15/10, Tony Mountifield t...@softins.clara.co.uk wrote: From: Tony Mountifield t...@softins.clara.co.uk Subject: Re: [asterisk-users] Important security alert: update

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Warren Selby
On Tue, Feb 16, 2010 at 4:38 PM, meetmecall i...@meetmecall.nl wrote: I have read the posts about the security issue and from what I understand there should be a check to make sure that the characters used are actually allowed. I wrote a very straightforward and not so rocket science kind of

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread meetmecall
I didn't know about the function but from what I understand from the show function FILTER output it doesn't validate a string but it cleans the string from not allowed characters. So TRIM(1234567890,01243567505) results in 01243567505. If the length of the output string is shorter then

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-16 Thread Warren Selby
On Tue, Feb 16, 2010 at 6:28 PM, meetmecall i...@meetmecall.nl wrote: I didn't know about the function but from what I understand from the show function FILTER output it doesn't validate a string but it cleans the string from not allowed characters. So TRIM(1234567890,01243567505) results in

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Lenz Emilitri
Or one could simply rewrite to: [incoming-from-voip] exten = XXX,1,Dial(${ext...@incoming-from-voip-old) exten = ,1,Dial(${ext...@incoming-from-voip-old) exten = X,1,Dial(${ext...@incoming-from-voip-old) exten = XX,1,Dial(${ext...@incoming-from-voip-old)

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Olle E. Johansson
15 feb 2010 kl. 09.33 skrev Lenz Emilitri: Or one could simply rewrite to: [incoming-from-voip] exten = XXX,1,Dial(${ext...@incoming-from-voip-old) exten = ,1,Dial(${ext...@incoming-from-voip-old) exten = X,1,Dial(${ext...@incoming-from-voip-old) exten =

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Randy R
On Mon, Feb 15, 2010 at 9:51 AM, Olle E. Johansson o...@edvina.net wrote: To avoid extensive rewriting and fix the current issue. That works in countries where you have fixed-length numbers. Unfortunately, not every dialplan works that way, so that can't be a generic advice even though it

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Rob Hillis
On 02/15/10 20:00, Randy R wrote: Olle, this may be a stupid question, but shouldn't a native santitize function be urgently added to the code base in all versions or change the dialplan compîler to ignore dangerous characters? Whilst I agree with this, the unfortunate attitude we seem to

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Olle E. Johansson
15 feb 2010 kl. 10.00 skrev Randy R: On Mon, Feb 15, 2010 at 9:51 AM, Olle E. Johansson o...@edvina.net wrote: To avoid extensive rewriting and fix the current issue. That works in countries where you have fixed-length numbers. Unfortunately, not every dialplan works that way, so that can't

Re: [asterisk-users] Important security alert: update your?dialplans now!

2010-02-15 Thread Michiel van Baak
On 08:48, Mon 15 Feb 10, Tilghman Lesher wrote: On Monday 15 February 2010 03:37:24 Rob Hillis wrote: On 02/15/10 20:00, Randy R wrote: Olle, this may be a stupid question, but shouldn't a native santitize function be urgently added to the code base in all versions or change the

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Lenz Emilitri
Yes but in any case you can enter all of the strings that reasonably match - even if you have variable-length numbers, you will be able to determine that a valid number be between 5 and 15 characters - or likely 2 to 20, all numbers. A number of 156 characters is very likely to be a problem. BTW,

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Steve Murphy
On Mon, Feb 15, 2010 at 8:25 AM, Lenz Emilitri lenz.lo...@gmail.com wrote: Yes but in any case you can enter all of the strings that reasonably match - even if you have variable-length numbers, you will be able to determine that a valid number be between 5 and 15 characters - or likely 2 to

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-15 Thread Tony Mountifield
In article 699ee941002150033t7c6e1be5xdba76cb0f68d5...@mail.gmail.com, Lenz Emilitri lenz.lo...@gmail.com wrote: -=-=-=-=-=- -=-=-=-=-=- Or one could simply rewrite to: [incoming-from-voip] exten = XXX,1,Dial(${ext...@incoming-from-voip-old) exten =

Re: [asterisk-users] Important security alert: update your?dialplans now!

2010-02-15 Thread Tilghman Lesher
On Monday 15 February 2010 09:05:33 Michiel van Baak wrote: On 08:48, Mon 15 Feb 10, Tilghman Lesher wrote: On Monday 15 February 2010 03:37:24 Rob Hillis wrote: On 02/15/10 20:00, Randy R wrote: Olle, this may be a stupid question, but shouldn't a native santitize function be

Re: [asterisk-users] Important security alert: update your?dialplans now!

2010-02-15 Thread Vinícius Fontes
He probably means AgentCallbackLogin While it has been deprecated, that hasn't been removed, either. If an enterprising person would like to try to fix it, I don't have an objection. Wasn't AgentCallBackLogin() removed in 1.6.1? --

Re: [asterisk-users] Important security alert: update your?dialplans now!

2010-02-15 Thread Tilghman Lesher
On Monday 15 February 2010 18:01:11 Vinícius Fontes wrote: He probably means AgentCallbackLogin While it has been deprecated, that hasn't been removed, either. If an enterprising person would like to try to fix it, I don't have an objection. Wasn't AgentCallBackLogin() removed in

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread Olle E. Johansson
14 feb 2010 kl. 03.25 skrev C F: Excellent and very informative article, Thanks Olle. You're welcome. I ran thru lots of my dialplans now quickly to see if I have a catch all exten anywhere. I couldn't find any that are accessible unauthenticated, I always declare all fixed length

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread C F
On Sun, Feb 14, 2010 at 2:30 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Sat, Feb 13, 2010 at 09:25:01PM -0500, C F wrote: Excellent and very informative article, Thanks Olle. I ran thru lots of my dialplans now quickly to see if I have a catch all exten anywhere. I couldn't find any

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread C F
On Sun, Feb 14, 2010 at 3:26 AM, Olle E. Johansson o...@edvina.net wrote: 14 feb 2010 kl. 03.25 skrev C F: Excellent and very informative article, Thanks Olle. You're welcome. I ran thru lots of my dialplans now quickly to see if I have a catch all exten anywhere. I couldn't find any that

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread Kyle Kienapfel
strip_ampersands(${EXTEN})? On Sun, Feb 14, 2010 at 10:56 AM, C F shma...@gmail.com wrote: On Sun, Feb 14, 2010 at 3:26 AM, Olle E. Johansson o...@edvina.net wrote: 14 feb 2010 kl. 03.25 skrev C F: Excellent and very informative article, Thanks Olle. You're welcome. I ran thru lots of my

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread Steve Edwards
On Sun, 14 Feb 2010, Kyle Kienapfel wrote: strip_ampersands(${EXTEN})? (sip.conf) [general] allow-characters= all disallow-characters = [example-did-provider] allow-characters= [:numeric:] -- Thanks in advance,

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread C F
While I like these solutions, they should never be substituting a good secure dialplan. On Sun, Feb 14, 2010 at 3:04 PM, Steve Edwards asterisk@sedwards.com wrote: On Sun, 14 Feb 2010, Kyle Kienapfel wrote: strip_ampersands(${EXTEN})? (sip.conf) [general]        allow-characters      

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread Olle E. Johansson
14 feb 2010 kl. 21.04 skrev Steve Edwards: On Sun, 14 Feb 2010, Kyle Kienapfel wrote: strip_ampersands(${EXTEN})? (sip.conf) [general] allow-characters= all disallow-characters = [example-did-provider] allow-characters

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-14 Thread Tzafrir Cohen
On Sun, Feb 14, 2010 at 11:22:12AM -0800, Kyle Kienapfel wrote: strip_ampersands(${EXTEN})? You forget other potentially harmful characters. @:,/| And maybe others. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406

[asterisk-users] Important security alert: update your dialplans now!

2010-02-13 Thread Olle E. Johansson
Friends, Last week, Hans Petter Selansky alerted us of a potential security issue in all releases of Asterisk. In fact, it doesn't involve the code, but the most common way to construct dialplans. If you have something like this in your Asterisk, you need to update your dialplans:

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-13 Thread C F
Excellent and very informative article, Thanks Olle. I ran thru lots of my dialplans now quickly to see if I have a catch all exten anywhere. I couldn't find any that are accessible unauthenticated, I always declare all fixed length extensions using patterns the exception being international

Re: [asterisk-users] Important security alert: update your dialplans now!

2010-02-13 Thread Tzafrir Cohen
On Sat, Feb 13, 2010 at 09:25:01PM -0500, C F wrote: Excellent and very informative article, Thanks Olle. I ran thru lots of my dialplans now quickly to see if I have a catch all exten anywhere. I couldn't find any that are accessible unauthenticated, I always declare all fixed length