"Pavel" == Pavel Roskin [EMAIL PROTECTED] writes:
[...]
Pavel I understand that your test case was to demonstrate the
Pavel first problem. But then "make distcheck" is irrelevant -
Pavel the problem can be detected already after "make distdir"
Yes!
[...]
Pavel However, please comment
Pavel I believe, the best fix will be to have tests/defs to copy the
Pavel right install-sh instead of creating an empty file.
I agree. I have a patch for this which I'll check in once the test
suite is done.
Tom
Pavel 1) "make dist" must ensure that out-of-date generated
Pavel distributable files (parser.c, Makefile.in etc) are not
Pavel included in the tarball either by running "make all" or
Pavel otherwise. Yes or no?
Yes. This has been on the to-do list for a long time.
I don't recall what has been
Alexandre Oliva wrote:
On Feb 28, 2001, "Derek R. Price" [EMAIL PROTECTED] wrote:
CVS uses a single second sleep to guarentee timestamps change cross-platform
IIRC, FAT filesystems can only store even second numbers. So, in
order to be 100% safe, you'd need to sleep for 2 seconds, but a
nit testing" of your tests. For example,
YACC=bison had no chances to work even when configuring in the source
tree, since bison outputs files with different names.
Regards,
Pavel Roskin
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,12 @@
+2001-02-27 Pavel Roskin [EM
On Feb 28, 2001, "Derek R. Price" [EMAIL PROTECTED] wrote:
CVS uses a single second sleep to guarentee timestamps change cross-platform
IIRC, FAT filesystems can only store even second numbers. So, in
order to be 100% safe, you'd need to sleep for 2 seconds, but a
1-second sleep should be ok
ED]
* tests/yaccvpath.test: Check for no gzip; run bison in yacc mode;
sleep before updating parse.y to have a different timestamp;
append a comment to parse.y instead of adding an usused rule;
grep for that comment in the resulting parse.c from the distribution
"Pavel" == Pavel Roskin [EMAIL PROTECTED] writes:
Pavel Hello, Alexandre!
Alexandre claims it fails.
Yes it should.
Pavel Then show us how it fails.
You did it in the next mail.
[...]
Pavel But I don't see that your are testing for that
Pavel problem. Your test is quite generic
Hello, Alexandre!
I'm applying my patch, Ok?
Pavel Now we have a more interesting error:
This is *the* error this test is expected to show. Thanks :)
The only question remains, whether it's a bug a not. I'm affraid it's a
highly debatable topic. I think it's Ok to test for features if
Pavel Roskin wrote:
Some unices (including GNU/Linux) are not very precise with respect to the
timestamps. It's likely that parse.c and the new parse.y are created in
the same second, so parse.c will appear to be up-to-date. Adding "sleep
3" (I have no idea what would be a minimal safe
Hello, Tom and Alexandre!
On 27 Feb 2001, Tom Tromey wrote:
"Pavel" == Pavel Roskin [EMAIL PROTECTED] writes:
Pavel I don't quite understand whether your test is supposed to work
Pavel or not. It's failing for me (besides the typo in
Pavel tests/Makefile.am that I've just fixed).
relevant
to the test.
Now we have a more interesting error:
make[3]: Leaving directory
`/usr/local/src/am1/tests/testSubDir/sub/foo-0.1/=build'
Error: files left after distclean
make[2]: *** [distcheck] Error 1
make[2]: Leaving directory `/usr/local/src/am1/tests/testSubDir/sub'
FAIL: yaccvpath
, and it's only
removed from there when the fix is committed.
Maybe you don't know, but yaccvpath.test fails very differently when
automake is configured in the source directory and outside it. You
probably should add AC_CONFIG_AUX_DIR(.) to the test (see e.g.
install2.test), unless I'm missing
committed, it is added to
Pavel XFAIL_TESTS, and it's only removed from there when the fix is
Pavel committed.
My fault.
Pavel Maybe you don't know, but yaccvpath.test fails very differently
Pavel when automake is configured in the source directory and outside
Pavel it. You probably should add AC_CONF
14 matches
Mail list logo
