Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

2015-06-12 Thread Ville Skyttä
On Fri, Jun 12, 2015 at 4:47 AM, isabella parakiss izaber...@gmail.com wrote: In line 1588 you use ruptime 2/dev/null. I have no ruptime but I do use a command_not_found_handle. Please apply the attached patch. Using an optional command before checking if it exists is a very commonly used

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

2015-06-12 Thread Ville Skyttä
On Fri, Jun 12, 2015 at 1:16 PM, isabella parakiss izaber...@gmail.com wrote: Sorry what? Ten lines above you check if avahi-browse is installed Yes, there are some cases where we do that, but it doesn't invalidate what I said. I don't think it's my code that needs to be fixed, and several

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

2015-06-12 Thread isabella parakiss
On 6/12/15, Ville Skyttä ville.sky...@iki.fi wrote: Using an optional command before checking if it exists is a very commonly used pattern in bash-completion, and I don't think we want to address their occurrences one at a time. TBH, I'm pretty sure if we'd rather not address that stuff at