Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

Ok this is not exactly the answer I was hoping to receive. On 6/12/15, Ville Skyttä wrote: > I'm going to see if the approach I proposed works sometime, when I > find time and interest, and helping with testing would quite likely > make that happen sooner. Then, if it does

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On Tue, Jun 23, 2015 at 10:42:55PM +0200, isabella parakiss wrote: Besides, as previously mentioned, people may want to run their custom completion functions from that handle. You assumed loudly something which does not appear so obvious. There *is* a point in having command_not_found_handle

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On Fri, Jun 12, 2015 at 2:11 PM, Ville Skyttä ville.sky...@iki.fi wrote: I'm going to see if the approach I proposed works sometime, when I find time and interest, and helping with testing would quite likely make that happen sooner. Then, if it does work, I'll probably spend time documenting

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On 6/23/15, Ville Skyttä ville.sky...@iki.fi wrote: On Fri, Jun 12, 2015 at 2:11 PM, Ville Skyttä ville.sky...@iki.fi wrote: I'm going to see if the approach I proposed works sometime, when I find time and interest, and helping with testing would quite likely make that happen sooner. Then, if

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On Tue, Jun 23, 2015 at 11:42 PM, isabella parakiss izaber...@gmail.com wrote: So you reported an issue on github to an unrelated project. Great. PackageKit is the upstream of the package installer used in Fedora and probably some other distros, which is the thing I said I'd fix if my idea

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

I submitted a patch a few days ago but I noticed now that it was rejected because it was too heavy ( 100kb). I'm attaching it again, gzipped. It should fix all the occurrencies of unchecked commands that i found in commit d0494819521c1a70e3d83e26f2a55620ea64e89d. Please consider using that

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On Fri, Jun 12, 2015 at 4:47 AM, isabella parakiss izaber...@gmail.com wrote: In line 1588 you use ruptime 2/dev/null. I have no ruptime but I do use a command_not_found_handle. Please apply the attached patch. Using an optional command before checking if it exists is a very commonly used

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On Fri, Jun 12, 2015 at 1:16 PM, isabella parakiss izaber...@gmail.com wrote: Sorry what? Ten lines above you check if avahi-browse is installed Yes, there are some cases where we do that, but it doesn't invalidate what I said. I don't think it's my code that needs to be fixed, and several

Re: [Bash-completion-devel] [PATCH] check if ruptime is installed

On 6/12/15, Ville Skyttä ville.sky...@iki.fi wrote: Using an optional command before checking if it exists is a very commonly used pattern in bash-completion, and I don't think we want to address their occurrences one at a time. TBH, I'm pretty sure if we'd rather not address that stuff at

[Bash-completion-devel] [PATCH] check if ruptime is installed

Hi, for some reason I couldn't register for an actual account on https://alioth.debian.org so I'm writing to the mailing list directly. In line 1588 you use ruptime 2/dev/null. I have no ruptime but I do use a command_not_found_handle. Please apply the attached patch. Hope this helps. ---