Re: [Bioc-devel] Controlling vignette compilation order

2018-12-22 Thread Aaron Lun
Yes, I had noticed the vignettes.rds as well, and I figured that would be a problem. I just tried setting set cache=TRUE in my vignettes, implemented such that BUILDing each downstream vignette will also run all upstream vignettes on which it depends (that haven’t already been compiled). If an

Re: [Bioc-devel] Controlling vignette compilation order

2018-12-22 Thread Aaron Lun
Yes, that is the simplest solution, and it’s what I’m doing now. It’s not overly confusing for a reader, but it’s awkward to add new vignettes in the middle of the compilation order, as I then have to rename the others (or give the new vignette a weird name, e.g., “xtra-3b-de.Rmd” to get it to

Re: [Bioc-devel] Controlling vignette compilation order

2018-12-22 Thread Henrik Bengtsson
On Sat, Dec 22, 2018 at 10:56 AM Michael Lawrence wrote: > > Anything that eventually lands in inst/doc is a vignette, I think, so > there might be a hack around that. Just so this is not misread - it's *not* possible to just hack your vignette "product" files (PDF or HTML) into inst/doc and

Re: [Bioc-devel] Controlling vignette compilation order

2018-12-22 Thread Martin Morgan
...but in the end isn't it just simpler to name your vignettes in collation order? Who other than you will be able to parse what you've done? Martin On 12/22/18, 1:56 PM, "Bioc-devel on behalf of Michael Lawrence" wrote: Anything that eventually lands in inst/doc is a vignette, I think,

Re: [Bioc-devel] Controlling vignette compilation order

2018-12-22 Thread Michael Lawrence
Anything that eventually lands in inst/doc is a vignette, I think, so there might be a hack around that. On Fri, Dec 21, 2018 at 11:26 PM Aaron Lun wrote: > > I gave it a shot: > > https://github.com/LTLA/DrakeTest > > This uses a single “controller” Rmd file

Re: [Bioc-devel] Aliasing `]` breaks BiocCheck::BiocCheck() version 1.18.0

2018-12-22 Thread Martin Morgan
Thanks I also updated upstream. Martin On 12/22/18, 9:56 AM, "Tierney, Luke" wrote: Modifying findGlobals to return empty variable lists for non-closure functions was an easy change so an updated codetools is ready to submit when the CRAN queue opens again in the new year.

Re: [Bioc-devel] Aliasing `]` breaks BiocCheck::BiocCheck() version 1.18.0

2018-12-22 Thread Tierney, Luke
Modifying findGlobals to return empty variable lists for non-closure functions was an easy change so an updated codetools is ready to submit when the CRAN queue opens again in the new year. Best, luke On Thu, 20 Dec 2018, luke-tier...@uiowa.edu wrote: > That's where the error is signaled, but