Re: [Bioc-devel] Question on GPL2 license copyright

2022-07-27 Thread Egon Willighagen
If that code is not GPL2 and therefore the full package too, then that's a license infringement. Wrapping GPL code in other code is generally only allowed when: 1. clean room reimplementation of the ideas (from what you say not the case), 2. the reused code has a clean API and can be easily be

[Bioc-devel] help with Win10 TSL problem?

2020-03-18 Thread Egon Willighagen
Hi all, in the BridgeDbR package I have a TSL issue, just on Windows10 [0]: > location <- getDatabase("Bacillus subtilis") Error in function (type, msg, asError = TRUE) : error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version Calls: getDatabase ... getBridgeNames ->

Re: [Bioc-devel] Best practice on commit

2018-03-11 Thread Egon Willighagen
. MacDonald <jmac...@uw.edu> wrote: > This was recently discussed: > > https://stat.ethz.ch/pipermail/bioc-devel/2018-February/012875.html > > On Sun, Mar 11, 2018 at 4:10 AM, Egon Willighagen < > egon.willigha...@gmail.com> wrote: > >> Hi Nicolas, >>

Re: [Bioc-devel] Best practice on commit

2018-03-11 Thread Egon Willighagen
Hi Nicolas, after doing a bit of work on the BridgeDbR package this weekend, I was wondering exactly the same thing. I prefer small patches, so that I can easily link the change with the commit message and have related changes together (and fairly, it allows me to see when I actually work on what

Re: [Bioc-devel] RMassBank (almost) builds ...

2016-10-13 Thread Egon Willighagen
Hi all, including all BioC developers, On Thu, Oct 13, 2016 at 4:32 PM, Zach Charlop-Powers wrote: > When I initially submitted to CRAN I did NOT check the Java version and > therefore users would be able to use Java 7 and would encounter errors only > when using

Re: [Bioc-devel] RMassBank (almost) builds ...

2016-10-13 Thread Egon Willighagen
cc: Rajarshi Hi Emma, On Wed, Oct 12, 2016 at 10:18 PM, Schymanski, Emma wrote: > Thanks to Laurent and Jo for updating MSnbase and thanks to the BioC team for > getting the email updates working again! The good news is that RMassBank now > builds on most

Re: [Bioc-devel] unit test results not showing up for BridgeDbR?

2016-09-29 Thread Egon Willighagen
sen > <l.eijs...@maastrichtuniversity.nl> > -Maintainer: Anwesha Bohler <anweshaboh...@gmail.com> > +Maintainer: Egon Willighagen <egon.willigha...@gmail.com> > Depends: R (>= 3.3.0), rJava > Imports: RCurl > Suggests: testthat > > > More on

[Bioc-devel] unit test results not showing up for BridgeDbR?

2016-09-29 Thread Egon Willighagen
Hi all, I have pushed a newer version of BridgeDbR to the repository, which includes tests with 'testthat', but when looking at the package homepage [0], it does not seem the test results are being picked up... I looked at the documentation, and did not find anything that could explain it (e.g.

Re: [Bioc-devel] updated BridgeDbR package

2016-04-29 Thread Egon Willighagen
to the repo. If > you don't have credentials we can request them for you. That would be nice. Please let me know if I need to make steps or if you need information. Egon > If you want the changes in quickly you could ask the maintainer to push > them. > > Valerie > > > On 04/29/2

[Bioc-devel] updated BridgeDbR package

2016-04-29 Thread Egon Willighagen
Hi all, I am one of the upstream developers of BridgeDbR and like to see newer version of the package included in Bioconductor. After the pull request I created was closed [0], I realized that was not the right approach. But I also do not have SVN write access, and therefore can not push it like