Re: [Bioc-devel] Best practice on commit

2018-03-11 Thread Egon Willighagen
Dear James, I should have mentioned that email... I had seen it. But I mostly read it as personal experience. However, given that you refer me to that, I will assume my proposal is acceptable, as it is comparable to Martin's write up. Thanks, Egon On Sun, Mar 11, 2018 at 5:06 PM, James W.

Re: [Bioc-devel] Best practice on commit

2018-03-11 Thread James W. MacDonald
This was recently discussed: https://stat.ethz.ch/pipermail/bioc-devel/2018-February/012875.html On Sun, Mar 11, 2018 at 4:10 AM, Egon Willighagen < egon.willigha...@gmail.com> wrote: > Hi Nicolas, > > after doing a bit of work on the BridgeDbR package this weekend, I was > wondering exactly

Re: [Bioc-devel] Best practice on commit

2018-03-11 Thread Egon Willighagen
Hi Nicolas, after doing a bit of work on the BridgeDbR package this weekend, I was wondering exactly the same thing. I prefer small patches, so that I can easily link the change with the commit message and have related changes together (and fairly, it allows me to see when I actually work on what