Re: Radv proto sending adverts on wrong interface

Hi Ondrej, It looks like made a mistake when testing my patch. It does in fact not fix the problem. I then did some more reading of the linux scriptures and it turns out PACKET_OUTGOING ("Out" in tcpdump) should actually be reliable so that meant that the "M" means that packet is actually coming

Re: Radv proto sending adverts on wrong interface

Hi Ondrej, On Sun, Mar 12, 2023 at 01:29:23PM +0100, Ondrej Zajicek wrote: > I do not really get this. For multicast, outgoing interface is defined by > setsockopt(IPV6_MULTICAST_IF) in sk_setup_multicast6(). Hmm, I hadn't seen that. That is odd indeed. Looking at this again I also noticed we

Re: [PATCH] [RFC] Babel: Implement route daming with fixed delay

Hi Juliusz, On Tue, Mar 07, 2023 at 01:20:28PM +0100, Juliusz Chroboczek wrote: > I have no signal processing background whatsoever; to my eyes, signal > processing is a fairly advanced for of magic. (My background is in logic > and programming languages.) > > To be honest, we hacked things

Re: [PATCH] [RFC] Babel: Implement route daming with fixed delay

Hi Juliusz, On Mon, Mar 06, 2023 at 03:59:14PM +0100, Juliusz Chroboczek wrote: > > In order to prevent RTT based routing from causing persistent traffic > > oscillations we delay core rte announcement of each prefix by a > > configurable but metric invariant amount of time. > > Could you please

Re: [PATCH 0/3] babel: Add support for the RTT extension

Hi Toke, On Tue, Feb 28, 2023 at 12:20:22PM +0100, Toke Høiland-Jørgensen wrote: > > I've thought about this some more, I think we absolutely shouldn't expose > > the smooted metric to filters. It's an implementation detail. There's a > > bunch of other valid ways to implement this sort of

Babel: Clarifications on seqno request handling in bird

Hi Ondrej, Toke, Juliusz and lists, I'm working on v4 of my bird route selection patch[1] and I just have a couple babel spec and bird implementation questions. [1]: http://trubka.network.cz/pipermail/bird-users/2023-January/016621.html Just a quick recap for anyone not following my "Replace

Re: [PATCH v3] Babel: Replace internal route selection by bird's nest

HI, On Sat, Feb 11, 2023 at 02:22:13PM +0100, Maria Matejka wrote: > > I'm still trying to find a convincing argument for why the bad case can > > never happen though. Can you think of a codepath that calls rt_notify with > > one of our own routes outside of us calling into rte_update*? I'm

Re: [PATCH v3] Babel: Replace internal route selection by bird's nest

Hi Maria, On Mon, Feb 06, 2023 at 02:19:53PM +0100, Maria Matejka wrote: > Picking up this, hoping that it is still relevant. Yes, absolutely :) > You can do this as the import/export limits in BGP do exactly this, yet the > appropriate function > > void proto_schedule_down(struct proto *p,

Re: [PATCH v3] Babel: Replace internal route selection by bird's nest

Hi Ondrej, On Tue, Jan 31, 2023 at 06:35:27PM +0100, Ondrej Zajicek wrote: > There are some corner cases where the behavior may be different - e.g., > if one has Babel and BGP with add-path enabled connected to one table, > then all Babel routes would be propagated with BGP. Or if you have a pipe

Re: [PATCH] Babel: Remove unecessary FIB_ITERATE restart

Hi Toke, On Mon, Jan 30, 2023 at 10:50:14PM +0100, Toke Høiland-Jørgensen wrote: > Daniel Gröber writes: > > > The route expiration code appears to have been stolen from rip.c, in that > > code the rt_notify function actually does modify the rtable fib by calling > > fib_get. The babel code

Re: [PATCH] [RFC] Babel: Replace internal route selection by bird nest

Hi Ondrej, On Mon, Jan 30, 2023 at 03:52:51PM +0100, Ondrej Zajicek wrote: > I was confused before, but is this really a breaking change? As i > understand it, both Babel and RIP keep list of received routes, select > the best, push the best to main (nest) table, but it must be explicitly >

Re: [PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes

Hi Ondrej, did you ever see my v2 patchset? [PATCH v2 1/2] Netlink: Drop ECMP route splitting hacks [PATCH v2 2/2] Netlink: Propagate ECMP nexthop weight to kernel for inet6 routes Since I never heard back on that. --Daniel On Mon, May 23, 2022 at 02:36:49AM +0200, Ondrej Zajicek

Re: [PATCH v3] Babel: Add option to support ecmp routes

On Thu, May 26, 2022 at 03:33:44PM +0200, Daniel Gröber wrote: > Changes in v3: > - Squash with ecmp weigth patch > - Add babel_route_is_selected() as replacement for e->selected > I'm not totally sure the lazy approach is safe yet. We might need > additional bookeeping to reset

Re: [PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes

After looking at this more I realise now how bird is splitting multiple ipv6 nexthops into sequences of route updates for the same prefix. Consequently the code doing this should also be removed. Though it seems it works just fine either way but I get errors for the (now redundant) route

Re: [PATCH 1/2] Babel: Add option to support ecmp routes

Hi Toke, On Mon, May 09, 2022 at 03:21:15PM +0200, Toke Høiland-Jørgensen wrote: > >> > + /* Update all routes to refresh ecmp settings. */ > >> > + FIB_WALK(>ip6_rtable, struct babel_entry, e) { > >> > +babel_select_route(p, e, NULL); > >> > + } > >> > + FIB_WALK_END; > >> > +

Re: [PATCH 1/2] Babel: Add option to support ecmp routes

Hi Toke, On Sun, May 08, 2022 at 09:06:43PM +0200, Toke Høiland-Jørgensen wrote: > Daniel Gröber writes: > > --- > > The FIB walks in babel_reconfigure_iface are a bit ugly, I tried to > > loop over ifa->neigh_list instead but couldn't get it to work. I'm > > open to suggestions :) > > > >

Re: [PATCH 2/2] Babel: Add option to control ecmp nexthop weight

Hi Toke, On Sun, May 08, 2022 at 09:09:13PM +0200, Toke Høiland-Jørgensen wrote: > Daniel Gröber writes: > > > --- > > doc/bird.sgml| 21 ++--- > > proto/babel/babel.c | 1 + > > proto/babel/babel.h | 2 ++ > > proto/babel/config.Y | 2 ++ > > 4 files changed, 19