Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-03-06 Thread Juliusz Chroboczek
>> (There's also the PMTUD problem described in RFC 9229 Section 3.) > Juliusz, do you, or any one else, have info on: > How does ${vendor} behave when reverse path filters are enabled? I was under the impression that some kinds of ICMP pakets are not subject to RPF. See RFC 4890 Section 4.3.1.

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-03-02 Thread Bernd Naumann
On 14.02.23 22:08, Juliusz Chroboczek wrote: > (There's also the PMTUD problem described in RFC 9229 Section 3.) Hey, Juliusz, do you, or any one else, have info on: How does ${vendor} behave when reverse path filters are enabled? I did some "research" aka an afternoon of web-search on that

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Juliusz Chroboczek
> btw, there is one question that i noticed. If an Update is ignored for > semantic reasons (e.g. update with valid metric, but missing next hop or > router id), should it update last prefix with P-flag? Such a packet would be incorrect. What to do in presence of an incorrect packet is left to

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Juliusz Chroboczek
> I just though that the default value for the option is enabled, but > perhaps it should be enabled only if such routes are supported by > platform code (i.e. enabled on Linux, but disabled on BSD, as we do > not support such routes on BSD). IMHO, it should not be possible to enable v4-via-v6

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Ondrej Zajicek
On Tue, Feb 14, 2023 at 06:25:33PM +0100, Juliusz Chroboczek wrote: > > 1) Changed the name of the option to 'extended next hop', for consistency > > with BGP (and in the future also with other protocols). As the option is > > enabled by default, the name likely does not matter that much. > > I

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Ondrej Zajicek
On Tue, Feb 14, 2023 at 06:04:33PM +0100, Andreas Rammhold wrote: > > Please check it, if it is acceptable for you, i will merge it to the master > > branch. > > These all sound fine. I've run it through my bird<->bird<->babeld<->babeld > test network and it passed. > > The changes look fine if

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Juliusz Chroboczek
> 1) Changed the name of the option to 'extended next hop', for consistency > with BGP (and in the future also with other protocols). As the option is > enabled by default, the name likely does not matter that much. I rather like v4-via-v6, which succintly and clearly states what it is about.

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Andreas Rammhold
Ondrej Zajicek writes: Hi, > On Wed, Jan 11, 2023 at 03:57:47PM +0100, Andreas Rammhold wrote: >> Any chance you could give this a look yet? > > Hi > > Finally i got to process the patch and prepare it for merging. > I did some changes, mainly: > > 1) Changed the name of the option to 'extended

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-02-14 Thread Ondrej Zajicek
On Wed, Jan 11, 2023 at 03:57:47PM +0100, Andreas Rammhold wrote: > Any chance you could give this a look yet? Hi Finally i got to process the patch and prepare it for merging. I did some changes, mainly: 1) Changed the name of the option to 'extended next hop', for consistency with BGP (and in

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-01-31 Thread Ondrej Zajicek
On Tue, Jan 31, 2023 at 05:59:25PM +0100, Martin Weinelt wrote: > Hi, > > thanks for the patch. I'm running it on a few machines and it simplifies > address management significantly, since it allows us to deallocate lots of > address pairs from all tunnel interfaces. > > Want to repeat the

Re: [PATCH] Babel: add RFC9229 (v4 via v6) support

2023-01-31 Thread Martin Weinelt
On 11.01.23 17:16, Ondrej Zajicek via Bird-users wrote: Hi Sorry, we received some reports about an important bug in 2.0.11, we are now working on 2.0.12 with several bugfixes (hopefully this week), after that i will check your patch. Hi, thanks for the patch. I'm running it on a few