Re: [blink-dev] Intent to Ship: Lazy load scroll margin

> > > Thanks, that sounds like a strict improvement. > Yes. ExplainerNone >>> > A short (inline) explainer would help reviewers to understand e.g. if this > involves changes to the API surface that developers need to care about. > Can you write a few words on the impact on developers? >

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

Thank you Tommy! Superfluous LGTM4 On Thu, Nov 30, 2023 at 1:58 AM Chris Harrelson wrote: > LGTM3 > > On Wed, Nov 29, 2023 at 8:36 AM Philip Jägenstedt > wrote: > >> LGTM2 >> >> On Wed, Nov 29, 2023 at 4:12 PM Yoav Weiss >> wrote: >> >>> LGTM1 >>> >>> On Wednesday, November 29, 2023 at

[blink-dev] Intent to Ship: URLPattern: hasRegExpGroups

Contact emailsjbro...@chromium.org ExplainerNone Specification https://urlpattern.spec.whatwg.org/#dom-urlpattern-hasregexpgroups Summary Allows easy inspection of whether a URLPattern uses one or more ECMAScript regular expression groups, and therefore may not be suitable for use in cases

[blink-dev] Re: Intent to Prototype: Extending Storage Access API (SAA) to non-cookie storage

requestStorageAccess currently provides no way to directly control any surfaces with first-party SameSite=Strict cookies. If the handle returned allowed you to access first-party SharedWorkers, those workers would have access to SameSite=Strict cookies. Chrome's decision at this juncture is to not

[blink-dev] Re: Intent to Prototype: Extending Storage Access API (SAA) to non-cookie storage

Ah that's too bad. I don't think using object urls would be performant. The data in the ArrayBuffer is still accessible after creating the object url, so that does not seem like it is getting transferred. Is there any chance an api could be exposed in the future that would allow two separate

[blink-dev] Re: Intent to Ship: Async Clipboard API: Read unsanitized HTML format

Thanks for re-sending this under different cover. I understand that the previous entry's Security review covers this, so LGTM1 Best, Alex On Wednesday, November 29, 2023 at 1:27:31 PM UTC-8 snianu wrote: > Resending the I2S with all the updates and a summary of discussion that > happened in

[blink-dev] Intent to Ship: Async Clipboard API: Read unsanitized HTML format

Resending the I2S with all the updates and a summary of discussion that happened in a different I2S thread. Contact emails sni...@microsoft.com, sa...@microsoft.com, est...@chromium.org, jsb...@chromium.org,

Re: [blink-dev] Intent to Experiment: X25519Kyber768 key encapsulation for TLS

Updating this thread to say that Kyber has been at 10% stable on all platforms since 2023-11-06. On Friday, September 8, 2023 at 3:32:09 PM UTC-6 David Benjamin wrote: > On Fri, Sep 8, 2023 at 4:16 PM 'David Adrian' via blink-dev < > blin...@chromium.org> wrote: > >> > LGTM to experiment from

[blink-dev] Re: Intent to Ship: Multiple Readers and Writers in File System Access API

+ajayrahate...@google.com On Wednesday, November 29, 2023 at 8:18:04 AM UTC-8 yoav...@chromium.org wrote: > Can you please tick all the review boxes in the Chrome status entry? > > On Monday, November 27, 2023 at 8:19:42 PM UTC+1 mem...@google.com wrote: > >> Contact emails >> >>

Re: [blink-dev] Intent to Ship: Storage Buckets API

Hi Philip, Here is a comprehensive list of web tests that verify storageBuckets behavior. We do feel the size of this list aligns well with the spec, which is fairly concise. As you can see, some are spread out in directories for the other storage APIs that storageBuckets brokers. That said, not

Re: [blink-dev] Re: Intent to Implement and Ship: Async Clipboard API: Allow empty ClipboardItem during read

LGTM3 /Daniel On 2023-11-29 18:01, Chris Harrelson wrote: LGTM2 On Wed, Nov 29, 2023 at 8:27 AM Yoav Weiss wrote: LGTM1 This seems to reduce interop risk. Thanks! On Tuesday, November 21, 2023 at 6:45:00 PM UTC+1 snianu wrote: Contact emails

Re: [blink-dev] Intent to Ship: Storage Buckets API

Hi Evan, Is https://wpt.fyi/results/storage/buckets?label=experimental=master the full set of tests? Given the size of the spec, does that cover the whole feature well? Best regards, Philip On Wed, Nov 29, 2023 at 5:58 PM Evan Stade wrote: > [reply-all this time] > > Hi Philip, > > thanks for

Re: [blink-dev] Re: Intent to Implement and Ship: Async Clipboard API: Allow empty ClipboardItem during read

LGTM2 On Wed, Nov 29, 2023 at 8:27 AM Yoav Weiss wrote: > LGTM1 > > This seems to reduce interop risk. Thanks! > > On Tuesday, November 21, 2023 at 6:45:00 PM UTC+1 snianu wrote: > >> Contact emails >> >> sni...@microsoft.com, est...@chromium.org, sa...@microsoft.com, >> jsb...@google.com >> >>

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

LGTM3 On Wed, Nov 29, 2023 at 8:36 AM Philip Jägenstedt wrote: > LGTM2 > > On Wed, Nov 29, 2023 at 4:12 PM Yoav Weiss wrote: > >> LGTM1 >> >> On Wednesday, November 29, 2023 at 4:04:49 PM UTC+1 Tommy Steimel wrote: >> >>> Okay the security reviewer has now re-reviewed it given the updated >>>

Re: [blink-dev] Intent to Ship: Storage Buckets API

[reply-all this time] Hi Philip, thanks for pointing out those two oversights. I have fixed the checkboxes on the chromestatus entry. It is in fact tested by WPT and supported on all Blink platforms. On Wed, Nov 29, 2023 at 8:43 AM Philip Jägenstedt wrote: > Hi Evan, > > A few questions

Re: [blink-dev] Intent to Ship: Document rules, response header, eagerness

LGTM3 On Wed, Nov 29, 2023 at 5:55 PM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2023-11-23 10:11, Yoav Weiss wrote: > > LGTM1 > > These all seem like useful improvements! :) > > > On Wed, Nov 22, 2023 at 8:14 PM Jeremy Roman wrote: > >> >> >> On Wed, Nov 22, 2023 at 11:10 AM Yoav Weiss

Re: [blink-dev] Intent to Ship: Document rules, response header, eagerness

LGTM2 /Daniel On 2023-11-23 10:11, Yoav Weiss wrote: LGTM1 These all seem like useful improvements! :) On Wed, Nov 22, 2023 at 8:14 PM Jeremy Roman wrote: On Wed, Nov 22, 2023 at 11:10 AM Yoav Weiss wrote: On Thu, Nov 16, 2023 at 12:33 AM Jeremy Roman wrote:

Re: [blink-dev] Re: Intent to Ship: CSS supports() condition for @import

LGTM3 /Daniel On 2023-11-29 17:45, Chris Harrelson wrote: LGTM2 On Wed, Nov 29, 2023 at 7:40 AM Yoav Weiss wrote: On Wed, Nov 29, 2023 at 4:34 PM Yoav Weiss wrote: I wonder if we should hold off on adding @import support until such a solution emerges. On

Re: [blink-dev] Re: Intent to Ship: CSS supports() condition for @import

LGTM2 On Wed, Nov 29, 2023 at 7:40 AM Yoav Weiss wrote: > > > On Wed, Nov 29, 2023 at 4:34 PM Yoav Weiss wrote: > >> I wonder if we should hold off on adding @import support until such a >> solution emerges. > > > On second thought, since we didn't delay `layer`, there's no real reason > to

Re: [blink-dev] Intent to Ship: Storage Buckets API

Hi Evan, A few questions inline. On Tue, Nov 14, 2023 at 9:38 PM Evan Stade wrote: > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)? > > No > Which platform will this not be supported on? > Is this feature fully

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

LGTM2 On Wed, Nov 29, 2023 at 4:12 PM Yoav Weiss wrote: > LGTM1 > > On Wednesday, November 29, 2023 at 4:04:49 PM UTC+1 Tommy Steimel wrote: > >> Okay the security reviewer has now re-reviewed it given the updated >> information. Thanks! >> >> On Mon, Nov 27, 2023 at 11:55 PM Rick Byers wrote:

[blink-dev] Re: Intent to Implement and Ship: Async Clipboard API: Allow empty ClipboardItem during read

LGTM1 This seems to reduce interop risk. Thanks! On Tuesday, November 21, 2023 at 6:45:00 PM UTC+1 snianu wrote: > Contact emails > > sni...@microsoft.com, est...@chromium.org, sa...@microsoft.com, > jsb...@google.com > > Explainer > > >

[blink-dev] Re: Intent to Ship: Multiple Readers and Writers in File System Access API

Can you please tick all the review boxes in the Chrome status entry? On Monday, November 27, 2023 at 8:19:42 PM UTC+1 mem...@google.com wrote: > Contact emails > > ds...@google.com, memm...@google.com > > Explainer > > https://github.com/whatwg/fs/blob/main/proposals/MultipleReadersWriters.md >

[blink-dev] Re: Intent to Experiment: IP Protection Phase 0

Putting all other concerns aside, wouldn't this "ip protection" proxy allow the owner/controllers of the proxies to decide what websites and content the end user will and won't be allowed to access? Why is this problem not listed with other concerns in any of the proposal write ups I have

Re: [blink-dev] Re: Intent to Ship: CSS supports() condition for @import

On Wed, Nov 29, 2023 at 4:34 PM Yoav Weiss wrote: > I wonder if we should hold off on adding @import support until such a > solution emerges. On second thought, since we didn't delay `layer`, there's no real reason to delay shipping here. But I strongly urge you to nudge this along :) > In

Re: [blink-dev] Re: Intent to Ship: CSS supports() condition for @import

I wonder if we should hold off on adding @import support until such a solution emerges. In any case, similar to layer support, you probably want to add tests that make sure that

[blink-dev] Re: Intent to Ship: WebGL drawingBufferStorage

Thanks! This seems like an important problem to solve.. On Monday, November 27, 2023 at 10:20:37 PM UTC+1 Christopher Cameron wrote: Contact emailsccame...@chromium.org ExplainerNone A short (inline?) explainer can help reviewers assess what this looks like and how developers may use it. As

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

LGTM1 On Wednesday, November 29, 2023 at 4:04:49 PM UTC+1 Tommy Steimel wrote: > Okay the security reviewer has now re-reviewed it given the updated > information. Thanks! > > On Mon, Nov 27, 2023 at 11:55 PM Rick Byers wrote: > >> On Wed, Nov 22, 2023 at 11:49 PM 'Tommy Steimel' via blink-dev

Re: [blink-dev] Intent to Prototype and Ship: MessagePort.onclose

Also, can you tick the review boxes in your Chrome status entry to kick off security, privacy and other reviews? On Wed, Nov 29, 2023 at 6:22 AM Yoav Weiss wrote: > I ran into a Chromium-internal case where having a `close` signal would've > helped me reduce complexity significantly. So I'm

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

Okay the security reviewer has now re-reviewed it given the updated information. Thanks! On Mon, Nov 27, 2023 at 11:55 PM Rick Byers wrote: > On Wed, Nov 22, 2023 at 11:49 PM 'Tommy Steimel' via blink-dev < > blink-dev@chromium.org> wrote: > >> >> On Tue, Nov 21, 2023 at 9:43 PM Yoav Weiss >>