Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-03-15 Thread 'Jacob Goldman' via blink-dev
Hi all, This sort of reporting would be incredibly useful for third-party Javascript given how widely it is deployed and potentially dangerous an infinite loop in that context could be. I'm an engineer who writes third-party JavaScript for Google's Display Ads products and having

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-02-23 Thread Rick Byers
Yikes, that definitely sounds like a potential privacy issue to me Dmitry, thanks! I added it as a question in the design doc , let's take the discussion there rather than blink-dev? Rick

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-02-23 Thread Dmitry Gozman
While reviewing the proposed implementation , I had the following privacy-related concern, and would like to consult the API owners on the topic. When capturing the stack trace in the renderer process, we do not attribute it to

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-01-30 Thread 'Issack John' via blink-dev
Hi all, Thank you for the great questions and insights. This feature will be restricted to only the execution stacks in the main world. As Rick described, extension code injected into the main world may be visible. *How do you know from the IO thread what the main thread isolate is?*

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-01-25 Thread Dave Tapuska
Yes I was thinking of how the stack trace format was standardized as well. How do wasm call stacks work with this proposal? dave. On Wed, Jan 24, 2024 at 8:27 PM Domenic Denicola wrote: > I agree with Dave's take on the importance of not including extension > scripts themselves, and Rick's

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-01-24 Thread Domenic Denicola
I agree with Dave's take on the importance of not including extension scripts themselves, and Rick's take on how it is OK to include extension-injected main world scripts. One additional interop concern that's worth highlighting here is that the stack trace format itself is not compatible across

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-01-24 Thread Rick Byers
Not to distract from Dave's good technical questions. But I just wanted to say that I'm quite excited about this work - I think it's an important capability for any serious platform to have that app developers can get actionable crash and hang reports, and this has been a gap. Thank you for

Re: [blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-01-24 Thread Dave Tapuska
Just a few thoughts... I haven't seen a proposed implementation but I presume you are going to restrict this only to execution stacks in the main world? If you get an extension executing scripts in the main world how will you prevent the endpoint from knowing about the agent's execution

[blink-dev] Intent to Prototype: Call stacks in crash reports from unresponsive web pages

2024-01-24 Thread 'Issack John' via blink-dev
Contact emails issackj...@microsoft.com, seth.bren...@microsoft.com Explainer https://github.com/WICG/crash-reporting/issues/12 Specification