Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-24 Thread Yoav Weiss (@Shopify)
LGTM3 On Wed, Jan 24, 2024 at 1:45 PM Noam Rosenthal wrote: > Oh thanks for pointing it out! This wouldn't be a breaking change, > probably a test bug from previous changes, will fix that before shipping of > course. > > On Wed, Jan 24, 2024 at 12:31 PM domenic via Chromestatus < >

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-24 Thread Noam Rosenthal
Oh thanks for pointing it out! This wouldn't be a breaking change, probably a test bug from previous changes, will fix that before shipping of course. On Wed, Jan 24, 2024 at 12:31 PM domenic via Chromestatus < admin+dome...@cr-status.appspotmail.com> wrote: > I found some interesting test

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-24 Thread domenic via Chromestatus
I found some interesting test failures at https://wpt.fyi/results/long-animation-frame/tentative/loaf-source-location-redirect.html?label=experimental=master . Do they represent anything worth worrying about, eg a potential breaking change? Assuming not, LGTM2. -- You received this message

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-24 Thread Mike Taylor
LGTM1 On 1/17/24 9:32 AM, 'Noam Rosenthal' via blink-dev wrote: Updating that Mozilla gave an official positive signal: https://github.com/mozilla/standards-positions/pull/962 Updated the corresponding chromestatus field. On Monday, January 15, 2024 at 10:34:19 AM UTC Noam Rosenthal wrote:

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-17 Thread Noam Rosenthal
Gotcha thanks! I totally missed those buttons... will file a UI bug on chromestatus, maybe their discoverability can be improved. On Wed, Jan 17, 2024 at 11:53 AM Manuel Rego Casasnovas wrote: > > > On 15/01/2024 11:31, Noam Rosenthal wrote: > > > > Link to entry on the Chrome

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-17 Thread Manuel Rego Casasnovas
On 15/01/2024 11:31, Noam Rosenthal wrote: Link to entry on the Chrome Platform Status https://chromestatus.com/feature/6118675067699200 Can you tick the other review boxes on the entry? Not sure I

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-17 Thread 'Noam Rosenthal' via blink-dev
Updating that Mozilla gave an official positive signal: https://github.com/mozilla/standards-positions/pull/962 Updated the corresponding chromestatus field. On Monday, January 15, 2024 at 10:34:19 AM UTC Noam Rosenthal wrote: > >> >> Regarding the spec, I see that it's monkeypatching WebIDL,

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-15 Thread Noam Rosenthal
> > > > Regarding the spec, I see that it's monkeypatching WebIDL, DOM and HTML. > This feels odd in a WG-adopted spec. > Have you tried to PR these changes upstream? > Was planning to upstream the monkey-patches once we have formal positive signals from Gecko/WebKit. -- You received this

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-15 Thread Noam Rosenthal
On Sat, Jan 13, 2024 at 4:32 AM Yoav Weiss wrote: > Thanks for working on this important problem! :) > Thanks for reviewing, I realize that the chromestatus entry was erroneous/lacking in a few important bits, let me try to rectify this :) Updating the chromestatus entry and posting the missing

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-12 Thread Yoav Weiss
Thanks for working on this important problem! :) On Fri, Jan 12, 2024 at 11:31 AM Noam Rosenthal wrote: > Contact emailsnrosent...@chromium.org > > Explainer > https://github.com/w3c/longtasks/blob/loaf-explainer/loaf-explainer.md > Can the explainer be updated? e.g. I'm assuming that the

[blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-12 Thread Noam Rosenthal
Contact emailsnrosent...@chromium.org Explainer https://github.com/w3c/longtasks/blob/loaf-explainer/loaf-explainer.md Specificationhttps://w3c.github.io/longtasks/ Summary This is an extension of long tasks. It measures the task