Re: [blink-dev] Intent to Ship: Make CaptureController derive from the EventTarget interface

2023-06-28 Thread Daniel Bratell
LGTM3 /Daniel On 2023-06-28 15:51, Chris Harrelson wrote: LGTM2 On Wed, Jun 28, 2023 at 1:11 AM Yoav Weiss wrote: LGTM1 after the PR lands. Thanks for the extra context!! This is a tiny change, with extremely low compat risk (developers would have to explicitly check for

Re: [blink-dev] Intent to Ship: Make CaptureController derive from the EventTarget interface

2023-06-28 Thread Chris Harrelson
LGTM2 On Wed, Jun 28, 2023 at 1:11 AM Yoav Weiss wrote: > LGTM1 after the PR lands. > > Thanks for the extra context!! > > This is a tiny change, with extremely low compat risk (developers would > have to explicitly check for CaptureController's inheritance for this > change to break existing

Re: [blink-dev] Intent to Ship: Make CaptureController derive from the EventTarget interface

2023-06-28 Thread Yoav Weiss
LGTM1 after the PR lands. Thanks for the extra context!! This is a tiny change, with extremely low compat risk (developers would have to explicitly check for CaptureController's inheritance for this change to break existing code) and which the WG seems to be on board with. As such, one can

Re: [blink-dev] Intent to Ship: Make CaptureController derive from the EventTarget interface

2023-06-27 Thread Frédéric Wang
Hello, To elaborate a bit more on this, it's a small IDL change to make the CaptureController interface derive from the EventTarget interface: https://github.com/w3c/mediacapture-screen-share/issues/268

[blink-dev] Intent to Ship: Make CaptureController derive from the EventTarget interface

2023-06-27 Thread Frédéric Wang
Contact emails fw...@chromium.org Explainer None Specification https://w3c.github.io/mediacapture-screen-share/#dom-capturecontroller Summary The CaptureController interface enables further manipulation of a screen capture session. In the future, it is