Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-24 Thread Philip Jägenstedt
LGTM3 On Wed, Apr 24, 2024 at 4:46 PM Jxck wrote: > @domenic > > I've updated finch name on ChromeStatus. > > Thanks > Jxck > > On Wednesday, April 24, 2024 at 12:45:52 PM UTC+9 Domenic Denicola wrote: > >> LGTM2 >> >> On Wed, Apr 24, 2024 at 1:50 AM Yoav Weiss (@Shopify) < >>

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-24 Thread Jxck
@domenic I've updated finch name on ChromeStatus. Thanks Jxck On Wednesday, April 24, 2024 at 12:45:52 PM UTC+9 Domenic Denicola wrote: > LGTM2 > > On Wed, Apr 24, 2024 at 1:50 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> LGTM1 >> >> Thanks for catching us up here! :) >> >>

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-23 Thread Domenic Denicola
LGTM2 On Wed, Apr 24, 2024 at 1:50 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > Thanks for catching us up here! :) > > On Tue, Apr 23, 2024 at 10:20 AM Domenic Denicola > wrote: > >> Thanks. One more thing: our process requires all features have a Finch >> feature name

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-23 Thread Yoav Weiss (@Shopify)
LGTM1 Thanks for catching us up here! :) On Tue, Apr 23, 2024 at 10:20 AM Domenic Denicola wrote: > Thanks. One more thing: our process requires all features have a Finch > feature name (i.e., a base::Feature) so that we can turn off the feature > remotely. Can you ensure your implementation

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-23 Thread Jxck
Thanks, I've done them. On Monday, April 22, 2024 at 3:53:27 PM UTC+9 Domenic Denicola wrote: > Can you request privacy, security, enterprise, debuggability, and testing > reviews on Chrome Status? > > On Thu, Apr 18, 2024 at 11:36 PM Jack J wrote: > >> Contact emailsj...@chromium.org >> >>

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-23 Thread Domenic Denicola
Thanks. One more thing: our process requires all features have a Finch feature name (i.e., a base::Feature) so that we can turn off the feature remotely. Can you ensure your implementation has one, and then update ChromeStatus with its name? On Tue, Apr 23, 2024 at 2:29 PM Jxck wrote: > Thanks,

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-22 Thread Domenic Denicola
Can you request privacy, security, enterprise, debuggability, and testing reviews on Chrome Status? On Thu, Apr 18, 2024 at 11:36 PM Jack J wrote: > Contact emailsj...@chromium.org > > ExplainerNone > > Specificationhttps://url.spec.whatwg.org/#dom-url-parse > > Design docs >

[blink-dev] Intent to Ship: URL.parse()

2024-04-18 Thread Jack J
Contact emailsj...@chromium.org ExplainerNone Specificationhttps://url.spec.whatwg.org/#dom-url-parse Design docs https://github.com/whatwg/url/pull/825 Summary Parsing url string and returning URL object. If it's invalid url format, returning null instead of throwing Error. Blink