Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-30 Thread Petr Machata
David Miller writes: > From: Petr Machata > Date: Mon, 28 May 2018 17:44:16 +0200 > >> Callers of br_fdb_find() need to hold the hash lock, which >> br_fdb_find_port() doesn't do. Add the missing lock/unlock >> pair. >> >> Signed-off-by: Petr Machata > > If all of the these uses of

Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-30 Thread David Miller
From: Petr Machata Date: Mon, 28 May 2018 17:44:16 +0200 > Callers of br_fdb_find() need to hold the hash lock, which > br_fdb_find_port() doesn't do. Add the missing lock/unlock > pair. > > Signed-off-by: Petr Machata If all of the these uses of br_fdb_find_port() are safe, then it should

Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-28 Thread Stephen Hemminger
On Mon, 28 May 2018 17:44:16 +0200 Petr Machata wrote: > Callers of br_fdb_find() need to hold the hash lock, which > br_fdb_find_port() doesn't do. Add the missing lock/unlock > pair. > > Signed-off-by: Petr Machata > --- > net/bridge/br_fdb.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-28 Thread Petr Machata
Nikolay Aleksandrov writes: > Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions") Correct. Thanks, Petr

Re: [Bridge] [PATCH net-next] net: bridge: Lock before br_fdb_find()

2018-05-28 Thread Nikolay Aleksandrov
On 28/05/18 18:52, Nikolay Aleksandrov wrote: > On 28/05/18 18:44, Petr Machata wrote: >> Callers of br_fdb_find() need to hold the hash lock, which >> br_fdb_find_port() doesn't do. Add the missing lock/unlock >> pair. >> >> Signed-off-by: Petr Machata >> --- >>